| *** diablo_rojo is now known as Guest1284 | 04:53 | |
| thomasb06 | gtema: Hello. It seems this is pretty much it for the unit directory. Would you have another series of refactoring for me? | 07:51 |
|---|---|---|
| gtema | hi thomasb06. Yes | 07:51 |
| gtema | this is also part of the bigger cleanup | 07:52 |
| gtema | it's about fixing identation of the docstrings through the code | 07:52 |
| thomasb06 | cool. Then, I can go on elsewhere | 07:52 |
| gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L574 - good example of docstring identation | 07:53 |
| gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L368 - bad example | 07:53 |
| gtema | so overall I want our docstring to be properly idented (so that linebreak of the param description gets +4 chars identation and not something else | 07:54 |
| thomasb06 | it's all in openstacksdk/openstack ? | 07:54 |
| gtema | I would say it currently distracts in openstack///_proxy.py and openstack/cloud/**.py | 07:55 |
| gtema | s//////* */* *// | 07:55 |
| gtema | maybe same is also present in tons of other places (in the resource files themselves) and it should be also fixed there, but proxy files are the most disturbing ones | 07:55 |
| thomasb06 | alright, then switch on indenting | 07:56 |
| gtema | thks a lot | 07:57 |
| thomasb06 | First attempt: https://review.opendev.org/c/openstack/openstacksdk/+/811658 | 08:43 |
| thomasb06 | It seems it can be handled by a regexp script | 08:44 |
| thomasb06 | the keywords are: `:param ?:`, `:returns:`, `:rtype:`, and `:raises:`. And there are second level indentation after a `*` | 08:47 |
| thomasb06 | maybe I go for an awk script for a couple of days | 08:47 |
| gtema | I doubt it can be very easy with regex | 09:04 |
| gtema | stephenfin: I remember around a year ago we were discussing what to do with hypervisor statistics in OSC but I forgot what we actually agreed upon | 10:27 |
| gtema | I try to rebase my hypervisor change now https://review.opendev.org/c/openstack/python-openstackclient/+/763414 and figure out it doesn't work really, cause in SDK there is no support for statistics | 10:27 |
| stephenfin | Could you leave that using novaclient and simply deprecate it? | 10:29 |
| stephenfin | The alternative to provide something like it by querying placement, but we haven't completed placement support in SDK yet either | 10:29 |
| gtema | can be done. But then we can not get rid of dependency on novaclient (I was actually sure we do not have it, but we do) | 10:30 |
| stephenfin | We can't do it this cycle, but we can do it in Z | 10:30 |
| stephenfin | that's not that far away, tbf | 10:30 |
| gtema | that's clear, I mean even overall | 10:31 |
| gtema | what I can do actually is to use SDK for direct API call from OSC | 10:31 |
| gtema | so that we do not need to implement it in SDK | 10:31 |
| stephenfin | I didn't know that was an option. Sure, that works for me too | 10:32 |
| gtema | ok, will do so. I actually used this few times in ansible modules already | 10:32 |
| opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: Switch hypervisor operations to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/763414 | 13:23 |
| opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add BFD monitor commands https://review.opendev.org/c/openstack/python-openstackclient/+/810286 | 13:49 |
| opendevreview | Sven Anders proposed openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | 15:14 |
| opendevreview | Sven Anders proposed openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | 15:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!