| thomasb06 | The Message class: https://review.opendev.org/c/openstack/openstacksdk/+/808876 | 07:41 |
|---|---|---|
| vkmc | hi folks | 10:44 |
| vkmc | trying to tweak and output to be more user friendly | 10:44 |
| vkmc | I'm using this function over here https://github.com/openstack/osc-lib/blob/master/osc_lib/utils/__init__.py#L487 | 10:45 |
| vkmc | basically the resource we have has it's id and the project_id | 10:45 |
| vkmc | wanted to add the project_name as well | 10:45 |
| vkmc | any tips on how to do this? | 10:45 |
| gtema | where do you want to add it to? | 10:46 |
| vkmc | to the output | 10:46 |
| gtema | in the output is load said - which output, which command? | 10:46 |
| vkmc | ah sorry | 10:47 |
| vkmc | manila share group type access list | 10:47 |
| vkmc | so, openstack share group type access list | 10:47 |
| vkmc | patch is here | 10:47 |
| gtema | generally we only "output" what API sends to us | 10:47 |
| vkmc | https://review.opendev.org/c/openstack/python-manilaclient/+/805064 | 10:47 |
| vkmc | more context here | 10:47 |
| vkmc | https://review.opendev.org/c/openstack/python-manilaclient/+/805064/16/manilaclient/osc/v2/share_group_type_access.py#89 | 10:47 |
| gtema | normally we do not add anything else, but there are exceptions where i.e. for server we also extend it with flavor details | 10:47 |
| vkmc | yep, is feeling a bit "against" the design to add that info | 10:48 |
| vkmc | gtema, so this use case is nowhere in some other projects implementations? | 10:50 |
| vkmc | I just want to keep consistency on how we do things | 10:50 |
| gtema | in principle the approach is fine. But definitely this is not really performant to find project each time | 10:50 |
| vkmc | hmm good point | 10:50 |
| gtema | this particular approach of extending output with project_name - no, it's not present anywhere | 10:50 |
| vkmc | I'll discuss with the reviewer | 10:51 |
| gtema | another issue is that the user might not really have priviliges to list/find project. This is unlikely, but you anyway can never say for sure it will work | 10:51 |
| vkmc | so this is an admin operation, in which case that shouldn't be the issue | 10:52 |
| vkmc | unless I'm missing something | 10:52 |
| gtema | ok, but you know - admin of manilla is not necessarily having admin privs in identity | 10:52 |
| vkmc | yep | 10:52 |
| vkmc | it's a good point | 10:53 |
| gtema | cloud operators are keen to really separate privs as much as possible and even you are domain admin but with the project scope token you might not have privs to list projects | 10:53 |
| vkmc | makes sense | 10:54 |
| *** artom_ is now known as artom | 16:36 | |
| *** artom_ is now known as artom | 17:22 | |
| * gouthamr is reading the scrollback now | 18:08 | |
| gouthamr | the admin in this context is a system admin | 18:08 |
| gouthamr | at least by default; although its possible to override | 18:09 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!