| thomasb06 | About the three commits I did wrong, would it be enough to click 'Abandon' in the UI? | 09:44 |
|---|---|---|
| gtema | yes | 09:44 |
| thomasb06 | Done, the new commit is: https://review.opendev.org/c/openstack/openstacksdk/+/807427 | 09:54 |
| thomasb06 | Sorry about it. Next time, I'll be more carefull and use commit --amend. From 4pm to 6pm, I have another tiny timeframe if you would have another cleaning modification for me | 09:56 |
| gtema | thomasb06: if you look at https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/block_storage/v3/test_proxy.py#L36 (pretty much the file as whole) | 10:12 |
| gtema | you see there are multiple test classes | 10:13 |
| gtema | which split test functions base on the "resource" we test | 10:13 |
| gtema | similar is present in https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/compute/v2/test_proxy.py | 10:13 |
| gtema | so if you can apply the same pattern (splitting single test class into multiple) for all the other services it would be great | 10:14 |
| gtema | basically openstacl/tests/unit//v/test_proxy.py | 10:14 |
| gtema | * basically openstack/tests/unit//v/test_proxy.py | 10:14 |
| thomasb06 | If I understood well you would need all the files `openstack/tests/unit/*/v/test_proxy.py` to be split into test classes as in `block_storage/v3/test_proxy.py` and `compute/v2/test_proxy.py` ? | 10:29 |
| gtema | Yes | 10:30 |
| thomasb06 | Very well, I start today | 10:31 |
| gtema | You can also consult with the corresponding proxy file at all | 10:31 |
| gtema | If you want, we can perhaps have a call today so that I get you briefly through the structure of the project | 10:32 |
| thomasb06 | Maybe it's safer indeed | 10:32 |
| thomasb06 | We have the same timezone so between 4 and 6, you can call any time. And at other moments too, I can take a 5mn break | 10:33 |
| thomasb06 | may I post my number here? Not too sure about it... | 10:34 |
| gtema | Not necessary | 10:35 |
| gtema | I will send link for web conference | 10:36 |
| gtema | Around 17 | 10:36 |
| thomasb06 | Alright, I'll by my mailbox | 10:36 |
| opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | 11:41 |
| *** sshnaidm_ is now known as sshnaidm|off | 14:01 | |
| gtema | thomasb06, are you here? Having time now? | 14:36 |
| thomasb06 | Yes, I'm ready | 14:38 |
| gtema | https://meetpad.opendev.org/sdk | 14:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!