| opendevreview | chimeng proposed openstack/openstacksdk stable/ussuri: Add 'on_maintenance' to Masakari segment https://review.opendev.org/c/openstack/openstacksdk/+/805325 | 03:09 |
|---|---|---|
| frickler | gouthamr: gtema: I'm not really convinced that I want to have my name on a patch that is so broken, even to fix the gate. what we could do is hardcode "arg_key=''" with a big todo note that this needs proper fixing, wdyt? | 05:29 |
| gouthamr | frickler: ack, wfm if gtema thinks so | 05:48 |
| gtema | frickler, why you say gate is not fixed by that? I was locally testing your patch and it seems absolutely reasonable and working (for local unittests). The alternative is now to drop caching at all and reimplement it freshly in a different way. But on practice - it was working properly earlier | 07:02 |
| frickler | gtema: according to what I tested, the "if" part in my patch is actually never triggered. so IMO it would be cleaner to drop it. the solution that I consider more correct, using arg_key = ','.join(map(str, args)), leads to unit failures, so would need more investigation | 07:36 |
| frickler | gtema: I'm not saying that gate isn't fixed by that patch, it's just misleading about the actual situation | 07:37 |
| gtema | but that one clearly didn't work in my test with (perhaps with older decorator version) | 07:37 |
| *** rpittau|afk is now known as rpittau | 07:38 | |
| frickler | gtema: my assumption is that the unit tests may actually be broken (or maybe the caching code) and arg_key = ','.join(map(str, args)) uncovers that | 07:38 |
| gtema | no, unittest actually creates in-memory cache and verifies communication, so it should be working | 07:38 |
| gtema | I am sadly still not really convinced how the cache should be reimplemented - was poking already few days without anything really useful | 07:39 |
| gtema | using decorator seems to easy, but - i never thought it can be broken that easily with new release | 07:40 |
| gtema | * using decorator seems so easy, but - i never thought it can be broken that easily with new release | 07:41 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Fix key generation for caching https://review.opendev.org/c/openstack/openstacksdk/+/804530 | 07:45 |
| frickler | gtema: gouthamr: I would propose to go with ^^ for now to unblock. if you want something different, feel free to replace with your own ideas | 07:46 |
| gtema | ok, no objections | 07:47 |
| *** rpittau is now known as rpittau|afk | 13:55 | |
| opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | 14:03 |
| opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | 14:09 |
| *** mgoddard- is now known as mgoddard | 17:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!