| *** efried1 is now known as efried | 07:27 | |
| opendevreview | Elias Wimmer proposed openstack/ansible-collections-openstack master: Return loadbalancer ID and facts when not changed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804495 | 08:30 |
|---|---|---|
| opendevreview | wushiming proposed openstack/openstacksdk master: Replace deprecated inspect.getargspec https://review.opendev.org/c/openstack/openstacksdk/+/804501 | 08:46 |
| opendevreview | 江治林 proposed openstack/keystoneauth master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/keystoneauth/+/789699 | 09:09 |
| frickler | gouthamr: thanks for the hint, I did a bit of bisecting, seems decorator==5.0.5 is broken, decorator==5.0.4. current would be 5.0.9. so that looks like a regression in the library to me, will try to dig further | 12:11 |
| frickler | someone already created an issue https://github.com/micheles/decorator/issues/127 | 12:15 |
| opendevreview | Elias Wimmer proposed openstack/ansible-collections-openstack master: Fix behaviour for already existing loadbalancer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804495 | 12:17 |
| frickler | I bisected the issue down to this commit https://github.com/micheles/decorator/commit/04bb6454ac4f7560759ec1a3e15756a5485067ac and the docs update seems to indicate that this is an intentional change and we need to adopt our code | 12:31 |
| frickler | the code in question was last touched by mordred and shrews it seems - stemming from shade almost completely - https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/_utils.py#L387-L407 | 12:33 |
| opendevreview | Elias Wimmer proposed openstack/ansible-collections-openstack master: Fix behaviour for already existing loadbalancer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804495 | 12:43 |
| opendevreview | cenne proposed openstack/openstacksdk master: Add support for reading node's "boot_mode" and "secure_boot" fields https://review.opendev.org/c/openstack/openstacksdk/+/802101 | 14:37 |
| opendevreview | cenne proposed openstack/openstacksdk master: Add support for changing baremetal node's boot_mode and secure_boot states https://review.opendev.org/c/openstack/openstacksdk/+/804529 | 14:37 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Fix key generation for caching https://review.opendev.org/c/openstack/openstacksdk/+/804530 | 14:49 |
| frickler | mordred: ^^ not sure if you saw my earlier ramblings, this fixes the unit tests for me, but I have no idea if it makes sense otherwise | 14:50 |
| opendevreview | cenne proposed openstack/openstacksdk master: Add support for changing baremetal node's boot_mode and secure_boot states https://review.opendev.org/c/openstack/openstacksdk/+/804529 | 16:22 |
| frickler | mordred: thanks for your +2 but after checking upon your comment, I'm not sure the patch is actually correct, maybe there's an actual bug in the caching to be uncovered. -W for now, will try to do more digging next week | 16:34 |
| mordred | Nod. I'll also try to poke some if I can find some time | 16:50 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!