| *** rpittau|afk is now known as rpittau | 07:49 | |
| opendevreview | Balazs Gibizer proposed openstack/openstacksdk master: Remove block storage v2 support https://review.opendev.org/c/openstack/openstacksdk/+/801864 | 14:27 |
|---|---|---|
| opendevreview | Balazs Gibizer proposed openstack/openstacksdk master: Remove block storage v2 func tests https://review.opendev.org/c/openstack/openstacksdk/+/801864 | 14:36 |
| gibi | hi! you might noticed the openstacksdk-functional-devstack job started to fail since cinder merged the v2 api removal in https://review.opendev.org/c/openstack/cinder/+/792299 | 14:40 |
| gibi | I proposed the removal of the v2 func test from the job https://review.opendev.org/c/openstack/openstacksdk/+/801864 to unblock the gate | 14:40 |
| gmann | gibi: also we should have test v2 as separate job and default jobs test to v3 only. that is how we did in tempest integration jobs | 14:57 |
| gtema | SDK has a contract to work on older clouds (not only for OSC, but also ansible collections, Zuul, etc). Dropping v2 support is definitely not the way we will go. Dropping tests seems ok, but I will check for a possibility to check whether specific version is available (in some cases we have skipTest if service is not available) | 14:59 |
| gibi | gtema: ack. I've limited experience in sdk so I follow any lead. I just wanted to unblock the gate | 15:01 |
| gtema | clear. If I am not able to find alternative solution in 1-2 hours I will approve the patch | 15:02 |
| gibi | gtema: thanks. I appreciate it! | 15:02 |
| gtema | then we can revert the tests with some logic | 15:02 |
| gmann | gtema: gibi we can skip in v2 test in job | 15:06 |
| gmann | I can try after TC meeting | 15:06 |
| gibi | gmann: feel free to take over my patch I will probably disappeare in a hour or so | 15:07 |
| gmann | gibi: I can do in separate and then we can discuss best way to remove v2 in your patch ? | 15:07 |
| gibi | that works for me too | 15:07 |
| opendevreview | Ghanshyam proposed openstack/openstacksdk master: Skip block_storage.v2 test in functional job https://review.opendev.org/c/openstack/openstacksdk/+/801872 | 15:41 |
| gmann | gtema: ^^ | 15:42 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend has_version function to accept version parameter https://review.opendev.org/c/openstack/openstacksdk/+/801900 | 16:01 |
| *** rpittau is now known as rpittau|afk | 16:02 | |
| gtema | gmann, gibi - my change extends version check to properly (hopefully) apply skipTest if v2 is not available | 16:03 |
| gtema | locally for me it did the trick (check worked properly), but I couldn't verify func test on devstack since VirtualBox crashed | 16:05 |
| gibi | gtema: I abandoned my patch in favor of gman's. for me both his and yours looks ok | 16:07 |
| gtema | extending version check for me looks more future oriented (next deprecation) rather then maintaining blacklists, but let's see whether this work like I expect | 16:09 |
| gibi | yeah, your reasoning make sense. | 16:10 |
| gibi | I have to drop now for today | 16:10 |
| gibi | gmann, gtema: thanks for jumping on this issue | 16:10 |
| gibi | o/ | 16:10 |
| gtema | anybody want to leave a comment on https://review.opendev.org/c/openstack/openstacksdk/+/801900 to unblock the gate? | 17:38 |
| gmann | gtema: sure, make sense. abandon the blacklist way. | 18:20 |
| *** sshnaidm is now known as sshnaidm|afk | 20:10 | |
| opendevreview | Merged openstack/openstacksdk master: Extend has_version function to accept version parameter https://review.opendev.org/c/openstack/openstacksdk/+/801900 | 20:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!