| rm_work | eugh, the switch to SDK for image-v2 broke --tag lookup :( | 00:19 |
|---|---|---|
| rm_work | https://github.com/openstack/python-openstackclient/commit/60e7c51df4cf061ebbb435a959ad63c7d3a296bf#diff-9c3c9b14e60641cabdf48b609e17c7f8244d4d6ccada0c13a690d05f96e992ea | 00:19 |
| rm_work | http://paste.openstack.org/show/805014/ | 00:22 |
| rm_work | ahhh I guess the actual issue is here: https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 00:23 |
| rm_work | so, need that merged, in the meantime SDK is broken for image tag lookup | 00:25 |
| *** enriquetaso has joined #openstack-sdks | 00:34 | |
| rm_work | oh right, I'm sdk core <_< | 00:38 |
| *** gtema has joined #openstack-sdks | 01:03 | |
| *** gtema has quit IRC | 01:08 | |
| *** __ministry has joined #openstack-sdks | 01:15 | |
| *** enriquetaso has quit IRC | 01:41 | |
| *** evrardjp has quit IRC | 02:33 | |
| *** evrardjp has joined #openstack-sdks | 02:33 | |
| *** LinPeiWen42 has quit IRC | 02:57 | |
| openstackgerrit | Merged openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | 03:57 |
| *** Hybrid512 has quit IRC | 05:06 | |
| frickler | rm_work: noonedeadpunk: ^^ that patch still failed the osc job, but with a later failure iiuc https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2 | 05:07 |
| rm_work | hmmmm | 05:07 |
| frickler | also I guess we'd still need a release in order to unblock osc | 05:07 |
| rm_work | it resolved the problem entirely in my testbed | 05:07 |
| frickler | rm_work: there's also a related osc patch https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | 05:09 |
| *** udesale has joined #openstack-sdks | 05:14 | |
| rm_work | ok | 05:14 |
| rm_work | that's probably good, though my concern was with resolving a regression ASAP | 05:14 |
| rm_work | since it was breaking pipelines | 05:14 |
| rm_work | (we have pipelines that run with the newest client from git, and used image selection by tag) | 05:15 |
| *** LinPeiWen has joined #openstack-sdks | 05:21 | |
| frickler | rm_work: yes, I'm all for fixing regression first, it's just that with that test result I'm not sure whether the fix is actually complete. hopefully the recheck I just did on the osc patch will show this in the tips job | 05:37 |
| *** Luzi has joined #openstack-sdks | 05:41 | |
| *** ralonsoh has joined #openstack-sdks | 05:46 | |
| *** ysandeep|away is now known as ysandeep | 06:02 | |
| *** slaweq has joined #openstack-sdks | 06:05 | |
| *** udesale has quit IRC | 06:29 | |
| frickler | rm_work: noonedeadpunk: that error seems to persist, so to me the fix looks incomplete. b"tag unset failed, '01' is a nonexistent tag \nFailed to unset 1 of 1 tags.\n" https://zuul.opendev.org/t/openstack/build/2e3fef6b75dc47fc93a3368393aaf01e | 06:43 |
| *** gtema has joined #openstack-sdks | 07:04 | |
| *** rpittau|afk is now known as rpittau | 07:05 | |
| *** Hybrid512 has joined #openstack-sdks | 07:24 | |
| *** tosky has joined #openstack-sdks | 07:48 | |
| frickler | o.k., I can reproduce that error locally and now it really looks like a regression in glance to me, which returns 404 for the API call. we might want to improve on the error message, though | 07:56 |
| *** dtantsur|afk is now known as dtantsur | 07:58 | |
| frickler | gtema: ^^ FYI still some issue remaining with the image tags after the sdk fix merged | 07:59 |
| frickler | oh, actually the 404 is only on the second attempt, when the tag has indeed been removed already | 08:00 |
| frickler | seems we interpret the 204 which we get on successful delete as error | 08:00 |
| *** jpich has joined #openstack-sdks | 08:00 | |
| gtema | logs please | 08:01 |
| frickler | http://paste.openstack.org/show/805024/ | 08:01 |
| frickler | gtema: was already on it ;) | 08:01 |
| frickler | gtema: if you missed the earlier conversation, this is where noonedeadpunk's patch still failed the osc job https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2 | 08:02 |
| *** dansmith has quit IRC | 08:08 | |
| *** dansmith has joined #openstack-sdks | 08:09 | |
| frickler | humm, the error is even weirder. "'NoneType' object has no attribute 'remove'" is what I get if I print the exception in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1214 | 08:12 |
| gtema | I do not see immediately a bug. 204 is not treated like an error. It looks like something else is throwing this exception. | 08:14 |
| gtema | if you are on it - can you look on what the Exception https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1215 really is? | 08:14 |
| *** LinPeiWen has quit IRC | 08:16 | |
| *** ysandeep is now known as ysandeep|lunch | 08:17 | |
| frickler | gtema: that's the full traceback I get http://paste.openstack.org/show/805025/ . I need to do some other stuff now, can hopefully continue later if needed | 08:17 |
| *** LinPeiWen70 has joined #openstack-sdks | 08:39 | |
| *** jpich has quit IRC | 09:20 | |
| *** jpich has joined #openstack-sdks | 09:20 | |
| *** ysandeep|lunch is now known as ysandeep | 10:06 | |
| *** brinzhang_ has quit IRC | 10:11 | |
| *** Luzi has quit IRC | 10:41 | |
| *** gtema has quit IRC | 10:53 | |
| *** gtema has joined #openstack-sdks | 10:53 | |
| *** Luzi has joined #openstack-sdks | 10:56 | |
| openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in message and workflow unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790219 | 11:00 |
| *** gtema has quit IRC | 11:06 | |
| *** gtema has joined #openstack-sdks | 11:11 | |
| *** gtema has quit IRC | 11:37 | |
| *** gtema has joined #openstack-sdks | 11:41 | |
| openstackgerrit | Dr. Jens Harbott proposed openstack/openstacksdk master: Revert overwriting tags for the imagev2 resource https://review.opendev.org/c/openstack/openstacksdk/+/790229 | 11:49 |
| frickler | gtema: noonedeadpunk: ^^ that's what came out of my testing, not sure whether that is the correct way forward, but if fixes the test cases for me | 11:50 |
| frickler | s/if/it | 11:50 |
| *** udesale has joined #openstack-sdks | 11:51 | |
| gtema | that's not correct way, since in this case fetching tags info will/may not properly work | 11:51 |
| gtema | most likely https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L2058 should be copied into the https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/image.py and https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L2076 (updating attribute) removed | 11:54 |
| gtema | maybe even completely 2069-2078 removed | 11:54 |
| frickler | o.k., then someone else needs to take this over. the revert would at least unblock osc and consumers | 11:55 |
| gtema | will try to find time in the upcoming days | 11:56 |
| *** cenne is now known as cenn | 11:59 | |
| *** ysandeep is now known as ysandeep|brb | 12:05 | |
| *** __ministry has quit IRC | 12:12 | |
| *** brinzhang has joined #openstack-sdks | 12:14 | |
| *** ysandeep|brb is now known as ysandeep | 12:29 | |
| *** enriquetaso has joined #openstack-sdks | 13:27 | |
| *** jpich has quit IRC | 13:37 | |
| *** jpich has joined #openstack-sdks | 13:38 | |
| *** whoami-rajat has joined #openstack-sdks | 13:39 | |
| *** gtema has quit IRC | 13:46 | |
| *** gtema has joined #openstack-sdks | 13:47 | |
| *** Luzi has quit IRC | 14:00 | |
| *** __ministry has joined #openstack-sdks | 14:22 | |
| *** rpittau is now known as rpittau|afk | 14:29 | |
| *** gtema has quit IRC | 14:53 | |
| *** gtema has joined #openstack-sdks | 14:54 | |
| *** jpich has quit IRC | 15:08 | |
| *** jpich has joined #openstack-sdks | 15:08 | |
| *** gtema has quit IRC | 15:45 | |
| *** gtema has joined #openstack-sdks | 15:45 | |
| *** ysandeep is now known as ysandeep|away | 16:01 | |
| *** jpich has quit IRC | 16:04 | |
| *** sum12- has joined #openstack-sdks | 16:19 | |
| *** sum12 has quit IRC | 16:19 | |
| *** dtantsur is now known as dtantsur|afk | 17:12 | |
| *** udesale has quit IRC | 17:32 | |
| *** ralonsoh has quit IRC | 17:34 | |
| *** gtema has quit IRC | 17:53 | |
| *** brinzhang_ has joined #openstack-sdks | 17:53 | |
| *** brinzhang has quit IRC | 17:56 | |
| *** __ministry has quit IRC | 18:09 | |
| *** knikolla has quit IRC | 18:32 | |
| *** lxkong has quit IRC | 18:32 | |
| *** knikolla has joined #openstack-sdks | 18:35 | |
| *** lxkong has joined #openstack-sdks | 18:35 | |
| openstackgerrit | Polina Gubina proposed openstack/openstacksdk master: Add IPsecSiteConnection resource and proxy layer functionality for it https://review.opendev.org/c/openstack/openstacksdk/+/788474 | 19:26 |
| openstackgerrit | Polina Gubina proposed openstack/openstacksdk master: Add IPsecSiteConnection resource and proxy layer functionality for it https://review.opendev.org/c/openstack/openstacksdk/+/788474 | 19:33 |
| *** efried has quit IRC | 20:00 | |
| *** efried has joined #openstack-sdks | 20:00 | |
| *** artom has quit IRC | 20:01 | |
| *** artom has joined #openstack-sdks | 20:02 | |
| *** Hybrid512 has quit IRC | 23:06 | |
| *** tosky has quit IRC | 23:08 | |
| *** enriquetaso has quit IRC | 23:32 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!