| *** artom has quit IRC | 00:14 | |
| *** artom has joined #openstack-sdks | 00:14 | |
| *** jistr has quit IRC | 00:18 | |
| *** jistr has joined #openstack-sdks | 00:19 | |
| *** iurygregory has quit IRC | 01:16 | |
| *** iurygregory has joined #openstack-sdks | 01:17 | |
| *** iurygregory has quit IRC | 01:18 | |
| *** iurygregory has joined #openstack-sdks | 01:18 | |
| *** iurygregory has quit IRC | 02:08 | |
| *** iurygregory has joined #openstack-sdks | 02:09 | |
| *** evrardjp has quit IRC | 02:33 | |
| *** evrardjp has joined #openstack-sdks | 02:33 | |
| *** diablo_rojo has quit IRC | 02:40 | |
| *** udesale has joined #openstack-sdks | 03:05 | |
| *** enriquetaso has quit IRC | 03:06 | |
| *** whoami-rajat has joined #openstack-sdks | 05:17 | |
| *** adriant has quit IRC | 05:43 | |
| *** iokiwi has quit IRC | 05:43 | |
| *** ysandeep|away is now known as ysandeep | 05:59 | |
| *** ralonsoh has joined #openstack-sdks | 06:10 | |
| *** slaweq has joined #openstack-sdks | 06:10 | |
| *** gtema has joined #openstack-sdks | 06:47 | |
| *** tosky has joined #openstack-sdks | 07:33 | |
| *** ysandeep is now known as ysandeep|lunch | 07:47 | |
| *** jpich has joined #openstack-sdks | 08:01 | |
| *** Luzi has joined #openstack-sdks | 08:18 | |
| *** jpich has quit IRC | 08:39 | |
| *** jpich has joined #openstack-sdks | 08:40 | |
| *** ysandeep|lunch is now known as ysandeep | 09:07 | |
| *** jpich has quit IRC | 09:34 | |
| *** jpich has joined #openstack-sdks | 09:35 | |
| *** gtema has quit IRC | 09:51 | |
| *** gtema has joined #openstack-sdks | 09:56 | |
| slaweq | gtema: stephenfin and other sdk cores, can You take a look at https://review.opendev.org/c/openstack/openstacksdk/+/782870? thx in advance | 10:01 |
|---|---|---|
| *** gtema has quit IRC | 10:06 | |
| *** gtema has joined #openstack-sdks | 10:12 | |
| stephenfin | gtema: Can you look at https://review.opendev.org/c/openstack/openstacksdk/+/782870 again? | 10:25 |
| stephenfin | I spotted one thing | 10:25 |
| stephenfin | slaweq: ^ | 10:25 |
| slaweq | stephenfin: thx, checking | 10:26 |
| slaweq | stephenfin: thx, I will address Your comments today | 10:27 |
| *** jpich has quit IRC | 10:40 | |
| *** jpich has joined #openstack-sdks | 10:40 | |
| *** openstackgerrit has joined #openstack-sdks | 10:41 | |
| openstackgerrit | Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870 | 10:41 |
| slaweq | stephenfin: gtema updated ^^ | 10:42 |
| slaweq | thx for review | 10:42 |
| slaweq | according that "assert isinstance()" I changed that but there is a lot of other places where it is used in functional tests | 10:43 |
| slaweq | do You think we should change it everywhere? | 10:43 |
| gtema | generally yes, but not now. Part of R1.0 - would be cool | 10:43 |
| slaweq | gtema: ok | 10:44 |
| *** gtema has quit IRC | 10:49 | |
| stephenfin | slaweq: Think you missed a test | 10:56 |
| *** gtema has joined #openstack-sdks | 10:59 | |
| *** mugsie__ is now known as mugsie | 11:01 | |
| openstackgerrit | Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870 | 11:03 |
| *** gtema has quit IRC | 11:13 | |
| *** gtema has joined #openstack-sdks | 11:33 | |
| *** dtantsur|afk is now known as dtantsur | 11:34 | |
| *** sshnaidm|off is now known as sshnaidm | 11:57 | |
| *** enriquetaso has joined #openstack-sdks | 12:36 | |
| *** jpich has quit IRC | 12:48 | |
| *** jpich has joined #openstack-sdks | 12:49 | |
| *** smcginnis has quit IRC | 12:53 | |
| openstackgerrit | David Hill proposed openstack/python-openstackclient master: Add rule parameter in openstackclient https://review.opendev.org/c/openstack/python-openstackclient/+/784100 | 13:19 |
| noonedeadpunk | I'm not sure, it feels like I missed to add some test, but wasn't able to find current one... And don't feel strength in writing proper one from scratch for https://review.opendev.org/c/openstack/openstacksdk/+/783849 | 13:28 |
| *** Luzi has quit IRC | 13:40 | |
| *** gtema has quit IRC | 13:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add rule parameter in openstackclient https://review.opendev.org/c/openstack/python-openstackclient/+/784100 | 14:03 |
| *** BakaKuna has joined #openstack-sdks | 14:40 | |
| openstackgerrit | Stephen Finucane proposed openstack/osc-lib master: parseractions: Make key validation reusable https://review.opendev.org/c/openstack/osc-lib/+/784110 | 14:50 |
| *** gtema has joined #openstack-sdks | 15:06 | |
| *** __ministry1 has joined #openstack-sdks | 15:10 | |
| *** noonedeadpunk has quit IRC | 15:27 | |
| *** noonedeadpunk has joined #openstack-sdks | 15:28 | |
| *** ysandeep is now known as ysandeep|away | 15:47 | |
| *** gtema has quit IRC | 15:48 | |
| *** gtema has joined #openstack-sdks | 15:52 | |
| *** __ministry1 has quit IRC | 16:01 | |
| *** diablo_rojo has joined #openstack-sdks | 16:06 | |
| *** gtema has quit IRC | 16:10 | |
| *** jpich has quit IRC | 16:16 | |
| openstackgerrit | Ryan Zimmerman proposed openstack/openstacksdk master: Add compute microversion 2.57 https://review.opendev.org/c/openstack/openstacksdk/+/781131 | 16:27 |
| *** gtema has joined #openstack-sdks | 16:29 | |
| stephenfin | gtema: Can you take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/773649 and https://review.opendev.org/c/openstack/python-openstackclient/+/780030 please? | 16:44 |
| gtema | ok | 16:44 |
| gtema | how should the pre-commit-hook work? I checked out your change, tried to add broken commit and nothing happened | 16:47 |
| *** udesale has quit IRC | 16:54 | |
| *** dtantsur is now known as dtantsur|afk | 17:04 | |
| stephenfin | gtema: Did you install pre-commit? | 17:09 |
| gtema | and how to do that? maybe this hints a release note is missing | 17:09 |
| stephenfin | I didn't want to include a release note because it seemed too internal | 17:10 |
| stephenfin | I could add docs though | 17:10 |
| gtema | exactly, and that is therefore unclear how to use | 17:10 |
| gtema | it's just every git is using their own way to use hooks and I never seen .pre-commit-config.yaml usage | 17:11 |
| *** gtema has quit IRC | 17:15 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030 | 17:19 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: hacking: Remove references to encoding https://review.opendev.org/c/openstack/python-openstackclient/+/784138 | 17:19 |
| *** gtema has joined #openstack-sdks | 18:39 | |
| openstackgerrit | Merged openstack/python-openstackclient master: network: Add support for vnic-type vdpa https://review.opendev.org/c/openstack/python-openstackclient/+/778571 | 18:40 |
| *** gtema has quit IRC | 18:53 | |
| *** gtema has joined #openstack-sdks | 18:57 | |
| *** gtema has quit IRC | 19:20 | |
| *** gtema has joined #openstack-sdks | 19:23 | |
| *** gtema has quit IRC | 19:31 | |
| openstackgerrit | Ashley Rodriguez proposed openstack/openstacksdk master: Add share access rules resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/784162 | 20:12 |
| *** ralonsoh has quit IRC | 20:31 | |
| *** whoami-rajat has quit IRC | 20:47 | |
| *** dansmith has quit IRC | 21:33 | |
| *** dansmith has joined #openstack-sdks | 21:38 | |
| *** artom has quit IRC | 21:44 | |
| *** artom has joined #openstack-sdks | 21:45 | |
| openstackgerrit | Mark Tony proposed openstack/openstacksdk master: Add a share network resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/784177 | 22:25 |
| openstackgerrit | Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the GroupType resource https://review.opendev.org/c/openstack/openstacksdk/+/784178 | 22:33 |
| openstackgerrit | Dylan Zapzalka proposed openstack/openstacksdk master: WIP Added support for the GroupType resource https://review.opendev.org/c/openstack/openstacksdk/+/784178 | 22:33 |
| *** BakaKuna has quit IRC | 22:38 | |
| *** enriquetaso has quit IRC | 22:39 | |
| *** tosky has quit IRC | 23:30 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!