| *** artom has quit IRC | 00:21 | |
| *** artom has joined #openstack-sdks | 00:22 | |
| *** artom has quit IRC | 01:04 | |
| *** jawad_axd has quit IRC | 01:19 | |
| openstackgerrit | Merged openstack/openstacksdk master: Remove duplicate test_zone_create https://review.opendev.org/763062 | 01:22 |
|---|---|---|
| openstackgerrit | Merged openstack/python-openstackclient master: trivial: Document removal of support for agents https://review.opendev.org/762825 | 01:22 |
| openstackgerrit | Emilien Macchi proposed openstack/openstacksdk stable/victoria: Don't set list_type to dict for server groups. https://review.opendev.org/763119 | 03:01 |
| openstackgerrit | Emilien Macchi proposed openstack/openstacksdk stable/ussuri: Don't set list_type to dict for server groups. https://review.opendev.org/763120 | 03:01 |
| openstackgerrit | Emilien Macchi proposed openstack/openstacksdk stable/train: Don't set list_type to dict for server groups. https://review.opendev.org/763121 | 03:01 |
| *** brinzhang has joined #openstack-sdks | 03:03 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-sdks | 05:33 | |
| *** rpittau|afk is now known as rpittau | 06:49 | |
| *** nikparasyr has joined #openstack-sdks | 06:54 | |
| *** gtema has joined #openstack-sdks | 07:29 | |
| *** ralonsoh has joined #openstack-sdks | 07:31 | |
| *** slaweq has joined #openstack-sdks | 07:43 | |
| *** dtantsur|afk is now known as dtantsur | 07:51 | |
| *** lbragstad_ has joined #openstack-sdks | 08:18 | |
| *** lbragstad has quit IRC | 08:22 | |
| *** iurygregory has quit IRC | 08:44 | |
| *** tosky has joined #openstack-sdks | 08:45 | |
| *** Hybrid512 has joined #openstack-sdks | 08:48 | |
| *** iurygregory has joined #openstack-sdks | 08:50 | |
| *** jpich has joined #openstack-sdks | 09:03 | |
| *** slaweq has quit IRC | 09:17 | |
| *** slaweq has joined #openstack-sdks | 09:19 | |
| *** yolanda__ has joined #openstack-sdks | 09:50 | |
| *** yoctozepto has quit IRC | 09:50 | |
| *** brinzhang_ has joined #openstack-sdks | 09:51 | |
| *** yoctozepto has joined #openstack-sdks | 09:51 | |
| *** brinzhang has quit IRC | 09:54 | |
| stephenfin | gtema: I was finished for the evening, but I'm here now | 09:54 |
| gtema | oki, no problem | 10:01 |
| gtema | "openstack aggregate cache image __aggregate__ __im1__ __im2__ __im3__" is not cool from my pov | 10:01 |
| stephenfin | Probably best to look at the reply I just left on the review. I'm not recommending this in isolation: there are numerous other examples of this is OSC already | 10:03 |
| gtema | well, from what I see when we support multiple inputs under the resource - it is a named parameter | 10:04 |
| gtema | so for me in this case it is really using a named param and not positional | 10:04 |
| gtema | while positional is used only for i.e. deleting multiple resources | 10:04 |
| stephenfin | See my reply. That's not true with OSC today. There are other non-deletion examples of passing multiple child resources | 10:05 |
| stephenfin | And personally I'd like to expand (in a follow-up, of course) some of the ones that only accept a single child resource to accept multiple child resources, e.g. 'aggregate add host' | 10:06 |
| gtema | for me the "object create _container_ _file1_ _file2_" is example where we do this | 10:07 |
| gtema | since deletion is not fitting as example - it is top resource | 10:07 |
| stephenfin | Yes, that's fair. 'object create' is a valid thing too though, and proves that this can work | 10:07 |
| gtema | I know it can work like that | 10:08 |
| gtema | it's just in my experience this is not a good UX | 10:08 |
| stephenfin | Positional arguments wouldn't make sense for something like 'flavor create'. i.e. you wouldn't do 'flavor create 512 4 0' instead of 'flavor create --ram 512 --vcpu 4 --disk 0' | 10:08 |
| stephenfin | but that's because those additional arguments are attributes of the resource. Also, they're all different meaning it's impossible to parse | 10:09 |
| gtema | exactly, and one step further if in one call you want to create multiple flavors ... | 10:09 |
| gtema | here images are also arguments to the aggregate | 10:09 |
| stephenfin | they're not though | 10:09 |
| stephenfin | they're resources in their own right | 10:09 |
| stephenfin | the command is called 'aggregate cache image' | 10:10 |
| stephenfin | so you're caching an <image> for an <aggregate>; those are two separate resources and there aren't multiple attributes to be set | 10:10 |
| gtema | well yes. When you use named params you can really mix positions of positional and named ones | 10:11 |
| gtema | create image _name_ --param1 --param2 | 10:12 |
| gtema | and | 10:12 |
| gtema | create image --param1 name --param2 | 10:12 |
| gtema | with this way of using only positional ones you have absolutely no choice | 10:12 |
| stephenfin | I don't think this is an issue | 10:13 |
| gtema | :) - for me yes. When you use IDs instead of names you have no clue looking to the command you type whether order is right or not | 10:13 |
| gtema | I was having with that pretty much problems in DNS area | 10:14 |
| stephenfin | traditional would dictate if your command is called '<resource_a> <action> <resource_b>', then the invocation of that looks like '<resource_a> <resource_b>' | 10:14 |
| gtema | "image cache cde42cs abcdef46423 cbfedf454334" - what is what | 10:14 |
| stephenfin | 'server add floating ip' -> 'SERVER FLOATING_IP'; 'aggregate add host' -> 'AGGREGATE HOST' | 10:15 |
| stephenfin | the first one is the aggregate, of course :) | 10:15 |
| gtema | can you add multiple FIPs in same command? | 10:15 |
| stephenfin | no, because the FIPs have an optional attribute | 10:16 |
| stephenfin | (fixed IP address) | 10:16 |
| gtema | aggregate add host also doesn'T allow multiple hosts | 10:16 |
| stephenfin | <stephenfin> And personally I'd like to expand (in a follow-up, of course) some of the ones that only accept a single child resource to accept multiple child resources, e.g. 'aggregate add host' | 10:16 |
| gtema | :D | 10:17 |
| stephenfin | and again, 'object create' does, so we have prior art here | 10:17 |
| gtema | I started SDK change for adding host support and was pulling hears from my head yesterday | 10:17 |
| stephenfin | :-D OSC and openstacksdk are both opinionated libraries. It's fair to expect strong opinions ;) | 10:18 |
| gtema | that's true | 10:18 |
| stephenfin | Also, to my credit, I think the rest of my reviews have been fair and I've caught a good few bugs | 10:18 |
| gtema | let me perhaps say like that: you come from nova, so I expect you more to be responsible for the nova CLIs | 10:19 |
| gtema | to your credit - sure. Great work | 10:20 |
| stephenfin | If the concern is purely with the fact that you can specify multiple images, then I'd be okay with only accepting a single image, i.e. 'aggregate cache image AGGREGATE IMAGE' | 10:20 |
| stephenfin | People can always invoke it multiple times | 10:20 |
| stephenfin | I really do think positional is the way to go though, and the fact that mriedem said the same (and dansmith didn't argue with him) helps my case | 10:21 |
| * stephenfin wishes we'd dtroyer around to settle things for us | 10:21 | |
| gtema | yeah yeah, doing that | 10:21 |
| gtema | nice hint with another patch - haven't seen that | 10:25 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server * -f yaml' output https://review.opendev.org/761205 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'usage * -f yaml' output https://review.opendev.org/761595 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server group * -f yaml' output https://review.opendev.org/761596 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'hypervisor show -f yaml' output https://review.opendev.org/763004 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add support for 'server group create --rule' parameter https://review.opendev.org/761597 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: trivial: Use plural for appended parameters https://review.opendev.org/761598 | 10:26 |
| openstackgerrit | Artem Goncharov proposed openstack/python-openstackclient master: Switch compute aggregate functions to SDK https://review.opendev.org/762134 | 10:26 |
| gtema | here you go | 10:26 |
| stephenfin | thanks :) | 10:27 |
| openstackgerrit | Ananya proposed openstack/ansible-collections-openstack master: migrating routers_info from AnsibleModule to OpenStackModule https://review.opendev.org/763149 | 10:27 |
| gtema | stephenfin, do you think we need to cover reboot/shutdown/start host stuff in SDK? | 10:29 |
| gtema | I think OSC currently doesn't support those | 10:29 |
| stephenfin | The SDK is supposed to be complete, but that API (os-hosts) is deprecated and the things we said to use instead (os-hypervisors, os-services) are present in 2.1 iirc | 10:30 |
| gtema | investing time in deprecated/dropped functionality is hard | 10:30 |
| stephenfin | So I think it's exceptionally low priority, IMO. I wouldn't bother, personally | 10:30 |
| gtema | pretty much same for me | 10:31 |
| gtema | my plan was to get basic host ops covered in SDK to be able to use them from OSC | 10:31 |
| stephenfin | we already have e.g. 'hypervisors list' | 10:32 |
| stephenfin | so I think you're covered there? | 10:32 |
| stephenfin | that'll give you host information | 10:32 |
| gtema | that's true, but if you want to fill 'openstack aggregate add host' with host check you need that | 10:33 |
| gtema | or you mean hypervisors are really giving same info back? | 10:33 |
| stephenfin | the latter; it's the same information exposed by both afaik | 10:33 |
| gtema | hm, interesting | 10:33 |
| stephenfin | To be clear though, that idea was also a nice-to-have UX improvement. Converting more of the other commands to SDK like you've been doing is maybe more helpful? | 10:35 |
| stephenfin | I should start prefixing those comments with 'idea:' or something to distinguish them | 10:35 |
| gtema | perfectly fine with that. I would be perhaps better if I work on SDK switch changes (SDK and OSC) and you improve UX | 10:36 |
| stephenfin | wfm :) | 10:36 |
| gtema | hypervisor vs host are 2 totally different set of APIs (facepalm) | 10:36 |
| gtema | making smooth transition is not easy | 10:37 |
| gtema | especially getting host details is so bad, while getting hypervisor details is ok | 10:37 |
| gtema | you will participate tomorrow in a meeting, right? | 10:39 |
| stephenfin | gtema: We could just deprecate the 'host *' commands | 10:39 |
| gtema | I wanted to agree on the "order" of next switches | 10:39 |
| stephenfin | rather than providing a shim | 10:39 |
| gtema | interesting idea. This would however mean we can't drop novaclient from deps in a long run | 10:39 |
| stephenfin | it's not like we'll break older clouds; those have os-hypervisors and os-services too | 10:40 |
| gtema | we did that with glance | 10:40 |
| stephenfin | we could if deprecate them for removal | 10:40 |
| stephenfin | i.e. we'll drop novaclient in the next major version bump | 10:40 |
| stephenfin | fwiw, we have the same issue with commands like 'server add floating ip' | 10:40 |
| gtema | I was personally thinking to do a major bump with nova switch, so we can take it with us | 10:41 |
| stephenfin | those use deprecated "orchestration" APIs; I've seen patches to replace some of those with client side equivalents but I'm not sure if that's better than asking people to do this stuff manually | 10:41 |
| stephenfin | as for the meeting, that's a 14:00 UTC, yeah? I can be there | 10:41 |
| gtema | so you suggest not to deal with host (SDK/OSC) as of now at all? | 10:42 |
| stephenfin | unless you really want to | 10:42 |
| stephenfin | just deprecate the commands and remove them in a future major version bump | 10:42 |
| gtema | surely not. As I said - my hears were flying around yesterday | 10:43 |
| stephenfin | then let's do that; if someone complains, they can do the SDK work :) | 10:43 |
| gtema | perhaps I will then finish SDK patch as is to get some sort of support | 10:43 |
| gtema | oki, then I will start with hypervisors next | 10:44 |
| *** belmoreira has joined #openstack-sdks | 10:46 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for deprecated nova hosts https://review.opendev.org/763081 | 10:47 |
| *** yolanda__ is now known as yolanda | 11:00 | |
| openstackgerrit | Ananya proposed openstack/ansible-collections-openstack master: Migrating routers_info from AnsibleModule to OpenStackModule https://review.opendev.org/763162 | 11:15 |
| openstackgerrit | Ananya proposed openstack/ansible-collections-openstack master: Migrating routers_info from AnsibleModule to OpenStackModule https://review.opendev.org/763162 | 11:28 |
| *** jpich has quit IRC | 11:29 | |
| *** jpich has joined #openstack-sdks | 11:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'server shelve --offload', 'server shelve --wait' options https://review.opendev.org/762396 | 11:36 |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Add 'server unshelve --wait' option https://review.opendev.org/763166 | 11:36 |
| *** slaweq has quit IRC | 11:39 | |
| *** slaweq has joined #openstack-sdks | 11:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server show --topology' option https://review.opendev.org/680928 | 11:53 |
| openstackgerrit | Merged openstack/openstacksdk master: Add update_flavor method https://review.opendev.org/762989 | 12:07 |
| openstackgerrit | Merged openstack/openstacksdk master: Complete compute aggregate functions https://review.opendev.org/762131 | 12:08 |
| openstackgerrit | Merged openstack/openstacksdk stable/victoria: Don't set list_type to dict for server groups. https://review.opendev.org/763119 | 12:08 |
| *** enriquetaso has joined #openstack-sdks | 13:01 | |
| *** dtantsur is now known as dtantsur|brb | 13:06 | |
| *** artom has joined #openstack-sdks | 13:17 | |
| stephenfin | gtema: FYI https://review.opendev.org/#/c/763178/ | 13:26 |
| stephenfin | that should unblock your aggregate and flavor OSC changes | 13:27 |
| gtema | hmm, I wanted to go with hypervisors further, but ok | 13:27 |
| gtema | do not really want to make release each week ;-), but is still required | 13:28 |
| stephenfin | meh, releases are cheap :) | 13:28 |
| openstackgerrit | Merged openstack/python-openstackclient master: Add a few selectable fields to the "openstack server list" output https://review.opendev.org/741181 | 13:28 |
| openstackgerrit | Merged openstack/openstacksdk master: Update TOX_CONSTRAINTS_FILE https://review.opendev.org/761055 | 13:28 |
| openstackgerrit | Merged openstack/python-openstackclient master: update lower-constraints.txt https://review.opendev.org/760270 | 13:28 |
| stephenfin | but we can wait of course, if you'd prefer | 13:29 |
| gtema | yes, they are | 13:29 |
| gtema | already +1-ed | 13:29 |
| stephenfin | sweet | 13:30 |
| gtema | hypervisors API is also not so straight forward | 13:32 |
| gtema | but not that bad as host | 13:32 |
| *** jpich has quit IRC | 14:01 | |
| *** jpich has joined #openstack-sdks | 14:02 | |
| openstackgerrit | Gregory Thiemonge proposed openstack/openstacksdk master: Add tls_enabled param for Octavia Pools https://review.opendev.org/763189 | 14:16 |
| openstackgerrit | Gregory Thiemonge proposed openstack/openstacksdk master: Add tls_enabled param for Octavia Pools https://review.opendev.org/763189 | 14:17 |
| *** dtantsur|brb is now known as dtantsur | 14:22 | |
| *** lbragstad_ is now known as lbragstad | 14:59 | |
| *** artom has quit IRC | 15:19 | |
| *** artom has joined #openstack-sdks | 15:22 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/763202 | 15:26 |
| *** nikparasyr has left #openstack-sdks | 15:46 | |
| *** belmoreira has quit IRC | 16:27 | |
| *** jpich has quit IRC | 17:14 | |
| *** gtema has quit IRC | 17:22 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListPort query https://review.opendev.org/754117 | 17:42 |
| openstackgerrit | Stephen Finucane proposed openstack/cliff master: trivial: Remove references to Python 2.7 https://review.opendev.org/760334 | 18:06 |
| *** dtantsur is now known as dtantsur|afk | 18:15 | |
| *** LinPeiWen67 has quit IRC | 18:26 | |
| *** ralonsoh has quit IRC | 18:31 | |
| -openstackstatus- NOTICE: The Gerrit service at review.opendev.org is being restarted quickly as a pre-upgrade sanity check, estimated downtime is less than 5 minutes. | 18:36 | |
| *** rpittau is now known as rpittau|afk | 18:39 | |
| *** openstackgerrit has quit IRC | 19:02 | |
| *** efried has quit IRC | 19:18 | |
| *** Hybrid512 has quit IRC | 19:38 | |
| *** openstackgerrit has joined #openstack-sdks | 19:56 | |
| openstackgerrit | Merged openstack/cliff master: Remove six https://review.opendev.org/754683 | 19:56 |
| *** efried has joined #openstack-sdks | 20:31 | |
| *** ricolin has quit IRC | 20:40 | |
| *** slaweq has quit IRC | 20:58 | |
| openstackgerrit | Merged openstack/cliff master: trivial: Remove references to Python 2.7 https://review.opendev.org/760334 | 21:08 |
| *** slaweq has joined #openstack-sdks | 21:30 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add tls_enabled param for Octavia Pools https://review.opendev.org/763189 | 21:42 |
| *** slaweq has quit IRC | 22:16 | |
| *** vkmc has quit IRC | 22:26 | |
| *** vkmc has joined #openstack-sdks | 22:26 | |
| *** johnsom has quit IRC | 22:27 | |
| *** johnsom has joined #openstack-sdks | 22:29 | |
| *** holser has quit IRC | 23:35 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!