| *** tosky has quit IRC | 00:26 | |
| *** LinPeiWen has joined #openstack-sdks | 00:30 | |
| *** lbragstad has joined #openstack-sdks | 01:37 | |
| *** lbragstad has quit IRC | 02:13 | |
| *** lbragstad has joined #openstack-sdks | 02:40 | |
| *** brinzhang has joined #openstack-sdks | 03:23 | |
| *** lbragstad has quit IRC | 03:27 | |
| *** lbragstad has joined #openstack-sdks | 03:33 | |
| *** brinzhang has quit IRC | 03:44 | |
| *** lbragstad has quit IRC | 04:44 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-sdks | 05:33 | |
| openstackgerrit | zhufl proposed openstack/openstacksdk master: Fix invalid assertIsNotNone statement https://review.opendev.org/761053 | 05:47 |
|---|---|---|
| *** brinzhang has joined #openstack-sdks | 05:58 | |
| openstackgerrit | wu.shiming proposed openstack/openstacksdk master: Update TOX_CONSTRAINTS_FILE https://review.opendev.org/761055 | 05:59 |
| *** nikparasyr has joined #openstack-sdks | 06:31 | |
| *** gtema has joined #openstack-sdks | 07:35 | |
| *** brinzhang_ has joined #openstack-sdks | 07:37 | |
| *** brinzhang has quit IRC | 07:40 | |
| *** ralonsoh has joined #openstack-sdks | 07:41 | |
| *** Luzi has joined #openstack-sdks | 07:45 | |
| *** slaweq has joined #openstack-sdks | 08:01 | |
| *** gtema has quit IRC | 08:08 | |
| *** gtema has joined #openstack-sdks | 08:10 | |
| *** rpittau|afk is now known as rpittau | 08:19 | |
| *** tosky has joined #openstack-sdks | 08:40 | |
| *** jpich has joined #openstack-sdks | 09:01 | |
| *** dtantsur|afk is now known as dtantsur | 09:35 | |
| *** nightmare_unreal has joined #openstack-sdks | 09:41 | |
| nightmare_unreal | brinzhang_: stephenfin can you review the code : https://review.opendev.org/#/c/741181/ | 09:41 |
| nightmare_unreal | Thanks . Hopefully it's correct this time | 09:41 |
| *** brinzhang_ has quit IRC | 09:49 | |
| *** brinzhang_ has joined #openstack-sdks | 09:49 | |
| brinzhang_ | nightmare_unreal: ack, added in my list | 09:50 |
| nightmare_unreal | thanks | 09:50 |
| *** Hybrid512 has joined #openstack-sdks | 09:52 | |
| *** sshnaidm|afk is now known as sshnaidm|rover | 09:56 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Fix formatting of the flavor properties https://review.opendev.org/760906 | 10:07 |
| dtantsur | hey folks! we're working on ansible 2.10 support in bifrost, does this ring any bells: | 10:11 |
| dtantsur | https://zuul.opendev.org/t/openstack/build/6302f5b438e24bfd95b14c25fccb11d0/log/job-output.txt#673 | 10:11 |
| dtantsur | sshnaidm|rover: ^^? | 10:11 |
| dtantsur | the same code used to work a few days ago | 10:11 |
| gtema | maybe https://review.opendev.org/#/c/746883/? | 10:12 |
| dtantsur | have we released that& | 10:13 |
| dtantsur | ? | 10:13 |
| gtema | I guess not | 10:13 |
| gtema | it's merged, but not released in galaxy | 10:13 |
| sshnaidm|rover | right, not released | 10:14 |
| dtantsur | we're using galaxy, so it's not it | 10:14 |
| dtantsur | https://github.com/ansible/ansible/blob/e05c62547b3d547ffb433d1cf66e82b353f24262/lib/ansible/utils/collection_loader/_collection_finder.py#L398 is not new at all, I wonder why we only hit it now | 10:14 |
| sshnaidm|rover | dtantsur, I think I got these errors while using old ansible-lint | 10:15 |
| sshnaidm|rover | looks very familair | 10:15 |
| dtantsur | mmm, that's a hint! it's the linter job that fails | 10:15 |
| dtantsur | how old was that, do you recall? | 10:15 |
| dtantsur | I think we're using the latest one though.. | 10:16 |
| sshnaidm|rover | dtantsur, https://review.opendev.org/#/c/753760/ | 10:16 |
| sshnaidm|rover | seems like related to py3.8 | 10:16 |
| dtantsur | sweet | 10:17 |
| sshnaidm|rover | and this https://review.opendev.org/#/c/754074/ | 10:19 |
| sshnaidm|rover | moved to bionic since it doesn't have 3.8 as default | 10:19 |
| dtantsur | avoiding 2.10 is an option, but we cannot do it forever | 10:19 |
| dtantsur | (especially since the actual code works) | 10:19 |
| sshnaidm|rover | dtantsur, where is your ansible-lint config? | 10:20 |
| dtantsur | sshnaidm|rover: not much interesting there https://opendev.org/openstack/bifrost/src/branch/master/.ansible-lint | 10:21 |
| sshnaidm|rover | still 1.0.0? https://opendev.org/openstack/bifrost/src/branch/master/ansible-collections-requirements.yml | 10:24 |
| dtantsur | sshnaidm|rover: is it a hard cap or a lower cap? | 10:25 |
| sshnaidm|rover | I think hard | 10:25 |
| sshnaidm|rover | dtantsur, just for an experiment, I'd try to run it on ubuntu-bionic | 10:25 |
| sshnaidm|rover | to know if it's py3.8 issue | 10:25 |
| sshnaidm|rover | but most probably not.. | 10:26 |
| dtantsur | I can change basepython locally | 10:26 |
| dtantsur | (I see it on my fedora just as well, but it also uses 3.8 | 10:26 |
| dtantsur | fails with 3.6 just as well | 10:28 |
| sshnaidm|rover | dtantsur, where do you install collection in the job? | 10:30 |
| dtantsur | okay, I think I got it. lemme show you in a minute | 10:30 |
| dtantsur | sshnaidm|rover: https://review.opendev.org/#/c/760127/5/tools/ansible-lint.sh | 10:34 |
| sshnaidm|rover | dtantsur, oh, so it didn't find collection | 10:35 |
| dtantsur | sshnaidm|rover: it DID find the collection, that's the problem | 10:36 |
| dtantsur | it found it via some implicit logic and choked on it | 10:36 |
| openstackgerrit | Cédric Jeanneret (Tengu) proposed openstack/keystoneauth stable/train: Cleanup session on delete https://review.opendev.org/760911 | 10:37 |
| sshnaidm|rover | tbh hard to understand where it's installed.. why not to build from ~/src/openstack/openstack-ansible-collections or whatever it is | 10:38 |
| sshnaidm|rover | that way you can use the newest from repo, not 1.0.0 release.. | 10:39 |
| dtantsur | sshnaidm|rover: you mean, install it from source? maybe that's what we should do, dunno | 10:40 |
| sshnaidm|rover | dtantsur, yep | 10:40 |
| dtantsur | (the linters job always uses a pre-created source installation) | 10:40 |
| *** Luzi has quit IRC | 10:55 | |
| stephenfin | gtema: Any chance you could stick https://review.opendev.org/#/c/757874/ on your review queue, please? :) | 11:03 |
| gtema | yes. BTW you make me disappointed in my changes ;-) | 11:04 |
| stephenfin | gtema: Ha, sorry. I hope I wasn't too harsh /o\ Let me know if you disagree with anything, of course | 11:05 |
| gtema | no problem | 11:05 |
| stephenfin | (The main problem was the performance issue of the fetch-update proxy calls, btw. The rest were nits and could be ignored) | 11:05 |
| gtema | btw, regarding your comment on delete_flavor_extra_specs_property calling get_Flavor 2 times | 11:05 |
| gtema | are you sure? Cause it actually should not be the case | 11:06 |
| stephenfin | I'm not sure, no. I was just reading the the openstacksdk code and it seemed like it would do a fetch each time | 11:06 |
| stephenfin | Perhaps I'm misreading it? | 11:06 |
| gtema | nope, it should not | 11:06 |
| gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L305 | 11:07 |
| gtema | this is the get_resource, which is in the end being invoked to decide what we pass to it: id or instance of the object. | 11:07 |
| gtema | in reality it doesn't invoke the fetch again | 11:07 |
| stephenfin | You're calling it with flavor.id though | 11:08 |
| gtema | yes, and it is enough for it | 11:09 |
| stephenfin | which means you trigger this path, I think? https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L327-L331 | 11:09 |
| stephenfin | though i didn't check if that actually fetches things | 11:09 |
| gtema | if I pass complete object it has no advantage, but disadvantage of passing more data to other function (especially ugly in tests) | 11:09 |
| * stephenfin checks | 11:09 | |
| gtema | even here no request is being send | 11:10 |
| stephenfin | oh, okay, I wasn't expecting that | 11:10 |
| * stephenfin is relatively new to openstacksdk | 11:10 | |
| gtema | without commit this is not doing anything | 11:11 |
| gtema | no problem with that | 11:11 |
| stephenfin | in that case, ignore that comment :) sorry for the confusion | 11:11 |
| gtema | no problem | 11:11 |
| gtema | I am actually since perhaps a year confused on pretty much that issue - passing more than require is not good (especially for huge objects), but passing less cause some extra functions | 11:12 |
| stephenfin | yeah, the Resource model and general lazy loading concept it uses does take a bit of time to wrap your head around | 11:13 |
| gtema | yes, it's woodoo | 11:13 |
| *** dtantsur is now known as dtantsur|bbl | 11:16 | |
| *** dulek has joined #openstack-sdks | 11:30 | |
| dulek | Hi! We're using openstacksdk as our main tool to connect to OpenStack APIs. When there's high load we start too see "urllib3.connectionpool [-] Connection pool is full, discarding connection" warnings. | 11:31 |
| dulek | While it seems those are harmless, is there a way to increase pool size? How deep should I look? | 11:31 |
| gtema | dulek, what exactly are you doing? | 11:32 |
| dulek | gtema: A ton of calls to Neutron and Octavia. Kuryr is reacting to events in K8s, so the number of events being handled might be massive. | 11:32 |
| gtema | hmm, not that I am aware of any explicit connection pools we have | 11:33 |
| gtema | could be it is coming from keystonauth | 11:33 |
| dulek | gtema: Yeah, or even from requests. Okay, I'll try to dig deeper. | 11:34 |
| gtema | I hope there might be some logs pointing where it is really coming from | 11:34 |
| gtema | dulek - I haven't found any reference in SDK/Keystone for using connectionpools at all | 11:39 |
| dulek | gtema: There's this: https://github.com/openstack/keystoneauth/blob/1f0412a042103009c5a95230e058d08e5bd91fa1/keystoneauth1/session.py#L1423 | 11:40 |
| gtema | seems you might then face the defaults | 11:40 |
| dulek | Yup! | 11:40 |
| gtema | aah, from adapters | 11:40 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListPort query https://review.opendev.org/754117 | 11:45 |
| dulek | It doesn't seem trivial to pass bigger pool there. | 11:46 |
| openstackgerrit | Cédric Jeanneret (Tengu) proposed openstack/keystoneauth stable/train: Cleanup session on delete https://review.opendev.org/760911 | 12:10 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Switch flavor ops in the cloud layer to proxy https://review.opendev.org/761124 | 12:21 |
| *** Hybrid512 has quit IRC | 12:45 | |
| *** lbragstad has joined #openstack-sdks | 12:53 | |
| *** dtantsur|bbl is now known as dtantsur | 12:54 | |
| *** Luzi has joined #openstack-sdks | 12:56 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add 'openstack server migration list --type' option https://review.opendev.org/757874 | 12:58 |
| *** lbragstad has quit IRC | 13:06 | |
| *** lbragstad has joined #openstack-sdks | 13:09 | |
| openstackgerrit | Hervé Beraud proposed openstack/microversion-parse master: Use Python 3.8 as the default runtime for tox https://review.opendev.org/761145 | 13:32 |
| *** jpich has quit IRC | 13:36 | |
| *** jpich has joined #openstack-sdks | 13:37 | |
| *** slaweq has quit IRC | 13:42 | |
| *** slaweq has joined #openstack-sdks | 13:47 | |
| *** jpich has quit IRC | 13:50 | |
| *** jpich has joined #openstack-sdks | 13:51 | |
| *** Hybrid512 has joined #openstack-sdks | 13:58 | |
| openstackgerrit | Merged openstack/microversion-parse master: Use Python 3.8 as the default runtime for tox https://review.opendev.org/761145 | 14:08 |
| *** purplerbot has quit IRC | 14:52 | |
| *** mordred has quit IRC | 15:00 | |
| *** Luzi has quit IRC | 15:10 | |
| lbragstad | follow up stable review if folks are interested in taking a look https://review.opendev.org/#/c/746968/ | 15:37 |
| *** mordred has joined #openstack-sdks | 15:41 | |
| *** mordred has quit IRC | 15:47 | |
| *** mordred has joined #openstack-sdks | 15:57 | |
| openstackgerrit | Cédric Jeanneret (Tengu) proposed openstack/keystoneauth stable/train: Cleanup session on delete https://review.opendev.org/760911 | 15:59 |
| *** LinPeiWen has quit IRC | 16:00 | |
| *** dave-mccowan has joined #openstack-sdks | 16:35 | |
| *** rpittau is now known as rpittau|afk | 16:46 | |
| *** dtantsur is now known as dtantsur|afk | 16:47 | |
| *** purplerbot has joined #openstack-sdks | 17:03 | |
| *** jpich has quit IRC | 17:04 | |
| *** dave-mccowan has quit IRC | 17:12 | |
| *** dave-mccowan has joined #openstack-sdks | 17:17 | |
| *** sshnaidm|rover is now known as sshnaidm|afk | 17:22 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Format list of tags for 'server list' https://review.opendev.org/761205 | 17:22 |
| *** tosky has quit IRC | 17:57 | |
| *** gtema has quit IRC | 18:07 | |
| *** gtema has joined #openstack-sdks | 18:29 | |
| *** ralonsoh has quit IRC | 18:49 | |
| *** gtema has quit IRC | 18:55 | |
| *** ianw_pto is now known as ianw | 18:59 | |
| *** Hybrid512 has quit IRC | 19:06 | |
| *** camelCaser has quit IRC | 19:17 | |
| *** nikparasyr has left #openstack-sdks | 19:21 | |
| *** camelCaser has joined #openstack-sdks | 19:23 | |
| *** tosky has joined #openstack-sdks | 20:27 | |
| *** slaweq has quit IRC | 20:33 | |
| *** slaweq has joined #openstack-sdks | 20:44 | |
| *** slaweq has quit IRC | 22:02 | |
| *** holser has quit IRC | 22:10 | |
| *** holser has joined #openstack-sdks | 22:11 | |
| *** tkajinam has joined #openstack-sdks | 22:59 | |
| *** tosky has quit IRC | 23:01 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!