| *** senrique_ has quit IRC | 00:54 | |
| *** dave-mccowan has quit IRC | 03:14 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-sdks | 04:33 | |
| *** slaweq has joined #openstack-sdks | 07:02 | |
| *** nightmare_unreal has joined #openstack-sdks | 07:16 | |
| *** tosky has joined #openstack-sdks | 07:19 | |
| *** ralonsoh has joined #openstack-sdks | 07:33 | |
| *** jpena|off is now known as jpena | 07:56 | |
| *** ianw has quit IRC | 08:01 | |
| *** ianw has joined #openstack-sdks | 08:02 | |
| *** ccamel has joined #openstack-sdks | 08:02 | |
| *** camelCaser has quit IRC | 08:03 | |
| *** stingrayza has quit IRC | 08:45 | |
| *** stingrayza has joined #openstack-sdks | 08:46 | |
| *** yolanda has quit IRC | 09:06 | |
| *** yolanda has joined #openstack-sdks | 09:16 | |
| *** dtantsur|afk is now known as dtantsur | 09:19 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/keystoneauth master: Correct major version discovery for non-keystone plugins https://review.opendev.org/743282 | 09:32 |
|---|---|---|
| dtantsur | mordred, cmurphy, a short version, also seems to work for us ^^^ | 10:53 |
| *** jpena is now known as jpena|afk | 10:56 | |
| *** jpena|afk is now known as jpena | 11:20 | |
| *** tkajinam has quit IRC | 11:36 | |
| *** jpena is now known as jpena|lunch | 11:48 | |
| *** mgariepy has quit IRC | 11:52 | |
| *** mgariepy has joined #openstack-sdks | 11:53 | |
| *** lbragstad_ has joined #openstack-sdks | 12:00 | |
| *** mgariepy has quit IRC | 12:01 | |
| *** lbragstad has quit IRC | 12:03 | |
| *** mgariepy has joined #openstack-sdks | 12:15 | |
| *** enriquetaso has joined #openstack-sdks | 12:48 | |
| *** nightmare_unreal has quit IRC | 12:48 | |
| *** dave-mccowan has joined #openstack-sdks | 12:58 | |
| *** jpena|lunch is now known as jpena | 12:59 | |
| mordred | dtantsur: awesome | 14:11 |
| *** lbragstad_ is now known as lbragstad | 14:58 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "numa_affinity_policy" attribute to "port" https://review.opendev.org/740422 | 15:03 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add NUMA affinity policy parameter to "port" https://review.opendev.org/740501 | 15:19 |
| *** irclogbot_1 has quit IRC | 15:56 | |
| *** irclogbot_2 has joined #openstack-sdks | 15:58 | |
| *** irclogbot_2 has quit IRC | 16:15 | |
| *** irclogbot_1 has joined #openstack-sdks | 16:17 | |
| dtantsur | cmurphy, mordred, thank you for approving https://review.opendev.org/#/c/743282/ ! Would it be possible to have a release in the near future? | 16:40 |
| cmurphy | dtantsur: sure, propose it and have knikolla +1 it | 16:41 |
| dtantsur | okie. I'm leaving for a day, so I guess on Monday. | 16:42 |
| dtantsur | (unless it merges really soon) | 16:42 |
| *** jpena is now known as jpena|off | 17:01 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add compute microversion 2.6 and 2.8 https://review.opendev.org/741674 | 17:29 |
| openstackgerrit | Merged openstack/openstacksdk master: baremetal-introspection: allow fetching unprocessed data https://review.opendev.org/743517 | 17:29 |
| *** dtantsur is now known as dtantsur|afk | 17:33 | |
| *** artom has joined #openstack-sdks | 17:45 | |
| artom | o/ | 17:45 |
| artom | In the context of fixing server rebuild parameters and bring them in line with the actual Nova API (https://review.opendev.org/#/c/741688/) - what's the difference between rebuild_server() in openstack/cloud/_compute.py and openstack/compute/v2/_proxy.py? | 17:46 |
| *** ralonsoh has quit IRC | 17:52 | |
| openstackgerrit | Merged openstack/keystoneauth master: Correct major version discovery for non-keystone plugins https://review.opendev.org/743282 | 17:59 |
| mordred | artom: openstack/cloud/_compute.py is the layer that used to be shade. it's the layer where we do a bunch of extra business logic for people. If you have a Connection called conn - you'd call that one like conn.rebuild_server - amongst the things it does is hide even which service a particular action comes from (a design that was more important back in the day of nova-image and nova-network alongside glance and neutron) | 18:19 |
| mordred | artom: openstack/compute/v2/_proxy.py is a layer down - we have an eventual goal to have the shade layer use the resource layer instead of making direct rest calls | 18:20 |
| mordred | artom: so - you know - all sorts of good history there :) | 18:20 |
| artom | mordred, so no one is expected to call stuff in openstack/compute/v2/_proxy.py directly? | 18:21 |
| mordred | artom: nah - either are actually fine - that both exist is a historical oddity at this point - with a few things we've gotten all the way to the shade layer being just a backwards compat shim over the other layer | 18:22 |
| mordred | I personally just use the shade layer because it's less typing | 18:22 |
| artom | mordred, so specifically in my rebuild case, shade doesn't actually call the compute proxy, it does the REST request directly | 18:23 |
| mordred | at one point I was thiking that the proxy/resource layer should be the thing that more closely tracks the rest api and the cloud layer is where we do extra things - but it turns out we have to deviate from the rest api at the proxy/resource layer anyway in many cases, so the distinction is one that I think ultimately is not useful | 18:24 |
| artom | Which means if I want to "fix" the rebuild_server args, I'd have to add **kwargs there as well, because there's a whole bunch of stuff that's in the API that's currently impossible with shade | 18:24 |
| mordred | yeah - also, wow that's a terrible signature in that rebuild_server call in the sahde layer :( | 18:25 |
| artom | Tell me about it :( | 18:25 |
| mordred | I almost think we might be better off making the shade layer use your updated resource layer and just figure out how to make the backwards compat not totally suck. I hate that we called the image parameter image_id though :( | 18:26 |
| artom | Ah, I see | 18:28 |
| artom | Yeah, that's a really bizarre method signature | 18:29 |
| artom | Some args are for the rebuild itself, others for when you show the server after | 18:29 |
| artom | Can we burn and start over? :) | 18:29 |
| mordred | at least the shade layer requires image as a parameter! ;) | 18:30 |
| artom | Hehe, true | 18:31 |
| artom | Ugh, I wasn't planning on thinking this much on a Friday afternoon | 18:31 |
| mordred | so - I'm ok with breaking compat in the resource layer for this - like you said the current thing is pretty broken | 18:31 |
| mordred | I think we can do the "update shade layer to use resource layer" as a followon - and we should be able to do it without breaking the shade layer's contract | 18:32 |
| mordred | since we'll just be adding a **kwargs or something similar | 18:32 |
| artom | Shovel down the line, future me can deal with it. I like how you think :) | 18:32 |
| mordred | it'll just be lame that the parameter name is image_id - but if that's the worst thing that happens | 18:33 |
| mordred | (I think we can improve that paramter to take image objects too and just document it - if people don't like the name they can pass it positionally :) ) | 18:33 |
| mordred | future me is always smarter than today me anyway | 18:33 |
| artom | Words of wisdom right there. | 18:35 |
| *** dave-mccowan has quit IRC | 18:46 | |
| mordred | artom: so - I'm +2 on that once there's a release note - probably with someting in the upgrade section | 18:51 |
| artom | mordred, cool, I have that locally, need to fix the test on top of it, then push | 18:51 |
| mordred | cool. | 18:52 |
| mordred | I might take a stab at the shade patch once you do | 18:52 |
| mordred | or I might leave that for tomorrow us | 18:52 |
| artom | Hehe | 18:55 |
| *** efried1 has joined #openstack-sdks | 19:01 | |
| *** efried has quit IRC | 19:02 | |
| *** efried1 is now known as efried | 19:02 | |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | 19:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | 19:43 |
| *** smcginnis has quit IRC | 20:12 | |
| *** smcginnis has joined #openstack-sdks | 20:13 | |
| mnaser | mordred: so i think https://github.com/openstack/openstacksdk/commit/75ae5bf4aadedf47e26264f278c19adb64871735 might actually break every single OSA deployment out there :( | 20:37 |
| mnaser | because by default the 'supports image import' is always enabled, even when we were deploying via uwsgi | 20:38 |
| mordred | mnaser: well that's bad | 20:38 |
| mnaser | dansmith pushed a patch to 'autodisable' that flag which was sadly -2d | 20:38 |
| mordred | mnaser: well ... we default to false | 20:38 |
| mordred | you have to opt-in to using import | 20:38 |
| mnaser | mordred: https://review.opendev.org/#/c/741497/ | 20:38 |
| mnaser | oh? well | 20:38 |
| mnaser | i'm a little confused then because | 20:38 |
| mnaser | https://de5fd82ca097fe66eeac-be64ab2c1211c8399b7ac2efe4751a63.ssl.cf5.rackcdn.com/744212/2/check/openstack-operator:functional/4959c4e/docker/k8s_glance_glance-zsvzl_openstack_71c819a2-2401-44f6-bbd7-6f222940b4c0_0.txt clearly makes /import calls | 20:39 |
| mnaser | https://de5fd82ca097fe66eeac-be64ab2c1211c8399b7ac2efe4751a63.ssl.cf5.rackcdn.com/744212/2/check/openstack-operator:functional/4959c4e/job-output.txt but devstack is just doing openstack image create | 20:39 |
| mordred | I mean - it shouldn't use import unless you explicitly request import - because even if it is there based on our discussion it's a less advantageous upload mechanism due to need for local things | 20:39 |
| mordred | hrm | 20:39 |
| mnaser | and --import is not actually being used | 20:39 |
| mnaser | in the cli calls | 20:40 |
| mnaser | i.e. `openstack --os-cloud=devstack-admin --os-region-name=RegionOne image create cirros-0.5.1-x86_64-disk --public --container-format bare --disk-format qcow2 --property hw_rng_model=virtio` | 20:40 |
| mordred | yeah. did we get the osc patch wrong? | 20:41 |
| mnaser | this is like... weirdly recent | 20:41 |
| mnaser | i dont know what changed.. | 20:41 |
| mordred | yeah - I don't see any code that should make that happen | 20:41 |
| mnaser | gmann: ^ any ideas? this just recently surfaced | 20:42 |
| mnaser | and there isnt much merged into osc lately | 20:42 |
| mnaser | or openstacksdk | 20:42 |
| mnaser | and i don't see anything tagged recently? | 20:42 |
| mordred | nope. | 20:43 |
| mordred | and I don't think we have any support to declaring that a cloud wants to default to import in clouds.yaml | 20:43 |
| mordred | mnaser: | 20:45 |
| mordred | if stores or all_stores or all_stores_must_succeed: | 20:45 |
| mordred | use_import = True | 20:45 |
| gmann | mnaser: it is enabled with GLANCE_USE_IMPORT_WORKFLOW flag in devstack case and that is false by default | 20:45 |
| mnaser | gmann: yeah and in devstack, i don't see it using --import | 20:45 |
| mnaser | but i think mordred is onto something, we're enabling import if we're specifying a store? | 20:45 |
| mordred | we have to - apparently you can't specify stores without import | 20:46 |
| mordred | I mean ... I don't see any stores listed in that command | 20:46 |
| mordred | but maybe osc is passing al_stores by default? | 20:46 |
| mnaser | yeah this is it: openstack --os-cloud=devstack-admin --os-region-name=RegionOne image create cirros-0.5.1-x86_64-disk --public --container-format bare --disk-format qcow2 --property hw_rng_model=virtio | 20:46 |
| mordred | nope - osc doesn't have any support for stores | 20:47 |
| mnaser | https://github.com/openstack/python-openstackclient/blob/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908/openstackclient/image/v2/image.py#L399-L400 | 20:47 |
| mnaser | yeah | 20:47 |
| mnaser | https://github.com/openstack/python-openstackclient/blob/8aed5feab8a5ae65658ea03fe1f2c238f6ffd908/openstackclient/image/v2/image.py#L327-L334 | 20:47 |
| mordred | mnaser: dude. that's weird | 20:47 |
| mnaser | do we have to put a default=false or something? | 20:47 |
| * mnaser goes to look at other devstack jobs | 20:48 | |
| mnaser | and i dont think this has to do with my operator stuff cause the cli invocations dont change | 20:48 |
| mordred | mnaser: zomg, having to put default=False would be super lame | 20:49 |
| mordred | but - would be the best explanation | 20:49 |
| mnaser | but normal devstack would have broken then no? | 20:49 |
| mnaser | i think devstack uses uwsgi too | 20:50 |
| gmann | mnaser: is it tempest-ful-py3 based job? becasue i enabled the import in that | 20:50 |
| mnaser | gmann: i don't think its based off that BUT searching devstack logs shows `GLANCE_USE_IMPORT_WORKFLOW=False` so | 20:50 |
| gmann | yeah it is parent with devstack-tempest | 20:51 |
| mnaser | wth, a more recent change that ran -- https://review.opendev.org/#/c/668668/ -- did not have the same issue | 20:52 |
| mnaser | that is 25 hours ago and i've noticed this surfaced very recently | 20:52 |
| mnaser | like a cople hours ago | 20:52 |
| mordred | mnaser: o_O | 20:53 |
| mnaser | this change 5 hours ago was ok https://review.opendev.org/#/c/743943/ | 20:56 |
| gmann | mnaser: devstack is default to standalone glance (not under uwsgi) and in your jobs also | 20:56 |
| mnaser | ah well i run under uwsgi (the devstack portion is largely noop for glance at that point) | 20:57 |
| mnaser | but even then looking at logs | 20:57 |
| mnaser | its doing post /file | 20:57 |
| mnaser | ohhhh | 20:57 |
| mnaser | i wonder if https://review.opendev.org/#/c/743943/3/devstack/lib/glance is the reason | 20:57 |
| mnaser | this further pushes the theory of enabled_import_methods mattering to the CLI | 20:58 |
| mordred | mnaser: but how? | 20:59 |
| mnaser | mordred: AH | 21:01 |
| mnaser | THE UPLOAD MUST HAVE FAILD! | 21:01 |
| mnaser | and supports_import is still being 'announced' | 21:01 |
| mordred | aroo? | 21:01 |
| mnaser | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/_proxy.py#L291-L301 | 21:01 |
| mnaser | raise Exception + supports_import=True => runs use_import code | 21:02 |
| mordred | AH | 21:02 |
| mordred | maybe that's a bad logic | 21:02 |
| mordred | given what we've learned I'm thinking that opting in to import should always be conscious now | 21:02 |
| mnaser | LOW AND BEHOLD | 21:03 |
| mnaser | there is a traceback | 21:03 |
| mnaser | https://www.irccloud.com/pastebin/cl6vW461/ | 21:03 |
| mnaser | yeah because its possible that you end up in a queued image | 21:03 |
| mordred | mnaser: neat! | 21:03 |
| mnaser | that will never upoad | 21:03 |
| mordred | yeah | 21:03 |
| mordred | you wanna remove that logic or want me to? | 21:04 |
| mnaser | mordred: could you? i'm in the middle of six different things | 21:04 |
| * mnaser was supposed to have had glance ussuri everywhere today | 21:04 | |
| mordred | yup | 21:04 |
| mnaser | yeah | 21:11 |
| gmann | different things but we should support other import method (web-dowload or copy-image) also and check it correctly before we calculate supports_import | 21:11 |
| gmann | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/_proxy.py#L281 | 21:11 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Stop falling back to image import https://review.opendev.org/744254 | 21:12 |
| mordred | mnaser: ^^ | 21:12 |
| gmann | otherwise it will say not supported if image_import_methods['web-download'] | 21:12 |
| mordred | yah | 21:12 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | 21:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | 21:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: compute: give server actions proper microversion support https://review.opendev.org/744258 | 21:40 |
| artom | Fuuuun | 21:43 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: compute: give server actions proper microversion support https://review.opendev.org/744258 | 21:44 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | 21:44 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | 21:44 |
| artom | Accidentally a word in the commit message | 21:44 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: compute: give server actions proper microversion support https://review.opendev.org/744258 | 21:46 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Fix rebuild_server named argument https://review.opendev.org/741688 | 21:46 |
| openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Func test for compute microversion 2.9 https://review.opendev.org/741689 | 21:46 |
| *** tosky has quit IRC | 22:10 | |
| *** slaweq has quit IRC | 22:17 | |
| *** slaweq has joined #openstack-sdks | 22:30 | |
| *** enriquetaso has quit IRC | 23:08 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!