Thursday, 2020-06-18

*** __ministry has quit IRC01:59
*** __ministry has joined #openstack-sdks02:01
*** enriquetaso has quit IRC02:11
*** lbragstad has quit IRC02:21
*** diablo_rojo has quit IRC03:41
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-sdks04:33
*** yolanda has quit IRC06:31
*** yolanda has joined #openstack-sdks06:36
*** gtema has joined #openstack-sdks06:41
*** noonedeadpunk has joined #openstack-sdks06:41
*** rpittau|afk is now known as rpittau06:43
openstackgerritMerged openstack/openstacksdk master: Add query parameter 'id' for security_groups  https://review.opendev.org/73560106:45
*** ttsiouts has joined #openstack-sdks07:06
*** slaweq has joined #openstack-sdks07:06
*** ttsiouts has quit IRC07:19
*** ttsiouts has joined #openstack-sdks07:19
*** ralonsoh has joined #openstack-sdks07:21
*** tosky has joined #openstack-sdks07:25
*** ttsiouts has quit IRC07:54
*** jpena|off is now known as jpena07:57
*** ttsiouts has joined #openstack-sdks07:58
*** jpich has joined #openstack-sdks08:07
*** ttsiouts has quit IRC08:12
*** ttsiouts has joined #openstack-sdks08:13
*** ttsiouts_ has joined #openstack-sdks08:16
*** ttsiouts has quit IRC08:17
*** dtantsur|afk is now known as dtantsur08:29
*** ttsiouts has joined #openstack-sdks08:36
*** ttsiout__ has joined #openstack-sdks08:37
*** ttsiouts_ has quit IRC08:40
*** ttsiouts has quit IRC08:41
*** jawad_axd has joined #openstack-sdks09:09
*** jpich has quit IRC09:20
*** jpich has joined #openstack-sdks09:21
*** ttsiouts has joined #openstack-sdks09:32
*** ttsiout__ has quit IRC09:32
*** tkajinam has quit IRC10:05
*** rpittau is now known as rpittau|bbl10:06
*** gtema has quit IRC10:43
*** gtema has joined #openstack-sdks10:56
openstackgerritPratik Raj proposed openstack/cliff master: optimize size and time using --no-cache-dir  https://review.opendev.org/73664111:36
*** jpena is now known as jpena|lunch11:38
*** mgariepy has quit IRC11:43
*** ttsiouts has quit IRC12:06
openstackgerritjayaditya gupta proposed openstack/cliff master: Output correct json for security groups in 'openstack server show'  https://review.opendev.org/73512812:07
*** ttsiouts has joined #openstack-sdks12:07
*** ttsiouts has quit IRC12:11
mordredslaweq: see comment from frickler on https://review.opendev.org/#/c/736005/ - it's possible there is a neutron bug12:13
slaweqmordred: looking12:13
mordredslaweq: (it's possible it's not - but when I see "unintended information leak" ...)12:14
*** mgariepy has joined #openstack-sdks12:19
*** rpittau|bbl is now known as rpittau12:20
*** ttsiouts has joined #openstack-sdks12:28
slaweqmordred: I just opened https://bugs.launchpad.net/neutron/+bug/188406712:34
openstackLaunchpad bug 1884067 in neutron "[API] Filtering by fields not allowed to see is possible for regular users" [High,Confirmed]12:34
slaweqmordred: frickler thx for finding this12:34
slaweqmordred: frickler I think we are not checking what fields are available for user during filtering, we are only removing such fields from the returned data12:35
fricklerslaweq: sorry, I wanted to ping you earlier about this but then got distracted, it just looked odd to me when testing mnaser's patch12:35
slaweqI will ask amotoki to take a look into it12:35
mordred\o/. we're helpful! good catch frickler  :)12:38
*** jpena|lunch is now known as jpena12:38
mordredmnaser: you made things betterer12:38
mnaserwhat did I do oops12:39
mnaseroh no12:39
mnaserthat’s no good12:39
mnaserwe should fix that soon :)12:40
mnaser(and if no one has the time to do that, I can, cause you know, that’s a little important)12:40
mnaserI’m not that worried though, we don’t expose the host id anywhere so I don’t think anyone can see it to use it later12:41
*** ttsiouts has quit IRC12:47
*** jawad_axd has quit IRC12:47
*** ttsiouts has joined #openstack-sdks12:47
*** ttsiouts has quit IRC12:52
*** ttsiouts has joined #openstack-sdks12:54
*** noonedeadpunk is now known as noonedeadpunk_12:57
*** lbragstad has joined #openstack-sdks13:16
*** ttsiouts has quit IRC13:18
*** ttsiouts has joined #openstack-sdks13:19
*** enriquetaso has joined #openstack-sdks13:19
*** ttsiouts has quit IRC13:23
*** sshnaidm is now known as sshnaidm|mtg13:23
*** ttsiouts has joined #openstack-sdks13:26
*** shaohe_feng has joined #openstack-sdks13:50
shaohe_fenghi, mordred and gtema13:51
shaohe_fengthere is a issue when I connect glance from cyborg13:52
shaohe_fengNeed you help13:52
shaohe_fengTraceback (most recent call last):13:53
shaohe_feng"/opt/stack/cyborg/cyborg/image/api.py", line 163, in download13:53
*** shaohe_feng has quit IRC13:53
mordredI want to help shaohe_feng13:56
*** shaohe_feng has joined #openstack-sdks13:56
shaohe_fengTraceback (most recent call last):13:56
shaohe_feng"/opt/stack/cyborg/cyborg/image/api.py", line 163, in download13:56
*** shaohe_feng has quit IRC13:56
*** shaohe_feng has joined #openstack-sdks13:58
*** senrique_ has joined #openstack-sdks14:09
*** enriquetaso has quit IRC14:12
mordredshaohe_feng: try pasting to paste.openstack.org and then copying the link here14:12
shaohe_fengmordred: this is the traceback http://paste.openstack.org/show/794946/14:14
shaohe_fengmordred: this is the conf http://paste.openstack.org/show/794948/14:17
shaohe_fengmordred:  this is the cyborg repo https://github.com/openstack/cyborg   and  glance api  code is here: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py14:19
mordredshaohe_feng: sadly I don't think we're going to be much help with that - it's using glanceclient not openstacksdk - I'm really not sure  what's going on :(14:20
shaohe_fengmordred I'm using SDK:14:21
shaohe_feng+    ksa_adap = utils.get_sdk_adapter(14:21
shaohe_fengin my code I chage it to get_sdk_adapter14:22
shaohe_fenghere I change get_ksa_adapter to get_sdk_adapter  https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L11314:23
mordredshaohe_feng: yes - but the traceback you pasted is flowing through glanceclient - so it seems that sdk adapter is just being used to find the list of glance servers14:24
mordredso - at some point that info is being passed to a Glanceclient constructor - and god only knows what it's doing14:25
shaohe_fenghttps://github.com/openstack/cyborg/blob/master/cyborg/common/utils.py#L13514:25
shaohe_feng^ mordred: what the get_sdk_adapter   define14:25
shaohe_fengso why it still use glanceclient ?14:26
shaohe_fengI already change it to get_sdk_adapter14:26
shaohe_fengsomething wrong when I change it to get_sdk_adapter  ?14:26
shaohe_fengmordred can you tell me what should I do?14:27
mordredshaohe_feng: that looks fine - but there is still this: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L12914:28
mordredshaohe_feng: let me look at the code a little more and see if I can make some suggestions14:28
shaohe_fengmordred: thank you.14:28
*** noonedeadpunk_ is now known as noonedeadpunk14:29
gtemashaone_feng - I guess you should be targeting dropping your cyborg/image/glance completely and modify cyborg/image/api to use SDK instead14:30
*** ttsiouts has quit IRC14:30
mordredgtema: looking at the master branch, it looks like they're laready doing that14:31
*** ttsiouts has joined #openstack-sdks14:31
gtemaoh, I was looking to the posted particular commit14:31
mordredoh - wait14:31
mordredeah14:31
mordredZOMG - the method is returning a GlanceClient and calling it a session14:32
gtemaeven in master there is still from cyborg.image import glance14:32
mordredyup.14:33
mordredI was fooled by "session.delete()"14:33
*** ttsiouts has quit IRC14:36
shaohe_fenggtema: mordred: I'm still use GlanceClient ?14:38
*** shaohe_feng has quit IRC14:38
mordredgtema: they're going to nerdsnipe me in to fixing cyborg aren't they?14:39
*** shaohe_feng has joined #openstack-sdks14:42
gtemashaone_feng - you stacktrace exactly points into that14:42
gtemamordred - right14:42
shaohe_fenggtema: mordred: sorry, I'm offline just now. something wrong with my network.14:42
shaohe_fengmay I missing something?14:43
gtemashaohe_feng - guess not14:43
mordredshaohe_feng: cyborg.image.api.API._get_session_and_image_id is constructing a Glanceclient object14:43
mordredshaohe_feng: which in turn is used in API.download14:44
shaohe_fenggood,  so what should I change?14:44
mordredprobably the entire cyborg/image/glance.py file14:44
shaohe_fengthe FPGA need to download image14:44
gtemayes - drop it and modify the cyborg/image/api14:44
shaohe_fengwe need to program the FPGA14:44
shaohe_fengany example for it?14:44
mordredshaohe_feng: I'm going to see if I can make a non-working example patch that can point you in the right direction14:44
shaohe_fengmordred good. thanks.14:45
mordredgtema: it's the same code as from nova, so if we fix it here for cyborg, we'll have a good example of how to fix it for nova too :)14:45
gtema:)14:45
*** ttsiouts has joined #openstack-sdks14:46
*** Luzi has joined #openstack-sdks15:01
*** senrique__ has joined #openstack-sdks15:03
*** senrique_ has quit IRC15:05
*** ttsiouts has quit IRC15:07
*** ttsiouts has joined #openstack-sdks15:07
*** mgariepy has quit IRC15:08
*** ttsiouts has quit IRC15:09
*** ttsiouts has joined #openstack-sdks15:09
*** ttsiouts has quit IRC15:14
*** senrique_ has joined #openstack-sdks15:23
*** senrique__ has quit IRC15:25
*** mgariepy has joined #openstack-sdks15:28
*** slaweq has quit IRC15:33
*** sshnaidm|mtg is now known as sshnaidm|ruck15:41
*** gtema_ has joined #openstack-sdks15:54
*** gtema has quit IRC15:57
*** also_stingrayza has joined #openstack-sdks15:58
*** diablo_rojo has joined #openstack-sdks16:00
*** Luzi has quit IRC16:01
*** stingrayza has quit IRC16:01
elmikoAPI SIG office hour open16:02
elmikomordred: i haven't seen much more activity on the service discovery PRs, i'm going to move towards a freeze and asking for wider review if that sounds good to you?16:04
mordredelmiko: ++16:07
elmikothank you sir =)16:07
mordredthank you!16:09
*** shaohe_feng has quit IRC16:20
*** jpich has quit IRC16:27
elmikook, frozen and email sent16:34
dtantsur\o/16:51
*** sshnaidm|ruck is now known as sshnaidm|off16:52
*** olaph has joined #openstack-sdks16:54
*** olaph is now known as stinky16:56
*** stinky is now known as olaph16:56
*** olaph has quit IRC16:58
*** olaph has joined #openstack-sdks16:58
*** rpittau is now known as rpittau|afk17:00
*** gtema_ has quit IRC17:02
elmikohave a good weekend all, stay safe and healthy out there =) o/17:08
*** dtantsur is now known as dtantsur|afk17:10
*** jpena is now known as jpena|off17:21
*** senrique__ has joined #openstack-sdks17:47
*** senrique_ has quit IRC17:49
*** ralonsoh has quit IRC17:57
*** factor__ has quit IRC18:11
*** factor__ has joined #openstack-sdks18:11
*** senrique__ has quit IRC18:54
*** gtema has joined #openstack-sdks19:03
*** gtema has quit IRC19:08
*** gmann is now known as gmann_afk19:22
*** gmann_afk is now known as gmann19:37
*** gmann is now known as gmann_afk20:10
*** slaweq has joined #openstack-sdks20:23
*** senrique__ has joined #openstack-sdks20:30
*** senrique__ has quit IRC21:26
*** gmann_afk is now known as gmann22:04
*** tonyb has joined #openstack-sdks22:05
openstackgerritMerged openstack/keystoneauth stable/ussuri: Fix E741 pep8 failure  https://review.opendev.org/73118822:06
*** slaweq has quit IRC22:13
*** slaweq has joined #openstack-sdks22:24
*** tosky has quit IRC22:25
*** slaweq has quit IRC22:28
*** tkajinam has joined #openstack-sdks23:00

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!