| *** ricolin has joined #openstack-sdks | 01:14 | |
| *** dayou has quit IRC | 01:38 | |
| *** dayou has joined #openstack-sdks | 01:47 | |
| *** ttsiouts_ has joined #openstack-sdks | 03:31 | |
| *** ttsiouts has quit IRC | 03:34 | |
| *** evrardjp has quit IRC | 04:37 | |
| *** evrardjp has joined #openstack-sdks | 04:37 | |
| *** dayou has quit IRC | 05:10 | |
| *** vishakha has quit IRC | 05:10 | |
| *** mnasiadka has quit IRC | 05:10 | |
| *** dayou has joined #openstack-sdks | 05:15 | |
| *** vishakha has joined #openstack-sdks | 05:15 | |
| *** mnasiadka has joined #openstack-sdks | 05:15 | |
| *** dayou has quit IRC | 05:54 | |
| *** dayou has joined #openstack-sdks | 05:55 | |
| *** gtema has joined #openstack-sdks | 06:49 | |
| *** yolanda has quit IRC | 06:59 | |
| *** yolanda has joined #openstack-sdks | 07:00 | |
| *** nightmare_unreal has joined #openstack-sdks | 07:02 | |
| *** slaweq has joined #openstack-sdks | 07:11 | |
| *** rpittau|afk is now known as rpittau | 07:19 | |
| *** jpena|off is now known as jpena | 07:22 | |
| *** tosky has joined #openstack-sdks | 07:30 | |
| *** ralonsoh has joined #openstack-sdks | 07:38 | |
| *** jpich has joined #openstack-sdks | 07:39 | |
| *** gtema has quit IRC | 07:51 | |
| iurygregory | mordred, hey o/ good morning (not sure if you are awake) re your comment in https://review.opendev.org/#/c/718746/1/openstack/baremetal/v1/_proxy.py you wanted to be volume_connectors only for that function since is the one to list correct? | 07:59 |
|---|---|---|
| *** ttsiouts_ has quit IRC | 08:11 | |
| *** dtantsur|afk is now known as dtantsur | 08:13 | |
| *** gtema has joined #openstack-sdks | 08:18 | |
| *** ttsiouts has joined #openstack-sdks | 08:21 | |
| iurygregory | hey everyone locally I'm trying to run tox -r -vv -e docs for openstacksdk using the master and it's failling any tips? | 08:26 |
| *** gtema has quit IRC | 08:29 | |
| *** gtema has joined #openstack-sdks | 08:30 | |
| amotoki | iurygregory: it is caused by sphinx 3.0. If you would like to get the rendered documents, you can avoid the error with sphinx <3. | 08:35 |
| AJaeger | is anybody looking into it or shall I? | 08:37 |
| amotoki | AJaeger: I don't know someone is looking into it. I just confirmed it locally but I have something other to do right now. | 08:38 |
| AJaeger | just noticed the logs - that's not one of the usual errors;( I'll check for 5 mins or so. | 08:39 |
| gtema | I was having to fight downstream with those issues and can prepare fix for SDK docs for support of Sphin >=3.0, but this is quite a lot | 08:40 |
| AJaeger | gtema: that would be appreciated! | 08:40 |
| gtema | ok, taken on my FIFO todo | 08:41 |
| AJaeger | thanks | 08:41 |
| *** ttsiouts has quit IRC | 08:47 | |
| iurygregory | amotoki, i have some high priorities atm >.< otherwise I would be happy to help | 08:49 |
| *** tkajinam has quit IRC | 08:51 | |
| *** ttsiouts has joined #openstack-sdks | 09:00 | |
| dtantsur | who could approve this simple patch please? https://review.opendev.org/#/c/717737/ | 09:03 |
| dtantsur | amotoki, mordred ^^ | 09:03 |
| amotoki | dtantsur: sure | 09:03 |
| *** ttsiouts has quit IRC | 09:16 | |
| *** yolanda has quit IRC | 09:23 | |
| *** yolanda has joined #openstack-sdks | 09:29 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/osc-lib master: Remove Babel from requirements https://review.opendev.org/717737 | 09:29 |
| dtantsur | amotoki: updated ^^ | 09:29 |
| amotoki | dtantsur: thanks. I read thru the translation handling scripts again :) | 09:30 |
| gtema | amotoki, i placed my + there also. If you find ok let's do +A | 09:32 |
| *** ttsiouts has joined #openstack-sdks | 09:39 | |
| *** yolanda has quit IRC | 10:10 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add resource option immutable https://review.opendev.org/715269 | 10:25 |
| *** rpittau is now known as rpittau|bbl | 10:30 | |
| *** gtema has quit IRC | 10:34 | |
| *** gtema has joined #openstack-sdks | 10:35 | |
| *** ttsiouts has quit IRC | 10:49 | |
| *** ttsiouts has joined #openstack-sdks | 10:50 | |
| openstackgerrit | Merged openstack/openstacksdk stable/rocky: Add ansible collection job to rocky branch https://review.opendev.org/714079 | 11:35 |
| openstackgerrit | Merged openstack/openstacksdk stable/rocky: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714086 | 11:35 |
| *** jpena is now known as jpena|lunch | 11:37 | |
| *** tkajinam has joined #openstack-sdks | 11:56 | |
| AJaeger | here's a change for os-client-config to cleanup py27 support, please review https://review.opendev.org/#/c/717609/ | 12:00 |
| AJaeger | and a similar one for service-types-authority, please: https://review.opendev.org/719183 | 12:00 |
| AJaeger | mordred: can you help, please? ^ | 12:00 |
| dtantsur | AJaeger: there is a question re 3.5 on the first of them | 12:01 |
| dtantsur | I remember discussing it on another patch, but I don't remember the resolution | 12:01 |
| openstackgerrit | Andreas Jaeger proposed openstack/os-client-config master: Cleanup py27 support https://review.opendev.org/717609 | 12:04 |
| *** tkajinam has quit IRC | 12:04 | |
| AJaeger | dtantsur: I followed your suggestion - as long as shade is testing 3.5, we need 3.5 in there... | 12:05 |
| dtantsur | thanks! | 12:06 |
| *** gtema has quit IRC | 12:10 | |
| *** ttsiouts has quit IRC | 12:12 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-openstackclient master: Move Babel to test-requirements https://review.opendev.org/720701 | 12:15 |
| dtantsur | not sure if even test-requirements is needed ^^^ | 12:16 |
| *** rpittau|bbl is now known as rpittau | 12:19 | |
| *** mgariepy has joined #openstack-sdks | 12:24 | |
| openstackgerrit | Merged openstack/service-types-authority master: Cleanup py27 support https://review.opendev.org/719183 | 12:24 |
| *** enriquetaso has joined #openstack-sdks | 12:24 | |
| *** ttsiouts has joined #openstack-sdks | 12:42 | |
| *** gtema has joined #openstack-sdks | 12:43 | |
| *** jpena|lunch is now known as jpena | 12:44 | |
| *** gtema has quit IRC | 12:47 | |
| *** gtema has joined #openstack-sdks | 12:47 | |
| *** ttsiouts has quit IRC | 12:48 | |
| *** dayou has quit IRC | 13:23 | |
| *** ttsiouts has joined #openstack-sdks | 13:23 | |
| *** dayou has joined #openstack-sdks | 13:27 | |
| *** gtema_ has joined #openstack-sdks | 13:30 | |
| *** ttsiouts has quit IRC | 13:32 | |
| *** ttsiouts has joined #openstack-sdks | 13:32 | |
| *** dayou has quit IRC | 13:33 | |
| *** gtema has quit IRC | 13:33 | |
| *** dayou has joined #openstack-sdks | 13:33 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701 | 13:38 |
| dtantsur | updated with the recent findings ^^^ | 13:38 |
| *** ttsiouts has quit IRC | 13:49 | |
| *** ttsiouts has joined #openstack-sdks | 14:06 | |
| *** dtantsur is now known as dtantsur|brb | 14:09 | |
| *** ttsiouts has quit IRC | 14:31 | |
| *** ttsiouts has joined #openstack-sdks | 14:36 | |
| *** ttsiouts has quit IRC | 14:48 | |
| AJaeger | who's reviewing shade? Here's a change to update the jobs which we need to move forward with py27 drop, please review https://review.opendev.org/#/c/718068/ | 14:49 |
| *** ttsiouts has joined #openstack-sdks | 14:50 | |
| openstackgerrit | Monty Taylor proposed openstack/shade master: Update master for stable/ussuri https://review.opendev.org/719021 | 14:54 |
| openstackgerrit | Monty Taylor proposed openstack/shade master: Add Python3 victoria unit tests https://review.opendev.org/719022 | 14:55 |
| mordred | AJaeger: done! | 14:55 |
| AJaeger | thanks, mordred | 14:58 |
| openstackgerrit | Andreas Jaeger proposed openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742 | 15:00 |
| *** dtantsur|brb is now known as dtantsur | 15:03 | |
| openstackgerrit | Sean McGinnis proposed openstack/shade master: Declare py38 support https://review.opendev.org/720746 | 15:07 |
| *** gtema_ has quit IRC | 15:18 | |
| *** ricolin has quit IRC | 15:19 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701 | 15:31 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701 | 15:32 |
| dtantsur | lower-constraints is quite a fragile thing | 15:33 |
| AJaeger | dtantsur: it's not working as designed IMHO | 15:40 |
| dtantsur | to me we should only list direct dependencies in lower-constraints.txt | 15:41 |
| dtantsur | but I seem to be alone in that | 15:41 |
| AJaeger | dtantsur: Let me write up something... | 15:41 |
| AJaeger | dtantsur: will take a bit, I need an example | 15:44 |
| dtantsur | depending on what you need, I may be able to help | 15:47 |
| smcginnis | Should be able to AND the packages between lower-constraints.txt and (requirements.txt and test-requirements.txt). | 15:51 |
| smcginnis | I think Doug's original reasoning for having other packages was to be able to test all other dependencies too. | 15:52 |
| dtantsur | for me it's very problematic every time the list is updated | 15:53 |
| dtantsur | if we include indirect dependencies (like babel now) | 15:53 |
| dtantsur | I can go back to putting babel in lower-constraints | 15:53 |
| dtantsur | whatever is better | 15:53 |
| smcginnis | Yeah, personally I would prefer to only enforce our direct dependencies too. | 15:53 |
| smcginnis | And trust that they are not installing their own dependencies unconstrained (which actually probably is a risky assumption). | 15:54 |
| AJaeger | The problem is: We install package X in version 0.1, then package Y needs X in version 0.2 - and pip -U installs that ;( I need to dig out an example, this is happening often. | 15:56 |
| dtantsur | is it a problem though? | 15:58 |
| dtantsur | I thought the goal was to verify our minimum caps | 15:58 |
| dtantsur | so that e.g. we don't put requests>=1.0 but use features from 1.2 | 15:59 |
| dtantsur | indirect dependencies are not used directly, so it makes no sense for them? | 15:59 |
| openstackgerrit | Merged openstack/shade master: Break out py27 job templates https://review.opendev.org/718068 | 15:59 |
| openstackgerrit | Merged openstack/shade master: Update master for stable/ussuri https://review.opendev.org/719021 | 15:59 |
| *** dustinc has joined #openstack-sdks | 16:00 | |
| AJaeger | dtantsur: yes, if you change one line, everything blows up as you noticed | 16:01 |
| smcginnis | AJaeger: That may be the reason for inclusing our indirect dependencies in there - to make sure that scenario doesn't happen my locking down everything and make sure we always get the versions we expect to get. | 16:01 |
| smcginnis | *including | 16:01 |
| AJaeger | smcginnis: but we don't - I need an example, give me somem time, please | 16:02 |
| AJaeger | And then let's discuss whether I'm right or not... | 16:02 |
| dtantsur | smcginnis: the other way around. if you include all dependencies, any change will likely cascade. | 16:02 |
| dtantsur | if you only include direct dependencies, you'll get into trouble only if your minimum cap conflicts with some other. | 16:03 |
| smcginnis | dtantsur: Yes, but that would be by design, right? | 16:03 |
| dtantsur | not sure | 16:03 |
| dtantsur | I see the goal of lower-constraints differently | 16:03 |
| smcginnis | If we want a definitive set of requirement minimums that can be used, we need to be explicit about everything that gets installed to be able to verify it actually works. | 16:03 |
| dtantsur | I only care about direct dependencies because that's what we (in a project) control | 16:04 |
| *** enriquetaso has quit IRC | 16:04 | |
| *** senrique_ has joined #openstack-sdks | 16:05 | |
| dtantsur | like, in this case I have to care that something else is using babel and pytz. I don't think I should. | 16:05 |
| smcginnis | But like Andreas pointed out, if we say we want version 1.0, but then an indirect dependency raises that to 2.0, we aren't actually capturing (or at least validating) what our minimum version of that lib should be. | 16:05 |
| dtantsur | smcginnis: in this case the job will fail and we'll know :) | 16:06 |
| dtantsur | that's literally what happened with my patch | 16:06 |
| smcginnis | I'm probably missing some context. Which patch is this? | 16:06 |
| dtantsur | smcginnis: tl;dr I've uncapped babel and it got pulled again down the road with a conflicting pytz requirement | 16:06 |
| smcginnis | Yeah, so that points to the reason for why lower-constraints should have packages that are not in requirements and test-requirements. | 16:07 |
| smcginnis | It needs to control the full environment. | 16:08 |
| dtantsur | for me it points to the opposite thing :) | 16:08 |
| dtantsur | I don't need this control. As a developer I don't care about it. | 16:08 |
| dtantsur | Maybe we see the goals of lower-constraints differently? | 16:08 |
| dtantsur | For me it's only to verify that we don't violate our minimum caps | 16:08 |
| smcginnis | But going the route you are advocating, you've just pointed out that causes problems. :) | 16:09 |
| dtantsur | it caused a problem because we also capped pytz | 16:09 |
| dtantsur | which wasn't a direct dependency either | 16:09 |
| dtantsur | or maybe it's too late for me to think clearly :) | 16:10 |
| smcginnis | The reason we have it in l-c is because it is an indirect dependency that of not constrained will install a different and potentially conflicting version like you are saying. | 16:11 |
| AJaeger | smcginnis: is lower-constraitns documented somewhere? | 16:11 |
| smcginnis | So even if we use neither babel nor pytz directly, having them in l-c will force the exact versions to be installed and avoid conflicts like that. | 16:12 |
| *** ttsiouts has quit IRC | 16:12 | |
| dtantsur | smcginnis: okay, I remembered why we stopped doing it in ironic, I think. It's fine while it works, but every time you need to update something, it's a cascading nightmare. | 16:12 |
| smcginnis | AJaeger: I'm not really sure. I remember when Doug was working on it, and he had to explain some of the reasoning for the approach to me a few times, but I don't recall reading a spec or anything like that. | 16:12 |
| dtantsur | anyway, if people feel I should keep Babel in lower-constraints, I can do it | 16:13 |
| dtantsur | just let me know | 16:13 |
| smcginnis | dtantsur: Well, again, you can argue that's by design. If you change one thing, then you have to expect there may be other packages that will also need to be raised. | 16:13 |
| dtantsur | it's not unreasonable, I just've never looked at it this way | 16:13 |
| *** jpich has quit IRC | 16:13 | |
| smcginnis | The exercise being to find what the new lowest set of requirements are that should be expected to work. | 16:14 |
| AJaeger | I found https://docs.openstack.org/project-team-guide/dependency-management.html | 16:14 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701 | 16:15 |
| dtantsur | updated ^^ | 16:15 |
| *** dtantsur is now known as dtantsur|afk | 16:16 | |
| *** rpittau is now known as rpittau|afk | 16:17 | |
| *** dtruong has quit IRC | 16:33 | |
| *** dtruong has joined #openstack-sdks | 16:34 | |
| AJaeger | smcginnis, dtantsur|afk https://etherpad.opendev.org/p/S_6OvGeqCniK5CLVxIan is what I found out so far. | 16:35 |
| AJaeger | So, lower-constraints might be working correctly - but we're usingn it in a broken way ;( | 16:35 |
| AJaeger | With removing install_command suddenly you open pandora's box since none of the requirements is correct anymore ;( | 16:35 |
| *** evrardjp has quit IRC | 16:37 | |
| *** evrardjp has joined #openstack-sdks | 16:37 | |
| AJaeger | I'll send this out as an email... | 16:40 |
| *** nightmare_unreal has quit IRC | 16:44 | |
| openstackgerrit | Andreas Jaeger proposed openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742 | 16:46 |
| openstackgerrit | Merged openstack/shade master: Add Python3 victoria unit tests https://review.opendev.org/719022 | 16:52 |
| smcginnis | AJaeger: Thanks for sending that. I've seen a few projects fix that over the last several months, but I'm sure there are probably several more that are still doing that wrong. | 16:53 |
| *** ttsiouts has joined #openstack-sdks | 17:04 | |
| openstackgerrit | Merged openstack/osc-lib master: Remove Babel from requirements https://review.opendev.org/717737 | 17:12 |
| AJaeger | smcginnis: too many repos ;( | 17:34 |
| *** jpena is now known as jpena|off | 17:40 | |
| *** ralonsoh has quit IRC | 17:53 | |
| *** ttsiouts has quit IRC | 18:14 | |
| *** ttsiouts has joined #openstack-sdks | 19:26 | |
| *** ttsiouts has quit IRC | 19:47 | |
| *** ttsiouts has joined #openstack-sdks | 19:47 | |
| *** gtema has joined #openstack-sdks | 19:53 | |
| *** gtema has quit IRC | 20:01 | |
| *** dustinc has quit IRC | 20:29 | |
| openstackgerrit | Merged openstack/os-client-config master: Cleanup py27 support https://review.opendev.org/717609 | 20:42 |
| AJaeger | smcginnis: coming back to our discussion, the project-team-guide does not talk about adding all dependencies, it only talks about the direct requirements, doesn't it? Updating it becomes really tricky in my experience: You increase one version, that needs further updates, that need further... | 21:05 |
| AJaeger | To me it looks like we're not mastering lower-constraints yet... | 21:05 |
| AJaeger | sorry, enough on that - need to leave now... | 21:05 |
| smcginnis | AJaeger: Have a good weekend! | 21:10 |
| smcginnis | Maybe we can invoke Doug for more background. The concepts behind this were probably lost due to not having openstack-specs anymore. Or at least some other good place to write it all down. | 21:11 |
| openstackgerrit | Merged openstack/python-openstackclient master: Use unittest.mock instead of third party mock https://review.opendev.org/717410 | 21:37 |
| *** ttsiouts has quit IRC | 21:56 | |
| *** gtema has joined #openstack-sdks | 21:57 | |
| *** gtema has quit IRC | 22:02 | |
| *** mgariepy has quit IRC | 22:06 | |
| *** ttsiouts has joined #openstack-sdks | 22:43 | |
| *** ttsiouts has quit IRC | 22:52 | |
| *** senrique_ has quit IRC | 23:13 | |
| *** tosky has quit IRC | 23:21 | |
| *** gtema has joined #openstack-sdks | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!