Sunday, 2020-03-29

« Saturday, 2020-03-28 Index Monday, 2020-03-30 »
*** tosky has quit IRC00:00
*** factor has joined #openstack-sdks00:43
*** gtema|afk has joined #openstack-sdks01:16
*** gtema|afk has quit IRC01:20
*** tkajinam has joined #openstack-sdks02:28
openstackgerritLichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env.  https://review.opendev.org/71567102:39
openstackgerritLichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env.  https://review.opendev.org/71567102:40
openstackgerritAkihiro Motoki proposed openstack/os-api-ref master: Update sphinx-testing requirements to >=1.0.1  https://review.opendev.org/71567303:54
openstackgerritLichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env.  https://review.opendev.org/71567104:19
*** evrardjp has quit IRC04:36
*** evrardjp has joined #openstack-sdks04:36
openstackgerritLichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env.  https://review.opendev.org/71567104:52
*** diablo_rojo has quit IRC06:40
*** gtema|afk has joined #openstack-sdks07:11
*** gtema|afk has quit IRC07:11
*** gtema|afk has joined #openstack-sdks07:11
*** gtema|afk has quit IRC07:14
*** tkajinam has quit IRC07:22
*** slaweq has joined #openstack-sdks07:34
openstackgerritLichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env.  https://review.opendev.org/71567107:51
*** slaweq has quit IRC07:56
*** slaweq has joined #openstack-sdks08:08
*** jistr has quit IRC08:09
*** jistr has joined #openstack-sdks08:12
*** slaweq has quit IRC08:12
*** slaweq has joined #openstack-sdks08:14
*** slaweq has quit IRC09:08
*** slaweq has joined #openstack-sdks09:09
openstackgerritAndreas Jaeger proposed openstack/openstacksdk master: Update hacking for Python3  https://review.opendev.org/71568410:23
*** tosky has joined #openstack-sdks10:52
*** sshnaidm|off has quit IRC10:58
*** slaweq has quit IRC10:59
*** sshnaidm has joined #openstack-sdks11:03
*** slaweq has joined #openstack-sdks11:10
*** slaweq has quit IRC11:14
*** dayou_ has joined #openstack-sdks11:26
*** dayou has quit IRC11:29
*** sshnaidm has quit IRC12:17
*** sshnaidm has joined #openstack-sdks12:17
openstackgerritAndreas Jaeger proposed openstack/openstacksdk master: Raise hacking to 2.x  https://review.opendev.org/71515513:00
openstackgerritAndreas Jaeger proposed openstack/openstacksdk master: Update local hacking checks  https://review.opendev.org/71568413:02
sshnaidmcores, please merge train patches: https://review.opendev.org/#/c/714770/ https://review.opendev.org/#/c/715192/13:52
sshnaidmmordred, dtantsur|afk ^^13:52
*** sshnaidm is now known as sshnaidm|afk14:07
*** sshnaidm|afk is now known as sshnaidm14:25
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock  https://review.opendev.org/71570615:30
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements  https://review.opendev.org/71570715:30
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Raise hacking to 2.x  https://review.opendev.org/71515516:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Update local hacking checks  https://review.opendev.org/71568416:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock  https://review.opendev.org/71570616:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements  https://review.opendev.org/71570716:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove uses of from six.moves  https://review.opendev.org/71571216:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove use of six  https://review.opendev.org/71571316:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Stop subclassing object  https://review.opendev.org/71571416:08
AJaegermordred: spring cleaning? ;)16:22
mordredAJaeger: yeah - your hacking patches made me think about those :)16:23
AJaeger;)16:23
AJaegeryes, there're quite a few places to cleanup after dropping to python2 - and many repos didn't do so yet16:24
AJaegermordred: want to review https://review.opendev.org/715531 as well, please? that's another hacking change for osc-lib16:25
mordredthe six change might make backporting patches to stable slightly harder - but I don't think it'll actually be that bad16:25
mordredAJaeger: done!16:25
AJaegeroften just a single line per file, so should be okish16:25
mordredand thanks16:25
AJaegerthanks16:25
*** evrardjp has quit IRC16:36
*** evrardjp has joined #openstack-sdks16:36
openstackgerritMerged openstack/openstacksdk stable/train: Run fetch-subunit-output role conditionally  https://review.opendev.org/71477017:49
openstackgerritMerged openstack/openstacksdk stable/train: [tests] Improve devstack/post playbook efficiency  https://review.opendev.org/71519217:49
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock  https://review.opendev.org/71570617:52
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements  https://review.opendev.org/71570717:52
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove uses of from six.moves  https://review.opendev.org/71571217:52
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove use of six  https://review.opendev.org/71571317:52
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Stop subclassing object  https://review.opendev.org/71571417:52
mnasermordred: going over those patches, seems like the unittest.mock switch seems to have failed with some missing #assert_called_once18:33
mnaserhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_547/715706/3/check/openstack-tox-py35/5471868/testr_results.html18:33
mordredmnaser: *awesome*18:39
mordredmnaser: DOH18:41
mordredmnaser: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_once ... added in 3.618:41
mordredsigh18:41
mnaserhmm18:42
mnasernot sure how you can use another combination of assertions to make it work18:42
mordredyeah. I'm gonna have to ponder that one :)18:59
mordredmnaser: got it :)19:02
mnasermordred: before you push, let me see if things further up the stack havent broken while they're still running :P19:03
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock  https://review.opendev.org/71570619:04
mnasermordred: yeah they all look good except for the py35 thing19:04
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements  https://review.opendev.org/71570719:04
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove uses of from six.moves  https://review.opendev.org/71571219:04
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove use of six  https://review.opendev.org/71571319:05
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Stop subclassing object  https://review.opendev.org/71571419:05
mordredmnaser: oh - whoops19:05
mordredmnaser: and yay!19:05
* mordred pushd before seeing "before you push"19:05
mnasermordred: perfect timing :P19:05
mordredmnaser: tl;dr - foo.assert_called_once() == self.assertEqual(1, foo.call_count)19:05
mnasermordred: ahhh, yeah, that'll make sense19:06
mnasermuch better than what i was thinking19:06
* mordred looked at the 3.7 impl of the method :)19:06
mnaserwhich was rewriting them to use assert_called_with which was going to be using assert_called_once_with19:06
mordredyeah - that was the first thing I looked at - and then I didn't want to do that :)19:06
mnasererr, i mean using assert_called_once_with instead of assert_called_with, but that's way cleaner andless work19:06
mnaserhaha yep19:06
*** slaweq has joined #openstack-sdks19:33
mnasermordred: https://review.opendev.org/686592 can probably be abandoned cause it looks like we're already not running anything in py27 right?20:09
mordredmnaser: totes20:15
mnasermordred: i'm going over a lot of reviews for sdk and found this https://review.opendev.org/602234 -- is that ok to land or probably too many things going on?20:50
openstackgerritMerged openstack/osc-lib master: Update hacking for Python3  https://review.opendev.org/71553120:52
openstackgerritMerged openstack/openstacksdk master: Add unit test for rackspace block-storage workaround  https://review.opendev.org/71505821:25
openstackgerritSagi Shnaidman proposed openstack/openstacksdk stable/train: Add tests for Ansible built-in modules in 2.8,2.9  https://review.opendev.org/71408921:30
openstackgerritSagi Shnaidman proposed openstack/openstacksdk stable/train: Add tests for Ansible built-in modules in 2.8,2.9  https://review.opendev.org/71408921:31
openstackgerritSagi Shnaidman proposed openstack/openstacksdk stable/stein: Add tests for Ansible built-in modules in 2.8,2.9  https://review.opendev.org/71408721:33
openstackgerritSagi Shnaidman proposed openstack/openstacksdk stable/stein: Add tests for Ansible built-in modules in 2.8,2.9  https://review.opendev.org/71408721:33
sshnaidmmordred, can we merge? https://review.opendev.org/#/c/714078/21:40
sshnaidmmordred, please in your time, not sure it's best solution though https://review.opendev.org/#/c/715620/21:42
*** slaweq has quit IRC21:43
mordredsshnaidm: I think that's a decent enough solution for now21:50
mordredsshnaidm: I feel like there's something smarter we can do - because also testing that those properly fail on too old sdk is also valuable ... but let's not block progress waiting to figure that out :)21:51
sshnaidmmordred, agree21:51
sshnaidmmaybe will figure out something for Tuesday mtg21:51
mordredsshnaidm: I've got some other crazy thoughts - but they're more of a tuesday thing :)21:52
sshnaidmall right :)21:52
sshnaidmmordred, btw, today was ansible contributors mtg, minutes if you're interested: https://meetbot.fedoraproject.org/ansible-community/2020-03-29/ansible_contributor_summit_2020.2020-03-29-10.50.html21:54
sshnaidmmaybe I'll bring some highlights important for us to Tuesday21:54
*** slaweq has joined #openstack-sdks21:54
mordredcool21:55
mordredone quick question - have you seen the stuff where they search PYTHONPATH for ansible_collection dirs? - do you happen to know what the precedence is between collections found that way and collections installed via ansible-galaxy collection install?21:56
*** slaweq has quit IRC21:59
openstackgerritMohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8  https://review.opendev.org/61074422:04
openstackgerritMohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8  https://review.opendev.org/61074422:14
*** smcginnis has quit IRC22:19
*** smcginnis has joined #openstack-sdks22:19
openstackgerritMohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8  https://review.opendev.org/61074422:36
*** tkajinam has joined #openstack-sdks22:53
*** tosky has quit IRC22:54
openstackgerritMerged openstack/openstacksdk stable/stein: Add ansible collection job to stein branch  https://review.opendev.org/71407823:20
openstackgerritMerged openstack/openstacksdk master: Added missing {user, project}_domain_name in Api  https://review.opendev.org/67274023:48
*** slaweq has joined #openstack-sdks23:52
openstackgerritMohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8  https://review.opendev.org/61074423:56
« Saturday, 2020-03-28 Index Monday, 2020-03-30 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!