| *** gtema has joined #openstack-sdks | 00:15 | |
| *** gtema has quit IRC | 00:19 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add bulk creation of rules for Security Group. https://review.opendev.org/714103 | 00:26 |
|---|---|---|
| *** tosky has quit IRC | 00:32 | |
| *** gtema has joined #openstack-sdks | 02:16 | |
| *** gtema has quit IRC | 02:20 | |
| *** ianw has quit IRC | 02:30 | |
| *** ianw has joined #openstack-sdks | 02:36 | |
| *** ianw has quit IRC | 02:37 | |
| *** ianw has joined #openstack-sdks | 02:40 | |
| *** evrardjp has quit IRC | 05:36 | |
| *** evrardjp has joined #openstack-sdks | 05:36 | |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Add ansible-collections-openstack to the required-projects https://review.opendev.org/714784 | 06:40 |
| openstackgerrit | Merged openstack/ansible-collections-openstack master: Update the badge shown in galaxy https://review.opendev.org/714795 | 06:42 |
| openstackgerrit | Merged openstack/openstacksdk master: Add support for Identity Providers https://review.opendev.org/714122 | 07:08 |
| *** gtema has joined #openstack-sdks | 07:33 | |
| *** nightmare_unreal has joined #openstack-sdks | 07:48 | |
| *** slaweq has joined #openstack-sdks | 07:59 | |
| *** ralonsoh has joined #openstack-sdks | 08:01 | |
| *** tkajinam has quit IRC | 08:19 | |
| *** stephenfin has quit IRC | 08:19 | |
| *** amoralej|off is now known as amoralej | 08:22 | |
| *** tosky has joined #openstack-sdks | 08:24 | |
| *** dtantsur|afk is now known as dtantsur | 08:29 | |
| *** stephenfin has joined #openstack-sdks | 08:30 | |
| *** rpittau|afk is now known as rpittau | 08:31 | |
| *** gtema has quit IRC | 08:34 | |
| *** slaweq has quit IRC | 08:41 | |
| *** jpena|off is now known as jpena | 08:54 | |
| *** jpich has joined #openstack-sdks | 09:03 | |
| *** tremble has quit IRC | 09:08 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/rocky: Fix pep8 issues in project https://review.opendev.org/714899 | 09:13 |
| *** sshnaidm|afk is now known as sshnaidm | 09:15 | |
| *** slaweq has joined #openstack-sdks | 09:18 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/rocky: Fix pep8 issues in project https://review.opendev.org/714899 | 09:36 |
| openstackgerrit | Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431 | 10:02 |
| *** factor has joined #openstack-sdks | 10:04 | |
| sshnaidm | dtantsur, mordred, cores, can you please take a look at https://review.opendev.org/#/c/714899 ? I don't really understand what Jens Harbott means, maybe I don't have a right context. But something should be done there to restore the gates. I don't know why fixing pep8 is such a problem, tbh. | 10:07 |
| *** sshnaidm has quit IRC | 10:18 | |
| *** sshnaidm has joined #openstack-sdks | 10:19 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/openstacksdk stable/rocky: Cap hacking to avoid pep8 failures https://review.opendev.org/714911 | 10:19 |
| frickler | sshnaidm: that's me, btw, and ^^ is my proposed alternative. not sure test-reqs.txt is the correct location, but I hope so | 10:20 |
| sshnaidm | frickler, great, thanks! | 10:21 |
| sshnaidm | let's see if it helps | 10:21 |
| sshnaidm | but there are a lot of pep8 issues, including non-4 indentation, etc | 10:21 |
| *** gtema has joined #openstack-sdks | 10:21 | |
| *** tremble has joined #openstack-sdks | 10:24 | |
| dtantsur | thanks frickler, I guess we should do it on all branches? | 10:27 |
| sshnaidm | frickler, it fails, on pep8 and requirements-check now | 10:28 |
| rpittau | frickler: I left a comment in the review | 10:33 |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/openstacksdk stable/rocky: Cap hacking to avoid pep8 failures https://review.opendev.org/714911 | 11:09 |
| frickler | rpittau: seems you were right, not sure why we do not pull in our local (test-)reqs.txt in the pep8 env, but this should fix the errors | 11:10 |
| rpittau | frickler: yeah, that should work | 11:11 |
| frickler | dtantsur: I didn't see pep8 failures for newer branches | 11:12 |
| dtantsur | frickler: they're probably fixed, but I think at some point we (as a community) came to a resolution to cap hacking | 11:21 |
| *** tosky is now known as tosky_ | 11:24 | |
| *** yolanda has joined #openstack-sdks | 11:32 | |
| *** sshnaidm has quit IRC | 11:34 | |
| *** sshnaidm has joined #openstack-sdks | 11:34 | |
| frickler | dtantsur: indeed, with https://review.opendev.org/640597 mordred fixed it the way I would have expected for train and beyond | 11:37 |
| frickler | not sure about stein, though | 11:37 |
| dtantsur | frickler: should we backport that instead of your patch maybe? | 11:38 |
| *** jpich has quit IRC | 11:39 | |
| *** jpich has joined #openstack-sdks | 11:39 | |
| frickler | dtantsur: maybe, let's wait what mordred thinks about it, did a -W on my patch in the meantime | 11:39 |
| *** tosky_ is now known as tosky | 11:40 | |
| dtantsur | frickler: I personally find it quite non-controversial. but I'm fine with waiting as well. | 11:41 |
| *** rpittau is now known as rpittau|bbl | 11:42 | |
| tremble | dtantsur, Can I interest you in https://review.opendev.org/#/c/714431/ and get the last of my SDK changes in? | 11:44 |
| dtantsur | you can try :) | 11:44 |
| * tremble smiles sweetly :) | 11:46 | |
| dtantsur | +2, a couple of minor things for your optional consideration | 11:50 |
| tremble | dtantsur, The brackets nit is an old habit from switching between programming languages I'm never 100% exactly what the evaluation order is and brackets make it obvious | 11:52 |
| gtema | tremble - will you do a followup or change it here? | 11:53 |
| gtema | since I will give it a go otherwise | 11:53 |
| dtantsur | tremble: I don't insist, but they look a bit weird for a long-term Python coder like me | 11:53 |
| gtema | agree | 11:54 |
| tremble | gtema, I'll get them cleaned up, if you guys are happy python will do the right thing then there's no reason to add my coding oddities to a shared code base. | 11:55 |
| *** gtema has quit IRC | 11:57 | |
| *** sshnaidm is now known as sshnaidm|afk | 12:08 | |
| openstackgerrit | Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431 | 12:19 |
| *** sshnaidm|afk is now known as sshnaidm | 12:24 | |
| *** gtema has joined #openstack-sdks | 12:29 | |
| *** jpena is now known as jpena|lunch | 12:29 | |
| gtema | dtantsur, https://review.opendev.org/#/c/699416/ please | 12:33 |
| *** rpittau|bbl is now known as rpittau | 13:00 | |
| dtantsur | gtema: you know that I'm not really on OSC core, right? | 13:02 |
| *** enriquetaso has joined #openstack-sdks | 13:08 | |
| *** amoralej is now known as amoralej|lunch | 13:12 | |
| mordred | frickler, dtantsur: I'm good backporting whichever pep8 patch makes sense ... the test-requirements seems fine since that's in master already | 13:13 |
| gtema | dtantsur - sure, but your opinion as SDK dev | 13:20 |
| dtantsur | okay, but I'm in a chain of meetings now | 13:24 |
| openstackgerrit | jayaditya gupta proposed openstack/python-openstackclient master: Add '--force; parameter to 'openstack quota set' https://review.opendev.org/713881 | 13:31 |
| *** jpena|lunch is now known as jpena | 13:32 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/openstacksdk stable/stein: Move pep8 requirements in to test-requirements https://review.opendev.org/714946 | 13:52 |
| frickler | mordred: dtantsur: sshnaidm: rpittau: ^^ that would be the backport, needed manual amending because the hacking factory seems to not be there, I don't think we would want to backport that, too, would we? | 13:53 |
| dtantsur | I guess not.. | 13:54 |
| mordred | frickler: wfm | 13:55 |
| sshnaidm | frickler, actually my patch is a backport, but with conflicts resolved | 13:55 |
| sshnaidm | I couldn't backport it automatically | 13:55 |
| sshnaidm | frickler, mordred https://review.opendev.org/#/c/714899/ | 13:56 |
| *** amoralej|lunch is now known as amoralej | 14:00 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 14:35 |
| *** gtema has quit IRC | 15:12 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Switch image to use SDK https://review.opendev.org/650374 | 15:19 |
| openstackgerrit | Merged openstack/python-openstackclient master: Complete switch from glanceclient to SDK for image service https://review.opendev.org/699416 | 15:19 |
| tremble | dtantsur ( gtema ), https://review.opendev.org/714431 now has your requested changes | 15:35 |
| dtantsur | will check after the current meeting | 15:35 |
| tremble | Sure thing | 15:36 |
| tremble | mordred, was there a nominal date for the next SDK 'release' ? | 15:37 |
| mordred | tremble: my current thinking is "as soon as your patches land" | 15:39 |
| mordred | tremble: but - absolutely by the end of this week | 15:40 |
| mordred | (so we need to get your patches landed by the end of this week at the latest) | 15:40 |
| mordred | s/patches/patch | 15:41 |
| tremble | Fair enough :) | 15:44 |
| tremble | mordred, Well https://review.opendev.org/714431 is ready for review :) | 15:44 |
| tremble | mordred, Dumb question - Do you need anything from me on the release notes side of things? I have no idea how reno works | 15:49 |
| mordred | tremble: it's probably not a bad idea. to make one, you just run "reno some-name" - so like "reno added-federation-support" - it'll make a file in releasenotes and show you the path to it | 15:50 |
| mordred | then you edit that file, remove sections that aren't relevant and put in content - so announcing the new feature - doesn't have to be a lot | 15:51 |
| mordred | then git add the file and add it to the commit | 15:51 |
| tremble | mordred, Most of the commits are merged already, should I just spawn a separate review? | 15:52 |
| mordred | yeah - or you could add it to your latest patch there | 15:52 |
| mordred | when we cut the release we'll pick up all of the notes from it - so they can be in a separate patch or in the same - whichever is easier for you will work for me :) | 15:52 |
| tremble | I'll drop it as its own patch, I've been having issues with test flakes | 15:53 |
| mordred | cool | 15:54 |
| tremble | In theory there's a 'service_provider' interface that I've not added support for because we're not using it (we offload the relevant pieces to Apache) | 16:00 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | 16:38 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | 16:38 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632 | 16:38 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633 | 16:38 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991 | 16:38 |
| openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992 | 16:38 |
| openstackgerrit | Mark Chappell proposed openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994 | 16:47 |
| *** dtantsur is now known as dtantsur|afk | 17:06 | |
| *** rpittau is now known as rpittau|afk | 17:13 | |
| *** evrardjp has quit IRC | 17:36 | |
| *** evrardjp has joined #openstack-sdks | 17:36 | |
| *** jpich has quit IRC | 17:44 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 17:50 |
| *** jpena is now known as jpena|off | 18:00 | |
| *** nightmare_unreal has quit IRC | 18:36 | |
| *** irclogbot_1 has quit IRC | 18:37 | |
| *** irclogbot_0 has quit IRC | 18:37 | |
| *** amoralej is now known as amoralej|off | 18:59 | |
| *** irclogbot_1 has joined #openstack-sdks | 19:02 | |
| *** ralonsoh has quit IRC | 19:26 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431 | 19:27 |
| openstackgerrit | Merged openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994 | 19:27 |
| *** irclogbot_1 has quit IRC | 19:37 | |
| sshnaidm | frickler, can we please revisit this patch again? https://review.opendev.org/#/c/714899/ it pass and fixes a lot of pep8 issues | 19:41 |
| *** irclogbot_1 has joined #openstack-sdks | 19:41 | |
| sshnaidm | seems like https://review.opendev.org/#/c/714911/ just ignores them.. also could be an option, of course | 19:41 |
| *** irclogbot_1 has quit IRC | 19:42 | |
| *** irclogbot_2 has joined #openstack-sdks | 19:46 | |
| *** irclogbot_2 has quit IRC | 20:00 | |
| *** irclogbot_0 has joined #openstack-sdks | 20:04 | |
| openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052 | 20:08 |
| *** irclogbot_0 has quit IRC | 20:12 | |
| *** irclogbot_1 has joined #openstack-sdks | 20:16 | |
| *** diablo_rojo has quit IRC | 20:16 | |
| *** irclogbot_1 has quit IRC | 20:16 | |
| *** irclogbot_1 has joined #openstack-sdks | 20:22 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add unit test for rackspace block-storage workaround https://review.opendev.org/715058 | 20:25 |
| *** camelCaser has quit IRC | 20:25 | |
| mordred | dtantsur|afk: ^^ | 20:25 |
| *** camelCaser has joined #openstack-sdks | 20:26 | |
| mordred | sshnaidm: just left a comment on your backports of the fetch-subunit-output - let's squash in odyssey4me's | 20:28 |
| mordred | (since I think the two of them together will be a nice improvement for all the branches) | 20:28 |
| sshnaidm | mordred, yeah, totally fine with that | 20:29 |
| mordred | cool | 20:30 |
| mordred | ianw: feel like a +A on https://review.opendev.org/#/c/714630/ ? | 20:30 |
| mordred | ianw: (it'll let us revert the override setting in our own clouds.yamls) | 20:30 |
| sshnaidm | any ideas about neutron tests fail in train? https://review.opendev.org/#/c/714770/ | 20:40 |
| *** tosky has quit IRC | 20:40 | |
| mordred | sshnaidm: I'm guessing you would not be happy with "train is old" as an answer ... | 20:46 |
| mordred | sshnaidm: but seriously - no. maybe slaweq has an idea ? | 20:46 |
| sshnaidm | slaweq, can you take a look in your time? devstack should work for train, maybe some settings miss ^ | 20:47 |
| sshnaidm | I'm actually fine if it's blocked forever and no breaking patches can come in.. also an option :) | 20:48 |
| mordred | haha | 20:52 |
| slaweq | sshnaidm: mordred looking | 20:53 |
| *** tosky has joined #openstack-sdks | 20:54 | |
| slaweq | mordred: sshnaidm the issue IMO is that it runs SDK from master branch on this patch | 20:54 |
| slaweq | not train | 20:54 |
| slaweq | and neutron is from train | 20:54 |
| slaweq | where we don't have "description" field in port forwarding | 20:55 |
| slaweq | as it was added just few weeks ago in Neutron master | 20:55 |
| slaweq | that's why those tests are failing | 20:55 |
| ianw | mordred: does https://review.opendev.org/#/c/714630/3/openstack/config/vendors/rackspace.json need a {projectid} on the end of it? | 20:55 |
| slaweq | but I believe it should run tests on stable/train branch of sdk, not master, right? | 20:56 |
| mordred | slaweq: well ... we should probably update something so that master sdk works with train and master of neutron | 20:57 |
| mordred | that said - I agree, the purpose of the stable/train test in this case is to test stable/train of sdk - so that means the test is likely misconfigured | 20:57 |
| sshnaidm | mordred, hmm https://github.com/openstack/openstacksdk/blob/stable/train/.zuul.yaml#L40:L40 | 20:58 |
| mordred | ianw: it doesn't - we added a special logic workaround - projectid isn't available at the time substitutions are done | 20:58 |
| slaweq | mordred: sdk will work | 20:58 |
| ianw | mordred: yeah, ok seeing that | 20:59 |
| slaweq | but test in master is always trying to send "description" attribute to neutron server | 20:59 |
| slaweq | and neutron from train don't know this field so it fails | 20:59 |
| mordred | ah - so it's just a test thing | 20:59 |
| slaweq | yes | 20:59 |
| slaweq | and no | 20:59 |
| slaweq | basically test from train branch https://github.com/openstack/openstacksdk/blob/stable/train/openstack/tests/functional/network/v2/test_port_forwarding.py don't send description field | 20:59 |
| mordred | sshnaidm: yeah - we might need to rethink that. the historical position has been "just install latest sdk" | 21:00 |
| *** diablo_rojo has joined #openstack-sdks | 21:00 | |
| slaweq | but the same test from master https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/network/v2/test_port_forwarding.py have this new field | 21:00 |
| mordred | slaweq: nod | 21:00 |
| mordred | cool. I think I at least understand the issue | 21:00 |
| mordred | the correct solution on the other hand ... | 21:00 |
| ianw | mordred: ahh, seems i'm only +1, but it LGTM. it's all tangled web, but i guess that's exactly what the SDK takes the burden of so you don't have to! | 21:01 |
| slaweq | and this failure in functional jobs in https://review.opendev.org/#/c/714770/ are because there is run test from master branch (with description field) | 21:01 |
| mordred | sshnaidm: let's remove that branch override from the stable/train sdk branch | 21:02 |
| sshnaidm | mordred, ok | 21:02 |
| mordred | sshnaidm: and see if things update themselves properly | 21:02 |
| slaweq | I hope I helped a bit :) | 21:02 |
| mordred | slaweq: yes - very much! | 21:02 |
| sshnaidm | also os-client-config ? | 21:02 |
| mordred | sshnaidm: honestly os-client-config can probably just be removed | 21:03 |
| mordred | but | 21:03 |
| mordred | yeah - go ahead and just remove its branch override for now | 21:03 |
| mordred | let's clean that up later so we're not shifting too many things at once | 21:03 |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | 21:03 |
| sshnaidm | ^^ | 21:03 |
| mordred | sshnaidm: I think we still might want to consider constructing some things (similar to the ansible collection tests) that do things like "test master of openstacksdk against stable/train cloud" | 21:03 |
| mordred | but that's gonna take a little work | 21:03 |
| sshnaidm | mordred, yeah, matrix | 21:04 |
| mordred | sshnaidm: would you remove teh comment too? | 21:04 |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | 21:05 |
| openstackgerrit | Sagi Shnaidman proposed openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | 21:06 |
| sshnaidm | now ^ | 21:06 |
| mordred | sshnaidm: honestly probably want the same thing on the other stable branches that you care about | 21:06 |
| sshnaidm | it's weird they pass though.. | 21:07 |
| sshnaidm | mordred, well, in stein it's override-branch: stable/stein | 21:08 |
| sshnaidm | seems redundant | 21:08 |
| sshnaidm | maybe just remove it? https://github.com/openstack/openstacksdk/blob/stable/stein/.zuul.yaml#L37:L37 | 21:08 |
| sshnaidm | and override-branch: stable/rocky in rocky: https://github.com/openstack/openstacksdk/blob/stable/rocky/.zuul.yaml#L52 | 21:10 |
| sshnaidm | that's why it works.. | 21:10 |
| mordred | nod. | 21:11 |
| mordred | so - this is something we've fixed before and forgotten about :) | 21:11 |
| *** enriquetaso has quit IRC | 21:17 | |
| sshnaidm | but why need overrides.. | 21:23 |
| mordred | sshnaidm: probably don't | 21:29 |
| mordred | sshnaidm: s/probably// | 21:29 |
| openstackgerrit | Merged openstack/python-openstackclient master: Don't look up project by id if given id https://review.opendev.org/712810 | 22:10 |
| *** gtema has joined #openstack-sdks | 22:27 | |
| *** Jeffrey4l has quit IRC | 22:27 | |
| *** Jeffrey4l has joined #openstack-sdks | 22:29 | |
| *** gtema has quit IRC | 22:32 | |
| *** slaweq has quit IRC | 22:34 | |
| *** slaweq has joined #openstack-sdks | 22:46 | |
| openstackgerrit | Merged openstack/openstacksdk master: Update Rackspace vendor profile for cinder v2 https://review.opendev.org/714630 | 22:46 |
| *** slaweq has quit IRC | 22:51 | |
| *** tkajinam has joined #openstack-sdks | 22:52 | |
| *** efried_gone has quit IRC | 23:18 | |
| openstackgerrit | Merged openstack/openstacksdk stable/train: Remove master override for openstacksdk https://review.opendev.org/715065 | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!