openstackgerrit | Merged openstack/openstacksdk stable/train: Include "fields" to "SecurityGroup" query parameters https://review.opendev.org/711622 | 01:30 |
---|---|---|
*** ricolin_ has joined #openstack-sdks | 01:39 | |
openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Change 'Volume' to 'Block Storage' https://review.opendev.org/532439 | 01:46 |
*** enriquetaso has quit IRC | 01:51 | |
openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Disallow setting default on internal network https://review.opendev.org/539303 | 02:03 |
openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Update http links in docs https://review.opendev.org/567729 | 02:16 |
*** enriquetaso has joined #openstack-sdks | 02:29 | |
openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Compute: Add tag support for server add port https://review.opendev.org/580977 | 02:34 |
*** enriquetaso has quit IRC | 03:05 | |
*** dave-mccowan has quit IRC | 04:40 | |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-sdks | 05:35 | |
*** ricolin_ has quit IRC | 06:23 | |
*** ricolin has joined #openstack-sdks | 06:23 | |
*** eandersson has quit IRC | 06:23 | |
*** eandersson has joined #openstack-sdks | 06:24 | |
*** slaweq has joined #openstack-sdks | 07:55 | |
*** tkajinam has quit IRC | 08:08 | |
*** tosky has joined #openstack-sdks | 08:18 | |
*** ralonsoh has joined #openstack-sdks | 08:50 | |
*** jpena|off is now known as jpena | 08:50 | |
*** jpich has joined #openstack-sdks | 08:59 | |
frickler | slaweq: could you take a look at https://review.opendev.org/539303 please? I'm not sure this really makes sense in all situations | 09:59 |
slaweq | frickler: sure, looking | 10:00 |
*** sshnaidm|afk is now known as sshnaidm | 10:01 | |
slaweq | frickler: IMO it makes sense | 10:03 |
slaweq | frickler: according to the https://docs.openstack.org/neutron/latest/admin/config-auto-allocation.html at least | 10:04 |
*** dtantsur|afk is now known as dtantsur | 10:06 | |
dtantsur | morning folks, looking for a 2nd +2 on https://review.opendev.org/#/c/711952/ it fixes os_ironic with newer SDK | 11:02 |
*** tkajinam has joined #openstack-sdks | 11:15 | |
frickler | slaweq: hmm, o.k., thx for checking | 11:29 |
*** jpich has quit IRC | 11:37 | |
*** Luzi has joined #openstack-sdks | 11:37 | |
*** jpich has joined #openstack-sdks | 11:38 | |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | 11:56 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | 11:59 |
openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add option for modules_default groups https://review.opendev.org/712057 | 12:12 |
*** enriquetaso has joined #openstack-sdks | 12:24 | |
*** jpena is now known as jpena|lunch | 12:25 | |
*** jpich has quit IRC | 12:39 | |
*** jpich has joined #openstack-sdks | 12:40 | |
*** rpittau has joined #openstack-sdks | 13:00 | |
smcginnis | Anyone aware of a change in the SDK that would cause this: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f9e/711930/2/check/openstacksdk-functional-devstack/f9e911a/testr_results.html | 13:04 |
smcginnis | Failing on a requirements update patch that doesn't seem to be related. | 13:04 |
*** jpena|lunch is now known as jpena | 13:04 | |
mordred | smcginnis: hrm - yes, possibly - but why would it not have failed on that patch that did it | 13:06 |
mordred | looking | 13:06 |
smcginnis | I always ask myself that with these kinds of things. :) | 13:06 |
mordred | smcginnis: I take it back - I don't see any reason for that | 13:07 |
rpittau | I'm also seeing some weird errors in testing https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_97c/711640/3/check/openstack-tox-py37/97cfb62/testr_results.html | 13:07 |
dtantsur | Oo | 13:08 |
mordred | smcginnis: we might want to check to see if nova recently landed any changes disallowing deleting aggregates by name | 13:09 |
mordred | rpittau: https://zuul.opendev.org/t/openstack/build/97cfb620a44b4c91b886e02318306ea2/log/job-output.txt#4355 - and https://zuul.opendev.org/t/openstack/build/97cfb620a44b4c91b886e02318306ea2/log/job-output.txt#4166 | 13:13 |
mordred | rpittau: I thnik something maybe timed out? | 13:13 |
mordred | and it hit a hard-kill | 13:13 |
mordred | doesn't look like it was that test - looks like it was another one? | 13:13 |
rpittau | mordred: yeah, the odd part is that it's happening in other jobs too | 13:14 |
rpittau | I triggered another recheck | 13:14 |
mordred | *excellent* | 13:14 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 13:18 |
mordred | smcginnis, dtantsur: ^^ if you don't mind - nova just landed a change that has broken our functional tests | 13:19 |
mordred | I'd complain at nova - but it's actually just causing a broken test to be shown to be broken | 13:19 |
mordred | hrm | 13:21 |
mordred | actually - no - I think I'm going to go complain | 13:21 |
rpittau | :D | 13:23 |
smcginnis | :) | 13:28 |
mordred | ok. I complained - and I'm back to thinking it's a bug on our side | 13:29 |
mordred | our delete method has a name_or_id argument, but it just passes it on directly without attempting to get an id | 13:30 |
smcginnis | Followed there... that makes sense. | 13:30 |
mordred | the REST call _only_ accepts ids | 13:30 |
mordred | it also seems they've defined the API to assert that those ids will always be ints - so we have an easy check we can do to see if a name was passed | 13:31 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 13:36 |
mordred | smcginnis, Shrews, dtantsur: ^^ that should fix the test and the behavior | 13:36 |
smcginnis | Nice, thanks for the quick fix mordred | 13:38 |
mordred | let me make one more quick update - I think it would also be fine for someone to pass an aggregate object in | 13:39 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 13:41 |
mordred | smcginnis: how's that look? | 13:41 |
smcginnis | Yeah, good call! | 13:42 |
mordred | we don't advertise being able to pass an object there - but it woudl actually work to :) | 13:42 |
smcginnis | Yeah, I like that being able to handle it. Could be nice for some situations. | 13:43 |
*** dave-mccowan has joined #openstack-sdks | 14:02 | |
dtantsur | mordred: oh sweet :( +2 | 14:07 |
Shrews | mordred: + | 14:10 |
Shrews | mordred: +A | 14:10 |
Shrews | gah | 14:10 |
mordred | Shrews: right? | 14:21 |
mordred | yay for breaking API changes | 14:21 |
*** Luzi has quit IRC | 14:32 | |
openstackgerrit | Merged openstack/python-openstackclient master: Disallow setting default on internal network https://review.opendev.org/539303 | 14:35 |
dtantsur | mordred: I've heard about this microversion thing, pity that nova doesn't use it | 14:36 |
mordred | dtantsur: heh | 14:36 |
*** iurygregory has quit IRC | 14:39 | |
*** iurygregory has joined #openstack-sdks | 14:43 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 14:50 |
mordred | dtantsur, Shrews, smcginnis: sorry to bother you again - unit test issue. ^^ | 14:50 |
mordred | also added a unit test while in there ... and fixed the logic error :) | 14:50 |
dtantsur | mordred: isinstance(name_or_id, six.string_types + six.binary_types) ? :) | 14:51 |
dtantsur | okay, okay, not nitpicking | 14:51 |
mordred | dtantsur: oh - does that work? | 14:52 |
dtantsur | mordred: worse issue: what is is_digit? I cannot see it in my python | 14:52 |
dtantsur | mordred: both are tuples, you can concatenate them | 14:52 |
mordred | cool. | 14:52 |
mordred | dtantsur: isdigit - no _ | 14:52 |
dtantsur | ah, gotcha | 14:52 |
mordred | I wish six just had a "six.seriously_all_the_stringlike_types" | 14:53 |
dtantsur | mordred: oops, there is only binary_type, not binary_types | 14:53 |
mordred | blerg. fix coming | 14:54 |
smcginnis | Hah | 14:54 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 14:54 |
mordred | I always write patches perfectly the first time | 14:55 |
dtantsur | mordred: nope, six.string_types + (six.binary_type,) | 14:55 |
dtantsur | or just ignore me and have two conditions | 14:55 |
mordred | hahaha | 14:55 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 14:56 |
mordred | dtantsur: I think the concat actually expresses the idea | 14:56 |
mordred | Shrews: got a sec for a re+A? | 14:58 |
Shrews | mordred: looking | 14:58 |
Shrews | mordred: now that i think about it, should we modify the log line below that to reference the original value if we changed it? or maybe both values? | 15:00 |
Shrews | otherwise a user might be "that's not the value i asked you to delete" | 15:00 |
Shrews | oh, we shouldn't actually hit that | 15:01 |
Shrews | nm | 15:01 |
Shrews | is this monday? i could swear this is monday | 15:01 |
mordred | feels like it | 15:02 |
mordred | did yesterday happen? | 15:02 |
Shrews | Tuesday is just Second Monday in hobbit world | 15:02 |
dtantsur | ++ | 15:02 |
*** jpich has quit IRC | 15:12 | |
*** jpich has joined #openstack-sdks | 15:13 | |
*** tkajinam has quit IRC | 15:17 | |
*** KeithMnemonic has joined #openstack-sdks | 15:38 | |
*** jpich has quit IRC | 15:38 | |
*** jpich has joined #openstack-sdks | 15:39 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/711952 | 16:39 |
mordred | dtantsur: ^^ rebased that on top of the functional test fix and re-+A'd | 16:39 |
dtantsur | thx! | 16:40 |
mordred | I'll cut another release when they land | 16:40 |
dtantsur | cool. I'll also propose a train backport | 16:41 |
mordred | ++ | 16:43 |
openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Import generate_temp_url from swiftclient https://review.opendev.org/711640 | 16:50 |
rpittau | ^^ rebase on top of the fix | 16:50 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support for stateless security groups https://review.opendev.org/711513 | 17:05 |
*** rpittau is now known as rpittau|afk | 17:10 | |
*** sshnaidm is now known as sshnaidm|afk | 17:31 | |
*** jpich has quit IRC | 17:35 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #openstack-sdks | 17:35 | |
*** dtantsur is now known as dtantsur|afk | 17:36 | |
*** jpena is now known as jpena|off | 17:43 | |
openstackgerrit | Merged openstack/openstacksdk master: Fix aggregate functional test for id restriction https://review.opendev.org/712068 | 17:46 |
mordred | woot | 18:19 |
*** factor has joined #openstack-sdks | 18:36 | |
*** ralonsoh has quit IRC | 19:07 | |
*** mugsie has quit IRC | 19:23 | |
*** mugsie has joined #openstack-sdks | 19:26 | |
openstackgerrit | Merged openstack/openstacksdk master: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/711952 | 19:27 |
*** openstackgerrit has quit IRC | 19:32 | |
*** openstackgerrit has joined #openstack-sdks | 19:53 | |
openstackgerrit | Merged openstack/openstacksdk master: Support for stateless security groups https://review.opendev.org/711513 | 19:53 |
*** slaweq has quit IRC | 20:03 | |
*** openstackstatus has joined #openstack-sdks | 20:20 | |
*** ChanServ sets mode: +v openstackstatus | 20:20 | |
*** dave-mccowan has quit IRC | 20:27 | |
*** factor has quit IRC | 21:19 | |
*** evrardjp has quit IRC | 22:17 | |
*** evrardjp has joined #openstack-sdks | 22:18 | |
*** evrardjp has quit IRC | 22:31 | |
*** evrardjp has joined #openstack-sdks | 22:33 | |
*** tkajinam has joined #openstack-sdks | 22:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!