Wednesday, 2020-03-04

*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:15
*** dayou has quit IRC00:36
*** dayou has joined #openstack-sdks00:37
*** slaweq has joined #openstack-sdks01:11
*** slaweq has quit IRC01:16
*** slaweq has joined #openstack-sdks02:11
*** slaweq has quit IRC02:15
*** __ministry has quit IRC02:59
*** slaweq has joined #openstack-sdks03:11
*** __ministry has joined #openstack-sdks03:12
*** slaweq has quit IRC03:16
*** slaweq has joined #openstack-sdks04:11
*** slaweq has quit IRC04:17
*** slaweq has joined #openstack-sdks05:11
*** slaweq has quit IRC05:15
*** evrardjp has quit IRC05:35
*** evrardjp has joined #openstack-sdks05:35
*** slaweq has joined #openstack-sdks06:11
*** slaweq has quit IRC06:16
*** slaweq has joined #openstack-sdks07:11
*** slaweq has quit IRC07:15
*** slaweq has joined #openstack-sdks07:38
*** slaweq has quit IRC07:43
*** slaweq has joined #openstack-sdks07:49
*** tosky has joined #openstack-sdks08:32
*** ralonsoh has joined #openstack-sdks08:33
*** jpena|off is now known as jpena08:48
*** jpich has joined #openstack-sdks09:03
*** tkajinam has quit IRC09:30
openstackgerritSlawek Kaplonski proposed openstack/openstacksdk master: Add description field to portforwarding NAT rules  https://review.opendev.org/70503809:55
*** dtantsur|afk is now known as dtantsur10:09
*** openstackstatus has joined #openstack-sdks11:51
*** ChanServ sets mode: +v openstackstatus11:51
openstackgerritHervé Beraud proposed openstack/python-openstackclient stable/train: Add parent project filter for listing projects  https://review.opendev.org/71120811:56
*** jpena is now known as jpena|lunch12:32
*** amito has quit IRC12:54
*** TheJulia has quit IRC12:54
*** TheJulia has joined #openstack-sdks12:54
*** vdrok has quit IRC12:54
*** Shrews has quit IRC12:54
*** amito has joined #openstack-sdks12:54
*** masayukig has quit IRC12:55
*** vdrok has joined #openstack-sdks12:55
*** Shrews has joined #openstack-sdks12:55
*** masayukig has joined #openstack-sdks12:56
*** vdrok has quit IRC13:23
*** efried1 has joined #openstack-sdks13:24
*** vdrok has joined #openstack-sdks13:25
*** efried has quit IRC13:25
*** efried1 is now known as efried13:25
*** enriquetaso has joined #openstack-sdks13:30
*** jpena|lunch is now known as jpena13:33
openstackgerritJavier Peña proposed openstack/openstacksdk master: [TEST DO NOT MERGE] Replace assertItemsEqual with assertCountEqual  https://review.opendev.org/71123513:50
openstackgerritLajos Katona proposed openstack/openstacksdk master: Add port property: ip_allocation  https://review.opendev.org/71123714:09
openstackgerritBharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode  https://review.opendev.org/71082314:15
brtknrShrews: ^^14:15
brtknralso mordred ^14:15
mordredbrtknr: beautiful - thanks14:23
*** ricolin has quit IRC14:25
mordredslaweq: https://review.opendev.org/#/c/711237/ look ok to you? also - I rechecked that description patch - it seems to just keep being unlucky14:26
openstackgerritBharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode  https://review.opendev.org/71082314:29
brtknrmordred: sorry, i had to fix the brackets out of OCD14:29
mordredbrtknr: I agree with your fix :)14:33
brtknrmordred: :D14:33
Shrewsbrtknr: thank you for the tests!14:38
brtknrShrews: my pleasure14:38
*** dtantsur is now known as dtantsur|brb14:46
slaweqmordred: looking14:55
slaweqmordred: +2 this patch and thx for rechecking the other one :)15:00
openstackgerritJavier Peña proposed openstack/openstacksdk master: Replace assertItemsEqual with assertCountEqual  https://review.opendev.org/71123515:14
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc  https://review.opendev.org/71124615:16
*** dtantsur|brb is now known as dtantsur16:00
*** jpich has quit IRC16:14
*** jpich has joined #openstack-sdks16:14
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc  https://review.opendev.org/71124616:15
openstackgerritBharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode  https://review.opendev.org/71082316:20
*** iurygregory has quit IRC16:20
openstackgerritBharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode  https://review.opendev.org/71082316:20
brtknrmordred: Shrews: Sorry i should have run tox -e pep8 before submitting16:21
mordredbrtknr: hahahaha16:21
*** gtema has joined #openstack-sdks16:26
*** ricolin has joined #openstack-sdks16:37
*** gtema has quit IRC17:02
openstackgerritClark Boylan proposed openstack/python-openstackclient master: Replace pkg_resources with importlib-metadata  https://review.opendev.org/66185617:03
smcginnisThanks mordred. Sad to see how many names are in the "no longer around" list.17:03
mordredsmcginnis: right?17:03
smcginnisJust imagine if there were still that many cores working on things here. That OSC thread definitely wouldn't have been an issue.17:04
dtantsurle sigh17:04
mordredsmcginnis: _seriously_17:04
dtantsur... and I'm not even officially assigned to work on SDK ...17:08
smcginnisHeh, I'm not even officially assigned to work on OpenStack. I just have a hard time moving on. :D17:09
dtantsuroh wow17:10
openstackgerritRiccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node  https://review.opendev.org/71103217:10
openstackgerritRiccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node  https://review.opendev.org/71103217:11
*** openstackgerrit has quit IRC17:20
mordreddtantsur: I've *never* been officially assigned to work on SDK ;)17:20
dtantsurLOOOL17:21
*** jpich has quit IRC17:21
*** evrardjp has quit IRC17:35
*** evrardjp has joined #openstack-sdks17:35
umbSublimeIs it possible to specify microversion to use on openstack.proxy.Proxy calls. Or at least force one to be used by the proxy. I know I've asked this in the past, but it wasn't possible then. Maybe it is now ?17:37
*** dtantsur is now known as dtantsur|afk17:41
umbSublimeI still get None on for example conn.compute.min_version and conn.compute.max_version yet information is there when inspecting: conn.compute.get_all_version_data()17:41
umbSublimeopenstack.version.__version__ == 0.41.0, keystoneauth1.__version__ == 3.18.017:43
mordredumbSublime: the intent is that as a user of the library you should never have to specify a microversion - let me look at the min_version / max_version thing ... what are you trying to do that isn't working? (other than specifying a microversion)17:44
mordred(I believe we did add the ability for you to force one - but I'm more curious why you need to)17:44
*** jpena is now known as jpena|off17:46
umbSublimeWell say I cann conn.compute.hypervisors(), then the 'id' is an int while when using microversion 2.53 I get UUIDs. Same can be observed with openstackclient: `openstack hypervisor list` vs `openstack --os-compute-api-version 2.53 hypervisor list`17:47
umbSublimeI can force it with conn.compute.get('/os-hypervisors', microversion="2.53"). But it would be awesome if i could do conn.compute.hypervisors(microversion="2.53")17:49
mordredshould we not maybe just default to 2.53 if it's available in this case?17:49
umbSublimeyes or whatever the max_microversion is  for the endpoint17:50
mordredwell - we have to pick max_microversion we can support- this doesn't sound like one we'd need to update anything else in the sdk to support, so it's pretty easy (sometimes thigs change key names or the liek and we need to add compat code to be able to safely provide them)17:51
*** openstackgerrit has joined #openstack-sdks17:52
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Set max_microversion to 2.53 for hypervisors  https://review.opendev.org/71129417:52
umbSublimeso then each api call requiring a specific microversion should be hard-coded on sdk side ?17:52
mordredumbSublime: ^^ that should do the trick for you17:52
mordredumbSublime: yes - otherwise microversion changes don't protect the user from very much and we might as well not have them17:52
mordredbut if we use them well, they're pretty awesome17:52
mordredwe don't hard-core the api calls themselves, we have a system where we can express what microversion a given resource knows how to handle the requests and responses for17:53
umbSublimeAhh I see.17:53
umbSublimeRegardless of that though in the event that new microversion is not yet supported by SDK, wouldn't it be also pretty neat to be able to specifiy it as kwarg on the method too ?17:54
umbSublimeBecause there are cases where a feature is supported between microverion X and Y and then removed or again modified in microversion Z17:55
mordrednot necessarily, because the SDK has to map the responses into the Resource objects. that said - I'm _pretty_ sure if you set compute_api_version to 2.53 in our clouds.yaml then we'll set default_microversion of it17:55
mordredumbSublime: oh that's joyous :)17:56
umbSublimemordred, I'll give that a shot17:56
mordreddtantsur|afk: darn, you're not here- we added support for configuring a defaut_microversion override didn't we?17:56
mordredyes17:57
mordredumbSublime: so you can either be _explicit_ and do compute_default_microversion=2.5317:57
mordredor you can do compute_api_version=2.53 and we'll infer that you mean default_microversion17:57
mordredhowever - just know that your mileage may vary if you do that - we may not necessarily know how to deal with all of the responses on all of the calls and it could blow up in fascinating ways :)17:58
mordred(always looking for improvements though - so if you do find a place where you do that and it blows up, let us know and we can figure out how to support that mv)17:58
umbSublimeindeed forcing compute_api_version in clouds.yaml does the job.17:59
umbSublimeI wasn't aware of that trick. Very useful!!17:59
*** sshnaidm is now known as sshnaidm|afk17:59
mordredwoot!18:00
* mordred has been helpful today - will now go back to hiding18:00
umbSublime^^18:00
umbSublimeAm I correct in assuming that if I set compute_default_microversion=2.53, then the microversion header will be sent to ALL compute requests ?18:01
mordredyes18:01
umbSublime\o/18:01
mordredwell - all compute requests where sdk isn't already setting something more explicitly18:02
umbSublimeright, like for example the patch on hypervisors you just did ?18:02
mordredthere are places with more explicit mv negotiation - live_migrate comes to mind18:02
mordredand yeah18:02
mordredso like I said - the GOAL is that you never have to do that - but we're obviously not 100% there on that goal18:03
umbSublimeAsside from debug log and reading the code, is there a programatic way to know what API version will be used by conn.compute.<method> ?18:03
mordredthat's an excellent question18:04
umbSublimeWell for me this clouds.yaml trick fixes a lot of headaches !!18:04
mordredI'm gonna say - "no" ... but I think that's an excellent thing to want to know18:04
mordredso I'll think about how we might accomplish that18:04
umbSublimemordred, thanks a lot !18:06
openstackgerritMerged openstack/openstacksdk master: Replace assertItemsEqual with assertCountEqual  https://review.opendev.org/71123518:07
mordredslaweq: if you have a sec, https://review.opendev.org/#/c/710030/ is neutron related18:19
mordredslaweq: as is https://review.opendev.org/#/c/710820/18:20
*** tosky has quit IRC18:44
mordreddtantsur|afk: whence you are back - I'm looking at switching to futurist ... we use concurrent.futures.as_completed currently - futurist seems to have wait_for_all and wait_for_any ... do you have a suggestion of the best way to accomplish a similar pattern to as_completed?18:47
mordreddtantsur|afk: hrm. actually - looking at the code wait_for_all should still work18:48
mordreddtantsur|afk: ACTUALLY - nothing shoudl stop us from using concurrent.futures.as_completed since futurist is using that as a base18:50
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Switch to futurist for concurrency  https://review.opendev.org/71130118:56
*** dmellado has quit IRC19:24
*** dmellado has joined #openstack-sdks19:25
*** mgoddard has quit IRC19:27
*** mgoddard has joined #openstack-sdks19:28
umbSublimeI just watched a talk from OS summit about the SDK. The speaker says a proxy object is created for every service_types_authority even if the target cloud doens't have the service in it's endpoints and even if no ressource objects are created (we should at least be able to get/put/post/delete). Has this been rolled back ? I have placement-api in my deployment but get and error with conn.placement. This is also something i've19:29
umbSublimediscussed here in the past (don't remembeer who). i had a work-around where I added a placement adapter to keystoneauth, but it was a bit dirty19:29
mordredumbSublime: WELL - that was probably me, and you should always take anything I say with a grain of salt19:30
mordredthat said - I could expect conn.placement to exist and be a proxy - how ever, if you don't have placement in your service-catalog, it's not going to know how to configure that proxy to be able to talk to anything because it's not going to know where the placement endpoint is19:31
mordredumbSublime: you can put placement_endpoint_override in your clouds.yaml with the placement endpoint and that should tell it where your placement service is19:32
umbSublimeI do see it with `openstack endpoint list`19:32
mordredok. so it is in your catalog19:32
umbSublimeyup19:32
mordredin that case I fully expect conn.placement to give you a working proxy19:32
* mordred is trying to think the best way to debug why you don't19:33
umbSublimeAny debug or things you want me to check (I assume there might be a bug)19:33
umbSublimeGreat talk BTW :D19:33
openstackgerritJames Denton proposed openstack/openstacksdk stable/stein: Add "name" filter in "list" call when retrieving a single register  https://review.opendev.org/71131419:33
umbSublimemordred, here is the stack-trace what the stacktrace looks like: https://hastebin.com/vizuhufiqi.rb19:37
mordredumbSublime: can you run http://paste.openstack.org/show/790311/ (obviosly change the connect call if you need to) and paste the output?19:37
mordredoh - hrm19:37
mordredwhat version of keystoneauth - and do you know what version of placement?19:37
umbSublimekeystoneauth1.__version__ == '3.18.019:38
*** ralonsoh has quit IRC19:38
umbSublime:facepalm: I didn't install osc-placement in that venv. potential pebcak19:38
mordredpossibly - however ... are you setting a placement_api_version there?19:39
umbSublimeOk so I get same stack-trace with osc-placement installed. And I have nothing related to placement in my clouds.yaml19:40
mordredyeah - I think this is placement not returning a proper version discovery doc for some reason - which is a thing I thought we'd put in a workaround for before19:41
mordredcould you run that little script above? that should catch the full http trace19:41
* mordred grumbles19:41
umbSublimebeing an private cloud do you mind If I just remove endpoint dict from the output i share with you ? (that's probably what you want to check :/ )19:42
mordrednah - actually I thnk that's fine - I mostly want to see the payload returned from the root of your placement service19:43
umbSublimeAfter the token request i see a call on the endpoint with the port my placement-api is running on. This is the response: {"versions": [{"min_version": "1.0", "max_version": "1.17", "id": "v1.0"}]}19:43
mordredsigh19:44
mordredok. so - that's a broken discovery dict - which I *think* we got fixed in upstream placement (I'll go check that next - it doesn't match my test fixture for placement)19:44
umbSublimeIs this correct response format?19:44
mordredfor now - set placement_endpoint_override19:44
mordredyeah19:44
mordredit's jst missing a status: field19:44
umbSublimeAhh so then i'd need to update my placement-api service19:45
mordredyeah - although I *also* want to see if I can't work around that in sdk too19:45
mordredbecause that's a bad experience for people19:45
mordredI thought we already had - but I see clearly we didn't19:45
mordredbut for now - if you set placement_endpoint_override to the base endpoint of the placement service it should work for you19:45
umbSublimewould be awesome. For newer clouds, I can update the version, but this legacy cloud will probably have to live with it's current placement version19:45
mordredyah19:45
umbSublimetesting now19:46
mordredand we aim to support older clouds too - so it's fair for us to deal with that19:46
*** iurygregory has joined #openstack-sdks19:46
umbSublimeI put the endpoint I get for `endpoint list` as a value right ?19:46
mordredyeah19:46
umbSublime\o/ print(conn.placement) -> <openstack.proxy.Proxy object at 0x7ffbdaf5a5c0>19:47
mordredWOOT19:47
mordredcool. I can work up a test case that has a broken old placement discovery dict and then figure out how to fix it :)19:48
mordredthanks for helping track that down19:48
umbSublimeMan I'm going to get rid of so much hacky code today ^^19:48
mordred\o/19:48
mordredmy main goal in life is facilitating the deletion of code19:48
umbSublimethanks a bunch !!!19:48
umbSublimehahaha it's working XD19:48
openstackgerritMerged openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode  https://review.opendev.org/71082320:05
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service  https://review.opendev.org/71132820:23
mordredumbSublime: ^^ that produces the same error - so there's that at leat20:25
mordredleast20:25
umbSublime:)20:28
umbSublimeDo you want me to file a bug for this. I'm not sure if the fix has to be implemented in keystoneauth1 or the SDK directly20:29
mordredumbSublime: nah - I'm working on it20:32
mordredumbSublime: although I feel lke I'm going to need a shower when I'm done :)20:33
umbSublime<320:33
*** iurygregory has quit IRC20:43
umbSublimeSay I wanted (one day) to try and tackle some low hanging fruit bugs on the SDK where are issues tracked. I don't see much stuff related to sdk in launchpad21:04
mordredwe're in storyboard ... https://storyboard.openstack.org/#!/project/openstack/openstacksdk21:06
mordredI'm pretty bad about using it myself though (hides)21:06
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service  https://review.opendev.org/71132821:09
mordredumbSublime: and there's the workaround :)21:10
mordredShrews: I feel like it's been too long since you've had to review patches from me touching version discovery in the guts of SDK ^^21:10
mordredefried: ^^ same story21:10
efriedmordred: can you link to the commit that corrected the missing status field in placement?21:13
mordredefried: uh ... I was sort of hoping you just magically new ... let me go look21:19
efriedmordred: I could have gone and looked myself. <lazy>21:19
efriedI probably wrote that patch. Or at least reviewed it.21:19
efriedBut I'm way behind memorizing the gerrit numbers and commit hashes of all the patches I've been involved in.21:20
mordredefried: https://review.opendev.org/#/c/575117/21:21
mordredefried: you want me to put a referene to that in the commit message?21:21
efriedmordred: yes please, but also one other comment...21:21
efriedmordred: ...posted21:22
efriedJSON doesn't allow comments???21:24
efriedI'll be back to +2 that in ~.5h21:24
Shrewsmordred: oh, i can't wait. really. no, seriously.21:24
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service  https://review.opendev.org/71132821:24
mordredefried: nope. that's one of teh nice things about yaml21:25
umbSublimeThanks mordred !21:25
mordredShrews: well - no need to wait - there you are, all nice and ready for you21:25
efriedmordred: +221:25
mordred\o/21:25
mordredumbSublime: thak you - that was very helpful debugging info - and I imagine you won't be the only one to hit that21:26
umbSublimeThat was the easy part ;)21:31
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add bindep file  https://review.opendev.org/71105521:36
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc  https://review.opendev.org/71124621:36
*** KeithMnemonic has joined #openstack-sdks21:37
*** enriquetaso has quit IRC21:59
openstackgerritSam Morrison proposed openstack/python-openstackclient master: Always display direction for security group rules  https://review.opendev.org/70901722:04
openstackgerritSam Morrison proposed openstack/python-openstackclient master: Always display direction for security group rules  https://review.opendev.org/70901722:05
*** tosky has joined #openstack-sdks22:11
*** slaweq has quit IRC22:21
openstackgerritMerged openstack/ansible-collections-openstack master: Fix H236 and remove exclusion  https://review.opendev.org/69806622:22
openstackgerritMerged openstack/ansible-collections-openstack master: Remove from __future__ lines  https://review.opendev.org/69806722:27
openstackgerritMerged openstack/ansible-collections-openstack master: Test with and assert support for python3  https://review.opendev.org/71064122:27
openstackgerritMerged openstack/openstacksdk master: Fix: Set image name correctly if filename is not passed  https://review.opendev.org/71036822:57
*** tkajinam has joined #openstack-sdks22:59
*** slaweq has joined #openstack-sdks23:11
*** slaweq has quit IRC23:16
openstackgerritMerged openstack/openstacksdk stable/train: Handle HTTP errors in add/remove router interface calls  https://review.opendev.org/71099423:19
openstackgerritMerged openstack/openstacksdk stable/train: Fix error handling on add/remove router iface calls  https://review.opendev.org/71099523:19
*** tosky has quit IRC23:40

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!