Thursday, 2020-01-30

« Wednesday, 2020-01-29 Index Friday, 2020-01-31 »
*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:16
*** ricolin has joined #openstack-sdks01:14
*** ricolin has quit IRC01:17
*** ricolin_ is now known as ricolin01:18
*** goldyfruit_ has quit IRC01:43
openstackgerritShogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg)  https://review.opendev.org/67991401:43
*** slaweq has joined #openstack-sdks02:11
*** __ministry has joined #openstack-sdks02:13
*** slaweq has quit IRC02:16
*** iokiwi has quit IRC03:26
*** adriant has quit IRC03:26
*** slaweq has joined #openstack-sdks04:11
*** slaweq has quit IRC04:16
*** ricolin has quit IRC04:42
*** adriant has joined #openstack-sdks05:06
*** iokiwi has joined #openstack-sdks05:06
*** adriant has quit IRC05:09
*** iokiwi has quit IRC05:09
*** iokiwi has joined #openstack-sdks05:10
*** adriant has joined #openstack-sdks05:10
*** slaweq has joined #openstack-sdks06:11
*** slaweq has quit IRC06:16
*** slaweq has joined #openstack-sdks07:05
*** jawad_axd has joined #openstack-sdks07:26
*** ralonsoh has joined #openstack-sdks07:31
*** yolanda has quit IRC07:32
*** jpena|off is now known as jpena08:10
*** sshnaidm|afk is now known as sshnaidm08:12
*** gtema has joined #openstack-sdks08:28
*** tosky has joined #openstack-sdks08:46
*** jpena is now known as jpena|off09:00
*** jpich has joined #openstack-sdks09:12
*** dtantsur|afk is now known as dtantsur09:29
*** gtema has quit IRC10:39
*** gtema has joined #openstack-sdks10:39
openstackgerritShilpa Devharakar proposed openstack/openstacksdk master: Added new filter `host_name` to segment list  https://review.opendev.org/70481411:58
*** gtema_ has joined #openstack-sdks12:07
*** gtema has quit IRC12:10
*** jpich has quit IRC12:27
*** jpich has joined #openstack-sdks12:28
*** iokiwi2 has joined #openstack-sdks12:30
*** iokiwi has quit IRC12:30
*** iokiwi2 is now known as iokiwi12:30
odyssey4mehey folks - what do we think is the best way to resolve https://github.com/ansible/ansible/issues/64495 / https://github.com/ansible/ansible/issues/64841 / https://bugs.launchpad.net/tripleo/+bug/186081012:37
openstackLaunchpad bug 1860810 in tripleo "os_ansible_tempest fails w/ create_network() got an unexpected keyword argument 'dns_domain'" [High,Triaged]12:37
odyssey4messhnaidm: ^ any thoughts?12:40
sshnaidmodyssey4me, seems like need to bump openstacksdk version?12:42
odyssey4messhnaidm: sure, I'm pushing up a patch to do that, but changing upper-constraints in openstack for a break in ansible/openstacksdk seems a bit odd12:43
openstackgerritMichał Dulko proposed openstack/openstacksdk master: Fix error handling on add/remove router iface calls  https://review.opendev.org/70499812:43
sshnaidmodyssey4me, yeah, need to look how we can protect..12:44
odyssey4meIt looks to me like the module code just takes the lead from openstacksdk, unless I'm misreading it or missing something... so it seems odd that suddenly the module behaviour changes with the same version of openstacksdk being used.12:44
sshnaidmodyssey4me, from my brief look seems like openstacksdk version is not compatible with openstack api, and os_network just pass everything as is12:47
odyssey4messhnaidm: so you're thinking that the sdk is passing something to the API and the API is the one returning the fail?12:48
sshnaidmodyssey4me, hmm.. or not: https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/openstack/os_network.py#L229-L23712:50
sshnaidmodyssey4me, so that sdk doesn't have this option12:50
odyssey4messhnaidm: yes, that makes more sense12:51
sshnaidmhttps://github.com/ansible/ansible/commit/6c74e29618a6872bc0da66e4992cfcd9cebf6acc12:51
sshnaidmit was something new ^12:52
odyssey4meyeah, and with that the sdk minimum version should have been updated12:52
odyssey4meodd, though is that we're getting this error from ansible2.812:52
odyssey4melemme see if I can find abackport12:52
odyssey4meno, this has not been ported back12:53
odyssey4meok - so that means that whatever we're getting that back from is actually running ansible 2.9 - not 2.812:54
odyssey4meI'll push a patch up to ansible to update the minimum SDK version... thanks for the help!12:54
sshnaidmall version: devel (#56453)   v2.9.4 v2.9.3 v2.9.2 v2.9.1 v2.9.0 v2.9.0rc5 v2.9.0rc4 v2.9.0rc3 v2.9.0rc2 v2.9.0rc1 v2.9.0b1 stable-2.9-branchpoint12:54
sshnaidmit's good point to think how can we avoid such failures, maybe all new sdk features should come with version check12:55
sshnaidmwhen they're used in ansible module12:55
*** goldyfruit_ has joined #openstack-sdks12:59
*** enriquetaso has joined #openstack-sdks13:27
odyssey4messhnaidm: ok, fixes to upstream modules are frozen, right? so I should submit this fix to the collection and directly to stable-2.9?13:29
sshnaidmodyssey4me, well, it could be a problem.. I think we set ci job for modules to fail, so not sure we can merge even to 2.9..13:32
sshnaidmodyssey4me, maybe we need to enabled it for 2.913:33
sshnaidmodyssey4me, what could be a fix? The revert?13:33
odyssey4messhnaidm: let me push up patches to ansible and into tyhe collection, then we figure out how to get the fix merged in all the places :)13:36
sshnaidmodyssey4me, ack, thanks13:37
odyssey4messhnaidm: https://github.com/ansible/ansible/pull/66944 pushed upstream, let me know if you find any other places where the openstacksdk is set13:47
odyssey4meI'm hoping that all the docs key off that, but I couldn't find a doc ref.13:47
sshnaidmodyssey4me, that will fail module if using lower openstacksdk version, right?13:50
odyssey4messhnaidm: yep13:51
odyssey4messhnaidm: I suppose an alternative approach would be, in the os_network module, to warn that a newer openstacksdk is required if the current version does not meet the minimum to support that parameter13:52
sshnaidmodyssey4me, I wonder if we can check sdk version and use or not to use dns_* parameter13:52
odyssey4methat's probably nicer than an outright fail13:52
sshnaidmI mean to fail only if this parameter set explicitly13:54
odyssey4meyeah, that'd be a much nicer approach13:54
odyssey4meok, let me see if I can work that out13:55
odyssey4mehmm, another option is to only fail it for os_network13:58
odyssey4messhnaidm: do you know where the openstack documentation fragment comes from - I see references to it, but can't find 'it'14:04
odyssey4messhnaidm: never mind: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#documentation-fragments14:05
*** sshnaidm is now known as sshnaidm|afk14:07
*** dtantsur is now known as dtantsur|brb14:18
*** sshnaidm|afk is now known as sshnaidm14:32
*** jawad_axd has quit IRC14:50
*** jawad_axd has joined #openstack-sdks14:50
*** jawad_ax_ has joined #openstack-sdks14:54
*** jawad_a__ has joined #openstack-sdks14:55
*** jawad_axd has quit IRC14:55
*** ricolin has joined #openstack-sdks14:58
*** jawad_ax_ has quit IRC14:58
*** gtema_ has quit IRC14:59
*** jawad_a__ has quit IRC15:00
openstackgerritPedro Henrique Pereira Martins proposed openstack/openstacksdk master: Add description field to portforwarding NAT rules  https://review.opendev.org/70503815:02
*** gtema has joined #openstack-sdks15:41
*** ricolin has quit IRC15:45
*** camelCaser has quit IRC15:49
*** camelCaser has joined #openstack-sdks15:53
*** gtema_ has joined #openstack-sdks15:58
sshnaidmwho is available for openstack ansible modules meeting?16:00
elmikoAPI SIG office hour now open16:00
sshnaidmI know I had to create a doodle about a new time, my bad16:01
sshnaidmwill do this today..16:01
*** gtema has quit IRC16:01
sshnaidm#startmeeting api-sig16:01
openstackMeeting started Thu Jan 30 16:01:53 2020 UTC and is due to finish in 60 minutes.  The chair is sshnaidm. Information about MeetBot at http://wiki.debian.org/MeetBot.16:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:01
*** openstack changes topic to " (Meeting topic: api-sig)"16:01
openstackThe meeting name has been set to 'api_sig'16:01
sshnaidmanybody here to talk16:02
sshnaidmto complain16:02
elmikolol16:04
sshnaidmto tell success stories16:04
sshnaidmmordred, can we be in touch next week for collection pushing?16:05
sshnaidmwe need your superpower for submitting a collection to galaxy16:05
*** dtantsur|brb is now known as dtantsur16:06
sshnaidmok, seems like the business is as usual16:07
sshnaidmplease do reviews in your time: https://review.opendev.org/#/q/project:openstack/ansible-collections-openstack16:08
sshnaidm#endmeeting16:08
*** openstack changes topic to "Bug tracker for SDK and OSC is now at https://storyboard.openstack.org"16:08
openstackMeeting ended Thu Jan 30 16:08:18 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:08
openstackMinutes:        http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-30-16.01.html16:08
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-30-16.01.txt16:08
openstackLog:            http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-30-16.01.log.html16:08
odyssey4meheh, wow - that went quickly :p16:12
odyssey4messhnaidm: we don't have documentation fragments in the collection, do we? how do I submit something for the change log16:13
sshnaidmodyssey4me, we should have16:13
sshnaidmthis one? ./plugins/doc_fragments/openstack.py16:14
odyssey4messhnaidm: right, but I need at add a changelog fragment for the bug fix - should I just make a directory called changelogs/fragments ?16:15
sshnaidmodyssey4me, I think it contains all changelogs, not only for openstack?16:16
sshnaidmodyssey4me, well, we don't have policy to make changelogs right now, so not must I think16:17
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain  https://review.opendev.org/70505416:18
odyssey4messhnaidm: well, there we go - let's figure it out in review :)16:18
*** gtema_ has quit IRC16:20
*** gtema has joined #openstack-sdks16:21
sshnaidmodyssey4me, cool, thanks16:22
sshnaidmodyssey4me, I wonder if we can use it asap..16:22
odyssey4messhnaidm: I did a brief test locally and it worked for me (adding the dns_domain arg made it fail with the older sdk)16:22
sshnaidmodyssey4me, great16:23
*** jawad_axd has joined #openstack-sdks16:23
*** jawad_axd has quit IRC16:27
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain  https://review.opendev.org/70505416:31
odyssey4messhnaidm: nice to see tests/unit/modules/cloud/openstack/test_os_server.py there - I was thinking that we should do unit testing... so assuming that works, it'd be nice to expand on those16:38
sshnaidmodyssey4me, actually I don't think we execute them currently :) but it's good to have it, yes16:40
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain  https://review.opendev.org/70505416:41
*** jawad_axd has joined #openstack-sdks16:43
*** gtema_ has joined #openstack-sdks16:48
*** jawad_axd has quit IRC16:48
*** gtema has quit IRC16:50
*** jawad_axd has joined #openstack-sdks17:04
*** factor has quit IRC17:08
*** jawad_axd has quit IRC17:08
*** gtema_ has quit IRC17:09
*** gtema has joined #openstack-sdks17:10
*** gtema has quit IRC17:24
*** jawad_axd has joined #openstack-sdks17:25
*** jawad_axd has quit IRC17:29
*** evrardjp has joined #openstack-sdks17:33
openstackgerritMichał Dulko proposed openstack/openstacksdk master: Fix error handling in network trunks operations  https://review.opendev.org/70507317:38
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/ansible-collections-openstack master: Bump minimum openstacksdk version when using os_network/dns_domain  https://review.opendev.org/70505417:40
*** jawad_axd has joined #openstack-sdks17:45
*** jawad_axd has quit IRC17:50
*** jpich has quit IRC17:52
*** dtantsur is now known as dtantsur|afk17:52
*** jawad_axd has joined #openstack-sdks18:06
*** ralonsoh has quit IRC18:11
*** jawad_axd has quit IRC18:11
*** sshnaidm is now known as sshnaidm|afk18:20
*** jawad_axd has joined #openstack-sdks18:27
*** jawad_axd has quit IRC18:31
*** jawad_axd has joined #openstack-sdks18:47
*** jawad_axd has quit IRC18:52
*** sshnaidm|afk is now known as sshnaidm|off18:53
*** gtema has joined #openstack-sdks19:10
*** gtema has quit IRC19:11
*** jawad_axd has joined #openstack-sdks20:31
*** jawad_axd has quit IRC20:35
*** jawad_axd has joined #openstack-sdks20:51
*** jawad_axd has quit IRC20:56
*** jawad_axd has joined #openstack-sdks21:12
*** jawad_axd has quit IRC21:16
*** jawad_axd has joined #openstack-sdks21:32
*** enriquetaso has quit IRC21:33
*** jawad_axd has quit IRC21:37
*** slaweq has quit IRC21:43
*** slaweq has joined #openstack-sdks21:45
*** jawad_axd has joined #openstack-sdks21:53
*** slaweq has quit IRC21:55
*** jawad_axd has quit IRC21:57
*** jawad_axd has joined #openstack-sdks22:21
*** efried has quit IRC22:24
*** jawad_axd has quit IRC22:25
*** efried has joined #openstack-sdks22:25
*** jawad_axd has joined #openstack-sdks22:42
*** jawad_axd has quit IRC22:47
*** jawad_axd has joined #openstack-sdks23:23
*** jawad_axd has quit IRC23:28
*** jawad_axd has joined #openstack-sdks23:44
*** jawad_axd has quit IRC23:52
« Wednesday, 2020-01-29 Index Friday, 2020-01-31 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!