| *** slaweq has joined #openstack-sdks | 00:10 | |
| *** slaweq has quit IRC | 00:15 | |
| *** jistr has quit IRC | 00:45 | |
| *** jistr has joined #openstack-sdks | 00:48 | |
| *** slaweq has joined #openstack-sdks | 01:22 | |
| *** slaweq has quit IRC | 01:27 | |
| *** camelCaser has quit IRC | 02:33 | |
| *** camelCaser has joined #openstack-sdks | 02:33 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-sdks | 05:34 | |
| *** Luzi has joined #openstack-sdks | 06:35 | |
| *** jawad-axd has joined #openstack-sdks | 07:02 | |
| *** jawad-axd has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-sdks | 07:07 | |
| *** jawad-axd has joined #openstack-sdks | 07:07 | |
| *** jawad-ax_ has joined #openstack-sdks | 07:10 | |
| *** jawad-axd has quit IRC | 07:12 | |
| *** slaweq has quit IRC | 07:12 | |
| *** slaweq has joined #openstack-sdks | 07:16 | |
| *** ralonsoh has joined #openstack-sdks | 07:29 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 08:22 |
|---|---|---|
| *** gtema has joined #openstack-sdks | 08:22 | |
| *** tosky has joined #openstack-sdks | 08:22 | |
| *** gtema has quit IRC | 08:26 | |
| *** jangutter has joined #openstack-sdks | 08:33 | |
| *** jpena|off is now known as jpena | 08:47 | |
| *** gtema has joined #openstack-sdks | 09:01 | |
| *** gtema has quit IRC | 09:02 | |
| *** jpich has joined #openstack-sdks | 09:06 | |
| *** gtema has joined #openstack-sdks | 09:08 | |
| openstackgerrit | Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325 | 09:56 |
| *** jawad-ax_ has quit IRC | 10:07 | |
| *** gtema has quit IRC | 10:20 | |
| *** jpich has quit IRC | 10:24 | |
| *** jpich has joined #openstack-sdks | 10:25 | |
| *** dtantsur|afk is now known as dtantsur | 10:32 | |
| *** jawad-axd has joined #openstack-sdks | 10:49 | |
| *** gtema has joined #openstack-sdks | 10:52 | |
| gundalow | sshnaidm: Hi, I'm back now :) | 10:52 |
| *** jawad-axd has quit IRC | 10:53 | |
| *** gtema has quit IRC | 11:04 | |
| sshnaidm | gundalow, welcome back! | 11:05 |
| sshnaidm | gundalow, will you be available this week for helping with ansible bits of moving OS modules? | 11:10 |
| gundalow | Sure, is there a doc where we are listing the steps? | 11:11 |
| sshnaidm | gundalow, I think we can use our etherpad for that: https://etherpad.openstack.org/p/openstack-ansible-modules | 11:14 |
| *** jawad-axd has joined #openstack-sdks | 11:14 | |
| *** gtema has joined #openstack-sdks | 11:19 | |
| gundalow | sshnaidm: perfect, thank you. Could you remind me if we decided on 1) namespace 2) Collection name 3) Host repo | 11:21 |
| sshnaidm | gundalow, updated in etherpad | 11:28 |
| sshnaidm | bbl | 11:38 |
| *** jpich has quit IRC | 11:40 | |
| *** jpich has joined #openstack-sdks | 11:43 | |
| *** gtema has quit IRC | 12:17 | |
| *** gtema has joined #openstack-sdks | 12:18 | |
| *** enriquetaso has joined #openstack-sdks | 12:21 | |
| *** jpena is now known as jpena|lunch | 12:23 | |
| *** gtema has quit IRC | 12:23 | |
| *** gtema has joined #openstack-sdks | 12:31 | |
| sshnaidm | gundalow, I'd like to send a mail to Ansible devs/cores to ask them not to merge patches to OS modules w/o exceptional ack from specific OS cores. Where can I send it to? | 12:43 |
| sshnaidm | gundalow, because we want to freeze them in current state now | 12:44 |
| *** adriant has quit IRC | 12:48 | |
| *** adriant has joined #openstack-sdks | 12:49 | |
| *** gtema has quit IRC | 13:08 | |
| *** jpena|lunch is now known as jpena | 13:22 | |
| *** gtema has joined #openstack-sdks | 13:30 | |
| *** KeithMnemonic has joined #openstack-sdks | 13:59 | |
| *** Luzi has quit IRC | 14:12 | |
| gundalow | hum, Ansibulbot will also automerge. I wonder if we can somehow make the PRs fail CI | 14:53 |
| *** jawad-axd has quit IRC | 15:27 | |
| *** dave-mccowan has joined #openstack-sdks | 15:47 | |
| sshnaidm | gundalow, I think we can, need just to configure openstack job to fail always, but also I'd like to make people aware about it | 15:51 |
| sshnaidm | gundalow, do you have kind of "ansible-dev" list..? | 15:51 |
| *** dave-mccowan has quit IRC | 15:52 | |
| KeithMnemonic | am i reading this failure correctly, that it also due to the thread on openstack-discuss about setuptools and python2? https://zuul.opendev.org/t/openstack/build/372bc8c66d794210aeb571491ed6e893 | 16:05 |
| dtantsur | KeithMnemonic: everything is broken, yes. the infra team is about to work it around though. | 16:25 |
| KeithMnemonic | thanks! | 16:28 |
| mordred | should be fixed now | 16:34 |
| KeithMnemonic | thanks mordred. Does anyone have any objections for me starting the cherry-pick to stein on this change while I am waiting for a WF+1? ? https://review.opendev.org/701299. That way i can start seeing if there are other issues on stable/stein. | 16:45 |
| KeithMnemonic | or would you prefer i wait until it merges | 16:45 |
| mordred | KeithMnemonic: go for it! stein has been a little shaky recently, so might as well go ahead and make sure things work | 16:48 |
| KeithMnemonic | thanks morded | 16:49 |
| KeithMnemonic | argh mordred: :-) | 16:50 |
| mordred | :) | 16:54 |
| *** icarusfactor has quit IRC | 16:55 | |
| dtantsur | note that if you press the cherry-pick button now, the patch will be missing the required "cherry picked from" line | 16:55 |
| KeithMnemonic | got it thanks, there is a merge conflict so i need to do it by hand anyway | 16:55 |
| *** jpich has quit IRC | 17:02 | |
| *** yolanda has quit IRC | 17:15 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add unit tests and release note for dns_publish_fixed_ip https://review.opendev.org/702266 | 17:24 |
| *** gtema_ has joined #openstack-sdks | 17:26 | |
| *** gtema has quit IRC | 17:30 | |
| *** jawad-axd has joined #openstack-sdks | 17:33 | |
| *** evrardjp has quit IRC | 17:33 | |
| *** evrardjp has joined #openstack-sdks | 17:34 | |
| *** dtantsur is now known as dtantsur|afk | 17:53 | |
| *** gtema_ has quit IRC | 18:02 | |
| *** jawad-axd has quit IRC | 18:04 | |
| *** jpena is now known as jpena|off | 18:06 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Raise hacking to more recent 2.0.0 https://review.opendev.org/702019 | 18:24 |
| openstackgerrit | Merged openstack/python-openstackclient master: Raise flake8-import-order version to latest https://review.opendev.org/702036 | 18:24 |
| *** gtema has joined #openstack-sdks | 18:36 | |
| *** gtema has quit IRC | 18:41 | |
| *** jawad-axd has joined #openstack-sdks | 18:45 | |
| *** gtema has joined #openstack-sdks | 18:51 | |
| *** jawad-axd has quit IRC | 19:00 | |
| efried | johnsom: Before I go digging, can you remind me where we are on the osc-lib business that was holding up https://review.opendev.org/#/c/692931/ ? | 19:03 |
| efried | looks like https://review.opendev.org/#/c/693267/ is still open. | 19:04 |
| johnsom | efried This is stuck: https://review.opendev.org/#/c/662864/ | 19:04 |
| johnsom | On this: https://review.opendev.org/#/c/693267 | 19:04 |
| efried | johnsom: is it just that we need the latter approved before the former can pick it up properly? | 19:05 |
| efried | approved/released/constrainted/etc? | 19:05 |
| johnsom | I think so, but it has been a long time, so the details are fuzzy | 19:05 |
| *** gtema has quit IRC | 19:07 | |
| efried | johnsom: Can we swap back in? Cause off the top I'm not sure I understand how https://review.opendev.org/#/c/662864/ needing https://review.opendev.org/#/c/693267 should hold up https://review.opendev.org/#/c/692931/ | 19:10 |
| johnsom | efried Yeah, the whole issue was the addition of "enhanced_help" you did. It broke other pending patches and is a bit of an oddity. So, the discussion was if we revert the "enhanced_help" change or if we move forward with it and add it to osc-lib. | 19:14 |
| efried | johnsom: but how does that relate to autogenerating docs for identity? | 19:14 |
| johnsom | efried if we reverted, this https://review.opendev.org/#/c/692931/ should not merge either | 19:14 |
| johnsom | efried that patch drops the versioning callout on the --tag options | 19:16 |
| efried | tbc, ...31 doesn't do anything with enhance_help. If we revert that, we would have to revert down that (already merged) series as well. | 19:16 |
| johnsom | Yep | 19:16 |
| efried | if my delta makes the versioning of --tags wrong, that's its own issue. | 19:16 |
| johnsom | It was a pretty nasty mess as I remember | 19:16 |
| efried | johnsom: I'm rechecking to get a new docs build to be sure, but looking at the code, it should be the case that we're only adding the docs for --tags to the v3 doc. | 19:19 |
| johnsom | It looks like Dean was ok with moving forward with the "enhanced_help" path, but it looks like the cores never confirmed that | 19:19 |
| efried | which is what we want to do. | 19:19 |
| efried | johnsom: "the cores" would be... Dean. | 19:19 |
| johnsom | lol, well | 19:19 |
| efried | I think dtroyer was waiting for you to confirm that that solution would work for you. | 19:20 |
| efried | before +2ing | 19:20 |
| johnsom | There are five folks on the list, but yeah, I understand this area is lacking at the moment | 19:20 |
| efried | I actually can't tell who's core in osc-lib | 19:21 |
| efried | is it python-openstackclient-core? | 19:21 |
| johnsom | yes | 19:21 |
| efried | in which case we really only have three: mordred, dtroyer, amotoki | 19:21 |
| efried | Matt is gone, and Doug hasn't been active there for a while. | 19:21 |
| johnsom | So maybe Dean is around and we can just get that osc-lib change rolling | 19:22 |
| efried | johnsom: so let me propose this: If the docs build confirms that --tags only show up in the v3 docs and not in the v2 docs, will you unblock the identity patch? Then we can decide whether to revert the enhance_help business -- in which case we'll need to do *something* else to fix that whole stack -- or approve the osc-lib patch, whereupon https://review.opendev.org/#/c/662864/ can be vetted to make sure it subsumes identity etc. | 19:23 |
| johnsom | I would really like to see a path forward on the centralized tags code before we merge another patch that changes the way we document / handle tags. | 19:24 |
| efried | I get that, but my point is that that ship has already sailed | 19:25 |
| johnsom | That change was pretty big breakage on an already half merged migration | 19:25 |
| efried | For that I apologize; I didn't know that change was in flight, and I was on a (totally unrelated) mission. | 19:25 |
| efried | that said, this kind of conflict is pretty standard fare for this kind of development | 19:26 |
| johnsom | Yeah, I get it. | 19:26 |
| openstackgerrit | Merged openstack/python-openstackclient master: Add dns_publish_fixed_ip attribute to subnets https://review.opendev.org/679834 | 19:27 |
| openstackgerrit | Merged openstack/python-openstackclient master: Remove redundant OpenStackShell.prepare_to_run_command https://review.opendev.org/691865 | 19:27 |
| johnsom | This is the tie-in with the identity stuff BTW: https://review.opendev.org/#/c/691767/4/openstackclient/identity/common.py | 19:31 |
| efried | got it | 19:32 |
| efried | mordred: you willing to be the second core on this? | 19:35 |
| efried | where "this" is: enhancing osc-lib's handling of --tag options to accept a callable so it can be decorated as pertaining to only a specific version of the API? | 19:36 |
| efried | johnsom: actually, wouldn't it only matter if add_project_domain_option_to_parser had *also* been added to osc-lib? (afaict it wasn't) | 19:39 |
| efried | And that guy is using enhance_help to decorate the help as pertaining only to neutron (as opposed to a particular version) | 19:41 |
| johnsom | Wasn't this all because you didn't want to fix the code structure to deal with the mixed neutron/nova commands? | 19:42 |
| efried | that's where it started, yes. | 19:43 |
| johnsom | The new docs system can't handle the current method and some projects were using static pages. | 19:43 |
| johnsom | Right. | 19:43 |
| efried | where "fix the code structure" would have entailed splitting neutron and nova-network classes into 100% separate packages, like what we see for identity | 19:44 |
| *** sshnaidm is now known as sshnaidm|bbl | 19:45 | |
| efried | doing all of this -- enhance_help in python-openstackclient and osc-lib and reworking your change -- is still an order of magnitude less effort than that would be. | 19:46 |
| efried | Arguably "the right thing", but... 80/20 rule. | 19:46 |
| johnsom | Yeah, and I agreed that I can live with that, we just need to commit to it or revert IMO | 19:47 |
| efried | that's fine, but I still don't agree that that should hold up https://review.opendev.org/#/c/692931/ (and its successor) which have nothing to do with enhance_help | 19:49 |
| efried | But that's your prerogative. So let's just push on dtroyer mordred amotoki to merge https://review.opendev.org/#/c/693267/ so we can move forward. | 19:50 |
| johnsom | Well, once the docs re-render maybe we can look at the changes and issues that related them. I think that if we revert, we will want to stick with the static pages until a new path forward is found | 19:50 |
| efried | The identity patch wouldn't be affected by that, though. | 19:52 |
| efried | the fact that there's an enhance_help in an identity lib is coincidental; it's only used by networking. | 19:52 |
| efried | that method is called in a hundred other places, but the enhance_help kwarg is only used from networking | 19:52 |
| efried | so whichever approach we choose, the identity docs split/autogen patch wouldn't be different. | 19:52 |
| * dtroyer starts catching up after lunch… | 20:02 | |
| efried | dtroyer: tl;dr: | 20:04 |
| efried | You +2ed the glance doc autogen patch https://review.opendev.org/#/c/693025/ and wondered why it hadn't been approved earlier | 20:04 |
| efried | I mentioned its predecessor https://review.opendev.org/#/c/692931/ was held up | 20:04 |
| efried | So I was discussing with johnsom whether that holdup was valid | 20:04 |
| efried | But whether it is or not, we would like to move the osc-lib enhance_help patch https://review.opendev.org/#/c/693267/ along | 20:04 |
| dtroyer | efried: right, I figured that was the case (after I looked at them in the wrong order). I'm getting to going ahead with merging 693267, but having to do something like this is a clue that maybe we should just copy that code instead now. DRY is good, until it isn't, and OSC has taught me that sometimes the duplication is work it in the end… thoughts to inform the future, I think we're going to finish this path at least for now | 20:09 |
| efried | dtroyer: ack, and thanks. | 20:11 |
| efried | to be clear, which piece would duplication have been better for in this scenario? | 20:11 |
| dtroyer | with the changes to help, I would have re-thought moving the tags stuff to osc-lib in the first place. In this case though that is being done to make it available to plugins… there is a school of thought that it is the plugins that should be eliminated so that would be an alternative someday | 20:14 |
| dtroyer | I just +W https://review.opendev.org/#/c/693267/, we'll need to do an osc-lib release so OSC can pick that up. | 20:16 |
| efried | gotcha. Thanks. johnsom ^ | 20:17 |
| *** ralonsoh has quit IRC | 20:34 | |
| johnsom | Sorry, had a meeting, catching up | 20:35 |
| johnsom | dtroyer Yeah, I think in the case of tags, it's a good thing that, plugins or not, we are using common code for tags. This is an area that is easy to start diverging in the commands.... This was part of why I proposed moving it into osc-lib and volunteered to do the work. | 20:37 |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add unit tests and release note for dns_publish_fixed_ip https://review.opendev.org/702266 | 21:10 |
| *** enriquetaso has quit IRC | 21:17 | |
| KeithMnemonic | smcginnis: it passed! first hurdle done | 21:26 |
| smcginnis | Finally! | 21:26 |
| openstackgerrit | Merged openstack/osc-lib master: Add enhance_help kwarg to tags option generators https://review.opendev.org/693267 | 21:55 |
| *** sshnaidm|bbl is now known as sshnaidm | 22:02 | |
| *** slaweq has quit IRC | 22:12 | |
| efried | smcginnis: Did we decide the first release after dropping py2 needs to be a 'major'? | 22:17 |
| efried | johnsom, dtroyer: https://review.opendev.org/702302 <== osc-lib 2.0.0 release (smcginnis assumed ^ yes) | 22:21 |
| johnsom | Yes, dropping py2 is a major bump | 22:22 |
| smcginnis | efried: Sorry - correct, that's considered a backwards incompatible change and needs the major version bump. | 22:23 |
| efried | cool, thanks. | 22:23 |
| *** camelCaser has quit IRC | 22:24 | |
| johnsom | There should have been a release note for the py2 drop as well, but it doesn't look like that happened | 22:24 |
| *** camelCaser has joined #openstack-sdks | 22:27 | |
| efried | johnsom: Doesn't need to be a separate release. I incorporated it in the same patch. smcginnis: is there any reason the first release after dropping py2 needs to be immediately after that patch? | 22:28 |
| efried | johnsom: in other news, the new build for https://review.opendev.org/#/c/692931/ is available. I linked to the 'project' subcommand pages, please confirm whether the presence/absence of --tag is appropriate there. | 22:29 |
| smcginnis | efried: You mean if it should be released right away after making the changes in the cycle goal versus waiting for a bit and picking up some other changes? | 22:30 |
| efried | smcginnis: yes, that's what I mean. | 22:30 |
| smcginnis | No, no real reason to have to do it right away. | 22:30 |
| smcginnis | Of course the sooner it's out there, the sooner others will pick it up and find out if there are any issues, but no reason that has to happen immediately. | 22:30 |
| efried | Or rather, in this case, given that other changes are already available, should I force an artificial major release in between so I can immediately push a 2.1.0 for the subsequent feature? | 22:30 |
| efried | ack, so I think we're good here. | 22:31 |
| johnsom | Yeah, release often is good actually. | 22:31 |
| openstackgerrit | Merged openstack/python-openstackclient master: Create Volume v3 functional tests https://review.opendev.org/695044 | 22:31 |
| smcginnis | Yeah, it's fine if there are other feature additions along with the py2 drop. | 22:31 |
| efried | cool | 22:31 |
| smcginnis | The major bump is just a signal to downstream consumers of "hey, might want to check what changed here before you upgrade to this one" ;) | 22:31 |
| johnsom | I was just mentioning (not earth shattering) that there is no release note with the "Drop python 2.7 support and testing " patch in 2.0.0. | 22:32 |
| smcginnis | That really should be included. | 22:32 |
| efried | mm. We could add a patch for that and include it in the release... | 22:32 |
| smcginnis | We can hold that release and quick get a release note added. | 22:32 |
| smcginnis | Jinx | 22:32 |
| openstackgerrit | Eric Fried proposed openstack/osc-lib master: Add a release note for dropping py2 https://review.opendev.org/702305 | 22:35 |
| efried | dtroyer, smcginnis, johnsom: ^ | 22:35 |
| johnsom | efried You are working on too many things... grin Commented | 22:35 |
| efried | johnsom: just trying to flush some stuff off my stack. | 22:36 |
| openstackgerrit | Michael Johnson proposed openstack/osc-lib master: Add a release note for dropping py2 https://review.opendev.org/702305 | 22:37 |
| efried | what did I miss? | 22:38 |
| johnsom | You said "nova" instead of "osc-lib" | 22:38 |
| efried | hah, whoops | 22:38 |
| efried | thanks, blind copy/paste | 22:38 |
| efried | dtroyer: ^ fast one if you please | 22:39 |
| openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Copy Volume v2 commands and unit tests to v3 https://review.opendev.org/695069 | 22:47 |
| *** tosky has quit IRC | 23:06 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!