| *** ricolin_ has joined #openstack-sdks | 01:50 | |
| *** ricolin_ has quit IRC | 03:18 | |
| *** ricolin has joined #openstack-sdks | 03:19 | |
| *** factor has quit IRC | 05:08 | |
| *** factor has joined #openstack-sdks | 05:08 | |
| *** goldyfruit has quit IRC | 05:30 | |
| *** goldyfruit has joined #openstack-sdks | 05:30 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-sdks | 05:34 | |
| *** jawad_axd has joined #openstack-sdks | 07:12 | |
| *** slaweq has joined #openstack-sdks | 07:18 | |
| *** gtema has joined #openstack-sdks | 07:50 | |
| *** tosky has joined #openstack-sdks | 08:12 | |
| *** factor has quit IRC | 08:50 | |
| *** factor has joined #openstack-sdks | 08:51 | |
| *** jpena|off is now known as jpena | 08:54 | |
| *** ralonsoh has joined #openstack-sdks | 08:56 | |
| *** jpich has joined #openstack-sdks | 09:02 | |
| *** dtantsur|afk is now known as dtantsur | 10:05 | |
| *** gtema_ has joined #openstack-sdks | 10:43 | |
| *** gtema has quit IRC | 10:46 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | 11:17 |
|---|---|---|
| *** sshnaidm is now known as sshnaidm|off | 11:52 | |
| *** jpena is now known as jpena|lunch | 12:01 | |
| *** enriquetaso has joined #openstack-sdks | 12:04 | |
| *** enriquetaso has quit IRC | 12:05 | |
| frickler | mordred: dtroyer: can the osc4 feature branch be dropped? we do have v4 in master now, don't we? | 12:31 |
| *** gtema has joined #openstack-sdks | 12:33 | |
| *** enriquetaso has joined #openstack-sdks | 12:33 | |
| *** gtema_ has quit IRC | 12:35 | |
| *** mgariepy has joined #openstack-sdks | 12:41 | |
| *** jpich has quit IRC | 12:41 | |
| *** jpich has joined #openstack-sdks | 12:41 | |
| *** jpena|lunch is now known as jpena | 12:57 | |
| *** gtema has quit IRC | 13:05 | |
| *** goldyfruit has quit IRC | 13:05 | |
| *** goldyfruit has joined #openstack-sdks | 13:06 | |
| *** gtema has joined #openstack-sdks | 13:38 | |
| *** umbSublime has quit IRC | 13:45 | |
| *** dtantsur is now known as dtantsur|brb | 14:27 | |
| *** jawad_axd has quit IRC | 14:36 | |
| *** jawad_axd has joined #openstack-sdks | 14:37 | |
| *** jawad_axd has quit IRC | 14:37 | |
| *** jawad_axd has joined #openstack-sdks | 14:41 | |
| *** jawad_axd has quit IRC | 14:45 | |
| *** dave-mccowan has joined #openstack-sdks | 15:07 | |
| dtroyer | frickler: yes it can | 15:14 |
| *** vkmc has joined #openstack-sdks | 15:26 | |
| vkmc | hey all o/ | 15:40 |
| vkmc | we are working on implementing the plugin for osc for manila | 15:40 |
| vkmc | wondering if there are guidelines for creating documentation for it | 15:40 |
| vkmc | I've seen that the osc client has their own docs, which each of the commands that it's implemented | 15:40 |
| mordred | vkmc: if it's a new plugin, it would be *awesome* if we could base it on openstacksdk and get the manila support in sdk solid - for docs, that's a good question ... dtroyer? | 15:45 |
| *** jpena is now known as jpena|brb | 15:45 | |
| vkmc | mordred, yes, brand new plugin | 15:45 |
| *** maaritamm has joined #openstack-sdks | 15:48 | |
| vkmc | maaritamm, o/ | 15:49 |
| vkmc | mordred, dtroyer, so maaritamm (outreachy intern) is the main lead on the manila plugin development | 15:50 |
| vkmc | we want to make sure we comply to any existing process that the community might have wrt to creating user docs for the client | 15:50 |
| mordred | yay outreachy intern! hi maaritamm | 15:50 |
| maaritamm | o/ | 15:51 |
| maaritamm | hi to all :) | 15:51 |
| mordred | I'm honestly not sure what the osc plugin docs story is ... maybe dtroyer or dtantsur|brb knows? | 15:52 |
| mordred | or amotoki if he's around | 15:52 |
| dtroyer | I think the docs story has changed a bit recently, efried was doing a lot of work on autodoc at the end of last year, and I think that has affected the story for plugins, but I don't have that in my head at the moment | 15:53 |
| vkmc | when is is the weekly meeting for this team? maybe we can use some minutes to talk about this | 15:54 |
| vkmc | if that works for you | 15:54 |
| amotoki | I haven't caught up the recent change on autodoc in osc, but as long as neutronclient osc plugin I think the autogen of OSC plugin CLI still works | 15:55 |
| dtroyer | vkmc: We haven't had weekly meetings in quite some time | 15:56 |
| vkmc | oh ok | 15:56 |
| dtroyer | Pretty much everything happens here as needed | 15:56 |
| vkmc | ok :) | 15:56 |
| efried | vkmc: Plugin docs should live in the plugin. The python-openstackclient should be updated to pull them in via an autoprogram-cliff directive. Let me grab some links... | 15:57 |
| vkmc | efried++ | 15:57 |
| amotoki | vkmc: you can find an example OSC plugin document at https://opendev.org/openstack/python-neutronclient/src/branch/master/doc/source/cli/osc/v2 | 15:57 |
| amotoki | vkmc: all OSC plguin CLI document is generated automatically | 15:58 |
| vkmc | perfect... yes, I assumed there was something to automatize the generation of docs but I wasn't sure | 15:58 |
| vkmc | amotoki, thanks for the sample | 15:58 |
| *** jangutter has quit IRC | 15:59 | |
| amotoki | vkmc: I am going to bed soon. if you have questions, feel free to drop them in this channel. | 16:00 |
| vkmc | amotoki, will do, thanks again! | 16:00 |
| mordred | dtroyer: if you have a sec, there's a naming question in https://review.opendev.org/#/c/677857/ that we discussed, but it hasn't landed yet, so would love your ack on where we wound up | 16:03 |
| *** jpich has quit IRC | 16:07 | |
| *** jpich has joined #openstack-sdks | 16:08 | |
| *** jawad_axd has joined #openstack-sdks | 16:08 | |
| *** dtantsur|brb is now known as dtantsur | 16:08 | |
| dtantsur | vkmc: you can check what ironicclient is doing. currently we're hosting its docs as part of docs.o.o/python-ironicclient | 16:09 |
| dtantsur | like https://docs.openstack.org/python-ironicclient/latest/cli/osc_plugin_cli.html | 16:09 |
| *** jawad_axd has quit IRC | 16:13 | |
| vkmc | dtantsur, perfect, I'll take a look at those too | 16:13 |
| vkmc | thanks! | 16:13 |
| efried | vkmc: Okay, using octavia as an example: | 16:14 |
| efried | - Your plugin's setup.cfg needs to define entry_points for each subcommand in this spirit: https://opendev.org/openstack/python-octaviaclient/src/branch/master/setup.cfg#L24 | 16:14 |
| efried | ==> The left-hand side is the subcommand syntax, s/ /_/ | 16:14 |
| efried | ==> The right-hand side is the package:class that handles that. | 16:14 |
| efried | I think that's just standard fare for plugin-ness. But the important point is that the docs will be generated from the argparse helps defined in the classes' get_parser overrides. | 16:14 |
| efried | Then in python-openstackclient you need to: | 16:14 |
| efried | - Include your plugin in doc/requirements.txt, like: https://opendev.org/openstack/python-openstackclient/src/branch/master/doc/requirements.txt#L27 | 16:14 |
| efried | - Set up a page with a title and any desired preamble text (preferably keep that minimal) with an autoprogram-cliff directive that references your entry point, like: https://opendev.org/openstack/python-openstackclient/raw/branch/master/doc/source/cli/plugin-commands/octavia.rst | 16:14 |
| efried | - Don't forget to add your new page ^ to the index https://opendev.org/openstack/python-openstackclient/raw/branch/master/doc/source/cli/plugin-commands/index.rst | 16:14 |
| efried | I *think* that's it. | 16:14 |
| efried | What would be really neat is if you could scribble this process into a doc of its own and publish it in python-openstackclient for future contributors... | 16:14 |
| mordred | ++ | 16:16 |
| vkmc | efried, yep, we definitely need to add this | 16:16 |
| vkmc | I can do that | 16:16 |
| efried | thanks! | 16:16 |
| vkmc | thanks! | 16:16 |
| johnsom | vkmc You can also ping me if you have questions. I authored the docs setup for octaviaclient and ironicclient. | 16:17 |
| johnsom | Well, at least the auto generate bits | 16:18 |
| vkmc | johnsom, oh nice, that would be helpful... in case we get stuck with anything there | 16:20 |
| *** jpena|brb is now known as jpena | 16:22 | |
| efried | phew, thanks johnsom -- cause all I did was framework stuff, no real clue how the docs themselves work :P | 16:22 |
| *** jawad_axd has joined #openstack-sdks | 16:44 | |
| *** jawad_axd has quit IRC | 16:49 | |
| *** jpich has quit IRC | 17:12 | |
| *** jawad_axd has joined #openstack-sdks | 17:20 | |
| *** jawad_axd has quit IRC | 17:25 | |
| *** dtantsur is now known as dtantsur|afk | 17:30 | |
| *** evrardjp has quit IRC | 17:33 | |
| *** evrardjp has joined #openstack-sdks | 17:34 | |
| openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Raise hacking to more recent 2.0.0 https://review.opendev.org/702019 | 17:43 |
| openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | 17:58 |
| *** gtema has quit IRC | 17:58 | |
| *** gtema has joined #openstack-sdks | 17:59 | |
| smcginnis | mordred: Restored and updated your patch, but let me know if there were other conversations around that that I am not aware of. ^^ | 18:01 |
| *** gtema has quit IRC | 18:04 | |
| smcginnis | dtroyer: Note that dropping py2 support requires a major version bump, so not sure if there are any other major-version-bumping-worthy changes in the works that we might want to get in along with that cycle goal change before doing an official release. ^ | 18:06 |
| dtroyer | smcginnis: I don't have any waiting since we just did 4.0, there may be some that I have not seen yet. But that likely needs some work on the openstackclient repo to match, I think I saw some stuff going on about that earlier this week (sorry I wasn't able to actually follow along with that) | 18:08 |
| smcginnis | I'm not aware either. Really just a heads up in case we had anything we were waiting on for an opportune time. ;) | 18:09 |
| dtroyer | sure, thanks. I have a vague memory that mriedem did run across one or two small things, not sure where to find that now | 18:10 |
| smcginnis | We can see how many major versions we can get over the next cycle or two. | 18:11 |
| smcginnis | Oh, I totally missed https://review.opendev.org/#/c/695427/. Oh well, still a couple little things needed per the cycle goal instructions. | 18:13 |
| openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | 18:14 |
| openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | 18:17 |
| *** jpena is now known as jpena|off | 18:25 | |
| *** ralonsoh has quit IRC | 18:59 | |
| *** factor has quit IRC | 19:27 | |
| *** jawad_axd has joined #openstack-sdks | 20:15 | |
| *** jawad_axd has quit IRC | 20:20 | |
| openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Raise flake8-import-order version to latest https://review.opendev.org/702036 | 20:23 |
| *** jawad_axd has joined #openstack-sdks | 20:36 | |
| *** jawad_axd has quit IRC | 20:41 | |
| *** jawad_axd has joined #openstack-sdks | 20:57 | |
| *** enriquetaso has quit IRC | 20:58 | |
| *** jawad_axd has quit IRC | 21:01 | |
| KeithMnemonic | smcginnis: Thank you very much for helping get the stable openstackclient branches working. it is very appreciated | 21:36 |
| smcginnis | KeithMnemonic: No problem, thanks for getting a lot of that in place to start with. | 21:37 |
| smcginnis | Hopefully we can get those stable branches cleaned up and jobs working again. | 21:37 |
| smcginnis | Only a few outstanding patches, but most look like good fixes to get merged if we can. | 21:38 |
| KeithMnemonic | i agree , it will be a much less stressful when just having to debug the code in the fix itself and not other external issues | 21:39 |
| *** lastmikoi has quit IRC | 22:28 | |
| *** KeithMnemonic has quit IRC | 22:46 | |
| *** dave-mccowan has quit IRC | 22:48 | |
| *** lastmikoi has joined #openstack-sdks | 23:27 | |
| *** camelCaser has quit IRC | 23:52 | |
| *** camelCaser has joined #openstack-sdks | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!