| *** goldyfruit___ has joined #openstack-sdks | 00:14 | |
| *** goldyfruit___ has quit IRC | 00:18 | |
| *** slaweq has joined #openstack-sdks | 00:36 | |
| *** slaweq_ has joined #openstack-sdks | 00:42 | |
| *** slaweq has quit IRC | 00:43 | |
| *** slaweq_ is now known as slaweq | 00:49 | |
| *** ricolin has joined #openstack-sdks | 01:01 | |
| *** slaweq has quit IRC | 01:22 | |
| *** slaweq has joined #openstack-sdks | 01:23 | |
| *** dave-mccowan has joined #openstack-sdks | 02:03 | |
| *** dave-mccowan has quit IRC | 02:04 | |
| *** dave-mccowan has joined #openstack-sdks | 02:19 | |
| *** dave-mccowan has quit IRC | 03:01 | |
| *** nicholas has quit IRC | 03:27 | |
| *** jpena|off has quit IRC | 03:27 | |
| *** jpena|off has joined #openstack-sdks | 03:28 | |
| *** ricolin has quit IRC | 04:25 | |
| *** slaweq has quit IRC | 04:35 | |
| *** slaweq has joined #openstack-sdks | 05:01 | |
| *** slaweq has quit IRC | 05:32 | |
| *** slaweq has joined #openstack-sdks | 05:34 | |
| *** ricolin has joined #openstack-sdks | 06:36 | |
| *** noama has joined #openstack-sdks | 07:19 | |
| *** jawad_axd has joined #openstack-sdks | 07:28 | |
| *** gtema has joined #openstack-sdks | 07:30 | |
| *** ricolin has quit IRC | 07:37 | |
| *** ralonsoh has joined #openstack-sdks | 07:39 | |
| *** ricolin has joined #openstack-sdks | 07:39 | |
| *** ricolin_ has joined #openstack-sdks | 07:43 | |
| *** ricolin has quit IRC | 07:46 | |
| *** ricolin_ has quit IRC | 07:58 | |
| *** tosky has joined #openstack-sdks | 08:19 | |
| *** jpena|off is now known as jpena | 08:38 | |
| *** slaweq has quit IRC | 08:39 | |
| *** jpich has joined #openstack-sdks | 08:52 | |
| *** tosky_ has joined #openstack-sdks | 08:56 | |
| *** tosky is now known as Guest25059 | 08:59 | |
| *** tosky_ is now known as tosky | 08:59 | |
| *** Guest25059 has quit IRC | 08:59 | |
| *** gtema_ has joined #openstack-sdks | 09:23 | |
| *** dtantsur|afk is now known as dtantsur | 09:37 | |
| *** cdent has joined #openstack-sdks | 09:43 | |
| *** cdent has quit IRC | 09:49 | |
| *** cdent has joined #openstack-sdks | 11:01 | |
| *** gtema has quit IRC | 11:22 | |
| *** cdent has quit IRC | 11:24 | |
| *** gtema_ has quit IRC | 11:30 | |
| *** gtema has joined #openstack-sdks | 11:32 | |
| *** gtema has quit IRC | 11:37 | |
| *** jpena is now known as jpena|lunch | 12:08 | |
| *** jpich has quit IRC | 12:09 | |
| *** jpich has joined #openstack-sdks | 12:10 | |
| *** cdent has joined #openstack-sdks | 12:38 | |
| *** mriedem has joined #openstack-sdks | 12:39 | |
| *** cdent has quit IRC | 12:58 | |
| *** goldyfruit___ has joined #openstack-sdks | 13:03 | |
| *** jpich has quit IRC | 13:06 | |
| *** jpich has joined #openstack-sdks | 13:07 | |
| *** jpena|lunch is now known as jpena | 13:11 | |
| *** cdent has joined #openstack-sdks | 13:13 | |
| *** gtema has joined #openstack-sdks | 13:55 | |
| *** cdent has quit IRC | 13:56 | |
| *** dmellado has quit IRC | 14:01 | |
| *** gouthamr has quit IRC | 14:02 | |
| *** gouthamr has joined #openstack-sdks | 14:04 | |
| *** dmellado has joined #openstack-sdks | 14:06 | |
| *** jawad_axd has quit IRC | 14:47 | |
| *** cdent has joined #openstack-sdks | 14:50 | |
| *** jawad_axd has joined #openstack-sdks | 14:51 | |
| *** slaweq has joined #openstack-sdks | 14:52 | |
| *** jawad_axd has quit IRC | 14:56 | |
| *** slaweq has quit IRC | 15:08 | |
| *** jpena is now known as jpena|off | 15:37 | |
| elmiko | API SIG office hour is now starting | 16:00 |
|---|---|---|
| efried | whee | 16:00 |
| elmiko | hehe | 16:00 |
| efried | does the API SIG extend its tentacles into osc ux? | 16:01 |
| elmiko | not specifically, but we have had talks in the past about helping the user community if possible | 16:02 |
| elmiko | sadly, that work never really panned out | 16:02 |
| *** jawad_axd has joined #openstack-sdks | 16:08 | |
| dtroyer | efried: I'm afraid all of the blame for OSC UX falls on my shoulders (except for putting the resource name in front of the verb. That I resisted for a long time) | 16:12 |
| *** jawad_axd has quit IRC | 16:12 | |
| efried | dtroyer: I'm not slinging blame, I think it's pretty cool given the scope of what it needs to do. I was just going to solicit an opinion on the thing we were talking about last night with johnsom | 16:13 |
| efried | and really ux where u is "developer" more than anything, though there are routes we could take where u is the docs consumer | 16:13 |
| elmiko | efried: from that standpoint, the api-sig explicitly does not get into the business of regular "code" apis | 16:14 |
| johnsom | OSC is a huge leap forward from the old clients. We have also got a lot of positive feedback about it for our project. Just saying.... | 16:14 |
| johnsom | That said, yeah, the topic here is good-form for shared library method signatures. | 16:19 |
| johnsom | efried FYI, it looks like the tips job on my patch with the depends-on did pass. | 16:21 |
| johnsom | The others will not pass now until your osc-lib patch merges given the other changes. | 16:21 |
| efried | johnsom: Okay, I hadn't looked yet this morning. IRL we would have to get it released and through u-c and required by python-openstackclient before merging. | 16:22 |
| johnsom | Well, merges, releases, and upper-constraints merges | 16:22 |
| efried | jinx | 16:22 |
| johnsom | Yeah, all that | 16:22 |
| efried | There was another osc-lib change I was looking for... | 16:22 |
| johnsom | Thus my grumpy mood yesterday | 16:22 |
| efried | oh, it was this: right now the generated docs from within python-openstackclient are still tagged with "This command is provided by the python-openstackclient plugin" | 16:23 |
| efried | I was trying to fix that from osc-lib, but I think I found out it has to be fixed either from python-openstackclient itself or from cliff, or possibly both, I can't remember if I closed the gap all the way yet. | 16:24 |
| efried | oh yeah, I ended up with this: | 16:25 |
| efried | https://review.opendev.org/692464 | 16:25 |
| efried | https://review.opendev.org/692465 | 16:25 |
| dtroyer | efried: I gave that cliff review a +2 but you might want to remove WIP from the commit just for cleanliness sake. | 16:30 |
| dtroyer | otherwise it looks good | 16:31 |
| gtema | dtroyer, you are finally online at the same time as I. | 16:31 |
| gtema | What about https://review.opendev.org/#/c/650374 - switch image to SDK | 16:31 |
| gtema | I know it's huge, but we need to do something | 16:32 |
| dtroyer | I'm still pondering on https://review.opendev.org/#/c/693267, I'm assuming it isn't done yet, update_tags_for_set() isn't touched... | 16:32 |
| dtroyer | gtema: yes, it is huge and I haven't been able to get the kind of block of time to go through that yet. I also want to make sure we have decent enough functional tests to validate everything before and after (you may have that) | 16:33 |
| gtema | I understand. Just want to get clear on that change to decide what/how to do next. | 16:34 |
| * dtroyer is considering taking vacation next week to get time to focus on osc | 16:35 | |
| gtema | I introduced in this change another sdk_utils, and wanted in the followup to clean it up in compute | 16:35 |
| dtroyer | gtema: is that something that maybe belings in osc-lib? would plugins want it? | 16:36 |
| gtema | well, this is something what any SDK based plugin might want | 16:36 |
| dtroyer | we're gearing up to release osc-lib soon for the tags changes anyway | 16:36 |
| gtema | should I propose adding it there then? | 16:37 |
| dtroyer | if you think it is stable, sure. if it makes more sense to expand it to another API first to make sure it is 'done' then maybe wait. I'll try to take a look at that today | 16:38 |
| gtema | well, it is there since network uses SDK, so yes, it is stable | 16:38 |
| gtema | it's basically more or less just to kinda "show" SDK resource | 16:39 |
| dtroyer | yeah, even if they don't belong in osc-lib network does have some things that should be generalized for osc itself | 16:39 |
| *** jpich has quit IRC | 16:40 | |
| *** gtema_ has joined #openstack-sdks | 16:43 | |
| *** gtema has quit IRC | 16:43 | |
| efried | dtroyer: none of the update_tags_for_* methods are touched. How would they be? | 16:55 |
| efried | dtroyer: I think the cliff WIP might have been because I wanted to add some kind of testing. | 16:56 |
| dtroyer | efried: doh, right on update_*() | 16:56 |
| efried | phew, cause I couldn't imagine how that would work :P | 16:56 |
| dtroyer | cliff is used outside OpenStack so we're a bit more cautious about changes there, I don't see this one as an issue, but yeah, tests++ | 16:57 |
| efried | dtroyer: also wanted to make sure stephenfin had a crack at the concept before I invested too much time in it. | 16:57 |
| efried | dtroyer: btw, the other approach was to override Command etc. to provide a dummy App from within python-openstackclient | 16:58 |
| efried | because that's what cliff is bouncing off of when it generates that line. | 16:58 |
| efried | I tried doing that from within osc-lib but then the package is... osc-lib, and you get the message anyway :( | 16:58 |
| dtroyer | yeah, there is a small set of things like that that can't move into osc-lib | 16:59 |
| efried | also, the App superclass is *really* not designed to be "docs build" oriented, so that would be a serious hack. | 16:59 |
| efried | so as long as stephenfin / other cliff maintainers are okay with "polluting" the config space with another option, this solution is reasonably simple and clean. | 17:00 |
| efried | I'll go back and add tests if I get some time, but I'm not in a rush as I don't expect stephenfin to look until next week at the very earliest. | 17:00 |
| elmiko | later all, have a good weekend o/ | 17:00 |
| efried | o/ elmiko | 17:00 |
| cdent | elmiko: | 17:02 |
| cdent | hi | 17:02 |
| cdent | that is all | 17:02 |
| elmiko | hey cdent! =) | 17:02 |
| gtema_ | looks like "That's all Folks" | 17:02 |
| dtroyer | gtema_: so I'm just making time now, as that isn't as large as I remembered and I didn't realize you only did v2… | 17:13 |
| dtroyer | the deal with image create from stdin isn a significant change and at a bare minimum needs to be release-noted. There are a few placed it would break scripts I've written | 17:13 |
| gtema_ | yeah, this is exactly the next point - what do we want to do with v1 (drop or port it in followup) | 17:13 |
| dtroyer | I don't want to drop v1, we'll need to convert it too eventuallly, I _REALLY_ want to get rid of glancelcient and it's weird deps | 17:14 |
| gtema_ | for the moment create from stdin is supported, but not efficient | 17:14 |
| gtema_ | ok, then I can work on v1 in a followup. I had nowhere a real v1 to test it works and didn't want change to explode | 17:15 |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| dtroyer | yeah, that was supposed to be tested with other ancient APIs in that devstack-like mitaka cloud I was working on when starlingx destroyed my (work) life… | 17:16 |
| gtema_ | what I find funny - in real usage OSC becomes faster in lots of cases, but osc tests are tiny bit longer | 17:16 |
| gtema_ | the func-ones I mean | 17:17 |
| *** cdent has quit IRC | 17:17 | |
| *** noama has quit IRC | 17:22 | |
| *** jpena|off is now known as jpena | 17:26 | |
| gtema_ | dtroyer: thanks. wrt pagination: currently if limit is set in osc it return only single page. "paginate" flag in SDK used to fetch everything to the end | 17:43 |
| *** efried is now known as efried_afk | 18:05 | |
| *** gtema_ has quit IRC | 18:08 | |
| *** mgariepy has quit IRC | 18:35 | |
| *** mgariepy has joined #openstack-sdks | 18:40 | |
| *** efried_afk is now known as efried | 18:54 | |
| *** jawad_axd has joined #openstack-sdks | 19:01 | |
| *** jpena is now known as jpena|off | 19:42 | |
| *** gtema has joined #openstack-sdks | 19:47 | |
| *** mriedem has quit IRC | 19:48 | |
| *** mriedem has joined #openstack-sdks | 19:50 | |
| *** gtema has quit IRC | 19:58 | |
| *** jawad_axd has quit IRC | 20:28 | |
| *** gtema has joined #openstack-sdks | 21:15 | |
| *** gtema has quit IRC | 21:19 | |
| *** ccamel has quit IRC | 21:44 | |
| *** camelCaser has joined #openstack-sdks | 21:44 | |
| *** mtreinish has quit IRC | 21:46 | |
| *** mtreinish has joined #openstack-sdks | 21:47 | |
| *** jawad_axd has joined #openstack-sdks | 21:49 | |
| *** jawad_axd has quit IRC | 21:54 | |
| *** jawad_axd has joined #openstack-sdks | 22:50 | |
| *** jawad_axd has quit IRC | 22:54 | |
| *** mriedem has quit IRC | 22:58 | |
| *** jawad_axd has joined #openstack-sdks | 23:11 | |
| *** jawad_axd has quit IRC | 23:15 | |
| *** tosky has quit IRC | 23:24 | |
| *** jawad_axd has joined #openstack-sdks | 23:31 | |
| *** jawad_axd has quit IRC | 23:36 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!