| *** jangutter_ has joined #openstack-sdks | 01:10 | |
| *** jangutter has quit IRC | 01:12 | |
| *** efried has quit IRC | 01:26 | |
| *** efried has joined #openstack-sdks | 01:26 | |
| *** ricolin has joined #openstack-sdks | 02:27 | |
| *** gouthamr has quit IRC | 04:15 | |
| *** gouthamr has joined #openstack-sdks | 04:16 | |
| *** Luzi has joined #openstack-sdks | 04:58 | |
| *** goldyfruit_ has joined #openstack-sdks | 05:26 | |
| *** slaweq has joined #openstack-sdks | 06:37 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 06:51 |
|---|---|---|
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 06:52 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 06:53 |
| mordred | efried, cmurphy, kmalloc, Shrews: https://review.opendev.org/#/q/topic:fix-auth-discovery <-- assuming all three are green, I believe that is now the stack with the right depends-on to fix the issue and that the tests jobs properly validate the issue. the sdk patches should show that the needed sdk fixes work without the ksa fix, then the sdk test jobs on the ksa patch show that they continue to work | 06:56 |
| mordred | with the fix added | 06:56 |
| mordred | which should make it safe to land the openstacksdk patches, cut a release, then land the ksa patch and cut a release. | 06:56 |
| mordred | of course, I *think* what we need here (correct me if I'm wrong efried) is that we need to land the patches, then backport to stable/train, then cut a stable release on train - first for sdk then for ksa | 06:57 |
| *** ttsiouts has joined #openstack-sdks | 07:03 | |
| *** tosky has joined #openstack-sdks | 07:18 | |
| *** e0ne has joined #openstack-sdks | 07:22 | |
| *** e0ne has quit IRC | 07:22 | |
| *** ttsiouts has quit IRC | 07:26 | |
| *** ttsiouts has joined #openstack-sdks | 07:26 | |
| *** jpich has joined #openstack-sdks | 07:29 | |
| *** ttsiouts has quit IRC | 07:31 | |
| *** jpena|off is now known as jpena | 07:38 | |
| *** ttsiouts has joined #openstack-sdks | 07:56 | |
| *** cdent has joined #openstack-sdks | 08:05 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Start supporting type info https://review.opendev.org/686397 | 08:09 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use generated list of services instead of metaclass https://review.opendev.org/686542 | 08:09 |
| *** ttsiouts has quit IRC | 08:10 | |
| *** ttsiouts has joined #openstack-sdks | 08:11 | |
| *** ttsiouts_ has joined #openstack-sdks | 08:14 | |
| *** ttsiouts has quit IRC | 08:15 | |
| *** zbr is now known as zbr|ruck | 08:23 | |
| *** e0ne has joined #openstack-sdks | 08:59 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use generated list of services instead of metaclass https://review.opendev.org/686542 | 09:05 |
| *** mugsie has quit IRC | 10:03 | |
| *** mugsie has joined #openstack-sdks | 10:05 | |
| *** ttsiouts_ has quit IRC | 10:12 | |
| *** ttsiouts has joined #openstack-sdks | 10:13 | |
| *** gtema has joined #openstack-sdks | 10:15 | |
| *** ttsiouts has quit IRC | 10:17 | |
| *** cdent has quit IRC | 10:18 | |
| *** factor has joined #openstack-sdks | 10:26 | |
| *** gtema has quit IRC | 10:45 | |
| *** gtema has joined #openstack-sdks | 10:53 | |
| mordred | gtema: https://review.opendev.org/#/c/686542/ if you get a sec | 10:57 |
| *** gtema has quit IRC | 10:58 | |
| *** jpena is now known as jpena|lunch | 11:00 | |
| *** jangutter_ is now known as jangutter | 11:07 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start supporting type info https://review.opendev.org/686397 | 11:09 |
| *** ttsiouts has joined #openstack-sdks | 11:12 | |
| *** zbr|ruck is now known as zbr|lunch | 11:15 | |
| mordred | Shrews, cmurphy, efried, kmalloc: woot! all green! | 11:27 |
| *** gtema has joined #openstack-sdks | 11:50 | |
| bverschueren_ | if anyone has a moment to look at https://review.opendev.org/#/c/682909/ ? thx | 11:58 |
| *** jpena|lunch is now known as jpena | 12:00 | |
| *** enriquetaso has joined #openstack-sdks | 12:01 | |
| *** goldyfruit_ has quit IRC | 12:22 | |
| mordred | gtema, efried: incidentally - the ksa patch also fixes a thing that sdk was doing but we weren't noticing - which is making a failed call to discovery before *every* nova call -- because it failed, it didn't cache a discovery document | 12:23 |
| gtema | really? cool | 12:23 |
| mordred | I only noticed it was happing debugging a different issue | 12:23 |
| mordred | yeah | 12:23 |
| gtema | ok. I do not see this in my cloud, so perhaps some additional Nova change is there, but cool that it fixes things generally | 12:24 |
| gtema | nom, you are totally right - I simply haven't noticed that | 12:28 |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Stop testing python2.7 https://review.opendev.org/686589 | 12:39 |
| *** cdent has joined #openstack-sdks | 12:42 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | 12:43 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Stop testing python2 https://review.opendev.org/686592 | 12:48 |
| *** camelCaser has quit IRC | 12:53 | |
| *** camelCaser has joined #openstack-sdks | 12:55 | |
| *** Luzi has quit IRC | 12:55 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 12:56 |
| mordred | gtema: ^^ I added a release note (was going to backport to stable/train, but noticed there was no release note explaining why the patch was important) | 12:57 |
| *** camelCaser has quit IRC | 12:59 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/python-openstackclient master: Update master for stable/train https://review.opendev.org/686607 | 13:06 |
| gtema | mordred: +2-ed | 13:12 |
| mordred | gtema: thanks! | 13:15 |
| *** mriedem has joined #openstack-sdks | 13:18 | |
| *** zbr|lunch is now known as zbr|ruck | 13:25 | |
| efried | mordred: I concur with your assessment. Were you thinking we would get those stable/train releases into train's requirements before the release? | 13:30 |
| openstackgerrit | Merged openstack/python-openstackclient master: Update master for stable/train https://review.opendev.org/686607 | 13:30 |
| *** goldyfruit_ has joined #openstack-sdks | 13:40 | |
| mordred | efried: I don't know if it's possible to - but I figured cutting a small point release on top of train shortly after the release could also work, yeah/ | 13:41 |
| mordred | ? | 13:41 |
| efried | mordred: the difference being that we cannot update e.g. nova's lower-constraints after the release, so we can't rely on the new behavior in train in that case. | 13:42 |
| *** camelCaser has joined #openstack-sdks | 13:43 | |
| *** ttsiouts has quit IRC | 13:44 | |
| mordred | hrm. maybe it's worth going and talking to our release friends | 13:44 |
| *** ttsiouts has joined #openstack-sdks | 13:45 | |
| *** ttsiouts has quit IRC | 13:46 | |
| *** ttsiouts has joined #openstack-sdks | 13:46 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 13:51 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 13:54 |
| *** gmann_afk is now known as gmann | 13:58 | |
| *** goldyfruit___ has joined #openstack-sdks | 14:16 | |
| *** goldyfruit_ has quit IRC | 14:19 | |
| *** ricolin_ has joined #openstack-sdks | 14:25 | |
| mordred | dtroyer: is this https://762ea4c4c4fb203eceec-1a0f674a3837e35101e72ddbc77fd8ba.ssl.cf2.rackcdn.com/686589/1/check/osc-functional-devstack-tips/de578de/testr_results.html.gz | 14:26 |
| mordred | something we should be worried about and/or know about already? | 14:26 |
| *** ricolin has quit IRC | 14:26 | |
| *** goldyfruit_ has joined #openstack-sdks | 14:36 | |
| *** cdent has quit IRC | 14:37 | |
| dtroyer | mordred: I do not recall seeing that before. volume tests are historically timing sensitive but we've eliminated most of them (I think). Thats a compute test but volumes are involved. Have you seen more than one of these? | 14:37 |
| *** goldyfruit___ has quit IRC | 14:39 | |
| mordred | dtroyer: no - I should probably just recheck then | 14:43 |
| *** ricolin_ has quit IRC | 14:49 | |
| efried | mordred: reviewing that test change, I wonder if has_service ought to return the endpoint(_data) so we don't wind up duplicating calls... | 15:02 |
| mordred | efried: well - the reason to change to has_service is that we don't actually need to do the full endpoint_data call (which results in a discovery api call) in a lot of cases | 15:03 |
| openstackgerrit | Merged openstack/os-client-config master: Update the constraints url https://review.opendev.org/685581 | 15:04 |
| efried | yah, I get that | 15:04 |
| mordred | oh - but ... maybe make has_service also take a mv arg? | 15:04 |
| efried | I'm looking for usages of has_service to see if any of the are directly followed by something that does discovery | 15:04 |
| efried | I would think that in most cases the discovery is cached already one way or another. | 15:04 |
| mordred | nod | 15:04 |
| mordred | yeah | 15:04 |
| mordred | once it's done - it should be cached | 15:04 |
| efried | yeah, nothing jumps out. Probably n/a then. Ignore me. | 15:05 |
| efried | mordred: I think the dep chain might be busted. Care to join me in -requirements ? | 15:15 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 15:30 |
| *** ttsiouts has quit IRC | 15:37 | |
| *** ttsiouts has joined #openstack-sdks | 15:38 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 15:40 |
| efried | wfm, thanks mordred | 15:40 |
| *** ttsiouts has quit IRC | 15:42 | |
| efried | dangit, where tf is the cloud data sdk tests with? | 15:42 |
| efried | k, found the discovery documents. Looking for the flavors it loads up... | 15:43 |
| mordred | efried: right there! | 15:44 |
| efried | mordred: Sorry, help please, still not seeing where flavor data comes from | 15:45 |
| efried | i.e. self.flavor here https://review.opendev.org/#/c/685999/7/openstack/tests/functional/cloud/test_inventory.py | 15:45 |
| efried | mebbe openstack.tests.fakes.make_fake_flavor ? | 15:47 |
| mordred | no - that's a functional test | 15:47 |
| mordred | it's the flavor that we get find from devstack | 15:48 |
| mordred | efried: from openstack.tests.functional.cloud.util import pick_flavor | 15:48 |
| efried | ...from devstack? | 15:48 |
| efried | Are these "functional" tests running in a devstack?? | 15:49 |
| mordred | efried: yes. that's how the sdk functional tests work. | 15:49 |
| mordred | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/functional/cloud/util.py#L23-L43 | 15:49 |
| mordred | efried: the idea is that we point sdk at the devstack and then we use that devstack as a remote cloud | 15:50 |
| efried | whoah. | 15:50 |
| efried | I mean, cool, but... whoah. | 15:50 |
| mordred | :) | 15:50 |
| mordred | it's a fun set of tests | 15:50 |
| efried | so what I don't get is why the deltas in that file are necessary/appropriate. | 15:50 |
| mordred | because what the ksa patch fixed was microversion detection - so we now correctly detect the available microversion, which means we're now fetching Server at the mv declared in the server resource | 15:51 |
| mordred | which means we get the new form of flavor now | 15:51 |
| mordred | this change SHOULD have gone into the change last april that bumped our microversion | 15:51 |
| efried | okay, the test is way more magic than I was seeing | 15:51 |
| efried | thanks. | 15:52 |
| mordred | but we didn;t notice a that point that the behavior changed because the mv discovery was silently broke | 15:52 |
| mordred | it's actually super un-magic- it's just actually creating a server on an openstack and checking that it works. easy peasy right? | 15:52 |
| efried | mordred: next point of confusion... | 15:54 |
| efried | the references to 'host' in this test code... | 15:54 |
| efried | are those actualy *instances*?? | 15:54 |
| efried | based on OpenStackInventory.list_hosts, it... kinda looks like they might be | 15:54 |
| efried | because that's doing compute.list_servers | 15:54 |
| mordred | yes indeed | 15:55 |
| mordred | those are instances | 15:55 |
| efried | what do we call hosts?? | 15:56 |
| mordred | the word is host here because this is a file in support of ansible dynamic inventory | 15:56 |
| efried | tribal. knowledge. | 15:56 |
| mordred | but in this file a "host" is a record describing how to connect to a remote compute - and in this case those remote computers are vms managed by openstack with nova | 15:57 |
| efried | wow | 15:57 |
| efried | neat | 15:57 |
| efried | mordred: so given all that, I dropped a question in https://review.opendev.org/#/c/685999/ for a moar bettr test. LMK if you agree. | 15:57 |
| *** gtema has quit IRC | 15:58 | |
| *** adriant has quit IRC | 15:59 | |
| *** cmurphy is now known as cmorpheus | 16:01 | |
| cmorpheus | i guess i need to do things? | 16:01 |
| efried | cmorpheus: I think you're just on the hook for this un: https://review.opendev.org/#/c/685042/ | 16:02 |
| cmorpheus | mmk | 16:03 |
| efried | aside from zuul, both gtema and I have tested it locally. | 16:03 |
| *** cdent has joined #openstack-sdks | 16:05 | |
| *** tosky has quit IRC | 16:05 | |
| cmorpheus | so that one depends-on https://review.opendev.org/685999 is there a tldr why that's okay? that makes it seem very much backwards incompatible | 16:08 |
| *** jpich has quit IRC | 16:10 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 16:12 |
| mordred | cmorpheus: the tl;dr is that the fix to ksa exposes a bug in sdk | 16:12 |
| mordred | so we need to land the bugfix in sdk and release it first | 16:12 |
| *** mriedem is now known as mriedem_lunch | 16:14 | |
| mordred | efried: o - you know what - I agreed with your comment - but then really I'm wrong in my latest iteration on that - because removing the id references is important - the main new thing is that their existence is now undefinable | 16:14 |
| mordred | let me do one more quick respin | 16:14 |
| efried | mordred: oh, you mean because the id will exist iff the original flavor hasn't been deleted? | 16:15 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 16:20 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Re-add functional tests on flavor content https://review.opendev.org/686765 | 16:20 |
| mordred | efried: no - I mean until ksa releases we're still on the old mv | 16:20 |
| efried | ugh | 16:20 |
| efried | but... that's okay because of the dep? | 16:21 |
| mordred | efried: so we can neither assert id is in or not in the flavor record - because of the underlying mv shift - it's impossible to have a consistent payload | 16:21 |
| efried | oh | 16:21 |
| efried | the dep is backwards | 16:21 |
| mordred | like - it's impossible in the real world | 16:21 |
| efried | can we tell whath mv we used? | 16:21 |
| efried | (not that I think we necessarily should, just wondering) | 16:21 |
| mordred | maybe? actually - I don't think there is a good way to do that right now | 16:22 |
| mordred | but - we could potentially cook something up | 16:22 |
| efried | mordred: so now we actually *do* want a l-c bump from sdk to ksa when the latter is released, so we can ... oic you did that in the fup patch ++ | 16:24 |
| mordred | cmorpheus: responded - my answer is sort of an existential one ... | 16:26 |
| mordred | efried: yeah. perhaps that followup makes the weird sequence a little clearer - or not :) | 16:27 |
| efried | mordred: +2s on the stuff we can do now. -1 to get matching l-c on that fup. Also wouldn't be a bad idea to make the commit message voice less future-y, since in git history it's going to be past-y. | 16:27 |
| mordred | efried: yeah - I'll respin it once ksa releases - and will fix the l-c thing then too | 16:28 |
| efried | ++ | 16:28 |
| mordred | agree on the voice | 16:28 |
| efried | Thanks for working through this mess mordred | 16:29 |
| cmorpheus | mordred: lol | 16:30 |
| mordred | efried: likewise. this would have bit someone more unexpectedly at some point - at least now it comes with a release note | 16:32 |
| *** goldyfruit_ has quit IRC | 16:32 | |
| *** e0ne has quit IRC | 16:32 | |
| cmorpheus | mordred: are you wanting to release both of these today? today as in friday? friday the week before final RCs? | 16:33 |
| mordred | cmorpheus: no - I think we figured out earlier today that we do not need to rush a fix out the door | 16:33 |
| cmorpheus | okay awesome | 16:33 |
| mordred | they've got a workaround for it in cyborg | 16:33 |
| mordred | so I'm thinking point release post release :) | 16:33 |
| efried | whereupon the version numbers in the renos will need to be changed in the backports | 16:34 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 16:36 |
| *** cdent has quit IRC | 16:39 | |
| *** goldyfruit_ has joined #openstack-sdks | 16:39 | |
| *** zbr|ruck has quit IRC | 16:39 | |
| openstackgerrit | Merged openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995 | 16:42 |
| *** goldyfruit_ has quit IRC | 16:46 | |
| *** zbr has joined #openstack-sdks | 16:51 | |
| *** jangutter has quit IRC | 16:56 | |
| *** jpena is now known as jpena|off | 17:08 | |
| *** mriedem_lunch is now known as mriedem | 17:51 | |
| *** efried has quit IRC | 17:56 | |
| *** efried has joined #openstack-sdks | 17:58 | |
| *** gtema has joined #openstack-sdks | 17:58 | |
| *** gtema has quit IRC | 18:02 | |
| *** zbr has quit IRC | 19:46 | |
| *** e0ne has joined #openstack-sdks | 19:50 | |
| *** bverschueren_ is now known as bverschueren | 19:54 | |
| *** e0ne has quit IRC | 20:09 | |
| *** slaweq has quit IRC | 20:59 | |
| *** enriquetaso has quit IRC | 21:01 | |
| *** tosky has joined #openstack-sdks | 21:31 | |
| *** goldyfruit_ has joined #openstack-sdks | 21:38 | |
| openstackgerrit | Merged openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 21:44 |
| *** mriedem has quit IRC | 21:47 | |
| *** goldyfruit_ has quit IRC | 22:04 | |
| *** goldyfruit_ has joined #openstack-sdks | 22:07 | |
| *** slaweq has joined #openstack-sdks | 22:11 | |
| *** slaweq has quit IRC | 22:16 | |
| *** slaweq has joined #openstack-sdks | 23:11 | |
| *** slaweq has quit IRC | 23:16 | |
| *** tosky has quit IRC | 23:39 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!