| *** goldyfruit_ has joined #openstack-sdks | 00:14 | |
| *** dave-mccowan has joined #openstack-sdks | 01:22 | |
| *** dave-mccowan has quit IRC | 03:04 | |
| *** gmann_afk is now known as gmann | 03:33 | |
| *** gkadam has joined #openstack-sdks | 03:55 | |
| *** gkadam has quit IRC | 04:08 | |
| *** ricolin has joined #openstack-sdks | 04:16 | |
| *** Luzi has joined #openstack-sdks | 05:02 | |
| *** ttsiouts has joined #openstack-sdks | 06:35 | |
| *** gtema has joined #openstack-sdks | 06:38 | |
| bverschueren_ | if someone could have a look at https://review.opendev.org/#/c/682909/ ? thx | 06:47 |
|---|---|---|
| *** slaweq has joined #openstack-sdks | 06:56 | |
| *** zbr is now known as zbr|ruck | 07:08 | |
| *** tosky has joined #openstack-sdks | 07:16 | |
| *** dtantsur|afk is now known as dtantsur | 07:23 | |
| *** cdent has joined #openstack-sdks | 07:35 | |
| *** ttsiouts has quit IRC | 07:43 | |
| *** jpena|off is now known as jpena | 07:43 | |
| *** ralonsoh has joined #openstack-sdks | 07:45 | |
| *** jpich has joined #openstack-sdks | 07:52 | |
| *** jangutter has quit IRC | 07:56 | |
| *** ttsiouts has joined #openstack-sdks | 07:57 | |
| *** Jeffrey4l has quit IRC | 07:59 | |
| *** Jeffrey4l has joined #openstack-sdks | 08:00 | |
| *** ttsiouts has quit IRC | 08:12 | |
| *** jangutter has joined #openstack-sdks | 08:14 | |
| *** ttsiouts has joined #openstack-sdks | 08:18 | |
| *** yolanda has joined #openstack-sdks | 08:23 | |
| *** e0ne has joined #openstack-sdks | 08:29 | |
| mordred | rm_work: yay! | 08:38 |
| cdent | I first read that as "rm work ; yay!" which would be pretty yay. | 08:41 |
| dtantsur | rm -rf | 08:48 |
| mordred | ++ | 08:51 |
| mordred | cdent: does the system continue working overall with that? like - if I just rm work, do I still get paychecks? | 08:51 |
| cdent | mordred: in my pretty little mind it does | 08:52 |
| mordred | cdent: I like the workings of that mind | 08:53 |
| cdent | it's a very generous mind | 08:54 |
| dtantsur | just copy paycheck somewhere before rm -rf | 08:54 |
| mordred | dtantsur: ++ | 08:54 |
| cdent | it's a fifo that you can read from as needed | 08:54 |
| mordred | dtantsur: wow. vendor_data2.json | 08:56 |
| mordred | dtantsur: because that's a filename | 08:56 |
| dtantsur | haha | 08:56 |
| mordred | heaven forbid we put any sort of versioning into the file content itself. | 08:57 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 09:12 |
| mordred | efried, kmalloc, cmurphy: ^^ that's a simpler version and I think should be backportable | 09:13 |
| *** ricolin has quit IRC | 09:44 | |
| *** ttsiouts has quit IRC | 10:08 | |
| *** ttsiouts has joined #openstack-sdks | 10:09 | |
| *** ttsiouts has quit IRC | 10:13 | |
| openstackgerrit | Merged openstack/openstacksdk master: Support vendor data in configdrive building https://review.opendev.org/683842 | 10:58 |
| openstackgerrit | Merged openstack/openstacksdk master: Add a non-voting ironic-inspector job https://review.opendev.org/684729 | 11:06 |
| *** dave-mccowan has joined #openstack-sdks | 11:11 | |
| *** ttsiouts has joined #openstack-sdks | 11:16 | |
| *** jpena is now known as jpena|lunch | 11:38 | |
| *** enriquetaso has joined #openstack-sdks | 12:06 | |
| *** gtema has quit IRC | 12:09 | |
| *** cdent has quit IRC | 12:31 | |
| *** ricolin has joined #openstack-sdks | 12:32 | |
| *** cdent has joined #openstack-sdks | 12:32 | |
| *** jpena|lunch is now known as jpena | 12:38 | |
| *** gtema has joined #openstack-sdks | 12:41 | |
| *** gtema has quit IRC | 12:41 | |
| *** gtema has joined #openstack-sdks | 12:42 | |
| *** Luzi has quit IRC | 12:55 | |
| *** dave-mccowan has quit IRC | 13:13 | |
| *** dave-mccowan has joined #openstack-sdks | 13:14 | |
| *** mriedem has joined #openstack-sdks | 13:15 | |
| *** dave-mccowan has quit IRC | 13:19 | |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ttsiouts has joined #openstack-sdks | 14:25 | |
| *** ttsiouts has quit IRC | 14:30 | |
| *** gtema_ has joined #openstack-sdks | 14:45 | |
| *** ttsiouts has joined #openstack-sdks | 14:49 | |
| mordred | efried: you'll be happy to know that the 401 fix for keystoneauth, in additional to uncovering a different issue with swift (easy to fix) also uncovered the fact that, since we weren't ACTUALLY doing version discovery for nova before, we were falling back to 2.1 in sdk in all cases (which was actually our intention - we wanted to opt-in to newer behavior as we supported it) - but we were falling back | 15:15 |
| mordred | to it accidentally- so with discovery fixed, sdk is getting newest rather than oldest microversion by default - and the change to flavor broke sdk | 15:15 |
| mordred | efried: yay for testing | 15:15 |
| mordred | gtema: didn't we have code in sdk that was supposed to cause sdk to skip trying to do version discovery for swift? | 15:19 |
| gtema | yes - skip_discovery in proxy | 15:19 |
| mordred | like - I feel like we had it - then I forgot about it and wrote it again | 15:20 |
| mordred | gtema: then why is https://07f03003afd3ca1f2387-1738d3a5d5585f54500f5c8600ed53a6.ssl.cf1.rackcdn.com/685042/4/check/openstacksdk-functional-devstack-tips/64dae12/testr_results.html.gz | 15:20 |
| mordred | openstack.tests.functional.object_store.v1.test_account.TestAccount | 15:20 |
| mordred | doing version discovery gets? | 15:20 |
| gtema | that's a different story :D | 15:21 |
| mordred | (I know why they're broken - that's the ksa patch - but upon reflection, why are we doing them in the first place?) | 15:21 |
| gtema | perhaps something else in your patches? lemme try in my cloud fast | 15:21 |
| mordred | gtema: oh! | 15:22 |
| mordred | gtema: it's the test itself | 15:22 |
| *** ttsiouts has quit IRC | 15:22 | |
| mordred | gtema: the functional base test has a "require_service" method which we have a todo to replace | 15:22 |
| mordred | which is doing an explicit get_endpoint_data | 15:22 |
| gtema | aah, ok. In real life discovery is not done for swift | 15:22 |
| mordred | yeah | 15:23 |
| mordred | so - I think ksa should throw a better error in the case that someone tries this - but I also think we should fix these tests | 15:23 |
| mordred | this is a fun rabbit hole | 15:23 |
| * mordred hands efried the prize for finding the funnest bug | 15:23 | |
| gtema | agree. But I like the approach of passing auth to endpoint if we got exception | 15:25 |
| mordred | ++ | 15:25 |
| gtema | I have it in my cloud everywhere | 15:25 |
| gtema | and this is exactly what I was pointing in the API-SIG rework about version discovery | 15:26 |
| gtema | those clear requirements were lost | 15:26 |
| efried | mordred: Is sdk *supposed* to be getting the newest rather than the oldest microversion by default? (by design) | 15:32 |
| mordred | nope | 15:32 |
| efried | okay, reread your first message, got it. | 15:32 |
| mordred | so - you know - bugs all around :) | 15:32 |
| efried | Though I would imagine specific operations would explicitly use newer microversions under the covers. | 15:32 |
| mordred | yes - absolutely! | 15:32 |
| mordred | and for those it should absolutely use them | 15:33 |
| efried | but, like, something where /foo changes payload formats with different microversions, and we have a foos() method, I guess we would need you to tell us which shape you wanted the response to take. | 15:33 |
| mordred | we just might need to take additional action sdk-side to keep the sdk api consistent, so we want to opt-in to microversion changes (which is one of the reasons I've become an ardent supporter of microversions) | 15:33 |
| efried | unless we obscure all of that by objectifying the response | 15:33 |
| efried | but there again, some fields might be present/absent depending | 15:34 |
| mordred | yah- in the normal shade and sdk layer, we obscure by objectifying. if you want the REST layer and know what you're doing, requesting like 2.latest should be fine | 15:34 |
| efried | presumably the microversion kwarg passes through request() seamlessly still? | 15:35 |
| mordred | yup | 15:35 |
| efried | yeah, it must, because we're using it for placement from nova | 15:35 |
| mordred | fields being different, specifically flavor, is what caused the tests to catch that the ksa 401 fix had unbroken a discovery thing that was accidentally keeping sdk working properly :) | 15:35 |
| efried | ...unless we're getting the latest, which would also be working without us knowing... | 15:35 |
| efried | yeesh, so we have to fix ksa and then blacklist the fix from sdk until we fix sdk? | 15:36 |
| mordred | no - we can fix sdk before we fix ksa | 15:36 |
| efried | I had a mentor early in my career who called this RBB | 15:36 |
| efried | Revoked Bug Benefit | 15:36 |
| mordred | yah | 15:36 |
| mordred | it's a good term | 15:36 |
| efried | mordred: well, in other news, I think I got compute versioned discovery unauthed working: https://review.opendev.org/685181 | 15:37 |
| mordred | \o/ | 15:37 |
| efried | question is whether the change in NoAuthMiddleware is going to be acceptable. I would hope that's not being used outside of our own testing, but it seems technically supported by our conf, so I'm not sure. | 15:37 |
| mordred | I'm glad it was broken though - look at all the other stuff we get to fix | 15:37 |
| efried | Unfortunately, people who would know or care seem to be sparse. | 15:38 |
| efried | yeah | 15:38 |
| *** jpena is now known as jpena|brb | 15:42 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 15:52 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995 | 15:54 |
| mordred | efried, gtema: I *think* that should handle all the things except for the nova microversion issue | 15:59 |
| gtema | cool | 15:59 |
| efried | ack | 16:00 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | 16:04 |
| *** jpich has quit IRC | 16:10 | |
| mordred | gtema, efried: BWAHAHAHAHA. it's "not a bug" that we're requesting a later microversion from nova - we actually bumped the sdk layer microversion for the server resource | 16:11 |
| *** gtema_ has quit IRC | 16:12 | |
| mordred | but - because of the other bug, we never actually were getting 2.72 payloads in devstack and didn't notice we needed to update our flavor support | 16:12 |
| gtema | life is perfect | 16:12 |
| gtema | (unless one touches anything) | 16:12 |
| mordred | yeah | 16:12 |
| gtema | discovery and microversions are voodoo things in OpenStack | 16:14 |
| *** e0ne has quit IRC | 16:18 | |
| *** jpena|brb is now known as jpena | 16:19 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | 16:23 |
| mordred | gtema: yah. although they wouldn't have been if the client libraries hadn't hardcoded around them and if people hadn't put versioned endpoints in the catalog for the last 9 years. like - there was this whole system that literally nobody actually used :( | 16:24 |
| gtema | sure | 16:24 |
| gtema | hope we will fix it now with Nova switched to SDK and others using it deeper | 16:25 |
| mordred | gtema: or we've just opened ourselves to a new kind of pain | 16:27 |
| *** ricolin has quit IRC | 16:33 | |
| gtema | that's of course as well | 16:35 |
| *** dtantsur is now known as dtantsur|afk | 16:40 | |
| *** jpena is now known as jpena|off | 17:16 | |
| *** enriquetaso has quit IRC | 17:21 | |
| *** ralonsoh has quit IRC | 17:27 | |
| *** gtema_ has joined #openstack-sdks | 17:34 | |
| *** e0ne has joined #openstack-sdks | 17:35 | |
| *** gtema has quit IRC | 17:37 | |
| *** e0ne has quit IRC | 18:17 | |
| *** gtema_ has quit IRC | 19:06 | |
| *** e0ne has joined #openstack-sdks | 19:08 | |
| *** slaweq has quit IRC | 19:59 | |
| *** enriquetaso has joined #openstack-sdks | 20:09 | |
| *** enriquetaso has quit IRC | 20:17 | |
| *** e0ne has quit IRC | 20:27 | |
| *** enriquetaso has joined #openstack-sdks | 20:41 | |
| *** cdent has quit IRC | 20:59 | |
| *** openstackstatus has quit IRC | 21:32 | |
| *** openstackstatus has joined #openstack-sdks | 21:35 | |
| *** ChanServ sets mode: +v openstackstatus | 21:35 | |
| *** mriedem has quit IRC | 21:56 | |
| *** enriquetaso has quit IRC | 23:01 | |
| *** tosky has quit IRC | 23:02 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!