| *** slaweq has joined #openstack-sdks | 00:11 | |
| *** slaweq has quit IRC | 00:15 | |
| *** mriedem has quit IRC | 00:45 | |
| *** slaweq has joined #openstack-sdks | 02:11 | |
| *** ricolin has joined #openstack-sdks | 02:16 | |
| *** slaweq has quit IRC | 02:16 | |
| *** slaweq has joined #openstack-sdks | 04:03 | |
| *** slaweq has quit IRC | 04:08 | |
| *** dave-mccowan has quit IRC | 04:14 | |
| *** slaweq has joined #openstack-sdks | 05:11 | |
| *** slaweq has quit IRC | 05:15 | |
| *** e0ne has joined #openstack-sdks | 05:19 | |
| *** e0ne has quit IRC | 05:20 | |
| *** e0ne has joined #openstack-sdks | 05:51 | |
| *** slaweq has joined #openstack-sdks | 06:07 | |
| *** slaweq has quit IRC | 06:13 | |
| *** e0ne has quit IRC | 06:24 | |
| *** e0ne has joined #openstack-sdks | 06:39 | |
| *** slaweq has joined #openstack-sdks | 06:49 | |
| *** brtknr has joined #openstack-sdks | 06:50 | |
| *** gtema has joined #openstack-sdks | 06:52 | |
| *** slaweq has quit IRC | 06:54 | |
| *** slaweq has joined #openstack-sdks | 07:04 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Remove Accept header with empty value for HEAD and DELETE requests https://review.opendev.org/679383 | 07:21 |
|---|---|---|
| gtema | dtantsur, mordred: please please please my stat change | 07:22 |
| *** tosky has joined #openstack-sdks | 07:29 | |
| *** jpena|off is now known as jpena | 07:36 | |
| *** cdent has joined #openstack-sdks | 07:39 | |
| *** jpich has joined #openstack-sdks | 07:45 | |
| *** dtantsur|afk is now known as dtantsur | 07:46 | |
| *** brtknr has quit IRC | 07:48 | |
| *** brtknr has joined #openstack-sdks | 07:51 | |
| *** gtema has quit IRC | 08:01 | |
| *** brtknr has quit IRC | 08:03 | |
| *** gtema has joined #openstack-sdks | 08:05 | |
| *** brtknr has joined #openstack-sdks | 08:06 | |
| *** cdent has quit IRC | 08:06 | |
| mordred | gtema: re: accept headers - I think the default value of '' is weird and it seems like changing that isn't a bad idea | 08:08 |
| gtema | I'm glad | 08:08 |
| gtema | mordred: can you please have another look on stats change? After your +2 I only addressed dtantsurs review - no functional changes | 08:10 |
| *** brtknr_ has joined #openstack-sdks | 08:10 | |
| gtema | I'm just tired rebasing my dockerfile, where I checkout this change | 08:10 |
| mordred | gtema: yup. just re-reviewed | 08:10 |
| gtema | cool, thanks | 08:11 |
| mordred | gtema: does that accept patch work on your cloud? I though someone was saying requests adds a */* if you don't do anything and you needed to pass accept: None if you wanted no header ... | 08:11 |
| *** brtknr has quit IRC | 08:11 | |
| mordred | (although it looks like the unit tests show no header - so I guess it does) | 08:11 |
| gtema | well, with this I was only only checking the Swift - and it works this way | 08:12 |
| gtema | Actually even swiftclient if you look is not passing any "Accept" header | 08:12 |
| gtema | but since I modified HEAD and DELETE globally - this might bring problems somewhere | 08:13 |
| mordred | I doubt it... but I guess anything is possible :) | 08:13 |
| dtantsur | I think we should start with being standard compliant, and only add hacks if proved required | 08:13 |
| gtema | that's exactly the problem - everything is possible | 08:13 |
| mordred | dtantsur: ++ | 08:13 |
| * dtantsur has approved the stats patch | 08:14 | |
| gtema | dtantsur: now I definitely owe you a beer. Let's see when we can meet | 08:14 |
| dtantsur | ++ :) | 08:14 |
| gtema | btw, I hope in one-two weeks I plan to come back to switching remaining stuff in cloud to proxy/resource | 08:15 |
| gtema | but we need to address one thing - caching | 08:15 |
| gtema | it's either we still cast everything to dict in the cloud return, or we teach dogpile/etc to serialize Resource (what it can't do now) | 08:17 |
| gtema | dtantsur: I also answered your question in https://review.opendev.org/#/c/665110/ - it's a default microver, so no change is required | 08:18 |
| mordred | gtema: oh - yeah - I have some thoughts about that - I should write them down so we can discuss whether they're any good | 08:19 |
| gtema | cool | 08:19 |
| dtantsur | gtema: approved as well | 08:21 |
| gtema | thanks | 08:24 |
| *** ralonsoh has joined #openstack-sdks | 08:26 | |
| *** e0ne has quit IRC | 08:40 | |
| *** e0ne has joined #openstack-sdks | 08:40 | |
| *** cdent has joined #openstack-sdks | 08:41 | |
| *** e0ne has quit IRC | 08:46 | |
| *** e0ne has joined #openstack-sdks | 09:03 | |
| openstackgerrit | Merged openstack/openstacksdk master: Rework statistics reporting https://review.opendev.org/659841 | 09:32 |
| openstackgerrit | Bo Tran proposed openstack/openstacksdk master: Add a fields meta_data to result of Senlin API https://review.opendev.org/678585 | 09:39 |
| *** e0ne has quit IRC | 10:01 | |
| *** brtknr_ is now known as brtknr | 10:10 | |
| *** e0ne has joined #openstack-sdks | 10:10 | |
| *** icarusfactor has quit IRC | 10:11 | |
| *** icarusfactor has joined #openstack-sdks | 10:11 | |
| *** icarusfactor has quit IRC | 10:12 | |
| *** icarusfactor has joined #openstack-sdks | 10:13 | |
| *** factor__ has joined #openstack-sdks | 10:17 | |
| *** icarusfactor has quit IRC | 10:20 | |
| *** mtreinish has quit IRC | 10:23 | |
| *** frickler has quit IRC | 10:23 | |
| *** tobiash has quit IRC | 10:23 | |
| *** stingrayza has quit IRC | 10:23 | |
| *** efried has quit IRC | 10:24 | |
| *** dtruong has quit IRC | 10:24 | |
| *** edleafe has quit IRC | 10:24 | |
| *** ebbex has quit IRC | 10:24 | |
| *** evrardjp has quit IRC | 10:24 | |
| *** lifeless has quit IRC | 10:24 | |
| *** frickler has joined #openstack-sdks | 10:24 | |
| *** irclogbot_3 has quit IRC | 10:25 | |
| *** mtreinish has joined #openstack-sdks | 10:26 | |
| *** efried has joined #openstack-sdks | 10:27 | |
| *** tobiash has joined #openstack-sdks | 10:27 | |
| *** evrardjp has joined #openstack-sdks | 10:27 | |
| *** dtruong has joined #openstack-sdks | 10:27 | |
| *** stingrayza has joined #openstack-sdks | 10:27 | |
| *** irclogbot_3 has joined #openstack-sdks | 10:28 | |
| *** lifeless has joined #openstack-sdks | 10:29 | |
| *** ebbex has joined #openstack-sdks | 10:29 | |
| *** gtema has quit IRC | 11:06 | |
| *** slaweq has quit IRC | 11:26 | |
| *** cdent has quit IRC | 11:30 | |
| *** gtema has joined #openstack-sdks | 11:31 | |
| *** jpena is now known as jpena|lunch | 11:33 | |
| *** ricolin has quit IRC | 11:35 | |
| *** gtema_ has joined #openstack-sdks | 11:46 | |
| *** gtema has quit IRC | 11:48 | |
| *** cdent has joined #openstack-sdks | 11:52 | |
| *** dave-mccowan has joined #openstack-sdks | 12:02 | |
| *** gtema has joined #openstack-sdks | 12:11 | |
| *** yolanda has quit IRC | 12:12 | |
| *** gtema has quit IRC | 12:14 | |
| frickler | mordred: dtroyer: I'm still seeing this "location | Munch..." spam in osc output, I thought we had fixed that some time ago already. can we get that fixed for the upcoming release still? http://paste.openstack.org/show/767631/ | 12:17 |
| frickler | the issue is triggered by openstacksdk>=0.24.0 but I can't remember whether it needs fixing in sdk or on osc side | 12:24 |
| Shrews | frickler: yeah, that's less than pleasing. I'm guessing it should be osc side since sdk is supposed to return Munch objects to the callers | 12:27 |
| dtroyer | frickler: one of the things we pushed in for osc4 is the output formatting changes, it may have crept back in with that sinne some of those were rather old | 12:30 |
| dtroyer | the good news there is that it might only be ne place to change… I do not recall what the fix was initially | 12:30 |
| gtema_ | dtroyer, since you are here and I remember this. I am going to finally come back to glanceclient=>SDK replacement (I think I need to redo this from scratch, rather then try to rebase). | 12:32 |
| frickler | dtroyer: it seems to happen with all 3.x released version I've tested, so possibly it never got fixed | 12:32 |
| gtema_ | should I do this in osc4 branch or in master? | 12:32 |
| dtroyer | gtema_: the osc4 branch is dormant. I rebased what we had into back into master after the last release so osc4 is in master now and will be the next release | 12:34 |
| gtema_ | ah, cool. | 12:34 |
| dtroyer | frickler: ah, ok. next Q then is if it happens only in columns with the new formatting or olny not in those. I've seen it but not kept track of exactly where… | 12:36 |
| *** jpena|lunch is now known as jpena | 12:40 | |
| *** yolanda has joined #openstack-sdks | 12:41 | |
| frickler | dtroyer: I'm not sure I understand that question. from a quick test up to now I only see this issue for command showing/creating items living in the neutron api | 12:45 |
| dtroyer | frickler: that is probably true as the others do not use SDK | 12:50 |
| *** mriedem has joined #openstack-sdks | 12:51 | |
| dtroyer | the change is the introduction of osc_lib.format_columns module to de-pythonize structured output, a recent example is on https://review.opendev.org/#/c/678689/2/openstackclient/compute/v2/aggregate.py | 12:52 |
| dtroyer | without looking I am hoping we can just make DictColumn understand Munch | 12:52 |
| dtroyer | if Much shows up in columns that are not handled by format_columns then we'll need to fix it on those columns specifically | 12:53 |
| frickler | dtroyer: hmm, I can fix it for one object by inserting invisible_columns = ['location'] here, but I think it would be nice to have a more global solution https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/network/v2/router.py#L78 | 12:59 |
| mordred | frickler: yeah - I think it would be nice to generally teach $something what to do when it sees a munch - or a Resource for that matter | 13:01 |
| *** gtema_ has quit IRC | 13:02 | |
| dtroyer | frickler: I have a thing this morning, will dig in to that after lunch if you guys haven't already solved it all :) | 13:03 |
| *** e0ne has quit IRC | 13:05 | |
| *** edleafe has joined #openstack-sdks | 13:11 | |
| *** cdent has quit IRC | 13:11 | |
| frickler | mordred: like that? http://paste.openstack.org/show/767638/ | 13:12 |
| frickler | hmm, that looks nice enough to me, I'll submit a patch for it | 13:13 |
| *** gtema has joined #openstack-sdks | 13:14 | |
| *** e0ne has joined #openstack-sdks | 13:14 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/python-openstackclient master: Don't display Munch objects in the output https://review.opendev.org/679445 | 13:17 |
| *** gtema has quit IRC | 13:18 | |
| *** gtema has joined #openstack-sdks | 13:23 | |
| gtema | frickler: just hiding munch columns is not a nice idea. Any complex structure will come out of SDK as munch, so you potentially loose important data | 13:27 |
| gtema | and while currently there is nothing else then location/project, it may be any time later | 13:27 |
| frickler | gtema: the idea is that it should be re-formatted to something that makes sense to an end user before it reaches that point. seeing "Munch(whatever)" in the cli output IMO should never happen | 13:29 |
| gtema | I know, but simply hiding that is also not a way to go | 13:29 |
| gtema | treat is as a dict and show correspondingly, but not simply hide | 13:29 |
| frickler | gtema: the other option would be to just drop the 'location' column for all network objects. the content isn't relevant afaict | 13:30 |
| mordred | frickler: it's a property of every object in sdk actually | 13:31 |
| frickler | ... in an osc context. it sure is relevant in the sdk context | 13:31 |
| mordred | frickler: nod. I'm not sure if it's useful to output from osc - it's mostly there so if you're doing multi-cloud-region things you can tell where a given object is from the object | 13:32 |
| gtema | I wouldn't hide location by definition. In some contexts it might make sense | 13:32 |
| mordred | it might not be super hard to make a generalized location renderer | 13:32 |
| gtema | yea, as mordred said | 13:32 |
| gtema | it's not actually only about location - it will be same for any complex structure in the SDK resource | 13:33 |
| gtema | so there need to be a "apply dict formatter to any munch", and then in the network you can additionally hide location | 13:33 |
| mordred | gtema: yeah. s/munch/resource or munch/ | 13:34 |
| gtema | it's following us in multiple contexts :) | 13:35 |
| mordred | gtema: maybe it's not terrible to hide it for now then do a followup patch that unhides it as a placeholder to remind us t deal with it? | 13:36 |
| gtema | beah, I am afraid it would be immediately forgotten | 13:36 |
| gtema | but ok, let us then have a fat TODO/NOTE for that | 13:37 |
| *** enriquetaso has joined #openstack-sdks | 13:48 | |
| *** cdent has joined #openstack-sdks | 13:55 | |
| openstackgerrit | Merged openstack/openstacksdk master: Volume.Backup restore fixes https://review.opendev.org/665110 | 14:06 |
| *** gtema has quit IRC | 14:16 | |
| *** e0ne has quit IRC | 14:35 | |
| *** e0ne has joined #openstack-sdks | 14:39 | |
| * dtroyer is back | 15:53 | |
| dtroyer | so the column formatting is exactly what we added in osc_lib.format_columns, to produce useful output rather than python-formatted strings. We need to either treat Munch as a dict and use DictColumn() or make a MunchColumn() to handle those. I am assuming that type is predictable per column? | 15:54 |
| *** jangutter has quit IRC | 16:04 | |
| *** e0ne has quit IRC | 16:04 | |
| mordred | dtroyer: yeah. I think treating Munch as a dict type is likely the right choice | 16:06 |
| *** jpena is now known as jpena|off | 16:07 | |
| *** e0ne has joined #openstack-sdks | 16:09 | |
| mordred | hrm. or - maybe a MunchColumn type woudl be right - that way we could run toDict() on it | 16:14 |
| openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Add a MunchColumn type https://review.opendev.org/679474 | 16:14 |
| mordred | dtroyer, frickler: ^^ something liek that perhaps | 16:14 |
| *** mriedem is now known as mriedem_afk | 16:16 | |
| dtroyer | mordred: see, I knew if I had lunch first… :) That approach works, is there enough difference to not just use DictColumn()? Other than having to call to_dict(). I am trying to decide if developers should know (or care) if they have a Much or a dict | 16:19 |
| mordred | dtroyer: no - it _should_ behave just the same | 16:20 |
| mordred | oh - yeah - actually - format_dict should totally work perfectly well with either Munch or Resource objects | 16:21 |
| dtroyer | so we really just need to apply the DictColum calls to them… am trying that now | 16:22 |
| mordred | ++ | 16:22 |
| dtroyer | \o/ I needed to make a pass through output one more time to catch columns added since the original work was done, that gets it | 16:25 |
| dtroyer | now, nested Munch/dicts :) | 16:25 |
| dtroyer | I am not sure how to represent those in the prettytable output | 16:26 |
| mordred | dtroyer: maybe just as emoji | 16:26 |
| mordred | dtroyer: or, more seriously, maybe with dotted notation ... | 16:27 |
| mordred | do like project.name=foo | 16:27 |
| dtroyer | that would be the cleanest visually | 16:27 |
| mordred | for location = { project: { name: "foo" }} | 16:27 |
| * mordred doesn't really want to think about writing that rendering code ... | 16:28 | |
| mordred | I mean - I say that - it's probably not really that hard as a recursive call | 16:28 |
| dtroyer | I don't recall if other dicts we processed are nested, I didn't notice that location was before now | 16:28 |
| mordred | I made it nested just to make life harder | 16:29 |
| dtroyer | I would also totally buy doing that in a follow-up | 16:29 |
| mordred | ++ | 16:30 |
| *** e0ne has quit IRC | 16:30 | |
| dtroyer | I think that could be limited to osc_lib format_dict(), so we'd pick it up when it that gets released | 16:32 |
| * mordred playing with it right now | 16:33 | |
| dtroyer | mordred: off-topic: do you have a preferred ansible role to run Gerrit? I have not found one that seems to be an obvious choice that seems actively maintained... | 16:34 |
| mordred | funny story - we're working on making one of those right now :) | 16:35 |
| mordred | dtroyer: so ask me that again in couple of weeks | 16:36 |
| *** dtantsur is now known as dtantsur|afk | 16:36 | |
| dtroyer | heh, wish I could wait… to be part of windmill? | 16:36 |
| mordred | dtroyer: for opendev - we're aiming to switch from puppet to ansible-driven-docker | 16:37 |
| mordred | dtroyer: that said - we install gerrit from upstream docker containers in the zuul docker-compose file and there's ansible around that to set it up ... maybe there's enough there to be helpful? | 16:38 |
| mordred | https://opendev.org/zuul/zuul/src/branch/master/doc/source/admin/examples/docker-compose.yaml | 16:38 |
| dtroyer | is that the QuickStart? I've been down that path and am trying to generalize it a bit | 16:39 |
| mordred | yeah | 16:39 |
| dtroyer | I'm using windmill for the rest and was headed in that direction, sounds like you are too | 16:39 |
| * dtroyer finds another opportunity to learn patience | 16:39 | |
| dtroyer | kk, thanks. we can return to our regularly scheduled client-ish topics | 16:40 |
| * mordred is very ready to be on docker-driven gerrit ... | 16:40 | |
| mordred | dtroyer: https://review.opendev.org/#/c/630406 is the beginning of the change - it's very WIP and needs a bunch more - but that's my current infra task | 16:41 |
| dtroyer | I'll take a peek, thanks | 16:41 |
| mordred | (after a week of Gerrit User Summit though I've finally got the docker images all building solidly :) ) | 16:41 |
| *** jpich has quit IRC | 16:45 | |
| openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Handle nested dicts https://review.opendev.org/679474 | 16:47 |
| mordred | dtroyer: ^^ that almost works - but seems to have an off-by-one for some reason | 16:47 |
| dtroyer | so ps2 looks good there at first glance | 16:58 |
| *** cdent has quit IRC | 17:15 | |
| *** ralonsoh has quit IRC | 17:19 | |
| *** ricolin has joined #openstack-sdks | 17:28 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Format location columns in network commands https://review.opendev.org/679490 | 17:54 |
| dtroyer | mordred, frickler: ^^ is formatting the network location columns. There may be other network columns that need addressing, this puts the mechanism in place to handle those easily | 17:55 |
| *** ricolin has quit IRC | 18:00 | |
| *** adriant has quit IRC | 18:17 | |
| *** adriant has joined #openstack-sdks | 18:18 | |
| *** dave-mccowan has quit IRC | 19:02 | |
| lifeless | win 84 | 19:12 |
| *** mriedem_afk is now known as mriedem | 19:24 | |
| *** slaweq has joined #openstack-sdks | 19:31 | |
| *** adriant has quit IRC | 20:17 | |
| *** adriant has joined #openstack-sdks | 20:18 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Bump min osc-lib to 1.14.0 https://review.opendev.org/679182 | 20:27 |
| openstackgerrit | Merged openstack/openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/637739 | 21:29 |
| *** slaweq has quit IRC | 21:53 | |
| *** enriquetaso has quit IRC | 22:00 | |
| *** mriedem has quit IRC | 22:09 | |
| *** dayou has quit IRC | 22:55 | |
| *** dayou has joined #openstack-sdks | 22:56 | |
| *** tosky has quit IRC | 23:14 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!