Friday, 2019-08-09

*** slaweq has joined #openstack-sdks00:11
*** ricolin__ has joined #openstack-sdks00:13
*** slaweq has quit IRC00:15
*** ricolin_ has quit IRC00:16
*** whoami-rajat has quit IRC00:34
*** mriedem has quit IRC00:52
*** whoami-rajat has joined #openstack-sdks01:32
*** slaweq has joined #openstack-sdks02:11
*** slaweq has quit IRC02:15
*** altlogbot_2 has quit IRC02:44
*** altlogbot_1 has joined #openstack-sdks02:45
*** redrobot has quit IRC03:22
*** gtema has joined #openstack-sdks03:37
*** gtema has quit IRC03:41
*** ricolin__ is now known as ricolin04:09
*** slaweq has joined #openstack-sdks04:11
*** factor has quit IRC04:12
*** factor has joined #openstack-sdks04:12
*** slaweq has quit IRC04:16
*** dave-mccowan has quit IRC04:25
*** slaweq has joined #openstack-sdks05:11
*** slaweq has quit IRC05:15
*** dave-mccowan has joined #openstack-sdks05:34
*** gtema has joined #openstack-sdks05:38
*** e0ne has joined #openstack-sdks05:40
*** gtema has quit IRC05:42
*** e0ne has quit IRC05:59
*** slaweq has joined #openstack-sdks06:11
*** slaweq has quit IRC06:15
*** dtantsur|afk is now known as dtantsur06:28
*** slaweq has joined #openstack-sdks06:42
*** tosky has joined #openstack-sdks07:23
*** jpich has joined #openstack-sdks07:49
*** ralonsoh has joined #openstack-sdks08:06
openstackgerritLoan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource  https://review.opendev.org/67511308:29
openstackgerritBrin Zhang proposed openstack/python-openstackclient master: Add server migration list CLI  https://review.opendev.org/67530408:45
*** jpich has quit IRC09:09
*** jpich has joined #openstack-sdks09:09
*** e0ne has joined #openstack-sdks09:24
*** cdent has joined #openstack-sdks09:37
*** gtema has joined #openstack-sdks09:40
*** gtema has quit IRC09:44
*** gtema has joined #openstack-sdks09:46
openstackgerritLoan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource  https://review.opendev.org/67511309:48
*** gtema has quit IRC09:51
openstackgerritLoan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource  https://review.opendev.org/67511310:04
*** jpich has quit IRC10:13
*** jpich has joined #openstack-sdks10:14
fricklerkmalloc: mordred: I've refreshed the logs on my devstack patch dropping the admin endpoint, this is the error in h-eng that I'm failing to resolve https://logs.opendev.org/92/651492/7/check/openstacksdk-functional-devstack/afeaec0/controller/logs/screen-h-eng.txt.gz#_Aug_09_08_44_55_81715110:54
fricklerthe traceback looks slightly similar to what cmurphy fixed for https://review.opendev.org/65179010:56
mordredfrickler: yeah - I think it means the devstack patch should also add interface=public to the middleware config - maybe that's just a thing that needs to be done for heat?11:15
fricklermordred: I tested that locally for all different heat config sections I have found, but it didn't seem to make any difference.11:28
mordredfrickler: boo11:28
mordredfrickler: maybe cmurphy will know the magical answers whence she awakens11:28
*** gtema has joined #openstack-sdks11:52
openstackgerritMerged openstack/openstacksdk master: Initalize pool_executor so close works  https://review.opendev.org/67512011:56
*** gtema has quit IRC11:57
openstackgerritShubham Potale proposed openstack/openstacksdk master: Add support for nfv-orchestration service  https://review.opendev.org/67560412:12
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add python-openstackclient support to vnf package APIs  https://review.opendev.org/67560912:17
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add commands for create and delete vnfpackage APIs  https://review.opendev.org/67561012:17
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add commands for list and show vnf package API's  https://review.opendev.org/67561112:17
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add command for upload vnf package API  https://review.opendev.org/67561212:17
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add python-openstackclient support to vnf package APIs  https://review.opendev.org/67560912:23
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add commands for create and delete vnfpackage APIs  https://review.opendev.org/67561012:23
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add commands for list and show vnf package API's  https://review.opendev.org/67561112:23
openstackgerritShubham Potale proposed openstack/python-openstackclient master: Add command for upload vnf package API  https://review.opendev.org/67561212:23
*** cdent has quit IRC12:48
*** cdent has joined #openstack-sdks12:48
*** cdent has quit IRC12:49
*** gtema has joined #openstack-sdks12:52
openstackgerritBence Romsics proposed openstack/openstacksdk master: Add router add/remove route operations  https://review.opendev.org/67432412:59
*** Guest1857 has joined #openstack-sdks12:59
openstackgerritBence Romsics proposed openstack/python-openstackclient master: fixup! Add command: router add/remove route --route  https://review.opendev.org/67561813:01
openstackgerritBence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route  https://review.opendev.org/67432513:04
*** cdent has joined #openstack-sdks13:09
*** mriedem has joined #openstack-sdks13:10
*** stephenfin is now known as finucannot13:46
*** lbragstad has joined #openstack-sdks13:46
*** gtema_ has joined #openstack-sdks13:48
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rename cloud_config to cloud_region  https://review.opendev.org/67562713:53
mordreddtantsur: ^^ I did the variable renaming in a followup13:54
*** lbragstad has quit IRC13:58
dtantsurcool!14:03
*** lbragstad has joined #openstack-sdks14:04
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting  https://review.opendev.org/65984114:06
*** lbragstad has quit IRC14:14
cmurphymordred: frickler no idea14:35
*** cdent has quit IRC14:42
*** cdent has joined #openstack-sdks14:45
*** ricolin has quit IRC14:57
*** ricolin has joined #openstack-sdks15:01
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture  https://review.opendev.org/67518715:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove container-infra.example.com hack  https://review.opendev.org/67537815:10
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rename cloud_config to cloud_region  https://review.opendev.org/67562715:10
*** gtema has quit IRC15:14
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Skip most service_description for unknown services  https://review.opendev.org/67513515:28
mordredShrews, efried, mriedem: ^^ this time with a test15:28
mordred(which even tests that no warnings are thrown)15:28
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation.  https://review.opendev.org/67411015:35
mordredthat has a test now too15:36
mordredShrews: that one should avoid the annoying warnings we get from swift about not being able to talk to the root url15:36
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Skip most service_description for unknown services  https://review.opendev.org/67513515:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation.  https://review.opendev.org/67411015:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Fix discovery cache sharing  https://review.opendev.org/67512115:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add support for global_request_id  https://review.opendev.org/67480715:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog  https://review.opendev.org/67513015:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project  https://review.opendev.org/67517815:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture  https://review.opendev.org/67518715:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Remove container-infra.example.com hack  https://review.opendev.org/67537815:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rename cloud_config to cloud_region  https://review.opendev.org/67562715:42
mordredrebased the stack15:42
*** gtema_ has quit IRC15:43
*** gtema has joined #openstack-sdks15:44
*** e0ne has quit IRC15:44
*** cmurphy is now known as cmorpheus15:45
*** gtema has quit IRC15:46
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Add 'openstack server resize (confirm|revert)' commands  https://review.opendev.org/66535715:48
*** cdent has quit IRC15:57
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Add openstack server create --boot-from-volume option  https://review.opendev.org/67411115:58
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Fix compute service set handling for 2.53+  https://review.opendev.org/67257716:00
*** Guest1857 is now known as redrobot16:17
*** cdent has joined #openstack-sdks16:22
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Support type=image with --block-device-mapping option  https://review.opendev.org/67334016:36
dtroyermriedem: I've mucked about with your bdm series (release notes), and likely in the wrong order so a bit of rebasing may be necessary.  This one ^^^ I wondered about including the vda bit in the release note, will leave it to your discretion.16:38
*** ricolin_ has joined #openstack-sdks16:41
mriedemdtroyer: replied16:42
dtroyermriedem: thanks, agreed16:42
*** ricolin has quit IRC16:44
openstackgerritMatt Riedemann proposed openstack/python-openstackclient master: Fix <id> description for --block-device-mapping  https://review.opendev.org/67410516:44
openstackgerritMatt Riedemann proposed openstack/python-openstackclient master: Add openstack server create --boot-from-volume option  https://review.opendev.org/67411116:44
mriedem$ openstack server create --image $IMAGE_ID --block-device-mapping  vda=$IMAGE_ID:image:1:true --flavor m1.tiny --wait  test-vol-backed-vm-from-image The volume cannot be assigned the same device name as the root device  vda (HTTP 400) (Request-ID: req-b4569b5f-4415-4911-9119-7afd856e2714)16:45
mriedemfrom my earlier testing16:45
dtroyeryup, that's a pretty clear error message16:45
*** irclogbot_0 has quit IRC16:47
*** irclogbot_3 has joined #openstack-sdks16:49
*** irclogbot_3 has quit IRC16:49
*** dtantsur is now known as dtantsur|afk16:50
*** irclogbot_2 has joined #openstack-sdks16:50
*** jpich has quit IRC17:09
Shrewsmordred: Should we just delete the openstacksdk-functional-devstack-magnum test, or do you know a magnum expert who might want to fix it? It never passes.17:23
mordredShrews: wow, and it fails "has service magnum"17:24
mordredShrews: I'd say it's pretty useless currently17:24
Shrewsmordred: yeah. i had a quick glance at it but couldn't figure out what, exactly, was wrong17:25
openstackgerritMerged openstack/python-openstackclient master: Make configuration show not require auth  https://review.opendev.org/67311017:29
efried!SHAZAM!17:32
openstackefried: Error: "SHAZAM!" is not a valid command.17:32
mordredefried: it's so sad that !SHAZAM! isn't a valid command17:36
efriedMaybe it doesn't work for everyone17:36
efriedBecause, you see, now I *look* like a superhero, but I'm still an immature kid on the inside.17:37
Shrewsthat movie disappointed me, particularly the ending17:39
efriedI went in with expectations too high, because a friend told me he really liked it.17:41
efriedmordred, Shrews: This seems... wrong: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L12917:42
efriedThe *args part17:42
efriedI don't think there's a way you can call that such that `args` has anything in it.17:43
efried(slightly surprising that python even lets you define a param list that way, but I've seen it before)17:43
mordredefried: I *think* if you were to call it like Proxy(session, statsd_client, statsd_prefix, prometheus_counter, prometheus_historgram, foo) that foo would wind up in *args17:46
efriedmordred: But then the super() call would blow up, nah?17:47
mordredyeah - totally.17:47
mordredwe should get rid of that *args - I don't think we want people calling things with positional args anyway tbh17:47
efriedI always ask people to name kwargs17:47
efriedeven in unit tests17:47
mordred++17:48
efriedbut it's not especially enforceable17:48
mordredin 3.6 it is ... foo(self, *, bar=None)17:48
mordreddefines bar as a keyword only argument17:48
mordredso once we drop 2.7 - bob's our uncle17:48
efriedneat.17:49
efriedI had *two* uncle Bobs.17:49
mordredHA bob17:50
efriedwell, one of them failed, and hasn't been replaced, so...17:52
mordred:(17:53
efriedAs my first superhero act, I'm sending https://review.opendev.org/#/c/675135/17:58
*** factor has quit IRC18:06
*** icarusfactor has joined #openstack-sdks18:06
Shrewsmordred: Do you know if swift converts the casing of any object metadata we supply? Looks like we store in lowercase, but it comes back camel cased. This is messing with our dict.get() calls18:10
*** cdent has quit IRC18:15
Shrewshrm, seems so. wow, none of the object code dealing with metadata allows for this18:17
Shrewsalso, the autocreate header we put on the objects has a different header value???18:26
ShrewsHOW IS ANYTHING WORKING?!?!?18:26
Shrews:)18:26
Shrewsreturned header is: x-object-meta-x-object-meta-x-sdk-autocreated18:29
Shrewsthe header we save is: x-object-meta-x-sdk-autocreated18:29
Shrewsan extra "x-object-meta" is prepended somewhere18:29
Shrewsdoesn't seem to happen on the checksum headers though18:30
Shrewscan open... worms everywhere18:30
mordredShrews: see - I look away for a few minutes and you discover that the entire world is broken18:32
Shrewsmordred: stop letting me do things18:32
mordredShrews: no- do more things! the worms - they're everywhere?!18:33
Shrewsserves me right for trying to do a real-world test on my object cleanup code18:34
Shrewsi guess this means we are also missing functional tests of all this code18:35
efriedShrews: Would you please have a look at https://review.opendev.org/#/c/674675/ when you get a chance? TIA18:36
efriedmordred: I think your patch may get rid of the warnings, but IMO we still want that ^ yah?18:36
*** efried is now known as efried_pto18:42
Shrewsefried_pto: yeah, i'm gonna tackle this swift problem first while i have it paged in18:47
* Shrews has inferior context switching h/w18:48
mordredefried_pto: yeah - might as well18:51
*** ricolin_ has quit IRC19:02
ShrewsAHA! found the header bug19:23
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: Add option to lowercase object meta keys  https://review.opendev.org/67568219:31
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: bug: avoid unnecessary object meta prefix  https://review.opendev.org/67568319:31
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: bug: Consider case when comparing object values  https://review.opendev.org/67568419:31
Shrewsmordred: enjoy all the things19:31
Shrewsmordred: two of those probably need tests19:32
timburkeShrews, mordred fwiw, swift will title case header names going out, but those are case-insensitive per the rfc. i know on py2, something (mimetools? rfc822?) would lower-case them when reading the response, while py3 preserves the casing from the wire19:32
timburkeheader values should preserve whatever casing you sent with the PUT/POST19:32
Shrewstimburke: well, looks like we get them back in camelcase, even though we put in lower19:33
Shrewsi'm not sure where or why that's happening19:33
Shrewsunless we camel case our debug output just to be weird?  /me checks19:34
openstackgerritMerged openstack/openstacksdk master: Skip most service_description for unknown services  https://review.opendev.org/67513519:35
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload  https://review.opendev.org/67513419:39
mordredShrews: so ...19:39
mordredShrews: the headers object on the requests.Response here: https://review.opendev.org/#/c/675682/1/openstack/cloud/_object_store.py ... should be of type CaseInsensitiveDict19:39
mordredShrews: that's super weird that you're having to lowercase them (although I totally believe you)19:40
*** e0ne has joined #openstack-sdks19:41
Shrewsmordred: oh? i not sure that i've even heard of CaseInsensitiveDict. If that's the case, my failed dict.get() calls were probably just the extra prefix thing19:42
mordredShrews: it's an object from the requests library19:43
Shrewsmordred: YOU'RE an object from the requests library19:43
mordredbecause http headers are theoretically case insensitive19:43
mordredShrews: some days I certainlky feel that way19:43
Shrewsmordred: ok. i'll get rid of the lowercase stuff then19:44
*** odyssey4me has left #openstack-sdks19:45
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: bug: avoid unnecessary object meta prefix  https://review.opendev.org/67568319:47
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload  https://review.opendev.org/67513419:47
Shrewsmordred: ok, that should be what we need now19:48
*** ralonsoh has quit IRC19:57
mordredShrews: that looks fantastic!20:04
Shrewsmordred: oh, oops. found a nit to fix in that20:09
mordreddoh20:09
openstackgerritDavid Shrewsbury proposed openstack/openstacksdk master: Retry large object manifest upload  https://review.opendev.org/67513420:09
Shrewsjust minor cleanup i forgot to do20:10
*** whoami-rajat has quit IRC20:12
*** e0ne has quit IRC20:18
*** slaweq has quit IRC21:10
*** e0ne has joined #openstack-sdks21:21
*** slaweq has joined #openstack-sdks21:26
*** slaweq has quit IRC21:32
*** e0ne has quit IRC21:32
*** e0ne has joined #openstack-sdks21:36
*** e0ne has quit IRC21:45
*** slaweq has joined #openstack-sdks21:51
*** slaweq has quit IRC21:56
*** mriedem has quit IRC22:17
openstackgerritMerged openstack/openstacksdk master: Allow limiting Connection service_types from oslo.config  https://review.opendev.org/67467523:30
*** tosky has quit IRC23:32

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!