Tuesday, 2019-07-09

*** bobh has joined #openstack-sdks01:07
*** bobh has quit IRC01:12
*** altlogbot_0 has quit IRC01:30
*** altlogbot_1 has joined #openstack-sdks01:32
*** jangutter has quit IRC01:33
*** jangutter has joined #openstack-sdks01:33
*** adriant has joined #openstack-sdks01:36
*** bobh has joined #openstack-sdks02:09
*** icarusfactor has quit IRC03:03
*** whoami-rajat has joined #openstack-sdks03:12
*** bobh has quit IRC03:28
*** factor has joined #openstack-sdks04:16
*** gtema has joined #openstack-sdks04:49
*** ricolin has joined #openstack-sdks05:03
*** Luzi has joined #openstack-sdks05:37
openstackgerritBoxiang Zhu proposed openstack/python-openstackclient master: Add host and hypervisor_hostname to create servers  https://review.opendev.org/66960906:18
*** gtema has quit IRC06:22
*** gtema has joined #openstack-sdks06:38
*** cdent has joined #openstack-sdks06:41
*** gtema has quit IRC06:53
*** gtema has joined #openstack-sdks06:55
openstackgerritzhangqing proposed openstack/python-openstackclient master: Use cliff formattable columns in compute commands  https://review.opendev.org/66930406:56
*** gtema_ has joined #openstack-sdks06:58
*** slaweq has joined #openstack-sdks07:02
*** gtema has quit IRC07:07
*** gtema has joined #openstack-sdks07:07
*** gtema has quit IRC07:14
*** ianw is now known as ianw_pto07:16
*** gtema has joined #openstack-sdks07:16
*** jpich has joined #openstack-sdks07:17
*** ttsiouts has joined #openstack-sdks07:23
*** tosky has joined #openstack-sdks07:28
*** ralonsoh has joined #openstack-sdks07:30
*** ttsiouts has quit IRC07:38
*** gtema has quit IRC07:39
*** gkadam has joined #openstack-sdks07:55
*** gkadam has quit IRC07:55
*** ttsiouts has joined #openstack-sdks07:57
*** dtantsur|afk is now known as dtantsur07:57
*** ttsiouts has quit IRC08:11
*** ttsiouts has joined #openstack-sdks08:12
*** ttsiouts_ has joined #openstack-sdks08:13
*** ttsiouts has quit IRC08:17
*** gtema_ has quit IRC08:31
*** gtema has joined #openstack-sdks08:31
openstackgerritVishakha Agarwal proposed openstack/openstacksdk master: Add application credential CRUD support  https://review.opendev.org/66933109:20
openstackgerritVishakha Agarwal proposed openstack/openstacksdk master: Add application credential CRUD support  https://review.opendev.org/66933109:42
*** gtema_ has joined #openstack-sdks09:44
*** gtema has quit IRC09:45
*** cdent has quit IRC10:07
*** ricolin has quit IRC10:14
*** ttsiouts_ has quit IRC10:16
*** ttsiouts has joined #openstack-sdks10:17
*** cdent has joined #openstack-sdks10:18
*** ttsiouts has quit IRC10:21
*** gtema_ has quit IRC10:22
*** ricolin has joined #openstack-sdks10:22
*** gtema has joined #openstack-sdks10:23
*** ricolin has quit IRC10:23
*** gtema has quit IRC10:41
*** gtema has joined #openstack-sdks10:42
*** gtema_ has joined #openstack-sdks10:45
*** gtema has quit IRC10:54
*** gtema has joined #openstack-sdks10:55
*** gtema_ has quit IRC10:59
*** ttsiouts has joined #openstack-sdks11:04
*** gtema has quit IRC11:06
*** gtema has joined #openstack-sdks11:08
*** altlogbot_1 has quit IRC11:19
*** irclogbot_0 has quit IRC11:19
*** altlogbot_2 has joined #openstack-sdks11:20
*** altlogbot_1 has joined #openstack-sdks11:20
*** zbr is now known as zbr|lunch11:22
*** altlogbot_1 has quit IRC11:25
*** altlogbot_2 has quit IRC11:25
*** gtema has quit IRC11:32
*** gtema has joined #openstack-sdks11:32
*** ricolin has joined #openstack-sdks11:44
*** ttsiouts has quit IRC11:44
*** ttsiouts has joined #openstack-sdks11:45
*** odyssey4me_ has joined #openstack-sdks11:49
*** ttsiouts has quit IRC11:49
*** ttsiouts has joined #openstack-sdks11:53
*** kinrui has joined #openstack-sdks11:54
*** fyx has quit IRC11:55
*** mordred has quit IRC11:55
*** guilhermesp has quit IRC11:55
*** kmalloc has quit IRC11:55
*** TheJulia has quit IRC11:55
*** dustinc has quit IRC11:55
*** fungi has quit IRC11:55
*** odyssey4me has quit IRC11:56
*** melwitt has quit IRC11:56
*** odyssey4me_ is now known as odyssey4me11:56
*** zbr|lunch is now known as zbr11:59
*** irclogbot_3 has joined #openstack-sdks12:00
*** fyx has joined #openstack-sdks12:01
*** mordred has joined #openstack-sdks12:01
*** guilhermesp has joined #openstack-sdks12:01
*** kmalloc has joined #openstack-sdks12:01
*** TheJulia has joined #openstack-sdks12:01
*** dustinc has joined #openstack-sdks12:01
*** altlogbot_2 has joined #openstack-sdks12:03
*** altlogbot_1 has joined #openstack-sdks12:03
*** altlogbot_2 has quit IRC12:05
*** altlogbot_1 has quit IRC12:05
*** irclogbot_3 has quit IRC12:05
*** altlogbot_2 has joined #openstack-sdks12:09
*** altlogbot_2 has quit IRC12:11
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use resource layer for compute flavors  https://review.opendev.org/65090312:11
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Push sort_key down to server for flavor filtering  https://review.opendev.org/66985712:11
mordredgtema: addressed a couple of review comments from dtantsur in the compute flavors patch ^^ and then added a followup.12:12
gtemasuper mordred. Wanted already to remind about the whole batch, but you was faster than I had time to switch context :-)12:13
gtemabtw, I would also need attention to the "rework monitoring" change, but I have found another case where metric name is not generated properly, so will do another PS shortly12:14
mordredcool - will look at that too12:17
gtemathks12:17
*** kinrui is now known as fungi12:21
gtemamordred, do you remember about project cleanup tasks we took with you? We need to start doing that, since that is also I need in my project12:26
mordredgtema: funny - I was *just* talking about that a little in #openstack-infra :)12:30
mordredgtema: I probably can't get that done this week, but probably can next week12:30
gtemano hurry, it's just a reminder, that we took that on us12:31
openstackgerritMerged openstack/shade master: Add Python 3 Train unit tests  https://review.opendev.org/66945212:43
mordredgtema: ++12:46
mgariepycan i please have some review on : https://review.opendev.org/#/c/668017/ and https://review.opendev.org/#/c/668018/12:53
*** altlogbot_3 has joined #openstack-sdks12:55
Shrewsmordred: https://review.opendev.org/666905 is fyi. i haven't looked to see if latest sdk handles that yet12:57
*** altlogbot_3 has quit IRC12:57
mordredShrews: it's *supposed* to - maybe we're missing a guard somewhere13:01
mordredShrews: oh - hrm. looking at the nodepool patch itself (not just the commit message) - nodepool is calling list_ports directly not just getting to it via create_server13:02
mordredI think in that case we're almost *Certainly* missing a guard - we should put a if not self.has_service('network'): return [] at the top or something similar13:03
Shrewsyeah, for port cleanup iirc13:03
Shrewsyes, agreed13:04
mordredShrews: I'll make a patch so you can review13:06
openstackgerritMerged openstack/openstacksdk master: Fix typo for subnet.py This 'slacc' should be 'slaac'  https://review.opendev.org/66966113:06
Shrewsk13:06
openstackgerritMerged openstack/openstacksdk master: Switch cloud layer to use proxy for DNS  https://review.opendev.org/66543513:11
openstackgerritMerged openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server  https://review.opendev.org/66299813:13
*** mriedem has joined #openstack-sdks13:13
*** goldyfruit has joined #openstack-sdks13:19
openstackgerritMerged openstack/openstacksdk master: Use Resource layer for next compute methods  https://review.opendev.org/66306413:21
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Return empty lists for resources if neutron doesn't exist  https://review.opendev.org/66986913:22
*** gtema has quit IRC13:23
mordredShrews: ^^13:24
*** gtema has joined #openstack-sdks13:24
*** slaweq has quit IRC13:43
*** ttsiouts has quit IRC13:47
*** ttsiouts has joined #openstack-sdks13:47
*** slaweq has joined #openstack-sdks13:48
ITD27M01mordred: Hello! I am in the way to catch you! Could you please leave a comment in this PR: https://github.com/ansible/ansible/pull/5140113:49
ITD27M01mordred: If you have a second for this :)13:50
*** ttsiouts has quit IRC13:52
mordredITD27M01: Shrews left some comments on that about needing to add self.templare.template() call which someone else also mentioned - can you either fix that or respond that you've verified it's not needed?13:52
openstackgerritCorey Bryant proposed openstack/openstackclient master: Add Python 3 Train unit tests  https://review.opendev.org/63773913:57
ITD27M01mordred: Thank you, I just wanted to make sure you knew. I am not an author and will try to contact the developer to continue working.13:57
*** Luzi has quit IRC13:57
*** ttsiouts has joined #openstack-sdks13:58
mordredah - ok, cool. maybe I'll leave that same comment on the PR14:00
mordred(and sorry - my IRC to github user mapping is incomplete)14:00
Shrewslooks like the latest commit addresses the template thing14:02
mordredyeah.14:02
Shrewsbut not version_added14:02
mordredthe way these comments get displayed is very confusing to me14:03
Shrewsgod i hate gh14:03
Shrewsyes, same14:03
Shrewsmordred: that comment from me on that PR had me questioning my sanity b/c that call is clearly there now14:10
*** whoami-rajat has quit IRC14:18
Shrewsi almost want to send my response to your response directly to GH higher ups, but i doubt they'd care14:18
dtantsurfolks, do we bypass major version detection when endpoint_override is used?14:51
mordreddtantsur: uhm ...15:05
mordreddtantsur: I know that if you provide api_version _and_ endpoint_override we completely trust you15:05
dtantsurI'm seeing ironic-inspector in bifrost accessed without /v115:05
dtantsurbut I don't think we provide api_version15:06
mordredoh - yeah - if you give endpoint_override it should be the versioned endpoint15:06
mordredendpoint_override says "use this endpoint exactly" - discovery to find a new endpoint will never happen. in some cases we might hit the discovery url to get the document so we can see microversion info15:07
mordredbut we won't look in to it to find a versioned endpoint if an unversioned endpoint was given15:07
* dtantsur contemplates whether he likes it or not15:08
mordreddtantsur: unfortunately, the base system has a two-layer system for finding the url to use - the keystone catalog and then service version discovery15:09
mordredthinking about it now - it seems like having 2 different possible endpoint_override parameters would actually make more complete sense15:09
mordredso you could say something like "catalog_endpoint_override" or "service_endpoint_override" (but with better names)15:10
mordreddtantsur: for more context - we also have to have people give both endpoint_override and api_version sometimes just to tell us what the api version is because the discovery documents are broken on their cloud15:11
dtantsurhuh15:11
dtantsurI think I feel a bit uneasy about putting versioned endpoints to configuration files15:11
mordredbut - maybe we could apply the heuritstic that if you provide an endpoint_override and an api_version and the endpoint you supply does not contain "v{api_version}" that we should attempt to do a discovery lookup - and if it fails just assume you gave us a versioned endpoint and that the api version you supplied is correct15:12
mordredalthough I think we'd need a new option for that, since it would be a behavior change15:13
mordreddtantsur: I agree with all of your uneasiness15:13
dtantsurthe practical question for me is whether to update openstacksdk or hack endpoint_override inside ironic15:15
*** bobh has joined #openstack-sdks15:15
mordreddtantsur: well - this logic is actually all in keystoneauth15:23
*** bobh has quit IRC15:27
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Return empty lists for resources if neutron doesn't exist  https://review.opendev.org/66986915:36
*** icarusfactor has joined #openstack-sdks16:04
*** bobh has joined #openstack-sdks16:04
*** factor has quit IRC16:06
*** factor__ has joined #openstack-sdks16:06
*** bobh has quit IRC16:06
*** icarusfactor has quit IRC16:08
*** altlogbot_0 has joined #openstack-sdks16:09
*** altlogbot_0 has quit IRC16:13
*** whoami-rajat has joined #openstack-sdks16:21
*** jpich has quit IRC16:29
*** factor__ has quit IRC16:29
*** factor__ has joined #openstack-sdks16:30
*** dtantsur is now known as dtantsur|afk16:34
*** goldyfruit has quit IRC16:35
*** bobh has joined #openstack-sdks16:38
*** bobh has quit IRC16:38
*** factor__ has quit IRC16:44
*** ttsiouts has quit IRC16:48
*** ttsiouts has joined #openstack-sdks16:48
*** gtema has quit IRC16:52
*** gtema has joined #openstack-sdks16:52
*** ttsiouts has quit IRC16:53
*** altlogbot_1 has joined #openstack-sdks17:01
*** gtema has quit IRC17:03
*** gtema has joined #openstack-sdks17:04
*** altlogbot_1 has quit IRC17:05
*** irclogbot_3 has joined #openstack-sdks17:11
*** irclogbot_3 has quit IRC17:13
*** ralonsoh has quit IRC17:36
Shrewsmordred: gtema: fyi, looks like the openstacksdk-functional-devstack-magnum and openstacksdk-functional-devstack-masakari check jobs have been consistently failing since https://review.opendev.org/66274317:54
Shrewsi was unable to find any earlier change with those failures (though it may exist)17:55
mordredShrews: oh - we should fix that then17:59
mordredShrews: looks like it's just failing the has_service Magnum check18:00
Shrewsi cant access the logs from this coffee shop. my vpn blocks logs.o.o for some reason18:00
mordredmaybe it's incidental and something changed in devstack18:00
Shrewsthats an odd check to fail in a magnum specific test  :)18:01
mordredShrews: yah18:02
mordredShrews: also - I guess it's good that we have that check18:02
Shrews++18:02
Shrewsheading back to the house. thought i could work from here just to get out of the house, but much too uncomfortable here. biab18:08
*** whoami-rajat has quit IRC18:30
*** melwitt has joined #openstack-sdks18:34
*** bobh has joined #openstack-sdks18:35
*** bobh has quit IRC18:36
*** irclogbot_3 has joined #openstack-sdks18:37
*** irclogbot_2 has joined #openstack-sdks18:37
*** irclogbot_2 has quit IRC18:39
*** irclogbot_3 has quit IRC18:39
*** factor has joined #openstack-sdks19:06
*** goldyfruit has joined #openstack-sdks19:25
*** ttsiouts has joined #openstack-sdks19:43
*** Hazelesque has quit IRC19:49
*** Hazelesque has joined #openstack-sdks19:49
*** cdent has quit IRC19:57
*** ttsiouts has quit IRC20:09
*** ttsiouts has joined #openstack-sdks20:09
*** ttsiouts has quit IRC20:14
*** irclogbot_3 has joined #openstack-sdks20:25
*** irclogbot_0 has joined #openstack-sdks20:25
*** irclogbot_0 has quit IRC20:27
*** irclogbot_3 has quit IRC20:27
*** ttsiouts has joined #openstack-sdks20:53
*** bobh has joined #openstack-sdks20:54
*** bobh has quit IRC21:01
*** ttsiouts has quit IRC21:04
*** ttsiouts has joined #openstack-sdks21:04
*** ttsiouts has quit IRC21:09
*** irclogbot_3 has joined #openstack-sdks21:15
*** irclogbot_1 has joined #openstack-sdks21:15
*** irclogbot_3 has quit IRC21:19
*** irclogbot_1 has quit IRC21:19
*** goldyfruit has quit IRC21:20
*** irclogbot_0 has joined #openstack-sdks21:39
*** irclogbot_0 has quit IRC21:43
*** irclogbot_2 has joined #openstack-sdks21:55
*** irclogbot_1 has joined #openstack-sdks21:55
*** irclogbot_2 has quit IRC21:59
*** irclogbot_1 has quit IRC21:59
*** tosky has quit IRC22:18
*** goldyfruit has joined #openstack-sdks22:28
*** altlogbot_0 has joined #openstack-sdks22:45
*** altlogbot_0 has quit IRC22:49
*** bobh has joined #openstack-sdks22:52
*** slaweq has quit IRC22:54
*** bobh has quit IRC22:57
*** goldyfruit has quit IRC23:14
*** bobh has joined #openstack-sdks23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!