*** slaweq has joined #openstack-sdks | 00:11 | |
*** slaweq has quit IRC | 00:16 | |
*** tosky has quit IRC | 00:36 | |
openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/665629 | 01:34 |
---|---|---|
*** whoami-rajat has joined #openstack-sdks | 02:08 | |
*** slaweq has joined #openstack-sdks | 02:10 | |
*** slaweq has quit IRC | 02:16 | |
*** ricolin has joined #openstack-sdks | 02:55 | |
*** markvoelker has joined #openstack-sdks | 03:00 | |
*** markvoelker has quit IRC | 03:06 | |
*** slaweq has joined #openstack-sdks | 03:11 | |
*** slaweq has quit IRC | 03:15 | |
*** markvoelker has joined #openstack-sdks | 04:01 | |
*** markvoelker has quit IRC | 04:06 | |
*** markvoelker has joined #openstack-sdks | 04:21 | |
*** slaweq has joined #openstack-sdks | 05:11 | |
*** e0ne has joined #openstack-sdks | 05:15 | |
*** slaweq has quit IRC | 05:16 | |
*** e0ne has quit IRC | 05:20 | |
*** christi3k has quit IRC | 05:27 | |
*** purplerbot has quit IRC | 05:27 | |
*** purplerbot has joined #openstack-sdks | 05:28 | |
*** christi3k has joined #openstack-sdks | 05:28 | |
*** irclogbot_0 has quit IRC | 05:30 | |
*** irclogbot_3 has joined #openstack-sdks | 05:32 | |
*** Luzi has joined #openstack-sdks | 05:50 | |
*** slaweq has joined #openstack-sdks | 06:11 | |
*** ricolin has quit IRC | 06:18 | |
*** ricolin has joined #openstack-sdks | 06:19 | |
*** gtema has joined #openstack-sdks | 06:29 | |
*** tosky has joined #openstack-sdks | 07:15 | |
*** ralonsoh has joined #openstack-sdks | 07:16 | |
*** markvoelker has quit IRC | 07:22 | |
*** ttsiouts has joined #openstack-sdks | 07:42 | |
*** jpena|off is now known as jpena | 07:43 | |
*** dtantsur|afk is now known as dtantsur | 07:56 | |
*** jpich has joined #openstack-sdks | 07:59 | |
*** gkadam has joined #openstack-sdks | 08:00 | |
*** ttsiouts has quit IRC | 08:06 | |
*** ttsiouts has joined #openstack-sdks | 08:07 | |
*** ttsiouts has quit IRC | 08:11 | |
*** ttsiouts has joined #openstack-sdks | 08:16 | |
*** markvoelker has joined #openstack-sdks | 08:22 | |
*** markvoelker has quit IRC | 08:27 | |
*** e0ne has joined #openstack-sdks | 08:34 | |
*** holser_ has joined #openstack-sdks | 08:45 | |
*** markvoelker has joined #openstack-sdks | 08:53 | |
openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | 08:57 |
*** markvoelker has quit IRC | 08:58 | |
openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/665629 | 09:03 |
openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/665629 | 09:06 |
openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/665629 | 09:09 |
openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/665629 | 09:12 |
*** cdent has joined #openstack-sdks | 09:15 | |
*** yolanda has quit IRC | 09:41 | |
*** tosky has quit IRC | 09:47 | |
*** tosky has joined #openstack-sdks | 09:48 | |
*** markvoelker has joined #openstack-sdks | 09:53 | |
*** markvoelker has quit IRC | 09:58 | |
*** gtema has quit IRC | 10:14 | |
*** gtema has joined #openstack-sdks | 10:15 | |
*** dave-mccowan has joined #openstack-sdks | 10:31 | |
*** ttsiouts has quit IRC | 10:47 | |
*** ttsiouts has joined #openstack-sdks | 10:48 | |
*** ttsiouts has quit IRC | 10:52 | |
*** markvoelker has joined #openstack-sdks | 10:54 | |
*** markvoelker has quit IRC | 10:59 | |
*** holser_ is now known as holser|lunch | 11:13 | |
*** yolanda has joined #openstack-sdks | 11:17 | |
*** jpena is now known as jpena|lunch | 11:19 | |
*** ttsiouts has joined #openstack-sdks | 11:32 | |
*** markvoelker has joined #openstack-sdks | 11:55 | |
*** markvoelker has quit IRC | 12:00 | |
*** gtema has quit IRC | 12:00 | |
*** mgariepy has joined #openstack-sdks | 12:15 | |
*** gtema has joined #openstack-sdks | 12:21 | |
*** holser|lunch is now known as holser_ | 12:28 | |
*** jpena|lunch is now known as jpena | 12:29 | |
dtantsur | mordred: morning! do I get it right that loading a Connection from an oslo config doesn't allow to set various SDK-specific options, such as retry count? | 12:33 |
mordred | dtantsur: yeah - I think we don't have support for that. there was discussion about adding support to the oslo.config loading to allow specifying a named cloud profile and then having things get loaded from a clouds.yaml (so that the oslo.config section would ultimately just be a pointer to the clouds.yaml) - but that hasn't been fully specced out yet | 12:35 |
dtantsur | I see. It makes it harder to switch to this feature (and I wonder what Nova folks are going to do about options, such as retry count. efried?) | 12:36 |
mordred | we could also potentially add support for specifying them I imagine | 12:37 |
* mordred needs to find coffee- will attempt to say smarter things in a little bit | 12:38 | |
dtantsur | coffee++ | 12:39 |
efried | dtantsur: "switch to this feature" -- you mean retrofit something that currently uses clouds.yaml to using oslo.config instead? Or you mean switching something like nova over from its current oslo.config-to-load-ksa to oslo.config-to-load-sdk? | 12:44 |
dtantsur | efried: the latter. e.g. making https://github.com/openstack/nova/blob/master/nova/conf/ironic.py#L41 still work | 12:45 |
efried | dtantsur: oic. Are these options normally available in clouds.yaml? | 12:46 |
dtantsur | efried: this one is implemented under a different name (something like status_code_retries) | 12:47 |
dtantsur | https://github.com/openstack/nova/blob/master/nova/conf/ironic.py#L54 is not implemented (retries are exponential) | 12:48 |
efried | so let me ask you this dtantsur: is it actually important that these values continue to be configurable? | 12:48 |
efried | dtantsur: If the options are available to the Connection() constructor, it would be pretty easy to plumb a **kwargs through here: https://review.opendev.org/#/c/643664/20/nova/utils.py@1252 | 12:51 |
dtantsur | efried: the api_retries is an important one for ironic, yes. I know that at least tripleo raises it quite significantly. | 12:51 |
dtantsur | I don't remember if adapter options are available in Connection. mordred? | 12:51 |
efried | get_cloud_region... | 12:53 |
efried | nope | 12:54 |
*** markvoelker has joined #openstack-sdks | 12:56 | |
efried | dtantsur: Okay, I can see a way to make this work, at least for status_code_retries, if there's not something else in place. | 12:57 |
efried | but, ugh, for the ones that aren't supported (like the retry interval), we might have to maintain both code paths in nova, deprecate the option, and remove the old code path and the option at the same time in a future release. | 12:59 |
efried | dtantsur, dustinc: How immediate is the need for this? Do you want me to sling something together today? | 13:00 |
*** ttsiouts has quit IRC | 13:00 | |
*** markvoelker has quit IRC | 13:00 | |
*** ttsiouts has joined #openstack-sdks | 13:01 | |
dtantsur | efried: I'm looking into updating keystoneauth actually | 13:02 |
efried | dtantsur: Oh, is this an option that was added to the ksa.Adapter constructor but not to its config opts? | 13:03 |
dtantsur | yep | 13:05 |
*** ttsiouts has quit IRC | 13:05 | |
mordred | ah - yeah - that would be a better fix probably | 13:05 |
mordred | also - oops | 13:05 |
efried | okay, yeah, for sure. | 13:05 |
dtantsur | and there is a sanity fix required there, hold on | 13:05 |
openstackgerrit | Dmitry Tantsur proposed openstack/keystoneauth master: Limit interval between retries to 1 minute https://review.opendev.org/666284 | 13:10 |
dtantsur | I know tripleo loves enormous retries, so ^^^ | 13:10 |
*** yolanda has quit IRC | 13:13 | |
*** yolanda has joined #openstack-sdks | 13:17 | |
*** ttsiouts has joined #openstack-sdks | 13:18 | |
*** cdent has quit IRC | 13:21 | |
openstackgerrit | Dmitry Tantsur proposed openstack/keystoneauth master: Allow setting retry counts for Adapter via configuration options https://review.opendev.org/666287 | 13:24 |
dtantsur | efried, mordred ^^^ | 13:25 |
dtantsur | now I wonder if we need an option for retry interval | 13:27 |
dtantsur | I definitely don't want to maintain two code paths.. | 13:27 |
mordred | dtantsur: -1 on the limit with what would normally be a nit but in this case I think is salient | 13:27 |
openstackgerrit | Dmitry Tantsur proposed openstack/keystoneauth master: Limit interval between retries to 1 minute https://review.opendev.org/666284 | 13:28 |
dtantsur | oh FFS when will I stop confusing these words?? | 13:28 |
* dtantsur is so ashamed of himself.. | 13:29 | |
dtantsur | thanks mordred, updated! | 13:29 |
mordred | dtantsur: they're more easily distinguishable in german :) | 13:30 |
dtantsur | definitely! I'm confusing other words here :D | 13:31 |
dtantsur | I cannot make up my mind on whether we should support setting retry intervals (overriding exponential retries) | 13:32 |
efried | dtantsur: I'm a proponent of "fewer knobs" wherever possible. I can't imagine a configurable retry interval is really important to anyone (whether they think it is or not). | 13:36 |
dtantsur | efried: I'm only concerned with upgrades. E.g. if something like tripleo has set api_retries=20 retry_interval=2 (40 seconds totally), which now will turn into many minutes. | 13:47 |
dtantsur | otherwise "fewer knobs"++ | 13:51 |
*** markvoelker has joined #openstack-sdks | 13:57 | |
efried | Are there really scenarios in tripleo where there are more than a couple of retries? | 14:00 |
efried | I guess if we're a deployment tool and we're waiting for a service to come up, having a fixed rather than exponential retry makes sense... | 14:00 |
efried | so, sigh, yeah, I guess it still makes sense for it to be configurable. | 14:00 |
*** markvoelker has quit IRC | 14:01 | |
dtantsur | efried: crazy hardware where BMC can start thinking for a minute about a power on request, locking a node in ironic? | 14:09 |
dtantsur | it happens less and less frequently, but still happens | 14:09 |
*** cdent has joined #openstack-sdks | 14:11 | |
dtantsur | mordred: when you have a minute: https://review.opendev.org/#/c/665645/ | 14:25 |
mordred | dtantsur: I really want a string subclass that is case-insensitive and treats - and _ the same | 14:27 |
mordred | dtantsur: I feel like it would make so many things easier | 14:27 |
dtantsur | totally | 14:27 |
mordred | I'll write one in all of my copious free time | 14:27 |
dtantsur | in your WHAT | 14:28 |
mordred | I mean - actually - requests already has a caseinsensitive dict it uses for headers- we could totally start using it for our internal dicts | 14:28 |
mordred | and maybe even update oslo.config to do the same (or similar) so that "foo-bar" in config_object would work as seamlessly as it does with response.headers | 14:29 |
mordred | but - yeah - still too much work for now | 14:29 |
mordred | +A on that patch | 14:29 |
*** Luzi has quit IRC | 14:36 | |
dtantsur | thx! | 14:47 |
*** mriedem has joined #openstack-sdks | 14:47 | |
*** mriedem has left #openstack-sdks | 14:48 | |
*** markvoelker has joined #openstack-sdks | 14:58 | |
*** markvoelker has quit IRC | 15:02 | |
dtantsur | is keystoneauth CI broken? | 15:16 |
dtantsur | the pep8 job tries to run bandit for some reason (and fails) | 15:17 |
*** gkadam has quit IRC | 15:19 | |
*** holser_ has quit IRC | 15:30 | |
*** holser_ has joined #openstack-sdks | 15:32 | |
*** holser_ has quit IRC | 15:37 | |
*** holser_ has joined #openstack-sdks | 15:46 | |
*** holser_ has quit IRC | 15:47 | |
*** holser_ has joined #openstack-sdks | 15:48 | |
openstackgerrit | Merged openstack/openstacksdk master: from_conf: fix handling service names with dashes https://review.opendev.org/665645 | 15:57 |
*** markvoelker has joined #openstack-sdks | 15:58 | |
*** ttsiouts has quit IRC | 16:02 | |
*** ttsiouts has joined #openstack-sdks | 16:03 | |
*** markvoelker has quit IRC | 16:03 | |
*** ttsiouts has quit IRC | 16:07 | |
openstackgerrit | jacky06 proposed openstack/os-client-config master: Sync Sphinx requirement https://review.opendev.org/666379 | 16:14 |
*** jpich has quit IRC | 16:27 | |
openstackgerrit | jacky06 proposed openstack/os-service-types master: Sync Sphinx requirement https://review.opendev.org/666384 | 16:29 |
mordred | dtantsur: uh. | 16:30 |
mordred | cmurphy, kmalloc: ^^ I thought I saw something about bandit a while back or something? | 16:30 |
cmurphy | um | 16:31 |
kmalloc | uh | 16:33 |
kmalloc | bandit was broken for lots of things. | 16:33 |
kmalloc | but afaik that was fixed | 16:33 |
cmurphy | did it release again? | 16:33 |
cmurphy | yep on friday | 16:34 |
mordred | http://logs.openstack.org/84/666284/2/check/openstack-tox-pep8/77e2cf5/job-output.txt.gz seems unhappy with access_token_type='access_token' in the oidc driver | 16:35 |
kmalloc | and it totally mis-catches that as a password | 16:35 |
mordred | yeah | 16:35 |
kmalloc | yeah... nope. | 16:35 |
kmalloc | i am less and less impressed with the bandit development | 16:35 |
kmalloc | i am guessing it's doing a crappy match on the word 'password' in the function signature | 16:36 |
kmalloc | as a kwarg. | 16:36 |
openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Cap bandit https://review.opendev.org/666388 | 16:36 |
kmalloc | cmurphy: +2/+A fast land if it passes zuul. | 16:37 |
kmalloc | cmurphy: feel free to self-approve if subsequent minor changes are needed (Carry my +2/+A) for unbreaking the KSA gate. | 16:37 |
cmurphy | kmalloc: o7 | 16:37 |
* kmalloc drinks coffee and tries to be less curmudgeonly towards external dependencies. | 16:39 | |
kmalloc | :P | 16:39 |
*** jpena is now known as jpena|off | 16:45 | |
*** tosky has quit IRC | 16:47 | |
*** ricolin has quit IRC | 16:48 | |
dtantsur | my API SIG friends, elmiko and edleafe (and everybody who cares): I'll be likely out for the next 2.5 weeks (i.e. 3 Thursdays) | 16:48 |
gtema | dtantsur: eh, lucky | 16:49 |
dtantsur | gtema: one week of that is a f2f meeting :) | 16:49 |
dtantsur | and on Friday I'm out because of the German exam, brrrr | 16:49 |
dtantsur | so my luck is only for the last week :) | 16:50 |
gtema | hehehe | 16:50 |
gtema | good luck with exam | 16:50 |
dtantsur | thank you, I feel like I'll need it :) | 16:50 |
gtema | Du muss es schaffen | 16:50 |
mordred | He must sheep it? | 16:52 |
gtema | nope - 2 "f" - means - do it (accomplish) | 16:53 |
dtantsur | :D | 16:53 |
gtema | and 1 "f" is a sheep | 16:54 |
dtantsur | ich hoffe, das ich es nicht schafen werde :D | 16:54 |
gtema | wieso nur?? | 16:54 |
mordred | ahhh | 16:54 |
dtantsur | ich wäre nicht ein Schaf :D | 16:55 |
dtantsur | anyway, enough of my silly German, see you later | 16:56 |
mordred | ich esse Schafen gern | 16:56 |
gtema | ich auch | 16:56 |
* dtantsur nicht | 16:56 | |
*** dtantsur is now known as dtantsur|afk | 16:56 | |
dtantsur|afk | \o | 16:56 |
edleafe | dtantsur|afk: enjoy! | 16:57 |
*** markvoelker has joined #openstack-sdks | 16:59 | |
*** markvoelker has quit IRC | 17:04 | |
elmiko | dtantsur|afk: ack, thanks for the heads up. have fun =) | 17:08 |
*** e0ne has quit IRC | 17:20 | |
*** cdent has quit IRC | 17:22 | |
*** holser_ has quit IRC | 17:49 | |
*** holser_ has joined #openstack-sdks | 17:54 | |
*** gtema has quit IRC | 17:54 | |
*** melwitt is now known as jgwentworth | 17:55 | |
*** gtema has joined #openstack-sdks | 17:59 | |
*** holser_ has quit IRC | 17:59 | |
*** markvoelker has joined #openstack-sdks | 18:00 | |
*** holser_ has joined #openstack-sdks | 18:00 | |
*** markvoelker has quit IRC | 18:05 | |
*** holser_ has quit IRC | 18:05 | |
*** e0ne has joined #openstack-sdks | 18:35 | |
*** e0ne has quit IRC | 18:36 | |
*** markvoelker has joined #openstack-sdks | 19:01 | |
*** e0ne has joined #openstack-sdks | 19:05 | |
*** markvoelker has quit IRC | 19:20 | |
openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Remove deprecated compute.v2.fixedip/floatingip https://review.opendev.org/538537 | 19:36 |
*** jkulik has quit IRC | 19:38 | |
*** gtema has quit IRC | 19:50 | |
*** jgwentworth is now known as melwitt | 19:52 | |
*** ralonsoh has quit IRC | 19:53 | |
*** holser_ has joined #openstack-sdks | 19:56 | |
*** holser_ has quit IRC | 20:00 | |
*** e0ne has quit IRC | 20:11 | |
*** markvoelker has joined #openstack-sdks | 20:17 | |
*** markvoelker has quit IRC | 20:36 | |
*** whoami-rajat has quit IRC | 20:47 | |
openstackgerrit | Merged openstack/keystoneauth master: Cap bandit https://review.opendev.org/666388 | 20:49 |
*** e0ne has joined #openstack-sdks | 20:55 | |
*** e0ne has quit IRC | 20:59 | |
*** e0ne has joined #openstack-sdks | 21:00 | |
*** markvoelker has joined #openstack-sdks | 21:33 | |
*** e0ne has quit IRC | 21:39 | |
*** markvoelker has quit IRC | 21:53 | |
*** zbr|ruck has quit IRC | 22:17 | |
*** markvoelker has joined #openstack-sdks | 22:50 | |
*** markvoelker has quit IRC | 23:05 | |
*** slaweq has quit IRC | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!