| *** markvoelker has quit IRC | 00:24 | |
| *** bobh has joined #openstack-sdks | 00:58 | |
| *** ttsiouts has joined #openstack-sdks | 01:00 | |
| *** ttsiouts has quit IRC | 01:06 | |
| openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Support Proxy-specific region_name https://review.opendev.org/662865 | 01:49 |
|---|---|---|
| *** bobh has quit IRC | 01:54 | |
| *** whoami-rajat has joined #openstack-sdks | 03:15 | |
| *** e0ne has joined #openstack-sdks | 05:43 | |
| *** slaweq has joined #openstack-sdks | 06:13 | |
| *** dtantsur|afk is now known as dtantsur | 06:16 | |
| *** holser_ has joined #openstack-sdks | 06:27 | |
| *** evrardjp_ is now known as evrardjp | 06:43 | |
| *** gtema has joined #openstack-sdks | 06:58 | |
| *** ITD27M01 has joined #openstack-sdks | 07:02 | |
| *** ttsiouts has joined #openstack-sdks | 07:09 | |
| *** e0ne has quit IRC | 07:09 | |
| *** slaweq has quit IRC | 07:16 | |
| *** adriant has quit IRC | 07:29 | |
| *** markvoelker has joined #openstack-sdks | 07:32 | |
| *** zbr has joined #openstack-sdks | 07:32 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for network SecurityGroups https://review.opendev.org/662724 | 07:34 |
| *** ttsiouts has quit IRC | 07:34 | |
| *** ttsiouts has joined #openstack-sdks | 07:35 | |
| *** ttsiouts has quit IRC | 07:39 | |
| *** slaweq has joined #openstack-sdks | 07:40 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for compute KeyPairs https://review.opendev.org/662729 | 07:44 |
| *** jpich has joined #openstack-sdks | 07:47 | |
| *** jpena|off is now known as jpena | 07:51 | |
| *** ttsiouts has joined #openstack-sdks | 08:02 | |
| *** markvoelker has quit IRC | 08:05 | |
| *** adriant has joined #openstack-sdks | 08:18 | |
| *** e0ne has joined #openstack-sdks | 08:32 | |
| *** ttsiouts has quit IRC | 09:01 | |
| *** ttsiouts has joined #openstack-sdks | 09:02 | |
| *** ttsiouts has quit IRC | 09:06 | |
| *** mugsie_ is now known as mugsie | 09:52 | |
| *** markvoelker has joined #openstack-sdks | 10:02 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server https://review.opendev.org/662998 | 10:15 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for the compute Hypervsors and Images https://review.opendev.org/662743 | 10:16 |
| *** cdent has joined #openstack-sdks | 10:27 | |
| *** slaweq has quit IRC | 10:30 | |
| *** markvoelker has quit IRC | 10:36 | |
| *** gtema has quit IRC | 10:43 | |
| *** gtema_ has joined #openstack-sdks | 10:43 | |
| *** gtema_ is now known as gtema | 10:43 | |
| *** slaweq has joined #openstack-sdks | 11:00 | |
| *** ttsiouts has joined #openstack-sdks | 11:22 | |
| *** holser_ is now known as holser|lunch | 11:26 | |
| *** ttsiouts has quit IRC | 11:33 | |
| *** markvoelker has joined #openstack-sdks | 11:33 | |
| *** ttsiouts has joined #openstack-sdks | 11:34 | |
| *** jpena is now known as jpena|lunch | 11:34 | |
| *** ttsiouts_ has joined #openstack-sdks | 11:37 | |
| *** dave-mccowan has joined #openstack-sdks | 11:37 | |
| *** ttsiouts has quit IRC | 11:38 | |
| *** yolanda has quit IRC | 11:44 | |
| *** holser|lunch is now known as holser_ | 11:49 | |
| *** cdent has quit IRC | 11:54 | |
| *** markvoelker has quit IRC | 12:05 | |
| *** mugsie is now known as mugsie_ | 12:18 | |
| *** mugsie_ is now known as mugsie | 12:18 | |
| *** gtema has quit IRC | 12:19 | |
| *** jpena|lunch is now known as jpena | 12:32 | |
| *** gtema has joined #openstack-sdks | 12:48 | |
| *** cdent has joined #openstack-sdks | 12:48 | |
| *** Luzi has joined #openstack-sdks | 13:00 | |
| *** ttsiouts_ has quit IRC | 13:10 | |
| *** ttsiouts has joined #openstack-sdks | 13:11 | |
| *** Luzi has quit IRC | 13:13 | |
| *** ttsiouts has quit IRC | 13:15 | |
| *** holser_ has quit IRC | 13:24 | |
| *** holser_ has joined #openstack-sdks | 13:25 | |
| *** ttsiouts has joined #openstack-sdks | 13:26 | |
| *** holser_ has quit IRC | 13:31 | |
| *** holser_ has joined #openstack-sdks | 13:32 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make factory for a CloudRegion from CONF objects https://review.opendev.org/643601 | 13:36 |
| mordred | gtema, Shrews, dtantsur, slaweq: ^^ is ready for review when y'all get a spare minute. this is the needed feature for shifting nova to sdk and off of python-*client | 13:37 |
| mordred | efried: I just added a release note in that latest patchset - tests look great, thanks! | 13:37 |
| efried | mordred: Nice. What more to get it merged? | 13:37 |
| mordred | efried: just need to convince people to review it now :) | 13:38 |
| *** cdent has quit IRC | 13:38 | |
| efried | oh, I see previous alert | 13:38 |
| efried | yes, cool. | 13:38 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support Proxy-specific region_name https://review.opendev.org/662865 | 13:38 |
| gtema | ok, got it | 13:38 |
| efried | mordred: region_name thing sane enough to fly, you think? | 13:38 |
| gtema | yeah, was looking at both today morning. Looked ok for me. If mordred also thinks ok - great | 13:39 |
| mordred | efried: reading that now | 13:40 |
| efried | mordred: One tweak in the reno, I'll fix that up quick if you agree. | 13:41 |
| mordred | efried: I'm sure I do - looking | 13:41 |
| efried | I mean, yes, you're using the CloudRegion to create a Connection, not sure if a CloudRegion is good for anything else, so maybe this is a distinction without a difference. | 13:42 |
| mordred | efried: yes. also - maybe it should be Connection or CloudRegion - because while you're right the primary thing is the CloudRegion- we also added a parameter to the Connection contructor | 13:42 |
| mordred | who knows what people are using CloudRegions for :) | 13:43 |
| efried | oh, sorry, you're right. Forest for the trees and all that. The primary use case would be Connection I guess, wouldn't it. | 13:44 |
| mordred | yeah. I could go either way ... | 13:45 |
| mordred | efried: what does "ddt this" mean? | 13:45 |
| efried | I'll leave it alone, since we've got gtema's +2 now :) | 13:45 |
| gtema | I can put another one - no problem | 13:46 |
| mordred | :) | 13:46 |
| efried | mordred: ddt does the same thing as testscenarios | 13:46 |
| mordred | ah. is it more pleasant to use? | 13:46 |
| gtema | but guys, what have you done with "/os-server-groups" with respect to microversions - all the finest things at once | 13:46 |
| efried | mordred: That's probably in the eye of the beholder. Let me dig up an example quick... | 13:47 |
| efried | mordred: I don't know if testscenarios works on a per-method basis; ddt does. | 13:47 |
| mordred | efried: cool - I like testscenarios - but I always have to go look at previous code I wrote to figure out how to use it | 13:47 |
| mordred | ah - no - testscenarios is purely class based | 13:47 |
| efried | ditto ddt | 13:47 |
| gtema | ++ - same for me | 13:47 |
| mordred | I like the concept of putting test data into a file too | 13:48 |
| efried | mordred: https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/test_nova_manage.py#L1339 | 13:49 |
| efried | The data gets passed to the method as params | 13:49 |
| mordred | I like that | 13:49 |
| mordred | that's nicer than class attributes, which I think is a bit too magical | 13:50 |
| * mordred has learned something today | 13:50 | |
| efried | vs testscenarios where they're instance vars, but of course that difference makes sense when it's per-test | 13:50 |
| *** holser_ has quit IRC | 13:50 | |
| efried | yeah, but it would be just as magical if they were method params, set up from the class level, wouldn't it? | 13:51 |
| efried | like using a @mock.patch decorator on your class, all your methods now get a new param. | 13:51 |
| mordred | oh - I don't think I've ever used mock.patch on a class :) | 13:51 |
| mordred | I guess I like that in ddt the magic is localized to the method you're looking at ... but yeah, still some magic | 13:52 |
| *** holser_ has joined #openstack-sdks | 13:52 | |
| efried | I usually don't (use mock.patch on a class). If I need it to apply to all my tests, I'll useFixture(fixtures.MockPatch()) in setUp - and if I need the mock, I'll create an instance attribute :) | 13:52 |
| mordred | I *really* like the file_data - I've done a few testscenarios with a BUNCH of scenarios and it quickly becomes hard to read | 13:52 |
| efried | ^ manual testscenarios :) | 13:52 |
| mordred | ++ to useFixture in setUp | 13:53 |
| *** holser_ has joined #openstack-sdks | 13:53 | |
| * efried experiences kumbaya moment on python test philosophy | 13:53 | |
| * mordred hands efried the bong | 13:54 | |
| efried | ahem, "guitar" | 13:54 |
| mordred | yes yes. "guitar". sorry | 13:54 |
| efried | but the point of the comment was: dedup this repetitive code | 13:55 |
| efried | I don't care if it's ddt or testscenarios or a helper method, whatevs. | 13:55 |
| mordred | ++ | 14:00 |
| *** cdent has joined #openstack-sdks | 14:02 | |
| openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Get rid of unused _OpenStackCloudMixin.get_region https://review.opendev.org/663038 | 14:05 |
| *** ITD27M01 has quit IRC | 14:12 | |
| gtema | mordred: I forgot a bit about ver discovery. In the service catalog endpoint contains project_id at the end, but version info is available under compute/v2.1 | 14:20 |
| gtema | the proxy is not able to discover supported microversion | 14:20 |
| mordred | gtema: version discovery should be able to handle project_id at the end of endpoint | 14:21 |
| gtema | well, in the small script it is not working properly | 14:21 |
| *** zbr has quit IRC | 14:21 | |
| gtema | wait a sec, posting | 14:22 |
| *** zbr has joined #openstack-sdks | 14:23 | |
| gtema | mordred: http://paste.openstack.org/show/752487/ | 14:24 |
| mordred | oh - you have a broken compute endpoint. it's requiring auth for version discovery | 14:24 |
| mordred | see that first GET with the 401 | 14:25 |
| gtema | oh, indeed | 14:25 |
| mordred | I think we've got it written down somewhere that people should not auth-protect service version discovery - I don't remember where though | 14:26 |
| efried | I remember this ^ but not sure if it's written | 14:26 |
| gtema | hmm, ok then. Will start alerting internally on all available channels | 14:26 |
| efried | It's written in IRC :) | 14:27 |
| mordred | efried: :) | 14:27 |
| gtema | life is great ;-/ | 14:27 |
| mordred | gtema: let me know if I can be helpful in corroborating that this should not be auth-protected. | 14:28 |
| mordred | s/should/must/ | 14:28 |
| gtema | we probably should add it into https://opendev.org/openstack/api-sig/src/branch/master/guidelines/microversion_specification.rst | 14:29 |
| mordred | gtema: yah. it's possible it's mentioned in https://review.opendev.org/#/c/459405/ - looking | 14:31 |
| efried | ++. I was looking for it in the keystoneauth docs, but that's the consuming side, so probably not the right place anyway. | 14:31 |
| mordred | https://review.opendev.org/#/c/459405/ | 14:32 |
| mordred | https://review.opendev.org/#/c/459710/17/guidelines/discoverability.rst@93 | 14:32 |
| gtema | hmm, 'it is recommended' is confusing. It is definitely not working at all otherwise | 14:33 |
| efried | it's possible to make it work, I suppose. "strongly recommended"? ;P | 14:35 |
| gtema | :D | 14:35 |
| gtema | as a consumer I doubt you will make it work. If we bake it in - sure | 14:36 |
| mordred | yeah - we should probably change that to be stronger | 14:37 |
| mordred | it's unpossible to make it work with the official openstack libraries or any of the tools. obviously you could make it work with direct REST calls ... | 14:38 |
| gtema | I guess it is either stricktly required, or possible otherwise (not as of now) | 14:38 |
| gtema | so yeah - exactly what I mean | 14:38 |
| mordred | ++ | 14:38 |
| mordred | it's also not a thing we can update keystoneauth to handle reasonably - it would take basically a full rewrite IIRC | 14:39 |
| gtema | ok. Sad, means cloud is still cloudy, but that is how it is | 14:39 |
| mordred | :( - sorry about that | 14:40 |
| gtema | another question for the same topic. Some stuff require 'min' version. Do we have something to pick the proper version out of it (not sticking for this min if current is better)? | 14:41 |
| mordred | we should really add a tempest test and get refstack to require that it works properly | 14:41 |
| gtema | that is a cool idea | 14:41 |
| efried | ++ | 14:41 |
| mordred | gtema: dtantsur added some stuff to the resource layer for specifying microversions needed for things - | 14:43 |
| mordred | there's also https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/compute/v2/server.py#L421 | 14:43 |
| mordred | how we're doing it for live migrations | 14:43 |
| mordred | there should probably be some sort of helper pattern extracted from that, because that's super manual | 14:44 |
| gtema | the question is basically coming from: /servers/.../createImage returns image_id only after 2.45. And do not want to simply say - use 2.45 here. I would like to treat microver as a "num" | 14:44 |
| gtema | to get the newest | 14:44 |
| mordred | I think what the current resource microversion stuff is saying is "This resource knows how to handle microversions as new as 2.45" - because just doing latest could mean semantic changes that the resource can't handle | 14:46 |
| mordred | then, in the code, if we wanted to make image_id part of our API all the time, we might need to make an extra call if the cloud is older than 2.45, yeah? | 14:47 |
| gtema | yeah, for server-group it is slightly more complicated - until 2.63 there is attr 'policies' | 14:47 |
| gtema | after 2.64 it is 'policy' and a single only | 14:47 |
| mordred | *awesome* | 14:48 |
| mordred | can there be more than one policy in the list until 2.63? or is it a list that happened to only ever have one policy in it? | 14:48 |
| gtema | so I need to somehow check - do we support max something older - than do one cool thing. If we support something newer than 2.64 - do other cool thing | 14:48 |
| gtema | nope, should not be | 14:49 |
| gtema | stated in docs - list with strictly one entity | 14:49 |
| mordred | so - we could conceivably support both in all cases and just map it differently depending on what we get back from the remote side | 14:49 |
| mordred | so have server_group.policy and server_group.polices - or we could just pick one and map in that direction regardless of server-side | 14:50 |
| gtema | yes, but depending on what is the max supported version I need to hack "create" | 14:50 |
| mordred | but yeah - this is where everything gets tricky :) | 14:50 |
| gtema | and if with following microvers new features will come - it will become even better | 14:50 |
| mordred | yah | 14:51 |
| gtema | (will add) | 14:51 |
| gtema | so we need really to treat microvers as numbers | 14:51 |
| efried | does microversion_parse help here? | 14:53 |
| gtema | efried: which one? | 14:54 |
| efried | treating microversions as numbers | 14:54 |
| efried | I'm probably not following closely enough to be useful here, sorry. | 14:55 |
| efried | "treat microversions as numbers" => has to be a tuple, not a float, of course. Else 1.23 < 1.4 | 14:55 |
| efried | ksa has a crap-ton of code dealing with this. | 14:55 |
| gtema | really? have not seen so far | 14:56 |
| gtema | need to admit was not even looking deeply | 14:56 |
| gtema | aha discover.normalize_version_number returns tuple | 14:56 |
| mordred | yah. there's also some methods in discover for comparing versions | 15:00 |
| gtema | cool, thks | 15:00 |
| *** ttsiouts has quit IRC | 15:04 | |
| *** ttsiouts has joined #openstack-sdks | 15:05 | |
| *** AJaeger has joined #openstack-sdks | 15:06 | |
| AJaeger | openstackclient cores, please review https://review.opendev.org/#/c/661947/3 and https://review.opendev.org/#/c/661974/ to update your docs Sphinx to pass checks again | 15:07 |
| *** ttsiouts has quit IRC | 15:09 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for next compute methods https://review.opendev.org/663064 | 15:21 |
| openstackgerrit | Merged openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947 | 15:21 |
| openstackgerrit | Merged openstack/openstackclient master: Switch to openstackdocstheme https://review.opendev.org/661974 | 15:21 |
| mordred | AJaeger: done! | 15:22 |
| AJaeger | thanks, mordred ! | 15:22 |
| openstackgerrit | Andreas Jaeger proposed openstack/openstackclient master: Dropping the py35 testing https://review.opendev.org/654658 | 15:24 |
| AJaeger | mordred: one more, please ^ | 15:24 |
| *** AJaeger has left #openstack-sdks | 15:27 | |
| *** e0ne has quit IRC | 15:32 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server https://review.opendev.org/662998 | 15:35 |
| gtema | mordred: is it ok from your pov not to check presence of both 'ephemeral' and 'OS-FLV-EXT-DATA:ephemeral' for flavors in func tests? | 15:42 |
| gtema | in resource we have ephemeral=OS-FLV-EXT-DATA:ephemeral | 15:42 |
| gtema | but func test expects both | 15:42 |
| gtema | for https://review.opendev.org/#/c/650903/ | 15:42 |
| *** gtema has quit IRC | 16:10 | |
| *** dtantsur is now known as dtantsur|afk | 16:11 | |
| *** holser_ has quit IRC | 16:23 | |
| *** holser_ has joined #openstack-sdks | 16:23 | |
| *** jangutter has quit IRC | 16:27 | |
| *** cdent has quit IRC | 16:29 | |
| *** jpich has quit IRC | 16:32 | |
| *** jpena is now known as jpena|off | 17:09 | |
| *** adriant has quit IRC | 17:20 | |
| *** whoami-rajat has quit IRC | 17:24 | |
| *** holser_ has quit IRC | 17:31 | |
| *** holser_ has joined #openstack-sdks | 17:32 | |
| *** holser_ has quit IRC | 17:37 | |
| *** ricolin has joined #openstack-sdks | 17:38 | |
| *** adriant has joined #openstack-sdks | 17:50 | |
| *** whoami-rajat has joined #openstack-sdks | 18:26 | |
| *** e0ne has joined #openstack-sdks | 18:54 | |
| *** e0ne has quit IRC | 18:55 | |
| *** ricolin has quit IRC | 19:10 | |
| *** cdent has joined #openstack-sdks | 19:20 | |
| *** e0ne has joined #openstack-sdks | 19:29 | |
| *** e0ne has quit IRC | 19:30 | |
| *** altlogbot_2 has joined #openstack-sdks | 19:40 | |
| *** slaweq has quit IRC | 19:43 | |
| *** slaweq has joined #openstack-sdks | 19:44 | |
| *** dave-mccowan has quit IRC | 19:55 | |
| *** dave-mccowan has joined #openstack-sdks | 20:01 | |
| openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add a handler for unknown HTTP errors https://review.opendev.org/663132 | 20:07 |
| *** e0ne has joined #openstack-sdks | 20:23 | |
| *** dave-mccowan has quit IRC | 20:27 | |
| *** e0ne has quit IRC | 20:41 | |
| *** e0ne has joined #openstack-sdks | 20:42 | |
| *** e0ne has quit IRC | 20:43 | |
| *** whoami-rajat has quit IRC | 20:54 | |
| *** cdent has quit IRC | 20:55 | |
| *** Qiming has quit IRC | 21:11 | |
| *** Qiming has joined #openstack-sdks | 21:14 | |
| *** slaweq has quit IRC | 22:07 | |
| *** slaweq has joined #openstack-sdks | 22:11 | |
| *** slaweq has quit IRC | 22:24 | |
| *** slaweq has joined #openstack-sdks | 22:34 | |
| *** dave-mccowan has joined #openstack-sdks | 22:44 | |
| *** slaweq has quit IRC | 22:47 | |
| *** dave-mccowan has quit IRC | 22:56 | |
| *** dave-mccowan has joined #openstack-sdks | 22:57 | |
| *** slaweq has joined #openstack-sdks | 23:04 | |
| *** slaweq has quit IRC | 23:17 | |
| *** slaweq has joined #openstack-sdks | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!