Thursday, 2019-05-23

*** ttsiouts has joined #openstack-sdks00:10
*** ttsiouts has quit IRC00:16
*** ttsiouts has joined #openstack-sdks00:45
*** markvoelker has joined #openstack-sdks00:50
*** slaweq has joined #openstack-sdks00:57
*** slaweq has quit IRC01:01
*** ttsiouts has quit IRC01:18
*** whoami-rajat has joined #openstack-sdks01:31
*** ricolin has joined #openstack-sdks01:36
*** slaweq has joined #openstack-sdks02:11
*** slaweq has quit IRC02:15
*** edleafe has quit IRC02:26
*** irclogbot_1 has quit IRC02:26
*** irclogbot_0 has joined #openstack-sdks02:30
*** ttsiouts has joined #openstack-sdks02:30
openstackgerritBrin Zhang proposed openstack/python-openstackclient master: Add changes-before attribute to server list  https://review.opendev.org/65737302:36
*** bobh has joined #openstack-sdks02:39
*** ttsiouts has quit IRC03:04
*** bobh has quit IRC03:12
*** samueldmq has quit IRC03:50
*** ttsiouts has joined #openstack-sdks04:09
*** slaweq has joined #openstack-sdks04:11
*** slaweq has quit IRC04:16
openstackgerritMerged openstack/osc-lib master: Final switch to stestr  https://review.opendev.org/66081504:37
*** ttsiouts has quit IRC04:43
*** ttsiouts has joined #openstack-sdks05:12
*** ttsiouts has quit IRC05:16
*** zbr has joined #openstack-sdks05:35
*** ttsiouts has joined #openstack-sdks05:49
*** slaweq has joined #openstack-sdks05:59
openstackgerritChinmay Naik proposed openstack/keystoneauth master: Resolves a typo in a link to use Application Credentials  https://review.opendev.org/66088606:00
*** Luzi has joined #openstack-sdks06:02
*** slaweq has quit IRC06:03
*** slaweq has joined #openstack-sdks06:11
*** ttsiouts has quit IRC06:23
openstackgerritzhulingjie proposed openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs  https://review.opendev.org/65501606:38
*** markvoelker has quit IRC07:03
*** markvoelker has joined #openstack-sdks07:03
*** markvoelker has quit IRC07:08
openstackgerritZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option  https://review.opendev.org/65751907:24
*** dhellmann_ has joined #openstack-sdks07:25
*** dhellmann has quit IRC07:26
*** dhellmann_ is now known as dhellmann07:29
*** ttsiouts has joined #openstack-sdks07:29
*** e0ne has joined #openstack-sdks07:31
*** tosky has joined #openstack-sdks07:32
openstackgerritZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option  https://review.opendev.org/65751907:43
*** jpena|off is now known as jpena07:45
*** tssurya has joined #openstack-sdks07:46
*** gtema has joined #openstack-sdks07:48
*** holser_ has joined #openstack-sdks07:49
*** tosky has quit IRC07:55
*** tosky has joined #openstack-sdks07:55
*** ralonsoh has joined #openstack-sdks08:04
*** tssurya has quit IRC08:05
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting  https://review.opendev.org/65984108:08
dtantsurmordred, gtema, 2x +2, anything blocking approval? https://review.opendev.org/#/c/660578/08:17
gtema:) - done08:18
dtantsurthx!08:18
*** ttsiouts has quit IRC08:32
openstackgerritMerged openstack/osc-lib master: Dropping the py35 testing  https://review.opendev.org/65465908:37
*** jangutter has joined #openstack-sdks08:54
*** ttsiouts has joined #openstack-sdks09:03
*** markvoelker has joined #openstack-sdks09:04
*** gtema has quit IRC09:15
*** ricolin has quit IRC09:15
*** gtema has joined #openstack-sdks09:16
*** ttsiouts has quit IRC09:37
*** markvoelker has quit IRC09:38
openstackgerritVishakha Agarwal proposed openstack/keystoneauth master: Bump bandit version and cap sphinx  https://review.opendev.org/66095609:44
openstackgerritMerged openstack/openstacksdk master: baremetal: allow updating name and extra fields of an allocation  https://review.opendev.org/66057809:55
*** cdent has joined #openstack-sdks10:03
openstackgerritMerged openstack/openstacksdk master: Add support for vendor hooks  https://review.opendev.org/65784810:11
openstackgerritMerged openstack/openstacksdk master: Add ability to provide qos_policy_id for port  https://review.opendev.org/66068010:21
*** holser_ is now known as holser|lunch10:33
*** markvoelker has joined #openstack-sdks10:35
*** ttsiouts has joined #openstack-sdks10:40
*** gtema has quit IRC10:57
*** gtema has joined #openstack-sdks10:58
*** ttsiouts has quit IRC10:59
*** ttsiouts has joined #openstack-sdks11:00
*** jpena is now known as jpena|lunch11:01
*** markvoelker has quit IRC11:08
*** ttsiouts has quit IRC11:14
*** dave-mccowan has joined #openstack-sdks11:26
*** bobh has joined #openstack-sdks11:47
openstackgerritSurya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock  https://review.opendev.org/65912411:58
*** markvoelker has joined #openstack-sdks11:59
*** tosky has quit IRC12:01
*** tosky has joined #openstack-sdks12:03
*** tosky__ has joined #openstack-sdks12:08
*** tosky has quit IRC12:11
*** edleafe has joined #openstack-sdks12:16
*** gtema has quit IRC12:17
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command  https://review.opendev.org/64357812:26
*** ttsiouts has joined #openstack-sdks12:28
*** jpena|lunch is now known as jpena12:30
*** tosky has joined #openstack-sdks12:33
*** tosky__ has quit IRC12:36
*** tosky__ has joined #openstack-sdks12:38
*** tosky has quit IRC12:40
*** tosky__ is now known as tosky12:40
*** gtema has joined #openstack-sdks12:47
*** bobh has quit IRC12:49
*** Luzi has quit IRC12:54
*** e0ne has quit IRC12:57
*** ttsiouts has quit IRC12:58
*** holser|lunch is now known as holser_13:07
*** dave-mccowan has quit IRC13:12
*** dave-mccowan has joined #openstack-sdks13:13
*** gtema has quit IRC13:27
*** samueldmq has joined #openstack-sdks13:36
*** ricolin has joined #openstack-sdks13:49
*** yolanda__ has joined #openstack-sdks14:02
*** ttsiouts has joined #openstack-sdks14:02
*** yolanda__ is now known as yolanda14:03
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Make 'destination' optional for live migration  https://review.opendev.org/62694914:16
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server resurrect' command  https://review.opendev.org/64357814:29
*** gtema has joined #openstack-sdks14:32
*** ttsiouts has quit IRC14:36
*** dave-mccowan has quit IRC14:52
*** dave-mccowan has joined #openstack-sdks14:52
openstackgerritMatt Riedemann proposed openstack/python-openstackclient master: Compute: Add user id support for keypair  https://review.opendev.org/57650714:52
*** ttsiouts has joined #openstack-sdks15:43
*** ttsiouts has quit IRC15:45
*** ttsiouts has joined #openstack-sdks15:46
openstackgerritSergii Golovatiuk proposed openstack/openstacksdk master: Log OpenStackCloudResourceNotFound exceptions  https://review.opendev.org/63716915:46
*** whoami-rajat has quit IRC15:50
edleafeWow! Time for another API-SIG Office Hour!!16:00
cdentI wonder if the api-sig saw the discussion between me and cmurphy about the errors guideline?16:03
* cdent looks for link16:03
cdentthis thread: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006377.html16:03
cdentand colleen's comments: http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006425.html16:04
elmikoo/16:05
edleafeI saw it, but I wasn't around for any of the original discussions, so I can't add much16:05
edleafeelmiko: you +W'd that change - any impressions?16:11
*** gtema has quit IRC16:13
elmikoi'm reading now16:14
* cdent must go vote16:14
cdentbut if you've got stuff to say please add to the thread16:14
*** cdent has quit IRC16:15
*** ttsiouts has quit IRC16:16
elmikoi'm really not sure how to respond to colleen's question16:17
elmikoi mean, having a list of errors seemed like a good idea at the time because more than one could be returned16:17
elmikoi think it was also inspired by prior art within the openstack community16:17
edleafeAre you aware of any other API that does anything similar?16:17
edleafejinxish16:17
elmikoi vaguely recall at the time we had examples of others doing it that way16:23
*** logan- has joined #openstack-sdks16:24
elmikoafter looking around, maybe we just need to revisit that guideline?16:28
elmikoi don't remember how we arrived at that, and i can't seem to find the reference materials16:29
edleafeI don't understand the confusion surrounding this. Wouldn't a developer *want* to know about all the errors that happened? Usually the last error isn't the genesis of the problem.16:31
elmikoright, and that goes in line with our thinking about having a possible list of errors16:32
logan-hello! in a vendor config, is there a way to specify that a certain provider network is only available in a certain list of regions? I'm asking because https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/config/vendors/limestonenetworks.json#L22 is only available in the us-dfw-1 region. We had a user receiving errors when trying to schedule nodes in the us-slc region related to this network.16:38
logan-the error was: http://paste.openstack.org/show/751177/, and it was worked around with a config for nodepool-launcher to exclude this network: https://github.com/ansible-network/windmill-config/pull/437/files16:38
mordredlogan-: yes - all of the settings that you can make can be tied to a region16:39
mordredlogan-: let me find you an example16:39
mordredlogan-: https://docs.openstack.org/openstacksdk/latest/user/config/configuration.html#per-region-settings16:41
mordredlogan-: the regions list can also be a list of dicts16:41
elmikoedleafe: i need to fix an issue with my emails to the list, then i will respond to colleen16:41
logan-thanks mordred16:41
edleafeelmiko: thx16:41
*** zbr has quit IRC16:45
*** ttsiouts has joined #openstack-sdks16:48
*** whoami-rajat has joined #openstack-sdks16:51
*** ttsiouts has quit IRC16:53
*** dtantsur is now known as dtantsur|afk16:54
*** ricolin has quit IRC16:55
elmikotake care edleafe, have a nice holiday weekend =)17:00
edleafeI shall! You too!17:03
*** tosky has quit IRC17:08
*** tosky has joined #openstack-sdks17:12
*** jpena is now known as jpena|off17:19
*** tosky has quit IRC17:22
*** tosky__ has joined #openstack-sdks17:23
*** ttsiouts has joined #openstack-sdks17:26
*** e0ne has joined #openstack-sdks17:29
openstackgerritLogan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config  https://review.opendev.org/66106317:44
*** holser_ is now known as holser|eod17:44
openstackgerritLogan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config  https://review.opendev.org/66106317:45
openstackgerritLogan V proposed openstack/openstacksdk master: Update Limestone Networks vendor config  https://review.opendev.org/66106317:45
*** ralonsoh has quit IRC17:51
*** ttsiouts has quit IRC17:59
*** holser|eod has quit IRC18:08
*** e0ne has quit IRC18:53
*** e0ne has joined #openstack-sdks18:54
*** ttsiouts has joined #openstack-sdks19:09
*** e0ne has quit IRC19:39
*** ttsiouts has quit IRC19:42
*** tosky__ is now known as tosky20:18
*** whoami-rajat has quit IRC20:31
cmurphyedleafe: elmiko cdent my issue is that if more than one error is returned, eg if nova fails because glance fails, I don't think it's the user's business to know what happened on the backend, it could even leak sensitive information, so it should just be nova's job to capture the error and reformat it as one error for the user, the operator has logs to see what really happened on the backend20:34
*** slaweq has quit IRC20:41
mordredcmurphy, edleafe, elmiko: it can be confusing as well - because those errors are not actionable. I know we've gotten that at times in Infra - an error booting a node because there was some issue between nova and glance that had nothing to do with our boot command or the image contents20:49
mordredso it tells us "blah blah cna't find /dev/xx05a blah blah ceph blah" - and it's both scary and makes us try to troubleshoot why we were trying to do something with ceph - and it turns out we're not we're just trying to boot a vm20:49
edleafecmurphy: I don't think that you should ever return internal details in a user-facing API, whether it's a single message or multiple. Your example of glance-level errors should only be on admin APIs20:50
mordrededleafe: should and are have so many differences20:50
mordrededleafe: (but I agree with you)20:50
edleafemordred: Guidelines are for "should"20:50
edleafe:)20:50
mordrededleafe: life is friendly in should20:51
edleafecmurphy: But to get back to your point: error messages and details should be informative. Packing every known bit of data in an error messages is just as bad as not including enough20:52
*** slaweq has joined #openstack-sdks20:52
edleafecmurphy: So if there are more than one relevant bits of information about the error, they should be included, not just one of them20:53
edleafeThe guideline is more about how to handle multiple bits of information. It doesn't require that you include more than one, though20:53
*** ttsiouts has joined #openstack-sdks20:56
*** slaweq has quit IRC20:57
*** ttsiouts has quit IRC21:26
elmikocmurphy: i don't think the intent was for a single service to bubble out errors from other services. i had always thought of it as a single service emitting multiple errors to a single call.21:41
*** bobh has joined #openstack-sdks21:42
*** ttsiouts has joined #openstack-sdks21:42
elmikoand i agree with edleafe re: the api not /requiring/ more than one21:42
*** bobh has quit IRC21:45
*** tosky has quit IRC23:05
openstackgerritMatt Riedemann proposed openstack/python-openstackclient master: WIP: Deprecate openstack server migrate --host option  https://review.opendev.org/65938223:30
*** ttsiouts has quit IRC23:42
*** ttsiouts has joined #openstack-sdks23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!