*** ttsiouts has quit IRC | 00:06 | |
*** slaweq has joined #openstack-sdks | 00:11 | |
*** slaweq has quit IRC | 00:24 | |
*** slaweq has joined #openstack-sdks | 01:16 | |
*** slaweq has quit IRC | 01:24 | |
*** cdent has quit IRC | 01:40 | |
*** slaweq has joined #openstack-sdks | 02:11 | |
*** ricolin has joined #openstack-sdks | 02:23 | |
*** slaweq has quit IRC | 02:24 | |
*** ttsiouts has joined #openstack-sdks | 02:39 | |
*** ttsiouts has quit IRC | 02:44 | |
*** whoami-rajat has joined #openstack-sdks | 03:02 | |
*** slaweq has joined #openstack-sdks | 03:12 | |
*** slaweq has quit IRC | 03:24 | |
adriant | mordred: I'm having some really really weird issues with using the SDK to talk to our octavia | 04:07 |
---|---|---|
johnsom | adriant: how so? | 04:07 |
adriant | a script that used to work, now doesn't seem to (for reasons I can't figure out) and even downgrading, or upgrading SDK or keystone auth versions does nothing | 04:07 |
adriant | http://paste.openstack.org/show/751055/ | 04:08 |
adriant | johnsom: see error | 04:08 |
adriant | i'm not sure if octavia is screwed and should be returning links to version urls, or if it never did | 04:08 |
johnsom | Octavia had the links, what version of Octavia API are you using? Very old versions didn’t have links, but the newer version does. Sdk accounted for this. | 04:11 |
*** slaweq has joined #openstack-sdks | 04:12 | |
adriant | johnsom: we are running Queens, Octavia, which I thought had links? | 04:17 |
adriant | at least from looking at the code | 04:17 |
adriant | https://github.com/openstack/octavia/blame/master/octavia/api/root_controller.py#L56 | 04:18 |
johnsom | adriant: 2.0.3 fixed the links issue. If you are running an older version of queens I highly recommend you update to the current queens version. | 04:18 |
johnsom | Current is 2.1.0 fyi | 04:19 |
adriant | I'm just curious why this 'used' to work | 04:20 |
adriant | and now doesn't | 04:21 |
adriant | we haven't upgraded octavia for a while, and I'm fairly sure the tools we had that used the SDK to talk to it, did used to work as recently as a month or two back :( | 04:21 |
johnsom | Yeah, I don’t have an answer for that. Octavia hasn’t touched the links code in a while so not likely the issue. | 04:21 |
adriant | weird :/ | 04:23 |
*** slaweq has quit IRC | 04:24 | |
adriant | johnsom: so looks like weird running a version that doesn't include links... | 04:32 |
adriant | but then why did the SDK used to work? | 04:32 |
adriant | was it updated to only expect links, or did it ever handle the non-link case? | 04:32 |
johnsom | Yeah, older versions compensated for that | 04:32 |
adriant | hmmm | 04:33 |
johnsom | I can’t speak for the sdk as I don’t track it closely. I can only talk to what we did in Octavia. | 04:34 |
adriant | any reason why it isn't capable of both cases? | 04:34 |
*** cdent has joined #openstack-sdks | 04:34 | |
adriant | although I guess that's a mordred question | 04:34 |
adriant | because it's an annoying bit of backward incompatibility :( | 04:34 |
johnsom | Yeah, we fixed it in Octavia as soon as it was raised that we had an issue/bug. | 04:35 |
adriant | we plan to upgrade octavia to stein soon anyway, but still awkward | 04:35 |
johnsom | Yeah, even a queen update would probably fix you up. | 04:35 |
adriant | meanwhile I'm going to just find an old version of the SDK that still works I guess | 04:36 |
johnsom | Ok. Sorry for the trouble! | 04:36 |
adriant | I'm just curious why this code every worked... | 04:38 |
adriant | ever* | 04:38 |
adriant | and downgrading the SDK gets me a different error! :P | 04:41 |
adriant | "UnboundLocalError: local variable 'api_version' referenced before assignment" | 04:41 |
* adriant cries | 04:41 | |
* cdent passes adriant a tissue | 04:42 | |
adriant | ty cdent | 04:43 |
adriant | well ok, I just can't make the SDK talk to Octavia :/ | 04:49 |
adriant | actually, johnsom, when did you add version discovery at all to Octavia? | 04:55 |
adriant | nvm, looked at the repo | 04:56 |
adriant | ages ago | 04:56 |
adriant | hmmm | 04:56 |
johnsom | Yeah, a long time ago | 04:58 |
*** cdent has quit IRC | 05:09 | |
*** slaweq has joined #openstack-sdks | 05:12 | |
adriant | I give up, I'll rewrite this code to use the octavia client tomorrow... | 05:20 |
adriant | if anyone has alternative ideas for me when I look at IRC tomorrow, I'd be happy to try them. | 05:20 |
*** slaweq has quit IRC | 05:24 | |
*** dims has quit IRC | 05:32 | |
*** dims has joined #openstack-sdks | 05:33 | |
*** ricolin_ has joined #openstack-sdks | 06:12 | |
*** ricolin has quit IRC | 06:12 | |
*** dims has quit IRC | 06:16 | |
*** slaweq has joined #openstack-sdks | 06:17 | |
adriant | HAH! 0.17.2 works! | 06:21 |
* adriant wonders why he's still here | 06:21 | |
adriant | so yeah, mordred, I'd call this a regression bug. SDK ought to work with older octavia despite the lack of links in the version listing. | 06:27 |
*** ricolin_ has quit IRC | 06:27 | |
*** yolanda_ has joined #openstack-sdks | 06:31 | |
*** slaweq has quit IRC | 06:32 | |
*** ttsiouts has joined #openstack-sdks | 06:34 | |
*** dims has joined #openstack-sdks | 06:42 | |
*** slaweq has joined #openstack-sdks | 06:42 | |
*** gtema has joined #openstack-sdks | 06:44 | |
*** dims has quit IRC | 06:49 | |
*** dims has joined #openstack-sdks | 06:54 | |
*** ralonsoh has joined #openstack-sdks | 07:29 | |
*** ttsiouts has quit IRC | 07:33 | |
*** Luzi has joined #openstack-sdks | 07:47 | |
*** noama has joined #openstack-sdks | 07:51 | |
*** jpich has joined #openstack-sdks | 07:54 | |
*** jpena|off is now known as jpena | 07:59 | |
openstackgerrit | Witold Bedyk proposed openstack/python-openstackclient master: document the --timing option https://review.opendev.org/657640 | 08:18 |
*** holser_ has joined #openstack-sdks | 08:31 | |
*** ttsiouts has joined #openstack-sdks | 09:06 | |
*** ttsiouts has quit IRC | 09:11 | |
*** holser_ is now known as holser|lunch | 10:15 | |
*** zbr|pto has quit IRC | 10:42 | |
*** ttsiouts has joined #openstack-sdks | 10:46 | |
*** ttsiouts has quit IRC | 10:50 | |
*** gtema has quit IRC | 11:19 | |
*** gtema has joined #openstack-sdks | 11:19 | |
*** holser|lunch is now known as holser_ | 11:27 | |
*** jpena is now known as jpena|lunch | 11:31 | |
*** jpich has quit IRC | 11:47 | |
*** jpich has joined #openstack-sdks | 11:48 | |
*** bobh has joined #openstack-sdks | 11:57 | |
*** bobh has quit IRC | 12:02 | |
*** mgariepy has quit IRC | 12:11 | |
*** mgariepy has joined #openstack-sdks | 12:21 | |
*** gtema has quit IRC | 12:25 | |
*** mgariepy has quit IRC | 12:29 | |
*** jpena|lunch is now known as jpena | 12:31 | |
*** ttsiouts has joined #openstack-sdks | 12:32 | |
*** mgariepy has joined #openstack-sdks | 12:34 | |
*** ttsiouts has quit IRC | 12:53 | |
*** noama has quit IRC | 12:57 | |
*** mgariepy has quit IRC | 12:58 | |
mordred | adriant: yeah - i agree - let's see if we can't figure out a fix | 13:06 |
mordred | adriant: oh - you know what ... (sorry I wasn't awake when you were encountering this ...) | 13:08 |
mordred | oh, no, nevermind. I thought there might be a one-line fix | 13:08 |
*** samueldmq has joined #openstack-sdks | 13:09 | |
*** mgariepy has joined #openstack-sdks | 13:09 | |
*** efried_pto is now known as efried | 13:12 | |
*** gtema has joined #openstack-sdks | 13:15 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Workaround for older octavia https://review.opendev.org/657799 | 13:16 |
mordred | adriant: when you wake up ... ^^ that should fix you from a workaround perspective | 13:17 |
mordred | adriant: looking at the code, I have a few ideas of how to solve this slighly less hacky - but they'll take a few more minutes to work on | 13:17 |
gtema | mordred: just a few minutes longer? that's like immediately ;-) | 13:18 |
mordred | gtema: hehe | 13:18 |
mordred | tl;dr - I think if we refactor openstack.service_description.ServiceDescription._make_proxy a little bit, we can make it easier to override parts of the story for individual services ... in their ServiceDescription subclass | 13:19 |
gtema | what do you mean? | 13:20 |
mordred | I'm not 100% sure yet :) | 13:21 |
gtema | :D | 13:21 |
mordred | johnsom: does octavia have microversions? (doesn't look like it) - also, I see a comment in the code that indicates exposing the v1 endpoint is a security risk - does that mean it's reasonable at this point to assume v2 is the only thing we'll be talking to (in the cases where version discovery doesn't work) | 13:24 |
mordred | gtema: I *think* what I'm thniking is that we have the ServiceDescription class do the initial stuff the same for everybody - then have a method we can override on a per-service basis (but most wouldn't) - that handles "what do I do if I found the service but service discovery didn't work" | 13:25 |
mordred | but what I shoudl really do is finish that patch from above and add some tests that show the correct behavior with a linkless octavia version document | 13:26 |
gtema | yes, right. | 13:27 |
gtema | mordred: as I see we do not currently have any tests for vendor profiles. I see those are really tricky, but probably need to introduce some | 13:28 |
gtema | especially since I am preparing this vendor_hook as part of the vendors/*.json and openstack.connect(vendor_hook='') | 13:29 |
*** ttsiouts has joined #openstack-sdks | 13:30 | |
mordred | gtema: yes. we should probably make some tests | 13:32 |
gtema | will try implement some for the vendor_hook patch | 13:32 |
gtema | and then extend separately | 13:33 |
* mordred wishes gtema good luck and backs slowly away | 13:33 | |
mordred | :) | 13:33 |
gtema | hehe | 13:33 |
johnsom | mordred: v1 is only for neutron to talk to us, it was never user facing. No microcersions either. | 13:48 |
mordred | johnsom: ok, cool | 13:49 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799 | 13:54 |
mordred | johnsom, adriant, gtema: ok - I was wrong - there is a one-line fix if you don't count the comment | 13:55 |
gtema | hehe, nice | 13:55 |
gtema | mordred: probably rename then network_adapter => adapter; network_endpoint => endpoint? | 13:57 |
*** Luzi has quit IRC | 13:57 | |
mordred | gtema: I thought about that - but I was worried about shadowing other variables in that method. lemme pull it into a helper method real quick | 14:00 |
gtema | ok | 14:00 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799 | 14:05 |
*** whoami-rajat has quit IRC | 15:02 | |
*** ttsiouts has quit IRC | 15:07 | |
*** slaweq has quit IRC | 15:09 | |
*** slaweq has joined #openstack-sdks | 15:10 | |
*** ttsiouts has joined #openstack-sdks | 15:12 | |
*** altlogbot_3 has quit IRC | 15:21 | |
*** irclogbot_0 has quit IRC | 15:22 | |
*** altlogbot_1 has joined #openstack-sdks | 15:22 | |
*** irclogbot_3 has joined #openstack-sdks | 15:24 | |
*** altlogbot_1 has quit IRC | 15:27 | |
*** altlogbot_1 has joined #openstack-sdks | 15:28 | |
*** irclogbot_3 has quit IRC | 15:28 | |
*** irclogbot_3 has joined #openstack-sdks | 15:30 | |
*** cdent has joined #openstack-sdks | 15:36 | |
*** e0ne has joined #openstack-sdks | 15:50 | |
*** e0ne has quit IRC | 15:53 | |
*** e0ne has joined #openstack-sdks | 16:11 | |
*** whoami-rajat has joined #openstack-sdks | 16:17 | |
openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for vendor hooks https://review.opendev.org/657848 | 16:23 |
*** e0ne has quit IRC | 16:26 | |
*** gtema has quit IRC | 16:28 | |
*** holser_ has quit IRC | 17:04 | |
*** ttsiouts has quit IRC | 17:10 | |
*** jpena is now known as jpena|off | 17:10 | |
*** e0ne has joined #openstack-sdks | 17:10 | |
*** e0ne has quit IRC | 17:12 | |
*** e0ne has joined #openstack-sdks | 17:18 | |
*** ttsiouts has joined #openstack-sdks | 17:19 | |
*** e0ne has quit IRC | 17:21 | |
*** ralonsoh has quit IRC | 17:30 | |
*** jpich has quit IRC | 17:35 | |
*** ttsiouts has quit IRC | 17:54 | |
*** mgariepy has quit IRC | 17:57 | |
*** mgariepy has joined #openstack-sdks | 17:58 | |
*** e0ne has joined #openstack-sdks | 17:59 | |
*** e0ne has quit IRC | 18:07 | |
*** ttsiouts has joined #openstack-sdks | 18:09 | |
*** ttsiouts has quit IRC | 18:14 | |
*** ttsiouts has joined #openstack-sdks | 18:42 | |
*** cdent has quit IRC | 19:20 | |
*** ttsiouts has quit IRC | 19:44 | |
*** ttsiouts has joined #openstack-sdks | 19:59 | |
*** cdent has joined #openstack-sdks | 20:03 | |
*** ttsiouts has quit IRC | 20:04 | |
*** slaweq has quit IRC | 20:05 | |
*** yolanda_ has quit IRC | 20:15 | |
*** edleafe has quit IRC | 20:15 | |
*** evrardjp has quit IRC | 20:15 | |
*** edleafe has joined #openstack-sdks | 20:16 | |
*** evrardjp has joined #openstack-sdks | 20:16 | |
*** purplerbot has quit IRC | 20:17 | |
*** christi3k has quit IRC | 20:17 | |
*** christi3k has joined #openstack-sdks | 20:20 | |
*** slaweq has joined #openstack-sdks | 20:28 | |
*** yolanda_ has joined #openstack-sdks | 20:28 | |
*** ttsiouts has joined #openstack-sdks | 20:37 | |
*** purplerbot has joined #openstack-sdks | 20:40 | |
*** ttsiouts has quit IRC | 20:42 | |
*** bobh has joined #openstack-sdks | 20:44 | |
*** bobh has quit IRC | 20:45 | |
*** cdent has quit IRC | 20:55 | |
*** cdent has joined #openstack-sdks | 21:00 | |
*** cdent has quit IRC | 21:08 | |
openstackgerrit | Jeremy Houser proposed openstack/python-openstackclient master: Alter test_volume.py to ensure volume deletion https://review.opendev.org/652682 | 21:18 |
*** bobh has joined #openstack-sdks | 21:22 | |
openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Fix bug in endpoint group deletion https://review.opendev.org/655889 | 21:22 |
*** bobh has quit IRC | 21:26 | |
*** slaweq has quit IRC | 21:26 | |
*** cdent has joined #openstack-sdks | 21:33 | |
*** slaweq has joined #openstack-sdks | 21:43 | |
*** slaweq has quit IRC | 21:48 | |
adriant | mordred: ty! | 21:59 |
adriant | I guess for that one script I'll downgrade to 0.17.2 for now, and then upgrade to the 0.28.0 release when it is out | 22:00 |
adriant | lemme grab that patch and test it | 22:00 |
*** whoami-rajat has quit IRC | 22:26 | |
mordred | adriant: yeah - let me know if it does, and we can get it in and get 0.28.0 out (which is overdue anyway) | 22:46 |
adriant | mordred: it works for me at least against an older Octavia | 22:52 |
adriant | I don't have a newer one to point to, but looking at the code changes I shouldn't change anything there either | 22:52 |
adriant | it* shouldn't | 22:52 |
mordred | adriant: cool. I'll try to get some tests written for it in the morning | 22:53 |
*** cdent has quit IRC | 23:15 | |
openstackgerrit | Merged openstack/python-openstackclient master: Fix --limit option in image list sub-command https://review.opendev.org/617139 | 23:25 |
openstackgerrit | LIU Yulong proposed openstack/python-openstackclient master: Add floating IP Port Forwarding commands https://review.opendev.org/650062 | 23:28 |
*** e0ne has joined #openstack-sdks | 23:35 | |
*** timburke has quit IRC | 23:40 | |
*** ttsiouts has joined #openstack-sdks | 23:41 | |
*** cdent has joined #openstack-sdks | 23:44 | |
*** e0ne has quit IRC | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!