Wednesday, 2019-05-08

*** ttsiouts has quit IRC00:06
*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:24
*** slaweq has joined #openstack-sdks01:16
*** slaweq has quit IRC01:24
*** cdent has quit IRC01:40
*** slaweq has joined #openstack-sdks02:11
*** ricolin has joined #openstack-sdks02:23
*** slaweq has quit IRC02:24
*** ttsiouts has joined #openstack-sdks02:39
*** ttsiouts has quit IRC02:44
*** whoami-rajat has joined #openstack-sdks03:02
*** slaweq has joined #openstack-sdks03:12
*** slaweq has quit IRC03:24
adriantmordred: I'm having some really really weird issues with using the SDK to talk to our octavia04:07
johnsomadriant: how so?04:07
adrianta script that used to work, now doesn't seem to (for reasons I can't figure out) and even downgrading, or upgrading SDK or keystone auth versions does nothing04:07
adrianthttp://paste.openstack.org/show/751055/04:08
adriantjohnsom: see error04:08
adrianti'm not sure if octavia is screwed and should be returning links to version urls, or if it never did04:08
johnsomOctavia had the links, what version of Octavia API are you using?  Very old versions didn’t have links, but the newer version does.  Sdk accounted for this.04:11
*** slaweq has joined #openstack-sdks04:12
adriantjohnsom: we are running Queens, Octavia, which I thought had links?04:17
adriantat least from looking at the code04:17
adrianthttps://github.com/openstack/octavia/blame/master/octavia/api/root_controller.py#L5604:18
johnsomadriant: 2.0.3 fixed the links issue. If you are running an older version of queens I highly recommend you update to the current queens version.04:18
johnsomCurrent is 2.1.0 fyi04:19
adriantI'm just curious why this 'used' to work04:20
adriantand now doesn't04:21
adriantwe haven't upgraded octavia for a while, and I'm fairly sure the tools we had that used the SDK to talk to it, did used to work as recently as a month or two back :(04:21
johnsomYeah, I don’t have an answer for that. Octavia hasn’t touched the links code in a while so not likely the issue.04:21
adriantweird :/04:23
*** slaweq has quit IRC04:24
adriantjohnsom: so looks like weird running a version that doesn't include links...04:32
adriantbut then why did the SDK used to work?04:32
adriantwas it updated to only expect links, or did it ever handle the non-link case?04:32
johnsomYeah, older versions compensated for that04:32
adrianthmmm04:33
johnsomI can’t speak for the sdk as I don’t track it closely. I can only talk to what we did in Octavia.04:34
adriantany reason why it isn't capable of both cases?04:34
*** cdent has joined #openstack-sdks04:34
adriantalthough I guess that's a mordred question04:34
adriantbecause it's an annoying bit of backward incompatibility :(04:34
johnsomYeah, we fixed it in Octavia as soon as it was raised that we had an issue/bug.04:35
adriantwe plan to upgrade octavia to stein soon anyway, but still awkward04:35
johnsomYeah, even a queen update would probably fix you up.04:35
adriantmeanwhile I'm going to just find an old version of the SDK that still works I guess04:36
johnsomOk. Sorry for the trouble!04:36
adriantI'm just curious why this code every worked...04:38
adriantever*04:38
adriantand downgrading the SDK gets me a different error! :P04:41
adriant"UnboundLocalError: local variable 'api_version' referenced before assignment"04:41
* adriant cries04:41
* cdent passes adriant a tissue04:42
adriantty cdent04:43
adriantwell ok, I just can't make the SDK talk to Octavia :/04:49
adriantactually, johnsom, when did you add version discovery at all to Octavia?04:55
adriantnvm, looked at the repo04:56
adriantages ago04:56
adrianthmmm04:56
johnsomYeah, a long time ago04:58
*** cdent has quit IRC05:09
*** slaweq has joined #openstack-sdks05:12
adriantI give up, I'll rewrite this code to use the octavia client tomorrow...05:20
adriantif anyone has alternative ideas for me when I look at IRC tomorrow, I'd be happy to try them.05:20
*** slaweq has quit IRC05:24
*** dims has quit IRC05:32
*** dims has joined #openstack-sdks05:33
*** ricolin_ has joined #openstack-sdks06:12
*** ricolin has quit IRC06:12
*** dims has quit IRC06:16
*** slaweq has joined #openstack-sdks06:17
adriantHAH! 0.17.2 works!06:21
* adriant wonders why he's still here06:21
adriantso yeah, mordred, I'd call this a regression bug. SDK ought to work with older octavia despite the lack of links in the version listing.06:27
*** ricolin_ has quit IRC06:27
*** yolanda_ has joined #openstack-sdks06:31
*** slaweq has quit IRC06:32
*** ttsiouts has joined #openstack-sdks06:34
*** dims has joined #openstack-sdks06:42
*** slaweq has joined #openstack-sdks06:42
*** gtema has joined #openstack-sdks06:44
*** dims has quit IRC06:49
*** dims has joined #openstack-sdks06:54
*** ralonsoh has joined #openstack-sdks07:29
*** ttsiouts has quit IRC07:33
*** Luzi has joined #openstack-sdks07:47
*** noama has joined #openstack-sdks07:51
*** jpich has joined #openstack-sdks07:54
*** jpena|off is now known as jpena07:59
openstackgerritWitold Bedyk proposed openstack/python-openstackclient master: document the --timing option  https://review.opendev.org/65764008:18
*** holser_ has joined #openstack-sdks08:31
*** ttsiouts has joined #openstack-sdks09:06
*** ttsiouts has quit IRC09:11
*** holser_ is now known as holser|lunch10:15
*** zbr|pto has quit IRC10:42
*** ttsiouts has joined #openstack-sdks10:46
*** ttsiouts has quit IRC10:50
*** gtema has quit IRC11:19
*** gtema has joined #openstack-sdks11:19
*** holser|lunch is now known as holser_11:27
*** jpena is now known as jpena|lunch11:31
*** jpich has quit IRC11:47
*** jpich has joined #openstack-sdks11:48
*** bobh has joined #openstack-sdks11:57
*** bobh has quit IRC12:02
*** mgariepy has quit IRC12:11
*** mgariepy has joined #openstack-sdks12:21
*** gtema has quit IRC12:25
*** mgariepy has quit IRC12:29
*** jpena|lunch is now known as jpena12:31
*** ttsiouts has joined #openstack-sdks12:32
*** mgariepy has joined #openstack-sdks12:34
*** ttsiouts has quit IRC12:53
*** noama has quit IRC12:57
*** mgariepy has quit IRC12:58
mordredadriant: yeah - i agree - let's see if we can't figure out a fix13:06
mordredadriant: oh - you know what ... (sorry I wasn't awake when you were encountering this ...)13:08
mordredoh, no, nevermind. I thought there might be a one-line fix13:08
*** samueldmq has joined #openstack-sdks13:09
*** mgariepy has joined #openstack-sdks13:09
*** efried_pto is now known as efried13:12
*** gtema has joined #openstack-sdks13:15
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Workaround for older octavia  https://review.opendev.org/65779913:16
mordredadriant: when you wake up ... ^^ that should fix you from a workaround perspective13:17
mordredadriant: looking at the code, I have a few ideas of how to solve this slighly less hacky - but they'll take a few more minutes to work on13:17
gtemamordred: just a few minutes longer? that's like immediately ;-)13:18
mordredgtema: hehe13:18
mordredtl;dr - I think if we refactor openstack.service_description.ServiceDescription._make_proxy a little bit, we can make it easier to override parts of the story for individual services ... in their ServiceDescription subclass13:19
gtemawhat do you mean?13:20
mordredI'm not 100% sure yet :)13:21
gtema:D13:21
mordredjohnsom: does octavia have microversions? (doesn't look like it) - also, I see a comment in the code that indicates exposing the v1 endpoint is a security risk - does that mean it's reasonable at this point to assume v2 is the only thing we'll be talking to (in the cases where version discovery doesn't work)13:24
mordredgtema: I *think* what I'm thniking is that we have the ServiceDescription class do the initial stuff the same for everybody - then have a method we can override on a per-service basis (but most wouldn't) - that handles "what do I do if I found the service but service discovery didn't work"13:25
mordredbut what I shoudl really do is finish that patch from above and add some tests that show the correct behavior with a linkless octavia version document13:26
gtemayes, right.13:27
gtemamordred: as I see we do not currently have any tests for vendor profiles. I see those are really tricky, but probably need to introduce some13:28
gtemaespecially since I am preparing this vendor_hook as part of the vendors/*.json and openstack.connect(vendor_hook='')13:29
*** ttsiouts has joined #openstack-sdks13:30
mordredgtema: yes. we should probably make some tests13:32
gtemawill try implement some for the vendor_hook patch13:32
gtemaand then extend separately13:33
* mordred wishes gtema good luck and backs slowly away13:33
mordred:)13:33
gtemahehe13:33
johnsommordred: v1 is only for neutron to talk to us, it was never user facing.  No microcersions either.13:48
mordredjohnsom: ok, cool13:49
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery  https://review.opendev.org/65779913:54
mordredjohnsom, adriant, gtema: ok - I was wrong - there is a one-line fix if you don't count the comment13:55
gtemahehe, nice13:55
gtemamordred: probably rename then network_adapter => adapter; network_endpoint => endpoint?13:57
*** Luzi has quit IRC13:57
mordredgtema: I thought about that - but I was worried about shadowing other variables in that method. lemme pull it into a helper method real quick14:00
gtemaok14:00
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery  https://review.opendev.org/65779914:05
*** whoami-rajat has quit IRC15:02
*** ttsiouts has quit IRC15:07
*** slaweq has quit IRC15:09
*** slaweq has joined #openstack-sdks15:10
*** ttsiouts has joined #openstack-sdks15:12
*** altlogbot_3 has quit IRC15:21
*** irclogbot_0 has quit IRC15:22
*** altlogbot_1 has joined #openstack-sdks15:22
*** irclogbot_3 has joined #openstack-sdks15:24
*** altlogbot_1 has quit IRC15:27
*** altlogbot_1 has joined #openstack-sdks15:28
*** irclogbot_3 has quit IRC15:28
*** irclogbot_3 has joined #openstack-sdks15:30
*** cdent has joined #openstack-sdks15:36
*** e0ne has joined #openstack-sdks15:50
*** e0ne has quit IRC15:53
*** e0ne has joined #openstack-sdks16:11
*** whoami-rajat has joined #openstack-sdks16:17
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Add support for vendor hooks  https://review.opendev.org/65784816:23
*** e0ne has quit IRC16:26
*** gtema has quit IRC16:28
*** holser_ has quit IRC17:04
*** ttsiouts has quit IRC17:10
*** jpena is now known as jpena|off17:10
*** e0ne has joined #openstack-sdks17:10
*** e0ne has quit IRC17:12
*** e0ne has joined #openstack-sdks17:18
*** ttsiouts has joined #openstack-sdks17:19
*** e0ne has quit IRC17:21
*** ralonsoh has quit IRC17:30
*** jpich has quit IRC17:35
*** ttsiouts has quit IRC17:54
*** mgariepy has quit IRC17:57
*** mgariepy has joined #openstack-sdks17:58
*** e0ne has joined #openstack-sdks17:59
*** e0ne has quit IRC18:07
*** ttsiouts has joined #openstack-sdks18:09
*** ttsiouts has quit IRC18:14
*** ttsiouts has joined #openstack-sdks18:42
*** cdent has quit IRC19:20
*** ttsiouts has quit IRC19:44
*** ttsiouts has joined #openstack-sdks19:59
*** cdent has joined #openstack-sdks20:03
*** ttsiouts has quit IRC20:04
*** slaweq has quit IRC20:05
*** yolanda_ has quit IRC20:15
*** edleafe has quit IRC20:15
*** evrardjp has quit IRC20:15
*** edleafe has joined #openstack-sdks20:16
*** evrardjp has joined #openstack-sdks20:16
*** purplerbot has quit IRC20:17
*** christi3k has quit IRC20:17
*** christi3k has joined #openstack-sdks20:20
*** slaweq has joined #openstack-sdks20:28
*** yolanda_ has joined #openstack-sdks20:28
*** ttsiouts has joined #openstack-sdks20:37
*** purplerbot has joined #openstack-sdks20:40
*** ttsiouts has quit IRC20:42
*** bobh has joined #openstack-sdks20:44
*** bobh has quit IRC20:45
*** cdent has quit IRC20:55
*** cdent has joined #openstack-sdks21:00
*** cdent has quit IRC21:08
openstackgerritJeremy Houser proposed openstack/python-openstackclient master: Alter test_volume.py to ensure volume deletion  https://review.opendev.org/65268221:18
*** bobh has joined #openstack-sdks21:22
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Fix bug in endpoint group deletion  https://review.opendev.org/65588921:22
*** bobh has quit IRC21:26
*** slaweq has quit IRC21:26
*** cdent has joined #openstack-sdks21:33
*** slaweq has joined #openstack-sdks21:43
*** slaweq has quit IRC21:48
adriantmordred: ty!21:59
adriantI guess for that one script I'll downgrade to 0.17.2 for now, and then upgrade to the 0.28.0 release when it is out22:00
adriantlemme grab that patch and test it22:00
*** whoami-rajat has quit IRC22:26
mordredadriant: yeah - let me know if it does, and we can get it in and get 0.28.0 out (which is overdue anyway)22:46
adriantmordred: it works for me at least against an older Octavia22:52
adriantI don't have a newer one to point to, but looking at the code changes I shouldn't change anything there either22:52
adriantit* shouldn't22:52
mordredadriant: cool. I'll try to get some tests written for it in the morning22:53
*** cdent has quit IRC23:15
openstackgerritMerged openstack/python-openstackclient master: Fix --limit option in image list sub-command  https://review.opendev.org/61713923:25
openstackgerritLIU Yulong proposed openstack/python-openstackclient master: Add floating IP Port Forwarding commands  https://review.opendev.org/65006223:28
*** e0ne has joined #openstack-sdks23:35
*** timburke has quit IRC23:40
*** ttsiouts has joined #openstack-sdks23:41
*** cdent has joined #openstack-sdks23:44
*** e0ne has quit IRC23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!