Tuesday, 2019-04-16

*** markvoelker has quit IRC00:00
*** tosky has quit IRC00:01
*** bobh has quit IRC00:14
*** bobh has joined #openstack-sdks00:23
*** bobh has quit IRC00:24
*** bobh has joined #openstack-sdks00:25
*** bobh_ has joined #openstack-sdks00:28
*** bobh has quit IRC00:33
*** bobh_ has quit IRC00:54
*** bobh has joined #openstack-sdks00:58
*** bobh has quit IRC00:59
*** bobh has joined #openstack-sdks01:11
*** keekz has joined #openstack-sdks01:45
*** whoami-rajat has joined #openstack-sdks01:53
*** bobh has quit IRC02:01
*** bobh has joined #openstack-sdks02:32
*** bobh has quit IRC02:37
*** ricolin has joined #openstack-sdks02:45
*** bobh has joined #openstack-sdks04:47
*** bobh has quit IRC04:51
*** e0ne has joined #openstack-sdks04:53
*** e0ne has quit IRC04:56
*** e0ne has joined #openstack-sdks05:21
*** e0ne has quit IRC05:25
*** Luzi has joined #openstack-sdks05:37
*** masayukig has quit IRC06:27
*** kmalloc has quit IRC06:28
*** vdrok has quit IRC06:28
*** TheJulia has quit IRC06:29
*** kmalloc has joined #openstack-sdks06:30
*** johnsom has quit IRC06:32
*** kmalloc has quit IRC06:40
*** ralonsoh has joined #openstack-sdks06:43
*** TheJulia has joined #openstack-sdks06:43
*** markvoelker has joined #openstack-sdks06:43
*** TheJulia has quit IRC06:47
*** slaweq has joined #openstack-sdks06:49
*** gtema has joined #openstack-sdks06:51
*** TheJulia has joined #openstack-sdks06:52
*** kmalloc has joined #openstack-sdks06:53
*** johnsom has joined #openstack-sdks06:55
*** masayukig has joined #openstack-sdks06:55
*** vdrok has joined #openstack-sdks06:58
*** bobh has joined #openstack-sdks07:04
*** e0ne has joined #openstack-sdks07:06
*** bobh has quit IRC07:09
*** e0ne has quit IRC07:09
*** e0ne has joined #openstack-sdks07:16
*** tosky has joined #openstack-sdks07:23
*** holser_ has joined #openstack-sdks07:27
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Continue refactoring of the image  https://review.openstack.org/65153407:30
*** bobh has joined #openstack-sdks07:37
*** bobh has quit IRC07:41
*** gtema has quit IRC07:45
*** gtema has joined #openstack-sdks07:45
*** e0ne has quit IRC07:52
*** e0ne has joined #openstack-sdks07:58
*** e0ne has quit IRC07:59
*** jpich has joined #openstack-sdks08:03
*** johnsom has quit IRC08:04
*** johnsom has joined #openstack-sdks08:05
*** masayukig has quit IRC08:05
*** masayukig has joined #openstack-sdks08:05
*** gkadam has joined #openstack-sdks08:09
*** gkadam has quit IRC08:10
*** e0ne has joined #openstack-sdks08:10
*** ttsiouts has joined #openstack-sdks08:21
openstackgerritLIU Yulong proposed openstack/python-openstackclient master: Add floating IP Port Forwarding commands  https://review.openstack.org/65006209:21
*** dtantsur|afk is now known as dtantsur09:35
*** holser_ is now known as holser|luuunch09:53
*** ttsiouts has quit IRC10:23
*** ttsiouts has joined #openstack-sdks10:24
*** ttsiouts has quit IRC10:28
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Continue refactoring of the image  https://review.openstack.org/65153410:31
*** cdent has joined #openstack-sdks10:39
*** jpich has quit IRC10:58
openstackgerritMerged openstack/openstacksdk master: Try to fix the masakari CI job  https://review.openstack.org/65263810:59
*** jpich has joined #openstack-sdks10:59
*** ttsiouts has joined #openstack-sdks11:02
*** jpich has quit IRC11:12
*** jpich has joined #openstack-sdks11:13
*** jpich has quit IRC11:14
*** holser|luuunch is now known as holser_11:27
*** jpich has joined #openstack-sdks11:30
*** jpich has quit IRC11:30
*** gtema has quit IRC11:40
*** cdent has quit IRC11:42
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Add image.stage methods  https://review.openstack.org/65298111:42
*** gtema has joined #openstack-sdks11:43
*** dtantsur is now known as dtantsur|brb11:45
*** bobh has joined #openstack-sdks11:48
*** bobh has quit IRC11:53
*** bobh has joined #openstack-sdks12:10
*** bobh has quit IRC12:18
*** cdent has joined #openstack-sdks12:23
*** Luzi has quit IRC12:24
*** jpich has joined #openstack-sdks12:25
*** Luzi has joined #openstack-sdks12:46
*** gtema has quit IRC12:54
*** bobh has joined #openstack-sdks13:07
*** dtantsur|brb is now known as dtantsur13:24
*** jpich has quit IRC13:25
*** jpich has joined #openstack-sdks13:26
*** tobiash has quit IRC13:31
*** tobiash has joined #openstack-sdks13:32
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Return None from get_server_by_id on 404  https://review.openstack.org/65299513:38
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Return None from get_server_by_id on 404  https://review.openstack.org/65299513:41
openstackgerritJeremy Houser proposed openstack/python-openstackclient master: Alter test_volume.py to ensure volume deletion  https://review.openstack.org/65268213:45
openstackgerritJeremy Houser proposed openstack/python-openstackclient master: Alter test_volume.py to ensure volume deletion  https://review.openstack.org/65268213:45
*** bobh has quit IRC13:50
*** cdent has quit IRC14:01
*** markvoelker has quit IRC14:07
*** Luzi has quit IRC14:09
*** ttsiouts has quit IRC14:23
*** ttsiouts has joined #openstack-sdks14:24
*** dtantsur has quit IRC14:27
*** ttsiouts has quit IRC14:27
*** ttsiouts has joined #openstack-sdks14:28
*** gtema has joined #openstack-sdks14:29
*** dtantsur has joined #openstack-sdks14:31
*** bobh has joined #openstack-sdks14:39
*** bobh has quit IRC14:41
mordredgtema: left a review on the image patches - I think they're close14:49
gtemayes, thanks. Few issues:14:49
gtemaauto_disk_config - I think it would be better to drop this attr from image resource and rely on the "properties" interpretation of it14:50
gtemadrop compute for list - ok, will do14:51
gtemaswitch to wait_for_task - it's this fallback for _IMAGE_ERROR_396 which makes it not easy14:52
mordredgtema: auto_disk_config - yeah14:52
mordredgtema: or else we should add ALL of the driver-specific properties14:52
gtemawhich we do not want to14:53
mordredgtema: yeah. and unfortunately _IMAGE_ERROR_396 is a wonderful thing that rackspace does throw. like - that chunk of logic exists because of issues production nodepool sees without it14:53
mordredgtema: totally. there's too many of them - it would make the image objects absurd14:54
gtemamorderd: so should I then drop all hw*, vmware*?14:54
mordredgtema: ugh. we do have a lot of these already don't we14:56
gtemayupp14:56
mordredgtema: maybe it's better that we just add the rest of them? I wish they were documented somewhere that isn't a wiki page14:56
mordredlike, you know - in the API docs14:56
mordredlemme ask rosmaita14:57
gtemaok14:57
mordredgtema: https://docs.openstack.org/glance/latest/admin/useful-image-properties.html15:02
gtemamorder: ack, will go through15:02
mordredwow. trait:trait_name is fantastic15:03
gtemahowever, if on Rackspace auto_disk_config returns you "disabled" - we have a problem and need to treat all those as strings only15:03
gtemasince it should be true or false15:04
*** cdent has joined #openstack-sdks15:05
mordredgtema: mriedem tells me that auto_disk_config is string in the nova schema, so even the true and false values are actually "true" and "false"15:09
gtemaok, that is the problem, that in Image it was casted to bool and therefore I had problem15:09
mordredaha!15:10
mordredhttps://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L23315:10
mordredgtema: this is apparently where we can look to find out actual thing15:10
gtemayeah, looks interesting15:11
gtemabut is also interesting "architecture" vs "hw_architecture"15:11
gtemahw_auto_disk_config15:11
mordredthere's a legacy property map at the bottom15:11
gtemaoh, thks15:11
mordredI wonder how hard it would be to write a gate job (or maybe a functional test that works only on devstack installs)15:12
gtemait's huge. Do we really want all of that?15:12
mordredthat would import that nova file and do a cross-check to make sure the property lists match15:12
mordredgtema: I don't know15:12
mordredit's an excellent questions15:12
gtemawe will anyway put everything what we get under properties and even allow to set anything15:13
gtemaand those traits - we can't define such things as of now15:14
mordredyeah ... so - in #openstack-nova I just said :15:15
mordredoh - screw it - copy/paste not worth it... basically - since the various base properties can have varied data types, we might really want to do the whole list so we can make sure everything in properties is just a string type and is a user-defined property15:16
mordredBUT15:16
mordredmaybe we can wait a bit and do that later15:16
mordredI think what's there now is fine for now until someone gets upset15:17
gtemaso simply let it stay how it is now?15:17
gtemaauto_disk_config - will remove type=bool15:17
mordredOH GOD. THERE ARE ENUMS15:18
mordredgtema: yeah. let's do that for now - I think dealing with the whole thing is ... large ... and requires some real thought15:19
mordredlike - if we wanted to actually tackle it - I'd want to figure out how to keep thigns liek enum lists in sync15:19
* gtema has opened a Pandora box15:19
mordredgtema: you know - there's also the schema field you added support for15:20
* gtema decides to close it while it is still possible15:20
gtemayes, I know15:20
mordredgtema: I wonder if it would be easier/better to just write something that grabs the schema and figures out which properties are base and which are user based on that schema15:20
gtemayou want us to make use of it?15:20
mordredmaybe? I don't know how useful it is15:20
gtemawell, I am not sure it is usefull as of now. Maybe later15:21
gtemathis would not be very efficient by default, since nearly always we would need to invoke it and/or cache schema data15:22
mordred++15:22
mordredyeah - we'd definitely have to cache schema data I think15:22
mordredbut for single-use processes like osc it woudl still be inefficient15:22
gtemadefinitely15:22
mordredso it's PROBABLY better to think about a test job that validates against the nova source code15:22
mordredbut HOLY CRAP that'll be a lot of work too due to the use of custom enum classes15:23
* mordred runs away to cry15:23
gtemaagree15:23
*** holser_ has quit IRC15:25
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Continue refactoring of the image  https://review.openstack.org/65153415:29
*** e0ne has quit IRC15:31
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Add image.stage methods  https://review.openstack.org/65298115:43
*** gtema has quit IRC15:49
*** ttsiouts has quit IRC15:59
*** ttsiouts has joined #openstack-sdks15:59
*** ttsiouts has quit IRC16:04
*** jpich has quit IRC16:04
*** dtruong has quit IRC16:40
*** dtruong has joined #openstack-sdks16:41
*** yolanda_ has quit IRC16:57
*** ricolin has quit IRC17:25
*** e0ne has joined #openstack-sdks17:32
*** ralonsoh has quit IRC17:34
*** dtantsur is now known as dtantsur|afk17:36
*** e0ne has quit IRC17:49
*** efried has joined #openstack-sdks18:22
*** Sundar has joined #openstack-sdks18:22
efriedmordred: This openstacksdk business is ready for primetime, yah? So like, new projects like cyborg that don't yet have a legacy commitment to python-*client and/or oslo.config for ksa can and should bootstrap their talking-to-other-services business with a clouds.yaml and production Connection constructor-ness?18:23
mordredefried: yes18:30
mordredefried: it would be very welcome for them to add support for their service into sdk directly18:30
efriedmordred: I was talking about cyborg wanting to communicate *at* other services, like placement and glance.18:30
mordredah. yes. that too18:31
Shrewsmordred: very very small nit on https://review.openstack.org/652995 but happy to merge as is too if you'd rather say "meh"18:31
efriedSundar: ^ Given that you've just succeeded in connecting using a ksa adapter, it should be fairly trivial to translate your oslo.config-based values into a clouds.yaml.18:31
mordredso - both things are true18:31
mordredefried: yah. although if they _want_ to use the oslo.config stuff, we've got that helper method we put in for nova18:32
efriedmordred: Well, yeah, it's still in flight.18:32
efriedmordred: And I'm not sure there's a reason to use oslo.config stuff, is there?18:32
mordredefried: god, have we not landed that yet? I should really finish writing tests18:32
efriedmordred: I did leave a poke there a week or two ago :)18:32
mordredefried: not really - other than consistency with other services for operators18:32
efriedI mean, how much gerrit mail could you possibly get?18:33
mordredefried: you think I get email from gerrit? :)18:33
efried:P18:33
efriedI've got a guy coming up to speed and working on the ironicclient swapout for nova18:33
efriedWe're getting close-ish to a point where we'll want that dep merged & released.18:33
efrieddustinc: ^18:34
mordredefried: cool. we'll get it merged for you then18:34
efriedmordred: Let me know if you need anything from me on that.18:35
mordreddon't think so - I think the nova depends-on patches provide good integration testing that it works - we just need to add some sdk-side testing and it should be good to go18:35
mordredShrews: oh piddle. can you tell I copy-pastad that?18:35
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Return None from get_server_by_id on 404  https://review.openstack.org/65299518:36
mordredShrews: ^^ fixed18:36
mordredthanks18:36
dtroyermordred: is there a known problem with Connection.add_service() currently?  I am attempting some manner of support of StarlingX APIs without adding them directly (just starting with direct REST for now) and I get different failures with latest release and master…18:36
dtroyerI need to work up a small test case, you don't want to try what I have at the moment…18:37
openstackgerritJeremy Houser proposed openstack/python-openstackclient master: Exploratory Fix for Common in Compute v2 Common  https://review.openstack.org/65307718:37
dustincefried, mordred: 👍18:37
*** irclogbot_2 has quit IRC18:39
*** irclogbot_1 has joined #openstack-sdks18:41
Shrewsmordred: +3'd18:42
dtroyermordred: nvm, nothing like pouring out your problems publicly to help in figuring it out…  that said I am exploring the best way to approach making a derivative SDK for STX.18:55
mordreddtroyer: cool - you may want to chat with gtema next time he's around - he's been working on that same thing for his cloud - they have some services that are non-openstack, so supporting that flow is important to him18:57
dtroyerok, will do.  I saw his recent improvements in add_service() that explained the different behaviours.18:58
mordredcool. also - I'm not opposed in principle to starlingx support in sdk ... but I also have spent exactly 0 seconds thinking about it, so maybe it's a bad idea for a reason I haven't thought of yet19:00
mordredbut we're all part of the same happy family, so it's not, you know, inconceivable19:00
mordredbut I'm also not going to say it _should_ be done that way if the other way seems better19:00
dtroyermordred: I think there is a service-types conversation to come first, that'll help decide.19:01
* mordred waves arms wildly in the air then runs into a hole to hide19:01
mordredcool19:01
*** bobh has joined #openstack-sdks19:25
*** bobh has quit IRC19:28
*** bobh has joined #openstack-sdks19:37
*** holser_ has joined #openstack-sdks20:13
*** ttsiouts has joined #openstack-sdks20:44
*** cdent has quit IRC20:50
*** bobh has quit IRC20:56
openstackgerritMerged openstack/openstacksdk master: Return None from get_server_by_id on 404  https://review.openstack.org/65299521:43
*** holser_ has quit IRC21:51
SundarAre the connections in openstack-sdk low cost enough that we can create one at each call site?21:57
mordredSundar: well....22:01
mordredSundar: they're _fairly_ low cost - but there's also a bunch of plumbing to deal with caching some various things, so I would avoid it in long-running services if you can22:01
mordredSundar: the Connection object itself should be thread safe - so sharing one should work properly22:02
mordredSundar: however - if, for whatever reason, you need to create one per call site - if you can share the Session and/or Auth objects, that will take care of most of the caching you'll care about22:03
mordred(since service discovery gets cached on the Session)22:03
*** ttsiouts has quit IRC22:10
*** ttsiouts has joined #openstack-sdks22:11
*** ttsiouts has quit IRC22:12
*** holser_ has joined #openstack-sdks22:36
Sundarmordred: Thanks for the detailed explanation22:40
openstackgerritMatt Riedemann proposed openstack/python-openstackclient master: Fix docs bug link to go to storyboard rather than launchpad  https://review.openstack.org/65316222:41
Sundarmordred: Also, in my devstack setup, I see specific roles like devstack_admin in clouds.yaml. Can we expect more standard roles like 'admin' irl?22:42
Sundarmordred: Also, is there a good way to avoid hardcoding the role like ``connection.Connection(cloud='devstack-admin')``?22:42
*** holser_ has quit IRC22:53
*** whoami-rajat has quit IRC23:02
dtroyerSundar: that isn't an actual role, it is a cloud user configuration that points at the devstack cloud.  The configurations you will find IRL could be anything, it is just a name. with a cloud configuration behind it, that needs to be set up for your target.23:16
*** tosky has quit IRC23:19
*** mriedem has joined #openstack-sdks23:20
mriedemneed some design help on fixing https://storyboard.openstack.org/#!/story/200546823:20
mriedemtrying to fix openstack server create --config-drive in a backward compatible way23:20
mriedemit takes a string today which is dumb b/c it's a boolean,23:20
mriedemit should just be that specifying --config-drive means yeah, add a config drive, and omitting the option means no config drive23:21
mriedembut i'm not sure how to deal with that as a string if it's not provided23:21
dtroyermriedem: it is likely possible (I personally dislike nargs but this is where it is useful)  I can take a close look tomorrow…23:21
mriedemlike i guess you can specify --config-drive None?23:21
dtroyerwe have done this in one or two other places, it is possible23:22
dtroyerand if I did that existing implementation I owe you a $COLD_BEVERAGE in DEN :)23:22
mriedemok i'll post what i have and we can sort it out tomorrow23:23
mriedemdtroyer: not your fault if so b/c it's copying the busted novaclient code23:23
mriedemwhich also says it can be a non-boolean string23:23
mriedemfrom 201223:23
Sundardtoyer: Thanks. So, how do we get the right 'cloud name' or user configuration name for ``connection.Connection(cloud='devstack-admin')``?23:43
Sundardtroyer: ^23:43
dtroyerI don't know the exact context you are in, but that depends totally on the cloud you are calling23:45
Sundardtroyer: let me put it this way. When one project (say Cyborg) calls another (say Glance), is it appropriate to embed names like 'devstack-admin' in the caller code? One would tjhink not. So, where do I get the right name for the caller?23:47
dtroyerSundar: from the point of view of the application, it comes from the app.  Most OpenStack services have a configuration value for service accounts like that, along with their DB config, etc.  In that case, you probably do not want to rely on clouds.yaml for that information but create your connection from the individual pieces in your config23:49
dtroyerwhere 'that case' is from a long-running service23:49
openstackgerritMatt Riedemann proposed openstack/python-openstackclient master: WIP: Fix openstack server create --config-drive value  https://review.openstack.org/65317623:50
mriedemSundar: e.g. nova's config for talking to glance https://docs.openstack.org/nova/latest/configuration/config.html#glance23:51
mriedemuses keystoneauth1 config options for building the ksa session adapter23:51
mriedemefried is well versed in all of that code23:51
Sundarmriedem: I am investigating the 'new' approach, newer than ksa adapter, which is to use openstack sdk with clouds.yaml.23:53
Sundarmriedem: efried is advocating that new approach23:53
Sundarmriedem: Along the lines of https://review.openstack.org/#/c/643664/23:56
Sundardtroyer: Got it. This should go into cyborg.conf23:56
mriedemSundar: ok i don't know why we're doing that,23:58
mriedemwe don't have a blueprint or anything for that in nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!