| *** slaweq_ has joined #openstack-sdks | 00:11 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Make factory for a CloudRegion from CONF objects https://review.openstack.org/643601 | 00:22 |
|---|---|---|
| mordred | I'm stupid | 00:22 |
| *** slaweq_ has quit IRC | 00:24 | |
| *** dave-mccowan has joined #openstack-sdks | 00:28 | |
| *** dave-mccowan has quit IRC | 00:31 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Make factory for a CloudRegion from CONF objects https://review.openstack.org/643601 | 00:31 |
| *** slaweq_ has joined #openstack-sdks | 01:11 | |
| *** slaweq_ has quit IRC | 01:24 | |
| *** slaweq_ has joined #openstack-sdks | 02:11 | |
| *** gkadam_ has joined #openstack-sdks | 02:11 | |
| *** gkadam_ has quit IRC | 02:17 | |
| *** irclogbot_2 has quit IRC | 02:23 | |
| *** slaweq_ has quit IRC | 02:24 | |
| *** edleafe has quit IRC | 02:27 | |
| *** slaweq_ has joined #openstack-sdks | 03:11 | |
| *** slaweq_ has quit IRC | 03:25 | |
| *** whoami-rajat has joined #openstack-sdks | 03:46 | |
| *** ttsiouts has quit IRC | 03:52 | |
| *** slaweq_ has joined #openstack-sdks | 04:14 | |
| *** slaweq_ has quit IRC | 04:24 | |
| *** slaweq_ has joined #openstack-sdks | 05:16 | |
| *** slaweq_ has quit IRC | 05:24 | |
| *** slaweq_ has joined #openstack-sdks | 06:11 | |
| *** slaweq_ has quit IRC | 06:24 | |
| *** e0ne has joined #openstack-sdks | 06:40 | |
| *** Luzi has joined #openstack-sdks | 06:53 | |
| *** e0ne has quit IRC | 07:02 | |
| *** slaweq_ has joined #openstack-sdks | 07:13 | |
| *** tosky has joined #openstack-sdks | 08:05 | |
| *** ttsiouts has joined #openstack-sdks | 08:06 | |
| *** tosky has quit IRC | 08:07 | |
| *** tosky has joined #openstack-sdks | 08:25 | |
| *** jpena|off is now known as jpena | 08:29 | |
| *** jangutter has joined #openstack-sdks | 08:34 | |
| *** tssurya has joined #openstack-sdks | 08:36 | |
| *** gtema has joined #openstack-sdks | 08:47 | |
| *** holser_ has joined #openstack-sdks | 09:10 | |
| *** dtantsur|afk is now known as dtantsur | 09:11 | |
| *** cdent has joined #openstack-sdks | 09:55 | |
| *** e0ne has joined #openstack-sdks | 10:28 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add unit tests for connection.add_service https://review.openstack.org/643604 | 10:47 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Create runtime descriptor for new service https://review.openstack.org/643918 | 11:03 |
| *** slaweq_ is now known as slaweq | 11:14 | |
| *** ttsiouts has quit IRC | 11:21 | |
| *** gtema has quit IRC | 11:32 | |
| *** gtema has joined #openstack-sdks | 11:46 | |
| *** ttsiouts has joined #openstack-sdks | 11:47 | |
| *** edleafe has joined #openstack-sdks | 12:21 | |
| *** markvoelker has quit IRC | 12:22 | |
| *** whoami-rajat has quit IRC | 12:35 | |
| gtema | mordred, dtantsur, Shrews: I would like to ask you to have a look at https://review.openstack.org/#/c/642218/ I am currently not very happy how it feels and want to know your opinions | 12:37 |
| *** ralonsoh has joined #openstack-sdks | 12:48 | |
| mordred | gtema: I think it looks great! | 12:49 |
| gtema | ok, I just dislike usage of stuff, which is not belonging to the object and is only present in runtime | 12:50 |
| gtema | but if you guys are ok with that we can push it and do probably some followup | 12:50 |
| *** e0ne has quit IRC | 12:51 | |
| gtema | thanks mordred | 12:51 |
| *** e0ne has joined #openstack-sdks | 12:52 | |
| mordred | gtema: well, what do you mean - maybe I'm missing the thing that's bothering you | 12:56 |
| mordred | gtema: the mixin classes do make the things part of the object | 12:56 |
| gtema | sure, and that is exactly the "problem" for me. It is ok when the class use stuff from Mixin, but I do no like when one Mixin use stuff from another Mixin | 12:57 |
| *** jpena is now known as jpena|lunch | 12:57 | |
| gtema | so I am more a fan of a regular inheritance, which is clear from the object description | 12:58 |
| gtema | something what I have done with _network_common. The most "clear" way would be if _compute, _network, _floating_ip would inherit from it, and not indirectly use stuff, which is added on a higher level | 12:59 |
| gtema | this could have also solved initialization of mixins in the connection - how it is currently done is not nice | 13:01 |
| gtema | ok, letme quickly remove WIP from the title | 13:04 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | 13:05 |
| mordred | gtema: ah - yes. I understand your concern there | 13:07 |
| gtema | mordred: great | 13:08 |
| *** whoami-rajat has joined #openstack-sdks | 13:08 | |
| *** dave-mccowan has joined #openstack-sdks | 13:09 | |
| mordred | gtema: I think we'll be fighting to balance a desire to organize stuff into files with the mixin mess just because python doesn't have a better way to organize implementation | 13:09 |
| gtema | agreed | 13:10 |
| gtema | ok, will continue "thinking" about that issue | 13:10 |
| mordred | all that said - I was originally thinking that once we got things moved into the proxy objects that potentially most of the remaining methods could just turn in to very small wrapper methods - and we could just shove all of OpenStackCloud directly on to Connection | 13:11 |
| mordred | but it would still be thousands of lines long even in the best case | 13:11 |
| gtema | yes, that's clear. With this change you have only "basic" logic left in the OpenStackCloud and it can be further merged into Connection. But here it is exactly the most prominent that mixins access methods, which they do not really belong | 13:12 |
| mordred | yeah | 13:12 |
| *** dave-mccowan has quit IRC | 13:15 | |
| gtema | mordred: any plans for SDK on PTG? | 13:15 |
| dtantsur | I feel like Forum may be a bit better for SDK | 13:17 |
| gtema | I mean both, I will be hopefully going to summit (tomorrow appointment in embassy) including PTG | 13:17 |
| *** needssleep is now known as TheJulia | 13:18 | |
| dtantsur | I'll probably spend the whole PTG in the ironic room | 13:20 |
| gtema | ok | 13:20 |
| mordred | I don't think we have any current plans to - in the past most of us have either been absent or too consumed with other rooms | 13:20 |
| gtema | got it | 13:20 |
| mordred | dtantsur: was there a forum session about the migrate-to-osc goal? | 13:20 |
| gtema | hmm, I haven't seen | 13:21 |
| gtema | shame on me | 13:21 |
| dtantsur | I haven't seen one either | 13:21 |
| mordred | gtema: that said - I'd be happy to sit down in either location and figure stuff out | 13:21 |
| dtantsur | s/either location/a bar/ | 13:22 |
| gtema | ok, great. If I'm there - definitely we will find a place :D | 13:22 |
| *** ttsiouts has quit IRC | 13:36 | |
| dtantsur | gtema: good luck with the interview! | 13:40 |
| *** ttsiouts has joined #openstack-sdks | 13:41 | |
| *** ttsiouts_ has joined #openstack-sdks | 13:42 | |
| *** ttsiouts has quit IRC | 13:46 | |
| gtema | dtantsur: thanks | 13:54 |
| *** e0ne has quit IRC | 13:58 | |
| *** Qiming has quit IRC | 13:59 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | 13:59 |
| *** Qiming has joined #openstack-sdks | 14:00 | |
| *** jpena|lunch is now known as jpena | 14:04 | |
| *** e0ne has joined #openstack-sdks | 14:05 | |
| mordred | gtema: maybe read http://www.qtrac.eu/pyclassmulti.html and then the Steven D'Aprano reply on https://groups.google.com/forum/?hl=en#!topic/comp.lang.python/goLBrqcozNY | 14:14 |
| mordred | gtema: there are maybe some ideas there that you might dislike less | 14:14 |
| *** gtema has quit IRC | 14:14 | |
| mordred | the class-level import-from is a *fascinating* idea I'd never considered | 14:15 |
| dtantsur | yeah, it's quite creative. I'm not sure if it's a good thing or not ;) | 14:15 |
| mordred | me either | 14:16 |
| mordred | like - I'm not sure it would be better than the mixin approach - but thought I'd drop it in here for consideration | 14:16 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix wait_for_server docstring https://review.openstack.org/643955 | 14:18 |
| *** mgariepy has quit IRC | 14:18 | |
| Shrews | hrm. my first impression of that is "ewwww" | 14:21 |
| dtantsur | I know a simple solution: let's write a metaclass to inject base classes in runtime | 14:22 |
| * dtantsur runs really fast | 14:22 | |
| Shrews | fwiw, we did somewhat split up that code in the past. but then put it back together again for some reasons lost to me | 14:23 |
| mordred | Shrews: I'm not sure we ever actually landed the patch to do the split | 14:31 |
| mordred | Shrews: I feel like we started working on it then gave up | 14:31 |
| dtantsur | there was a user cloud/admin cloud split, I think | 14:32 |
| * brtknr is wondering why python-openstackclient doesnt work with 3.6+ | 14:32 | |
| mordred | brtknr: I am also wondering about that - since we have gate jobs for 3.6 and 3.7 | 14:34 |
| brtknr | mordred: Sorry, just realised that this is a problem with python-magnumclient so it might not apply to this | 14:36 |
| Shrews | mordred: oh we landed it. messed git history up tremendously well | 14:37 |
| mordred | Shrews: neat! | 14:37 |
| mordred | brtknr: awesome. well - for that I can't help much :) | 14:38 |
| openstackgerrit | OpenStack Release Bot proposed openstack/keystoneauth master: Update master for stable/stein https://review.openstack.org/643996 | 14:39 |
| openstackgerrit | OpenStack Release Bot proposed openstack/openstacksdk master: Update master for stable/stein https://review.openstack.org/644016 | 14:41 |
| *** e0ne has quit IRC | 14:41 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/os-client-config master: Update master for stable/stein https://review.openstack.org/644024 | 14:41 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Make factory for a CloudRegion from CONF objects https://review.openstack.org/643601 | 14:42 |
| *** e0ne has joined #openstack-sdks | 14:42 | |
| mordred | efried: ^^ took a stab at your suggestion from PS8 | 14:42 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-lib master: Update master for stable/stein https://review.openstack.org/644042 | 14:43 |
| efried | mordred: yeah, nice, guess we'll see if it works, I'll recheck the dependents. | 14:43 |
| mordred | cool | 14:43 |
| mordred | efried: once we get a version of it that we're happy with for the downstream patches, I'll work on some unittests for it | 14:44 |
| efried | mordred: any thoughts on the `valid_interfaces` debacle? | 14:45 |
| mordred | efried: you mean the need to support valid_interfaces as an alternate way of saying interface? | 14:46 |
| efried | mordred: Well, ksa adapter conf options have valid_interfaces and deprecate interface. And the thing we're doing here is accepting ksa adapter conf opts. | 14:47 |
| efried | mordred: But the logic that converts the valid_interfaces conf opt into the internal `interface` thingy - which accepts a list IIUC - only lives in the load-from-conf ksa code | 14:47 |
| mordred | heh. well - openstacksdk accepts a list or a scalar for interface | 14:47 |
| efried | which is currently embedded in a factory method that can't easily be invoked from sdk code, from what I can see. | 14:48 |
| mordred | yeah - valid_interfaces is really only a thing in oslo.config files - it's not the actual interface anywhere else | 14:48 |
| efried | Proposal: factor the logic in ksa loading into a helper method that we can call. | 14:48 |
| mordred | we could - except I don't want to deprecate interface in openstacksdk - so we'd have to make sure not to throw any warnings | 14:49 |
| mordred | (interface is the better option name - I think the issue is that oslo.config doesn't support defining a single thing as list-or-single-value and that's why we had to add valid-interfaces right? | 14:49 |
| efried | mordred: I refer to: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/adapter.py#L223-L232 | 14:49 |
| mordred | AH | 14:50 |
| efried | I think it's because we had already defined 'interface' as not a list opt? | 14:50 |
| mordred | that | 14:50 |
| efried | yeah, we don't need it to sling a warning. We just need to accept (and in fact prefer) valid_interfaces over interface in oslo conf. | 14:50 |
| mordred | yeah. and oslo.config can't have an option that's both a listopt and a stringopt | 14:50 |
| mordred | ++ | 14:50 |
| mordred | agree with that | 14:50 |
| mordred | efried: so yeah - I think extracting that into a helper method/function is a great idea | 14:51 |
| efried | rn that ends with load_from_options which instantiates Adapter, which doesn't work in the Connection flow; so we have to pull that chunk into a method. | 14:51 |
| mordred | efried: we should probably include line 220-22 too | 14:51 |
| efried | yup | 14:51 |
| efried | mordred: Okay, I can propose that, will tag ya. | 14:52 |
| mordred | efried: cool | 14:52 |
| *** e0ne has quit IRC | 14:53 | |
| *** e0ne has joined #openstack-sdks | 14:55 | |
| *** e0ne has quit IRC | 15:05 | |
| dtroyer | brtknr: have you sorted your magnumclient problem yet? I started chasing something last week that led to it failing in some gate tests elsewhere late last week… | 15:10 |
| *** Luzi has quit IRC | 15:13 | |
| brtknr | not yet, ive posted a story though: https://storyboard.openstack.org/#!/story/2005257 | 15:14 |
| *** e0ne has joined #openstack-sdks | 15:20 | |
| brtknr | dtroyer: also, it looks like there's already a fix: https://review.openstack.org/#/c/638077/4 | 15:28 |
| brtknr | dtroyer: just tested the same command using the master branch and it seems happy now | 15:29 |
| brtknr | mordred: would you be able to comment on this: https://review.openstack.org/#/c/643195/6 | 15:37 |
| *** mgariepy has joined #openstack-sdks | 15:38 | |
| mordred | brtknr: seems fine to me! | 15:39 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Do not disregard tags when updating stacks https://review.openstack.org/643195 | 15:39 |
| mordred | brtknr: rebased it on top of the latest from gtema | 15:39 |
| brtknr | mordred: thanks :) | 15:40 |
| brtknr | mordred: didn't realise I was speaking to Monty Taylor | 15:40 |
| brtknr | mordred: I'll be attending your talk at OpenInfra days :) | 15:41 |
| dtantsur | The Monty Taylor. The one and only! | 15:41 |
| mordred | uhoh. that means I might have to say things :) | 15:42 |
| mordred | brtknr: which one? | 15:42 |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Factor Adapter conf-processing logic into a helper https://review.openstack.org/644251 | 15:42 |
| brtknr | mordred: the workshop! | 15:43 |
| mordred | sweet! well - hopefully that goes well and you don't all end up throwing rotten vegetables at me | 15:44 |
| brtknr | mordred: you'll do fine I'm sure :) | 15:45 |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Factor Adapter conf-processing logic into a helper https://review.openstack.org/644251 | 15:45 |
| efried | oh look, those get posted here too ^ | 15:46 |
| mordred | efried: it's almost like these pieces all depend on each other | 15:46 |
| efried | heh | 15:46 |
| *** ttsiouts_ has quit IRC | 16:05 | |
| *** ttsiouts has joined #openstack-sdks | 16:13 | |
| *** e0ne has quit IRC | 16:14 | |
| *** e0ne has joined #openstack-sdks | 16:19 | |
| *** tssurya has quit IRC | 16:44 | |
| *** ttsiouts has quit IRC | 16:57 | |
| *** gtema has joined #openstack-sdks | 17:09 | |
| *** e0ne has quit IRC | 17:14 | |
| openstackgerrit | Eric Fried proposed openstack/openstacksdk master: WIP Make factory for a CloudRegion from CONF objects https://review.openstack.org/643601 | 17:49 |
| efried | mordred: Still need to test locally but ^ | 17:49 |
| efried | ahcrap, forgot depends-on... | 17:50 |
| openstackgerrit | Eric Fried proposed openstack/openstacksdk master: WIP Make factory for a CloudRegion from CONF objects https://review.openstack.org/643601 | 17:51 |
| *** gtema has quit IRC | 17:51 | |
| mordred | efried: update looks good | 17:59 |
| *** jpena is now known as jpena|off | 18:06 | |
| *** dtantsur is now known as dtantsur|afk | 18:23 | |
| *** gmann is now known as gmann_afk | 18:34 | |
| efried | mordred: It once again suffers the NoSuchOptError problem, and now I don't have a good way to fix it. Going to reinstate your conditional import thing, unless you think I shouldn't bother and should just trap Exception. | 18:39 |
| mordred | efried: can you not do project_name in config? (I guess that didn't work out?) | 18:42 |
| efried | mordred: that part would work; what breaks is if that group didn't import ksa opts, then you get e.g. | 18:43 |
| efried | oslo_config.cfg.NoSuchOptError: no such option valid_interfaces in group [cinder] | 18:43 |
| mordred | efried: it looks like a ConfigOpts is a collections.Mapping and defines __contains__ | 18:43 |
| mordred | oh! different issue | 18:43 |
| efried | mordred: so I would have to, like, load up the conf opts and query the group whether it has 'em before invoking the helper method, which seemed like horrible man. | 18:44 |
| mordred | efried: we could have the ksa method do a hasattr before every get? is that a terrible idea? | 18:45 |
| efried | I could put something in the helper to convert the exception to something standard, or return a bool, or... but all of that is really ugly too. | 18:45 |
| mordred | efried: or we could just trap Exception in sdk until it becomes an issue | 18:45 |
| efried | yup, that's what I'm setting up now. | 18:46 |
| openstackgerrit | Eric Fried proposed openstack/openstacksdk master: WIP Make factory for a CloudRegion from CONF objects https://review.openstack.org/643601 | 18:50 |
| efried | mordred: thar she blows | 18:50 |
| mordred | efried: I believe in her | 18:50 |
| efried | now dep updates | 18:51 |
| *** gmann_afk is now known as gmann | 18:56 | |
| *** dave-mccowan has joined #openstack-sdks | 19:06 | |
| *** whoami-rajat has quit IRC | 19:55 | |
| *** cdent_ has joined #openstack-sdks | 19:59 | |
| *** cdent has quit IRC | 20:02 | |
| *** cdent_ is now known as cdent | 20:02 | |
| *** ralonsoh has quit IRC | 20:05 | |
| *** irclogbot_2 has joined #openstack-sdks | 20:12 | |
| *** holser_ has quit IRC | 20:17 | |
| *** irclogbot_2 has quit IRC | 20:25 | |
| *** irclogbot_2 has joined #openstack-sdks | 20:27 | |
| *** e0ne has joined #openstack-sdks | 20:28 | |
| *** dave-mccowan has quit IRC | 20:39 | |
| *** e0ne has quit IRC | 20:41 | |
| *** dave-mccowan has joined #openstack-sdks | 20:44 | |
| *** holser_ has joined #openstack-sdks | 20:53 | |
| *** irclogbot_2 has quit IRC | 21:05 | |
| *** irclogbot_2 has joined #openstack-sdks | 21:07 | |
| *** irclogbot_2 has quit IRC | 21:26 | |
| *** cdent has quit IRC | 21:28 | |
| *** irclogbot_2 has joined #openstack-sdks | 21:28 | |
| *** holser_ has quit IRC | 22:50 | |
| *** tosky has quit IRC | 23:48 | |
| *** holser_ has joined #openstack-sdks | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!