| *** Qiming has joined #openstack-sdks | 00:04 | |
| *** Qiming has quit IRC | 00:08 | |
| *** Qiming has joined #openstack-sdks | 00:11 | |
| *** slaweq has joined #openstack-sdks | 00:11 | |
| *** markvoelker has quit IRC | 00:12 | |
| *** Qiming has quit IRC | 00:22 | |
| *** Qiming has joined #openstack-sdks | 00:23 | |
| *** slaweq has quit IRC | 00:24 | |
| *** markvoelker has joined #openstack-sdks | 00:43 | |
| *** whoami-rajat has joined #openstack-sdks | 00:51 | |
| *** slaweq has joined #openstack-sdks | 01:11 | |
| *** markvoelker has quit IRC | 01:21 | |
| *** slaweq has quit IRC | 01:24 | |
| *** zbr has quit IRC | 01:34 | |
| *** slaweq has joined #openstack-sdks | 02:26 | |
| *** slaweq has quit IRC | 02:39 | |
| *** slaweq has joined #openstack-sdks | 03:12 | |
| *** slaweq has quit IRC | 03:24 | |
| *** slaweq has joined #openstack-sdks | 04:11 | |
| *** slaweq has quit IRC | 04:24 | |
| *** slaweq has joined #openstack-sdks | 05:11 | |
| *** slaweq has quit IRC | 05:24 | |
| *** markvoelker has joined #openstack-sdks | 05:47 | |
| *** slaweq has joined #openstack-sdks | 06:11 | |
| *** slaweq has quit IRC | 06:24 | |
| *** slaweq has joined #openstack-sdks | 06:26 | |
| *** dayou has quit IRC | 06:30 | |
| *** slaweq has quit IRC | 06:36 | |
| *** yolanda has quit IRC | 06:36 | |
| *** e0ne has joined #openstack-sdks | 06:40 | |
| *** masayukig[m]2 is now known as masayukig[m] | 06:45 | |
| *** masayukig[m] is now known as masayuki4 | 06:45 | |
| *** dayou has joined #openstack-sdks | 06:47 | |
| *** masayuki4 is now known as masayuki6 | 06:48 | |
| *** masayuki6 is now known as masayukig[m] | 06:48 | |
| *** Luzi has joined #openstack-sdks | 06:48 | |
| *** masayukig[m] is now known as masayukig | 06:48 | |
| *** yolanda has joined #openstack-sdks | 07:09 | |
| *** slaweq has joined #openstack-sdks | 07:11 | |
| *** tonyb is now known as tonyb_gone | 07:20 | |
| *** tonyb_gone is now known as tonyb | 07:21 | |
| *** slaweq has quit IRC | 07:24 | |
| *** e0ne has quit IRC | 07:31 | |
| *** slaweq has joined #openstack-sdks | 07:34 | |
| *** gkadam has joined #openstack-sdks | 07:48 | |
| *** kailun has joined #openstack-sdks | 07:49 | |
| kailun | amotoki: hi | 07:49 |
|---|---|---|
| amotoki | kailun: hi | 07:49 |
| *** e0ne has joined #openstack-sdks | 07:51 | |
| kailun | amotoki: regarding L193 in review 624798, there is another case, that is --shared, --private and --project are all not specified | 07:51 |
| kailun | amotoki: in this situation, we should consider the created range to be a "shared" one, which means "project_id" should not be populated into the attr | 07:52 |
| amotoki | kailun: before digging into the detail, let me sort out which patterns are possible. | 07:53 |
| kailun | amotoki: based on the current logic, this'll goto L205 which populates attrs w/ the current project_id, this is not expected | 07:53 |
| kailun | amotoki: sure | 07:54 |
| amotoki | kailun: possible patterns are (a) none of --shared, --private and --project are specified (b) --shared only (c) --private only (d) --private and --project | 07:55 |
| kailun | amotoki: we should have 6 patterns I guess? | 07:55 |
| amotoki | kailun: the above are valid, right? | 07:55 |
| amotoki | kailun: (e) --project only and (f) --project and --shared are invalid. | 07:56 |
| kailun | amotoki: right | 07:56 |
| amotoki | kailun: regarding L.193, I think the previous logic looks enough. | 07:57 |
| amotoki | it is because "if not parsed_args.private and parsed_args.project" (L.171) catches (e) and (f) cases. | 07:58 |
| amotoki | right? | 07:58 |
| kailun | amotoki: yes, I agree | 07:58 |
| kailun | amotoki: L205 is needed | 07:58 |
| amotoki | kailun: looking at L.205 now | 07:58 |
| amotoki | kailun: L.182-186 ensures attrs['shared'] is False only when --private is specified, so "elif not attrs['shared']" at L.205 looks enough. | 08:00 |
| amotoki | kailun: I mean "and not parsed_args.shared" looks unnecessary at L.205. | 08:00 |
| kailun | amotoki: agree | 08:01 |
| amotoki | kailun: thanks for clarification. I try to simplify the logic for easy maintenance. | 08:02 |
| *** tssurya has joined #openstack-sdks | 08:02 | |
| amotoki | kailun: I will add a note to the review based on this discussion. | 08:02 |
| kailun | amotoki: I kind of know that some conditions are necessary when I write that patch, I just want to make it easier from a semantic level | 08:03 |
| kailun | amotoki: anyway, great thanks for your review, make sense to me | 08:03 |
| amotoki | kailun: yw | 08:03 |
| kailun | *unnecessary | 08:03 |
| amotoki | kailun: I post follow-up comments in your review. thanks | 08:06 |
| kailun | amotoki: sure, thanks much | 08:06 |
| *** ralonsoh has joined #openstack-sdks | 08:09 | |
| openstackgerrit | Kailun Qin proposed openstack/python-openstackclient master: Fix: incorrect check when no shared/private input https://review.openstack.org/642708 | 08:10 |
| *** holser_ has joined #openstack-sdks | 08:15 | |
| *** e0ne has quit IRC | 08:36 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Delete the LB object quotas set command in openstackclient https://review.openstack.org/576465 | 08:48 |
| *** jpena|off is now known as jpena | 08:49 | |
| *** ttsiouts has joined #openstack-sdks | 08:53 | |
| *** jpich has joined #openstack-sdks | 08:58 | |
| *** zbr has joined #openstack-sdks | 09:06 | |
| *** ttsiouts has quit IRC | 09:06 | |
| *** ttsiouts has joined #openstack-sdks | 09:07 | |
| *** ttsiouts has quit IRC | 09:11 | |
| *** dtantsur|afk is now known as dtantsur | 09:14 | |
| *** gtema has joined #openstack-sdks | 09:24 | |
| *** ttsiouts has joined #openstack-sdks | 09:26 | |
| *** holser_ has quit IRC | 09:32 | |
| *** cdent has joined #openstack-sdks | 09:32 | |
| *** jangutter has joined #openstack-sdks | 09:59 | |
| *** dave-mccowan has joined #openstack-sdks | 10:40 | |
| *** dave-mccowan has quit IRC | 10:45 | |
| *** holser_ has joined #openstack-sdks | 11:01 | |
| openstackgerrit | Merged openstack/openstacksdk master: Collapse OpenStackSDKAdapter into Proxy https://review.openstack.org/642231 | 11:03 |
| *** cdent has quit IRC | 11:09 | |
| *** tosky has joined #openstack-sdks | 11:17 | |
| *** gkadam_ has joined #openstack-sdks | 11:24 | |
| *** jpena is now known as jpena|lunch | 11:25 | |
| *** gkadam has quit IRC | 11:25 | |
| *** e0ne has joined #openstack-sdks | 11:36 | |
| *** cdent has joined #openstack-sdks | 11:51 | |
| *** jpena|lunch is now known as jpena | 12:00 | |
| *** ttsiouts has quit IRC | 12:06 | |
| *** ttsiouts has joined #openstack-sdks | 12:06 | |
| *** ttsiouts has quit IRC | 12:11 | |
| *** markvoelker has quit IRC | 12:12 | |
| *** markvoelker has joined #openstack-sdks | 12:13 | |
| *** ttsiouts has joined #openstack-sdks | 12:28 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | 12:41 |
| mordred | cmurphy, kmalloc, adriant: ^^ I think that should do the trick re: yesterday's discussion of unscoped identity operations | 12:42 |
| *** e0ne has quit IRC | 13:05 | |
| *** tosky has quit IRC | 13:22 | |
| *** cdent_ has joined #openstack-sdks | 13:54 | |
| *** cdent has quit IRC | 13:54 | |
| *** cdent_ is now known as cdent | 13:54 | |
| *** gkadam_ has quit IRC | 14:02 | |
| *** irclogbot_2 has quit IRC | 14:09 | |
| *** e0ne has joined #openstack-sdks | 14:10 | |
| *** irclogbot_2 has joined #openstack-sdks | 14:12 | |
| *** irclogbot_2 has quit IRC | 14:25 | |
| *** irclogbot_2 has joined #openstack-sdks | 14:28 | |
| *** Luzi has quit IRC | 15:14 | |
| openstackgerrit | Glenn Van de Water proposed openstack/python-openstackclient master: Fix service discovery in functional tests https://review.openstack.org/642074 | 15:17 |
| *** cdent has quit IRC | 15:28 | |
| *** irclogbot_2 has quit IRC | 15:36 | |
| *** irclogbot_2 has joined #openstack-sdks | 15:39 | |
| *** irclogbot_2 has quit IRC | 15:49 | |
| *** irclogbot_2 has joined #openstack-sdks | 15:51 | |
| *** irclogbot_2 has quit IRC | 15:52 | |
| *** irclogbot_2 has joined #openstack-sdks | 15:56 | |
| *** holser_ has quit IRC | 15:58 | |
| *** holser_ has joined #openstack-sdks | 16:01 | |
| *** cdent has joined #openstack-sdks | 16:09 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Split OpenStackCloud into reasonable pieces https://review.openstack.org/642218 | 16:10 |
| *** gtema has quit IRC | 16:13 | |
| *** gtema has joined #openstack-sdks | 16:30 | |
| *** holser_ has quit IRC | 16:41 | |
| *** dave-mccowan has joined #openstack-sdks | 16:42 | |
| *** gtema has quit IRC | 16:50 | |
| *** e0ne has quit IRC | 17:01 | |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| *** tssurya has quit IRC | 17:26 | |
| *** dave-mccowan has quit IRC | 17:27 | |
| *** jpich has quit IRC | 17:35 | |
| *** jpena is now known as jpena|off | 17:42 | |
| *** ttsiouts has quit IRC | 18:01 | |
| *** ttsiouts has joined #openstack-sdks | 18:01 | |
| mordred | cmurphy, kmalloc: does a domain scoped token get a catalog in its token? | 18:05 |
| *** ttsiouts has quit IRC | 18:05 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | 18:17 |
| *** ralonsoh has quit IRC | 18:31 | |
| *** gmann is now known as gmann_afk | 18:48 | |
| cmurphy | mordred: yes it's basically the same as a project token | 18:51 |
| mordred | kk. cool. so that update should make more sense then | 18:52 |
| *** e0ne has joined #openstack-sdks | 19:01 | |
| cmurphy | cool | 19:11 |
| mordred | cmurphy: so ... there is a possibly completely ill-conceived feature in sdk that your review comment has indicated to me that I should fix | 19:27 |
| cmurphy | \o/ | 19:27 |
| mordred | cmurphy: oh - no - we already do the correct thing. double \o/ | 19:40 |
| cmurphy | awesome | 19:41 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | 19:42 |
| mordred | cmurphy: I think *that* should be correct now | 19:42 |
| cmurphy | mordred: lgtm | 19:46 |
| mordred | yay | 19:47 |
| mordred | thanks for the reviews there | 19:47 |
| cmurphy | np | 19:47 |
| *** e0ne has quit IRC | 20:38 | |
| *** gmann_afk is now known as gmann | 20:41 | |
| *** e0ne has joined #openstack-sdks | 20:41 | |
| *** e0ne has quit IRC | 20:45 | |
| *** whoami-rajat has quit IRC | 21:11 | |
| adriant | mordred: will take a look! | 21:30 |
| *** cdent has quit IRC | 21:37 | |
| mordred | adriant: uhoh. maybe I should fix the tests ... | 21:41 |
| adriant | Yes, test is busted :P | 21:41 |
| *** cdent has joined #openstack-sdks | 21:42 | |
| *** cdent has quit IRC | 21:42 | |
| adriant | oh and mordred, I'll have a new patch up for the Project Resource Cleanup goal hopefully today which rewrites it as additions to the SDK | 21:42 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use auth_url as identity endpoint when not project scoped https://review.openstack.org/643037 | 21:45 |
| mordred | adriant: woot! | 21:53 |
| mordred | adriant: (woot on resource cleanup goal) | 21:53 |
| mordred | adriant: also - I think that latest patch is better from a testing perspective - the previous break was due to being lazy and trying to reuse an exitsing test fixture | 21:53 |
| *** tosky has joined #openstack-sdks | 21:56 | |
| kmalloc | hah =/ | 22:03 |
| brtknr | hey all, how do i make sure os_stack ansible module passes tag arg correctly to update_stack function? | 22:15 |
| brtknr | the server is returning this error: File \"/usr/lib/python2.7/dist-packages/heat/engine/parameters.py\", line 554, in _validate_user_parameters\n raise exception.UnknownUserParameter(key=param)\n\nUnknownUserParameter: The Parameter (tags) was not defined in template. | 22:22 |
| brtknr | IIUC, tags is not a user parameter | 22:22 |
| *** lifeless has quit IRC | 22:27 | |
| *** lifeless has joined #openstack-sdks | 22:27 | |
| *** adriant has quit IRC | 22:29 | |
| *** holser_ has joined #openstack-sdks | 22:40 | |
| *** slaweq has quit IRC | 23:05 | |
| *** slaweq has joined #openstack-sdks | 23:11 | |
| *** slaweq has quit IRC | 23:15 | |
| *** tosky has quit IRC | 23:23 | |
| *** dave-mccowan has joined #openstack-sdks | 23:28 | |
| *** dave-mccowan has quit IRC | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!