| *** ttsiouts has quit IRC | 00:02 | |
| *** tosky has quit IRC | 00:29 | |
| *** dave-mccowan has joined #openstack-sdks | 00:51 | |
| *** Qiming has quit IRC | 00:59 | |
| *** Qiming has joined #openstack-sdks | 01:00 | |
| openstackgerrit | Duc Truong proposed openstack/openstacksdk master: Change Resource location type to Header https://review.openstack.org/631362 | 01:07 |
|---|---|---|
| *** slaweq has joined #openstack-sdks | 01:11 | |
| *** dave-mccowan has quit IRC | 01:15 | |
| *** slaweq has quit IRC | 01:16 | |
| *** mriedem has quit IRC | 01:39 | |
| *** bobh has joined #openstack-sdks | 01:57 | |
| *** adriant has quit IRC | 02:17 | |
| *** edleafe has quit IRC | 02:19 | |
| *** adriant has joined #openstack-sdks | 02:20 | |
| *** bobh has quit IRC | 02:37 | |
| *** manfred has joined #openstack-sdks | 02:40 | |
| *** lifeless has quit IRC | 02:40 | |
| *** lifeless has joined #openstack-sdks | 02:41 | |
| *** gtmanfred has quit IRC | 02:42 | |
| *** manfred is now known as gtmanfred | 02:42 | |
| *** gtmanfred is now known as excitebike | 02:42 | |
| *** excitebike is now known as dontcare | 02:42 | |
| *** dontcare is now known as gtmanfred | 02:42 | |
| *** toabctl has quit IRC | 02:46 | |
| *** nicholas has quit IRC | 02:46 | |
| *** odyssey4me has quit IRC | 02:46 | |
| *** larsks has quit IRC | 02:46 | |
| *** larsks has joined #openstack-sdks | 02:58 | |
| *** slaweq has joined #openstack-sdks | 03:11 | |
| *** slaweq has quit IRC | 03:15 | |
| *** lifeless has quit IRC | 04:30 | |
| *** slaweq has joined #openstack-sdks | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** lifeless has joined #openstack-sdks | 05:51 | |
| *** slaweq has joined #openstack-sdks | 06:11 | |
| *** radeks has joined #openstack-sdks | 06:12 | |
| *** radeks_ has joined #openstack-sdks | 06:14 | |
| *** slaweq has quit IRC | 06:16 | |
| *** radeks has quit IRC | 06:17 | |
| *** rcarrillocruz has joined #openstack-sdks | 06:27 | |
| *** Luzi has joined #openstack-sdks | 06:43 | |
| *** slaweq has joined #openstack-sdks | 06:56 | |
| *** radeks_ has quit IRC | 07:16 | |
| *** radeks_ has joined #openstack-sdks | 07:32 | |
| *** e0ne has joined #openstack-sdks | 07:52 | |
| *** gtema has joined #openstack-sdks | 08:14 | |
| *** radeks__ has joined #openstack-sdks | 08:36 | |
| *** jpich has joined #openstack-sdks | 08:38 | |
| *** radeks_ has quit IRC | 08:39 | |
| *** jpena|off is now known as jpena | 08:39 | |
| *** tosky has joined #openstack-sdks | 08:40 | |
| *** dtantsur|afk is now known as dtantsur | 09:25 | |
| *** odyssey4me has joined #openstack-sdks | 09:44 | |
| *** odyssey4me has quit IRC | 10:49 | |
| *** gtema has quit IRC | 10:51 | |
| *** cdent has joined #openstack-sdks | 10:54 | |
| *** e0ne has quit IRC | 11:44 | |
| *** e0ne has joined #openstack-sdks | 11:52 | |
| *** jpena is now known as jpena|lunch | 12:45 | |
| *** irclogbot_2 has quit IRC | 12:48 | |
| *** bobh has joined #openstack-sdks | 12:55 | |
| *** irclogbot_2 has joined #openstack-sdks | 12:58 | |
| *** gtema has joined #openstack-sdks | 13:11 | |
| *** irclogbot_2 has quit IRC | 13:12 | |
| *** bobh has quit IRC | 13:19 | |
| *** irclogbot_2 has joined #openstack-sdks | 13:27 | |
| *** edleafe- has joined #openstack-sdks | 13:30 | |
| *** edleafe- is now known as edleafe | 13:31 | |
| *** irclogbot_2 has quit IRC | 13:35 | |
| *** radeks__ has quit IRC | 13:36 | |
| *** jpena|lunch is now known as jpena | 13:41 | |
| *** irclogbot_2 has joined #openstack-sdks | 13:49 | |
| *** e0ne has quit IRC | 13:53 | |
| *** e0ne has joined #openstack-sdks | 13:59 | |
| *** radeks__ has joined #openstack-sdks | 14:08 | |
| *** gtema has quit IRC | 14:31 | |
| *** mriedem has joined #openstack-sdks | 14:58 | |
| *** radeks__ has quit IRC | 15:21 | |
| *** radeks__ has joined #openstack-sdks | 15:21 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add class to override clustering delete responses https://review.openstack.org/631362 | 15:31 |
| *** ignatenkobrain has quit IRC | 15:32 | |
| *** Luzi has quit IRC | 15:33 | |
| *** ignatenkobrain has joined #openstack-sdks | 15:35 | |
| *** radeks__ has quit IRC | 15:55 | |
| edleafe | API-SIG Office Hour starts in 2 minutes. Buckle your seat belts! | 15:58 |
| dtantsur | do they serve drinks in this flight? | 15:59 |
| edleafe | Yes, but they're cash-only | 15:59 |
| tosky | those low-cost companies | 16:00 |
| dtantsur | ah this low-cost world | 16:00 |
| dtantsur | great minds think alike, yeah? | 16:00 |
| edleafe | You'd think moving from a WG to a SIG would be a step up, right? | 16:00 |
| tosky | :D | 16:00 |
| elmiko | o/ | 16:01 |
| elmiko | someone say drinks? | 16:01 |
| dtantsur | lol | 16:02 |
| *** e0ne has quit IRC | 16:25 | |
| elmiko | heads up edleafe dtantsur, i'll be on CET next week so i will most likely show up for the early session (gonna be at a conference) | 16:56 |
| edleafe | elmiko: ack | 16:56 |
| *** aspiers has joined #openstack-sdks | 17:02 | |
| *** evrardjp has joined #openstack-sdks | 17:02 | |
| *** witek has joined #openstack-sdks | 17:02 | |
| aspiers | hi... we have a question about what the path for the new version of the oslo.middleware healthcheck API should be | 17:03 |
| aspiers | IIUC the current one is /healthcheck | 17:03 |
| aspiers | no doubt I'm about to ask a stupid question as never worked with OpenStack API code before | 17:04 |
| aspiers | but I guess /v2/healthcheck is a bad idea since that stomps on the whole microversion thing? | 17:04 |
| edleafe | aspiers: I'm not familiar with the usage. Do users specify a version for the healthcheck call? | 17:04 |
| evrardjp | edleafe: not right nwo | 17:04 |
| aspiers | I think the idea was to specify it in the path | 17:04 |
| aspiers | but we're open to recommendations | 17:04 |
| aspiers | https://review.openstack.org/#/c/617924/1/oslo_middleware/healthcheck/__init__.py | 17:04 |
| aspiers | is the WIP prototype from mugsie | 17:05 |
| edleafe | Generally a header is preferred over mangling the path with version info | 17:05 |
| aspiers | I'm just polishing it up now | 17:05 |
| dtantsur | elmiko: cool! | 17:05 |
| aspiers | edleafe: OK, but this would be a different header to the normal microversion? | 17:05 |
| dtantsur | "normal microversion"? :D | 17:05 |
| elmiko | dtantsur: you gonna be at devconf? | 17:05 |
| dtantsur | elmiko: devconf.cz - yep | 17:05 |
| evrardjp | aspiers: it could technically be the same header, it's a different path | 17:06 |
| mugsie | in this case, there is a pre-existing URL, so it should be something like /status - move away from the /healthcheck that v1 uses | 17:06 |
| dtantsur | OpenStack-Api-Version: compute 2.42, healthcheck 1.1\ | 17:06 |
| dtantsur | or something | 17:06 |
| elmiko | dtantsur: \o/ | 17:06 |
| aspiers | right, that one | 17:06 |
| edleafe | aspiers: microversions are per-call | 17:06 |
| evrardjp | mugsie: I like that idea | 17:06 |
| aspiers | edleafe: sure | 17:06 |
| aspiers | evrardjp: me too | 17:06 |
| aspiers | status can be about more than just health | 17:07 |
| mugsie | and microversions make it unusable for a lot of monitoring application uses - so we should avodi it if possible | 17:07 |
| cdent | I think if we want the middleware to be super easy, all it should be is a path | 17:07 |
| dtantsur | just a word of caution: obvious things like /status may clash with services that do not use major versions | 17:07 |
| evrardjp | mugsie: agreed again | 17:07 |
| mugsie | dtantsur: true | 17:07 |
| evrardjp | cdent: ok | 17:07 |
| aspiers | ah ok | 17:07 |
| aspiers | Apache has mod_status.so which uses /status IIRC | 17:07 |
| dtantsur | so if we declare a standard endpoint, we may want it verbose. something like /openstack-status | 17:07 |
| edleafe | mugsie: my only concern is when you run out of synonyms for 'healthcheck' :) | 17:07 |
| aspiers | although that is optional | 17:08 |
| mugsie | /statuscheck /superhealthcheck | 17:08 |
| dtantsur | just to make sure e.g. Placement never wants to introduce its own /status :) | 17:08 |
| evrardjp | dtantsur: thanks for the advice here , I would totally have forgotten that | 17:08 |
| dtantsur | now, if you do insist on major versions (we you shouldn't), it could be /openstack-status/v1 | 17:09 |
| * dtantsur is not sure what he meant by "we" | 17:09 | |
| evrardjp | haha | 17:09 |
| aspiers | there is some benefit to being somewhat consistent with the existing /healthcheck | 17:09 |
| aspiers | /healthcheck-v2 ? | 17:09 |
| dtantsur | what is this benefit? | 17:10 |
| * evrardjp takes his bike to the shed | 17:10 | |
| aspiers | and we want to leave room for v3 somehow :) | 17:10 |
| dtantsur | if you want to leave room for large changes, use microversions | 17:10 |
| mugsie | dont | 17:10 |
| aspiers | dtantsur: so that people aren't confused about two totally different endpoints coming from the same oslo.middleware code | 17:10 |
| elmiko | mugsie: ++ for /superhealthcheck XD | 17:10 |
| mugsie | microversions will make it really hard for a lot of monitoring tools | 17:10 |
| evrardjp | I think it would be fine to later add different path for different /superhealthchecks | 17:10 |
| evrardjp | mugsie: I agree with you there | 17:11 |
| dtantsur | mugsie: microversions are hard for everything, essentially | 17:11 |
| * dtantsur hides | 17:11 | |
| evrardjp | we need the simplest thing for monitoring | 17:11 |
| mugsie | personally, I am OK with /v<number>, but thats just me | 17:11 |
| aspiers | I don't want to have to write a doc which says "for v1, use /healthcheck, for v2 use /openstack-status, and for v3 use /superawesomebunchofchecks" | 17:11 |
| dtantsur | I don't see a problem with ^^ tbh | 17:11 |
| dtantsur | especially if openstack-status is broader than healthcheck | 17:12 |
| aspiers | OK I can try to privately deal with my OCD about inconsistency then :) | 17:12 |
| edleafe | The problem is the repeated change of the API. | 17:12 |
| dtantsur | I hear you, it can be painful | 17:12 |
| elmiko | i'm more in favor of a commonly known path that could live outside of any path-based versioning scheme, but that's just my opinion | 17:12 |
| dtantsur | hmm, we can do /healthcheck/v2 even while keeping /healthcheck | 17:12 |
| elmiko | i don't have a strong technical argument | 17:12 |
| aspiers | dtantsur: if that works, it sounds good | 17:13 |
| evrardjp | elmiko: /healthcheck-v2.0 then /healthcheck-v3.0 ? | 17:13 |
| mugsie | elmiko: this should be independant of the API version | 17:13 |
| evrardjp | should that happen later? | 17:13 |
| dtantsur | just make /healthcheck/(?!v2) redirect to /healthcheck/v1 and move the old stuff to /v1 | 17:13 |
| *** masayukig[m] has joined #openstack-sdks | 17:13 | |
| elmiko | honestly, we should get this stuff written into the proposed spec/guideline for health checks | 17:13 |
| elmiko | mugsie: right, that's why i like it to live on a consistent endpoint | 17:13 |
| edleafe | dtantsur: that's the least terrible so far | 17:13 |
| dtantsur | so e.g. /healthcheck/foo/bar redirects to /healthcheck/v1/foo/bar | 17:13 |
| evrardjp | elmiko: it sounds like we're gonna get 10 different answers | 17:13 |
| dtantsur | but /healthcheck/v2/foo/bar is just v2 | 17:13 |
| aspiers | LOL, we're back where we were in the same bikeshed as 2 years ago XD | 17:13 |
| elmiko | evrardjp: imo, /healthcheck/v{whatever} is preferable | 17:14 |
| elmiko | evrardjp: yup, pretty much | 17:14 |
| aspiers | I like /healthcheck/v$NUMBER | 17:14 |
| dtantsur | I think we actually do it in ironic with our only major version (/nodes equivalent to /v1/nodes) | 17:14 |
| mugsie | +1 | 17:14 |
| aspiers | mugsie: that work for you? | 17:14 |
| edleafe | Not to divert the conversation, but what is driving the need for new healthcheck versions? | 17:14 |
| dtantsur | edleafe: it's a good question actually | 17:14 |
| aspiers | edleafe: https://storyboard.openstack.org/#!/story/2001439 | 17:14 |
| mugsie | edleafe: the old one misses some information, and the body changes | 17:14 |
| aspiers | please read that first :) | 17:15 |
| aspiers | there's a lot of history here | 17:15 |
| aspiers | a *lot* | 17:15 |
| *** mattoliverau has joined #openstack-sdks | 17:15 | |
| aspiers | about 2+ years of bikeshedding | 17:15 |
| aspiers | ;-0 | 17:15 |
| dtantsur | "please read these 2 years of bikeshedding history first", thanks, so nice of you :D | 17:15 |
| edleafe | dtantsur: it'll cure your insomnia :) | 17:15 |
| dtantsur | so, breaking changes? | 17:15 |
| evrardjp | edleafe: also check L105 around https://etherpad.openstack.org/p/BER-t-series-goals | 17:15 |
| evrardjp | even if it's not enough for the context | 17:16 |
| elmiko | imo aspiers, whoever is writing the initial draft spec/guideline you just pick a path and we can debate the wording in the pr | 17:17 |
| elmiko | at least get a vote on record at that point | 17:18 |
| elmiko | i'm fine to see my opinion lose in the end, but at least some sort of roll call on the pr would help drive the discussion | 17:18 |
| elmiko | (unless this has already happened and i missed it all XD) | 17:18 |
| edleafe | My feelings on API changes is to not release it until there is very little liklihood of it needing to be changed in the foreseeable future. IOW, it should not be an iterative process | 17:18 |
| elmiko | ++ agreed | 17:19 |
| elmiko | mind you, i am not proposing the release but the spec/guideline that proposes the usage | 17:19 |
| *** jpich has quit IRC | 17:19 | |
| *** radeks__ has joined #openstack-sdks | 17:23 | |
| dtantsur | yeah, a spec would be nice (I thought we had one?) | 17:24 |
| *** witek has quit IRC | 17:24 | |
| elmiko | i thought we did too, but maybe mugsie did such a good job presenting it that i just didn't notice XD | 17:27 |
| cdent | clearly the healthcheck can be written, tested, and nearly packaged without ever needing to choose its official name, yes? | 17:28 |
| elmiko | oh definitely | 17:28 |
| elmiko | /s | 17:28 |
| cdent | in fact, ideally the middleware would be written with the name being a parameter | 17:28 |
| cdent | (with a default) | 17:28 |
| mugsie | cdent: I did think about that | 17:28 |
| mugsie | But I like the idea that we have a single well known url | 17:28 |
| elmiko | i do too mugsie | 17:29 |
| mugsie | just make it part of the refstack tests with the good URL, and that should fix it :P | 17:29 |
| cdent | mugsie: oh, yeah, I want there to be a single well known url too | 17:29 |
| cdent | I'm just saying that the coding doesn't require that | 17:29 |
| mugsie | in 2-5 years | 17:29 |
| elmiko | heh, ++ | 17:30 |
| elmiko | well see, we just add a new entry in the service catalog for healthcheck uris..... (kidding!) | 17:30 |
| * cdent glares at elmiko | 17:31 | |
| * elmiko runs | 17:31 | |
| dtantsur | welll | 17:31 |
| dtantsur | it's kind of these additional fields in DNS, right? | 17:31 |
| elmiko | metadata all the things! \o/ | 17:31 |
| dtantsur | so we probably could do it.. but then the monitoring tools will have to learn about the catalog | 17:32 |
| elmiko | ok, i'm headed out for lunch. take care all o/ | 17:35 |
| dtantsur | yeah, I should go as well | 17:36 |
| *** dtantsur is now known as dtantsur|afk | 17:37 | |
| *** jpena is now known as jpena|off | 17:43 | |
| *** e0ne has joined #openstack-sdks | 18:14 | |
| *** e0ne has quit IRC | 18:16 | |
| *** bobh has joined #openstack-sdks | 18:23 | |
| *** e0ne has joined #openstack-sdks | 18:36 | |
| *** bobh has quit IRC | 18:39 | |
| *** radeks__ has quit IRC | 18:56 | |
| *** ttsiouts has joined #openstack-sdks | 19:11 | |
| *** ttsiouts has quit IRC | 19:11 | |
| *** bobh has joined #openstack-sdks | 19:18 | |
| *** radeks__ has joined #openstack-sdks | 19:33 | |
| *** e0ne has quit IRC | 19:44 | |
| *** toabctl has joined #openstack-sdks | 20:05 | |
| *** gtema has joined #openstack-sdks | 20:12 | |
| *** irclogbot_2 has quit IRC | 20:37 | |
| *** irclogbot_2 has joined #openstack-sdks | 20:48 | |
| *** openstackgerrit has quit IRC | 20:56 | |
| *** bobh has quit IRC | 21:30 | |
| *** cdent has quit IRC | 21:48 | |
| *** mriedem has quit IRC | 21:49 | |
| *** mriedem has joined #openstack-sdks | 21:56 | |
| *** radeks__ has quit IRC | 22:05 | |
| *** mriedem has quit IRC | 23:17 | |
| *** tosky has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!