| *** mriedem has quit IRC | 00:27 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Turn off unneeded devstack services https://review.openstack.org/626058 | 00:41 |
|---|---|---|
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: More volume functional test fixes https://review.openstack.org/626020 | 01:10 |
| *** dayou has quit IRC | 01:59 | |
| *** dayou has joined #openstack-sdks | 02:06 | |
| *** dave-mccowan has joined #openstack-sdks | 03:05 | |
| *** dave-mccowan has quit IRC | 03:24 | |
| *** bobh has joined #openstack-sdks | 03:25 | |
| *** slaweq has quit IRC | 04:13 | |
| *** bobh has quit IRC | 04:30 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: More volume functional test fixes https://review.openstack.org/626020 | 04:33 |
| *** gildub has joined #openstack-sdks | 04:40 | |
| *** bobh has joined #openstack-sdks | 04:43 | |
| *** bobh has quit IRC | 05:22 | |
| *** gildub has quit IRC | 05:24 | |
| *** dims has quit IRC | 06:27 | |
| *** dims has joined #openstack-sdks | 06:28 | |
| *** dims has quit IRC | 06:33 | |
| *** dims has joined #openstack-sdks | 06:34 | |
| *** mgagne has quit IRC | 06:35 | |
| *** mgagne has joined #openstack-sdks | 06:40 | |
| *** ianw is now known as ianw_pto | 06:43 | |
| *** slaweq has joined #openstack-sdks | 07:59 | |
| *** tosky has joined #openstack-sdks | 08:02 | |
| *** markvoelker has joined #openstack-sdks | 08:10 | |
| *** gkadam has joined #openstack-sdks | 08:11 | |
| *** jpena|off is now known as jpena | 08:47 | |
| *** e0ne has joined #openstack-sdks | 08:47 | |
| *** jpich has joined #openstack-sdks | 09:04 | |
| *** e0ne has quit IRC | 09:28 | |
| *** e0ne has joined #openstack-sdks | 09:50 | |
| *** ttsiouts has joined #openstack-sdks | 09:58 | |
| *** gtema has joined #openstack-sdks | 10:15 | |
| *** ttsiouts has quit IRC | 10:16 | |
| *** ttsiouts has joined #openstack-sdks | 10:16 | |
| *** ttsiouts has quit IRC | 10:21 | |
| *** ttsiouts has joined #openstack-sdks | 10:25 | |
| *** ssbarnea|rover has joined #openstack-sdks | 10:37 | |
| *** e0ne has quit IRC | 11:09 | |
| *** ttsiouts has quit IRC | 11:27 | |
| *** e0ne has joined #openstack-sdks | 12:01 | |
| *** ttsiouts has joined #openstack-sdks | 12:20 | |
| *** jpena is now known as jpena|lunch | 12:29 | |
| *** ttsiouts has quit IRC | 12:54 | |
| *** ttsiouts has joined #openstack-sdks | 12:57 | |
| *** jpena|lunch is now known as jpena | 13:01 | |
| *** bobh has joined #openstack-sdks | 13:04 | |
| *** mriedem has joined #openstack-sdks | 13:06 | |
| *** dave-mccowan has joined #openstack-sdks | 13:08 | |
| *** gtema has quit IRC | 13:14 | |
| *** markvoelker has quit IRC | 13:24 | |
| *** e0ne has quit IRC | 13:43 | |
| *** e0ne has joined #openstack-sdks | 14:02 | |
| *** bobh has quit IRC | 14:25 | |
| *** ssbarnea|rover has quit IRC | 14:40 | |
| *** ssbarnea has joined #openstack-sdks | 14:41 | |
| *** cdent has joined #openstack-sdks | 16:01 | |
| *** bobh has joined #openstack-sdks | 16:06 | |
| *** bobh has quit IRC | 16:06 | |
| *** bobh has joined #openstack-sdks | 16:08 | |
| *** e0ne has quit IRC | 17:05 | |
| *** jpich has quit IRC | 17:11 | |
| *** ttsiouts has quit IRC | 17:14 | |
| *** e0ne has joined #openstack-sdks | 17:19 | |
| *** e0ne has quit IRC | 17:24 | |
| *** gkadam has quit IRC | 17:46 | |
| *** jpena is now known as jpena|off | 17:54 | |
| *** cdent has quit IRC | 18:15 | |
| *** e0ne has joined #openstack-sdks | 18:33 | |
| *** tobiash has quit IRC | 18:35 | |
| *** e0ne has quit IRC | 18:40 | |
| *** tobiash has joined #openstack-sdks | 18:44 | |
| *** tobiash has quit IRC | 18:47 | |
| *** tobiash has joined #openstack-sdks | 18:48 | |
| mordred | Shrews: sorry for the delay - I'm sort of down a little bit of a rabbit hole poking at tests that aren't doing what we think they are | 19:29 |
| Shrews | mordred: i don't have you on any timer | 19:32 |
| mordred | Shrews: I ... I started pulling on some threads | 19:33 |
| Shrews | spelunk down those rabbit holes if it entertains you :) | 19:33 |
| mordred | Shrews: "entertain" | 19:35 |
| *** gouthamr_ is now known as gouthamr | 19:38 | |
| *** e0ne has joined #openstack-sdks | 19:40 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Properly munch for resource sub-dicts https://review.openstack.org/625923 | 19:45 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start using direct REST in normalize tests https://review.openstack.org/626379 | 19:45 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Compute location properly in server https://review.openstack.org/626380 | 19:45 |
| mordred | Shrews: the first two are solid, the third is a deeper rabbit hole that needs to be done but is not essential for this moment in time | 19:46 |
| Shrews | looking | 19:46 |
| Shrews | mordred: what is 'original_names'? | 19:48 |
| mordred | Shrews: it's whether you want the dict from the sdk Resource to have the keys as they came from the remote host, or whether you want it to have its already normalized names | 19:49 |
| mordred | Shrews: right now in the shade layer we're asking for original_names so that our normalize things, which were written to normalize the unnormalized names, will still work | 19:50 |
| mordred | but that's so many layers or normalizing | 19:50 |
| mordred | Shrews: I was figuring that a two-step approach to getting to just returning the Resource objects directly would be a patch to say original_names=False with the update to the normalize function - then a patch to update the Resource with any missing fields, remove the normalize function and just return the resource | 19:51 |
| mordred | Shrews: although, in reality, it's likely more confusing to do that- and just doing a patch to return the resource directly is fine... | 19:52 |
| mordred | Shrews: at least once the test_normalize file is actually doing all requests_mock so we're testing the outcome of calling the method | 19:52 |
| mordred | since that shoudl then let us test that we're not breaking contract over the switch | 19:52 |
| *** tobiash has quit IRC | 19:53 | |
| Shrews | mordred: we should probably make tobiash's new test depend on that when it is ready to validate it fixes the nodepool issue | 19:54 |
| Shrews | (and doesn't break something _else_) | 19:55 |
| mordred | ++ | 19:55 |
| Shrews | mordred: https://review.openstack.org/#/c/626379/1/openstack/tests/unit/base.py <-- you don't like 'p' in your project names???? :) | 19:58 |
| *** tobiash has joined #openstack-sdks | 19:58 | |
| Shrews | line 216 | 19:58 |
| mordred | Shrews: p's are for lusers | 19:58 |
| Shrews | i thought they were for posers | 19:59 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Properly munch for resource sub-dicts https://review.openstack.org/625923 | 20:19 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start using direct REST in normalize tests https://review.openstack.org/626379 | 20:19 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Compute location properly in server https://review.openstack.org/626380 | 20:19 |
| mordred | Shrews: ok. I think that should take care of the issues | 20:19 |
| mordred | tobiash: ^^ | 20:20 |
| mordred | Shrews: while I've got you here: https://review.openstack.org/#/c/626058/ is a copy of stuff clarkb did for nodepool | 20:22 |
| *** e0ne has quit IRC | 20:23 | |
| mordred | slaweq: if you have a sec, another neutron patch for you: https://review.openstack.org/#/c/625381/3 | 20:23 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Drop self.conn from base.TestCase https://review.openstack.org/625115 | 20:25 |
| slaweq | mordred: looking | 20:37 |
| slaweq | mordred: commented | 20:44 |
| slaweq | mordred: basically this feature has only spec merged so far and I'm not sure if it's good time to merge it | 20:45 |
| *** bobh has quit IRC | 20:53 | |
| mordred | slaweq: cool- thanks! (This is why it's good to defer to subject matter experts :) ) | 20:58 |
| *** ssbarnea has quit IRC | 21:00 | |
| slaweq | mordred: yes, I agree :) | 21:01 |
| *** tosky has quit IRC | 21:02 | |
| *** bobh has joined #openstack-sdks | 21:29 | |
| *** bobh has quit IRC | 21:34 | |
| openstackgerrit | Merged openstack/openstacksdk master: Import code for building ironic-compatible configdrives https://review.openstack.org/624441 | 21:38 |
| openstackgerrit | Merged openstack/openstacksdk master: Turn off unneeded devstack services https://review.openstack.org/626058 | 21:53 |
| *** slaweq has quit IRC | 22:13 | |
| *** markvoelker has joined #openstack-sdks | 22:15 | |
| *** bobh has joined #openstack-sdks | 22:19 | |
| *** bobh has quit IRC | 22:23 | |
| *** bobh has joined #openstack-sdks | 22:55 | |
| *** bobh has quit IRC | 23:00 | |
| *** bobh has joined #openstack-sdks | 23:15 | |
| *** bobh has quit IRC | 23:38 | |
| *** tosky has joined #openstack-sdks | 23:56 | |
| *** slaweq has joined #openstack-sdks | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!