| kmalloc | Shrews: out of curiosity, why do we have our own ... on-demand cache-on-arguments that does it independantly of import time? this seems odd... is it just to override the self-being-needed in the .invalidate? | 00:06 |
|---|---|---|
| *** slaweq has joined #openstack-sdks | 00:11 | |
| *** slaweq has quit IRC | 00:16 | |
| ianw | https://review.openstack.org/#/c/171456/ is where it seems to have come in | 00:31 |
| *** dtroyer has quit IRC | 00:34 | |
| *** dtroyer has joined #openstack-sdks | 00:35 | |
| *** dtroyer has quit IRC | 00:36 | |
| *** dtroyer has joined #openstack-sdks | 00:37 | |
| *** cdent has quit IRC | 00:39 | |
| *** slaweq has joined #openstack-sdks | 01:09 | |
| *** slaweq has quit IRC | 01:15 | |
| *** d0ugal has quit IRC | 01:56 | |
| *** d0ugal has joined #openstack-sdks | 02:11 | |
| *** dave-mccowan has joined #openstack-sdks | 02:38 | |
| *** slaweq has joined #openstack-sdks | 03:11 | |
| ianw | I have updated https://storyboard.openstack.org/#!/story/2004605 and have a small test-case in an upstream issue https://github.com/sqlalchemy/dogpile.cache/issues/140 | 03:15 |
| *** slaweq has quit IRC | 03:15 | |
| kmalloc | weird... | 03:22 |
| kmalloc | this is just odd | 03:22 |
| kmalloc | ianw: i can't log into github atm, or i'd comment on your issue | 03:25 |
| kmalloc | ianw: i think dogpile is doing the sane thing and openstacksdk is doing something very weird. | 03:25 |
| kmalloc | ianw: i know it's a behavior change but i wonder why we didn't just raise up the invalidate instead of adding another layer of wrapping | 03:26 |
| ianw | kmalloc: at this point i dunno, i'm going a bit cross-eyed from staring at it :) gonna switch gears to look at the pin, because we kind of need that to unblock other stuff | 03:29 |
| ianw | we have a circular dependency in fixing nodepool jobs | 03:29 |
| openstackgerrit | Ian Wienand proposed openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485 | 03:34 |
| openstackgerrit | Ian Wienand proposed openstack/openstacksdk master: Avoid dogpile.cache 0.7.0 https://review.openstack.org/624485 | 03:37 |
| *** Hazelesque has quit IRC | 03:43 | |
| *** lbragstad has joined #openstack-sdks | 03:50 | |
| *** lbragstad has quit IRC | 03:51 | |
| *** Hazelesque has joined #openstack-sdks | 03:51 | |
| kmalloc | ianw: ++ | 03:57 |
| kmalloc | ianw: i'll poke at mordred and Shrews i'm sure they know | 03:57 |
| *** dave-mccowan has quit IRC | 04:03 | |
| *** slaweq has joined #openstack-sdks | 04:11 | |
| *** lbragstad has joined #openstack-sdks | 04:13 | |
| *** slaweq has quit IRC | 04:16 | |
| *** markvoelker has joined #openstack-sdks | 05:04 | |
| *** slaweq has joined #openstack-sdks | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** slaweq has joined #openstack-sdks | 07:11 | |
| *** Luzi has joined #openstack-sdks | 07:13 | |
| *** slaweq has quit IRC | 07:16 | |
| *** slaweq has joined #openstack-sdks | 07:41 | |
| *** markvoelker has quit IRC | 07:45 | |
| *** slaweq has quit IRC | 07:47 | |
| *** slaweq has joined #openstack-sdks | 07:50 | |
| *** markvoelker has joined #openstack-sdks | 08:16 | |
| *** jpena|off is now known as jpena | 08:48 | |
| *** cdent has joined #openstack-sdks | 08:50 | |
| *** tosky has joined #openstack-sdks | 08:53 | |
| *** ttsiouts has joined #openstack-sdks | 09:45 | |
| *** markvoelker has quit IRC | 10:36 | |
| *** markvoelker has joined #openstack-sdks | 10:37 | |
| *** e0ne has joined #openstack-sdks | 10:40 | |
| *** markvoelker has quit IRC | 10:41 | |
| *** cdent has quit IRC | 11:09 | |
| *** markvoelker has joined #openstack-sdks | 11:16 | |
| *** Luzi has quit IRC | 11:44 | |
| *** ttsiouts has quit IRC | 12:05 | |
| *** ttsiouts has joined #openstack-sdks | 12:05 | |
| *** ttsiouts has quit IRC | 12:10 | |
| *** ttsiouts has joined #openstack-sdks | 12:16 | |
| *** bobh has quit IRC | 12:24 | |
| *** bobh has joined #openstack-sdks | 12:30 | |
| *** jpena is now known as jpena|lunch | 12:31 | |
| *** bobh has quit IRC | 12:41 | |
| *** bobh has joined #openstack-sdks | 12:44 | |
| openstackgerrit | melissaml proposed openstack/openstacksdk master: Change openstack-dev to openstack-discuss https://review.openstack.org/625247 | 12:53 |
| *** dave-mccowan has joined #openstack-sdks | 13:09 | |
| *** bobh has quit IRC | 13:14 | |
| *** dave-mccowan has quit IRC | 13:15 | |
| *** bobh has joined #openstack-sdks | 13:20 | |
| *** bobh has quit IRC | 13:25 | |
| *** jpena|lunch is now known as jpena | 13:35 | |
| Shrews | kmalloc: i think the intent was to have an invalidate function (i don't know the history of dogpile.cache here, but latest code seems to always have an invalidate func) and to eventually support per-resource caches | 13:52 |
| Shrews | kmalloc: i'm not familiar enough with dogpile to know how to properly get rid of our custom decorator and have things still work | 13:53 |
| *** mriedem has joined #openstack-sdks | 13:56 | |
| Shrews | kmalloc: i tried https://review.openstack.org/624767 but I can't remember what on earth i saw wrong with that to cause me to abandon it. i think it was not being able to support per-resource caches | 13:57 |
| Shrews | which we don't appear to be doing anyway | 13:57 |
| Shrews | my head was so confused trying to unravel this :/ | 13:57 |
| *** bobh has joined #openstack-sdks | 14:26 | |
| *** dave-mccowan has joined #openstack-sdks | 14:32 | |
| *** bobh has quit IRC | 14:32 | |
| *** bobh has joined #openstack-sdks | 14:37 | |
| kmalloc | Shrews: it's always had an invalidate function | 14:39 |
| kmalloc | Shrews: as long as we've been using it | 14:39 |
| kmalloc | Shrews: it does require passing the "Self" to the invalidate explicitly | 14:39 |
| kmalloc | Shrews: *shrug*. i think the quick fix is unwrap the extra layer of wrapping | 14:40 |
| kmalloc | Shrews: brie has surgery this morning, but this afternoon i should be able to spin up and chase down a fix that undoes the wrapping | 14:40 |
| Shrews | kmalloc: then i'm not sure what the purpose of https://review.openstack.org/171456 was then. i can't remember that far back | 14:41 |
| kmalloc | yeah, maybe mordred knows | 14:41 |
| Shrews | kmalloc: k, thx for helping | 14:41 |
| kmalloc | Shrews: also i could see a order of operation issue with configuring the dogpile cache region | 14:41 |
| Shrews | unpossible that there are more bugs | 14:42 |
| kmalloc | well i mean with unwrapping it :P | 14:42 |
| kmalloc | sorry it's super early here and i've been up 3 times to walk the dog already | 14:42 |
| * kmalloc needs a yard. | 14:42 | |
| Shrews | oh! that's what was wrong with my attempt to unwrap it | 14:42 |
| kmalloc | :) | 14:42 |
| Shrews | i didn't have the region to make the wrapper call | 14:42 |
| kmalloc | AHAH | 14:42 |
| kmalloc | oslo_cache has a lot of mechanisms to make sure we have a region. | 14:43 |
| *** dave-mccowan has quit IRC | 14:43 | |
| kmalloc | anyway, i can help chase this down after brie is back from the dr. and she's settled sleeping off the anesthesia | 14:44 |
| Shrews | ++ | 14:44 |
| kmalloc | Shrews: also.. "YAY YEARLY COMPLIANCE TRAINING" | 14:44 |
| kmalloc | :P | 14:45 |
| *** markvoelker has quit IRC | 15:06 | |
| kmalloc | mordred: ^ cc (so you know i haven't forgotten it) :P | 15:37 |
| kmalloc | Shrews: i'll be back sometime post noon pacific | 15:38 |
| kmalloc | Shrews: so i'll get to work on SDK things unless someone else has hit it first. | 15:38 |
| *** bobh has quit IRC | 16:18 | |
| *** e0ne has quit IRC | 16:24 | |
| *** bobh has joined #openstack-sdks | 16:26 | |
| *** tosky has quit IRC | 16:56 | |
| *** ttsiouts has quit IRC | 17:02 | |
| *** mriedem is now known as mriedem_lunch | 17:10 | |
| *** e0ne has joined #openstack-sdks | 17:13 | |
| *** tobiash has quit IRC | 17:29 | |
| *** markvoelker has joined #openstack-sdks | 17:31 | |
| *** markvoelker has quit IRC | 17:35 | |
| *** tobiash has joined #openstack-sdks | 17:40 | |
| *** e0ne has quit IRC | 17:41 | |
| *** e0ne has joined #openstack-sdks | 17:43 | |
| *** tobiash has quit IRC | 17:45 | |
| *** tobiash has joined #openstack-sdks | 17:55 | |
| *** tobiash has quit IRC | 18:05 | |
| *** jpena is now known as jpena|off | 18:06 | |
| *** tobiash has joined #openstack-sdks | 18:07 | |
| *** mriedem_lunch is now known as mriedem | 18:49 | |
| *** mriedem has quit IRC | 18:52 | |
| *** mriedem has joined #openstack-sdks | 18:56 | |
| kmalloc | mordred: ^ do you know the reasoning for the original extra layer wrap for cache_on_arguments ? | 18:57 |
| kmalloc | mordred: it seems superfluous as it just re-implements invalidate, which was already added? | 18:58 |
| kmalloc | By dogpile* | 18:58 |
| kmalloc | It's the source of the issue and exception because dogpile now expects to own the wrapping, won't work with bound methods (as method.xxx = thing doesn't work on bound methods) | 18:59 |
| kmalloc | Nor would setattr | 18:59 |
| *** e0ne has quit IRC | 19:13 | |
| *** ttsiouts has joined #openstack-sdks | 19:28 | |
| *** ttsiouts has quit IRC | 20:04 | |
| *** ttsiouts has joined #openstack-sdks | 20:04 | |
| *** bobh has quit IRC | 20:09 | |
| *** e0ne has joined #openstack-sdks | 20:11 | |
| *** e0ne has quit IRC | 20:11 | |
| *** ttsiouts has quit IRC | 20:33 | |
| *** ttsiouts has joined #openstack-sdks | 21:03 | |
| kmalloc | Shrews: ok... so part of the issue with dogpile is the chicken-egg issue. we're dynamically building on instantiation of the mixin the dogpile region | 21:45 |
| kmalloc | that is... something we can do on import. we'll just need to run the configuration at __init__ time for the region(s) | 21:46 |
| kmalloc | Shrews: oh gah. the per-resource cache is ... the problem. | 21:48 |
| kmalloc | maybe we can do it with a metaclass? | 21:48 |
| slaweq | mordred: hi | 21:52 |
| slaweq | mordred: I just opened story https://storyboard.openstack.org/#!/story/2004618 for sdk and osprofiler | 21:53 |
| slaweq | mordred: please take a look, maybe You will have some quick idea how we can solve this issue - I don't know this parts too much TBH :) | 21:53 |
| *** ttsiouts has quit IRC | 22:00 | |
| *** mriedem has quit IRC | 22:01 | |
| *** ttsiouts has joined #openstack-sdks | 22:07 | |
| kmalloc | Shrews: unfortunately the whole "undecorate" for ease of debugging is also part of the issue. | 22:19 |
| *** ttsiouts has quit IRC | 22:19 | |
| kmalloc | i'm trying to make this work with a metaclass, but since connection already has a meta, this is going to be weird... i need to look into the MRO and class traversal with super() in the cases of metaclasses. | 22:19 |
| kmalloc | really we should stop trying to be extra dynamic and just build cache regions that make sense | 22:20 |
| kmalloc | we can dynamically configure them at __init__ time with values, but the whole "only make some cache regions and decorate/undecorate" is way overly complex. | 22:21 |
| kmalloc | mordred: ^ cc | 22:21 |
| *** e0ne has joined #openstack-sdks | 22:23 | |
| kmalloc | aha, i think i found the simplest solution... | 22:25 |
| *** slaweq has quit IRC | 22:33 | |
| *** e0ne has quit IRC | 22:40 | |
| openstackgerrit | Morgan Fainberg proposed openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370 | 22:52 |
| openstackgerrit | Morgan Fainberg proposed openstack/openstacksdk master: Fix dogpile.cache 0.7.0 interaction https://review.openstack.org/625370 | 22:55 |
| *** lbragstad has quit IRC | 23:08 | |
| *** lbragstad has joined #openstack-sdks | 23:16 | |
| *** lbragstad has quit IRC | 23:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!