Monday, 2018-10-29

*** bobh has joined #openstack-sdks00:14
*** bobh has quit IRC01:02
*** bobh has joined #openstack-sdks01:09
*** chenyb4 has joined #openstack-sdks02:08
*** dayou_ has joined #openstack-sdks02:44
*** dayou_ has quit IRC02:50
*** dhellmann has quit IRC02:55
*** dhellmann has joined #openstack-sdks03:01
*** d0ugal has quit IRC03:11
*** charz has joined #openstack-sdks03:13
openstackgerritMike Chen proposed openstack/python-openstackclient master: Compute: Add description support for server  https://review.openstack.org/56854903:36
*** d0ugal has joined #openstack-sdks03:39
*** bobh has quit IRC03:48
*** d0ugal has quit IRC04:00
*** d0ugal has joined #openstack-sdks04:11
*** d0ugal has quit IRC04:17
*** Luzi has joined #openstack-sdks06:50
*** maxbab has joined #openstack-sdks07:23
*** noama has joined #openstack-sdks07:35
*** gkadam has joined #openstack-sdks07:44
*** d0ugal has joined #openstack-sdks07:49
*** slaweq has joined #openstack-sdks07:53
*** slaweq has quit IRC07:54
*** d0ugal has quit IRC07:56
*** slaweq has joined #openstack-sdks07:59
*** slaweq has quit IRC07:59
*** d0ugal has joined #openstack-sdks08:00
*** slaweq has joined #openstack-sdks08:11
*** gkadam has quit IRC08:22
*** gkadam has joined #openstack-sdks08:22
*** maxbab has quit IRC08:29
*** d0ugal has quit IRC08:32
*** gtema has joined #openstack-sdks08:38
*** d0ugal has joined #openstack-sdks08:39
*** e0ne has joined #openstack-sdks08:45
*** gkadam has quit IRC08:53
*** gkadam has joined #openstack-sdks08:55
*** jpena|off is now known as jpena08:57
*** d0ugal has quit IRC09:27
*** d0ugal has joined #openstack-sdks09:54
*** slaweq has quit IRC09:56
*** cdent has joined #openstack-sdks09:57
*** slaweq has joined #openstack-sdks09:59
*** slaweq has quit IRC10:25
*** slaweq has joined #openstack-sdks10:27
*** dtantsur|afk is now known as dtantsur10:35
*** chenyb4 has quit IRC10:51
*** rcarrillocruz has joined #openstack-sdks11:15
*** zigo has quit IRC11:17
*** e0ne has quit IRC11:25
*** e0ne has joined #openstack-sdks11:34
*** bobh has joined #openstack-sdks12:13
*** elmiko has joined #openstack-sdks12:20
*** edleafe- has joined #openstack-sdks12:29
*** edleafe- is now known as edleafe12:29
*** bobh has quit IRC12:51
*** e0ne has quit IRC12:58
*** jpena is now known as jpena|lunch13:03
*** cdent has quit IRC13:03
nmimiHi all again!13:04
nmimiI have one qustion, if someone knows the answer....13:04
nmimiI try to create a server with SDK with the following attributes:13:04
nmimiinstance = self.conn.compute.create_server(name=vm_name,image_id=image.id,flavor_id=flavor_obj.id,networks=[{"uuid": network.id}], key_name=keypair.name)13:04
nmimiWhen the server is created i noticed that although i haven't set security groups attribute, "Default" sec_group is being added to the server:13:04
nmimisecurity_groups                     | name='default'13:04
nmimiIs there a way to create the server without security groups (even "Default")?13:05
dtantsurnmimi: the API docs say "If you omit this attribute, the API creates the server in the default security group"13:09
dtantsurso it's not even openstacksdk doing, I suspect13:09
*** d0ugal has quit IRC13:09
*** e0ne has joined #openstack-sdks13:11
*** zigo has joined #openstack-sdks13:12
*** e0ne has quit IRC13:17
*** e0ne has joined #openstack-sdks13:19
*** mriedem has joined #openstack-sdks13:19
nmimidtantsur: Thanks for the answer!13:21
*** elbragstad is now known as lbragstad13:22
*** e0ne has quit IRC13:24
*** bobh has joined #openstack-sdks13:27
mordredyeah, that is a very true statement13:27
*** e0ne has joined #openstack-sdks13:30
fricklernmimi: iiuc the only possible workaround for your issue is to create a port in your network beforehand and pass that to the "create_server" call: "Requested security groups are not applied to pre-existing ports."13:46
*** jpena|lunch is now known as jpena|mtg13:55
nmimifrickler: i will try it, thanks!13:57
*** jpich has joined #openstack-sdks13:58
mordredfrickler: ooh. that's a workaround we should maybe put into create_server14:01
mordredlike - make security_groups=False create a port and pass it in14:01
mordrednmimi: also - you might want to try  self.conn.create_server instead of self.conn.compute.create_server - it's a bit more complete, and its api is more stable14:03
smcginnisThere are probably those that expect that behavior, so if we did a workaround in create_server we would probably have to make it a --no-security-group arg or something.14:03
fricklermordred: I don't think that we want to do that in the sdk, because you will not be able to clean up properly on deleting the server14:03
mordredfrickler: hrm. that is a good point14:06
*** cdent has joined #openstack-sdks14:20
openstackgerritDaniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates  https://review.openstack.org/60941614:37
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource  https://review.openstack.org/59144514:43
*** gtema has quit IRC14:43
*** jpena|mtg is now known as jpena14:59
*** Luzi has quit IRC15:04
*** jpich has quit IRC15:09
*** wouterdb has joined #openstack-sdks15:09
*** irclogbot_2 has joined #openstack-sdks15:10
*** dtantsur is now known as dtantsur|brb15:10
wouterdbhi all, I'm getting started with openstacksdk. I wonder: how do I close the connection? each connection maintains a thread pool and I'm opening a LOT of connections.15:11
wouterdbI couldn't find anything in the documentation or the source and I can't figure out the search function on the bug tracker15:11
mordredwouterdb: I don't know that we have a close function - but the connection opening a threadpool piece will be going away soon, so that issue should solve itself15:13
mordredwouterdb: that said- any reason you're opening a lot of connections instead of sharing a connection? you should be able to use one connection from many threads15:14
mordred(we do that in nodepool at pretty large scale - it's built to handle that use case)15:14
mordredwouterdb: for reference- this: https://review.openstack.org/#/c/604926/ is the upcoming patch to remove the internal creation of thread pools - as soon as I write some tests for the keystoneauth-side replacement we should be able to get that forward - the extra threads spawned are annoying even in the shared connection usecase, so using the existing parallelism of the calling context to handle15:17
mordredconcurrency should be an improvement for everybody15:17
*** cdent has quit IRC15:22
*** d0ugal has joined #openstack-sdks15:24
*** d0ugal has quit IRC15:37
wouterdbmordred: I'm writing code that logs in to the same openstack using different users15:38
*** d0ugal has joined #openstack-sdks15:38
mordredwouterdb: ah - gotcha. that makes sense15:48
*** cdent has joined #openstack-sdks15:48
mordredwouterdb: well, this will get better in a few weeks. in the mean time, if it's killing you, you can pin back to < 0.18.015:50
mordredthe thread-splosion was introduced in 0.18.0 - and should go away hopefully by 0.20.015:50
wouterdbok, can I find the docs for that version somewhere?15:55
wouterdbI try connection.identity.find_domain(domain) on the 0.17.2 and I get AttributeError: 'Proxy' object has no attribute 'find_domain'15:57
mordredwouterdb: that sounds like you're getting the v2 version of the proxy - find_domain has been on the v3 proxy object since 201516:00
mordredwouterdb: you might want to set OS_IDENTIY_API_VERSION=3 - or in your clouds.yaml set identity_api_version: 3 - up until 0.18.0 this was all driven by config (0.18 switch to properly using discovery)16:01
mordred(I'm sorry this is wonky for you right now)16:01
*** d0ugal has quit IRC16:02
wouterdbIt is a bit unfortunate, I've been working at porting code from the old client to openstacksdk for a week, under the assumption they don't have a close function because they don't really consume any system resources. But now it turns out that they do. So I really can't use it, as I can't properly dispose of the threadpools (even in the 604926 patch set, there still is a thread pool and no close).16:08
wouterdb16:09
wouterdbI really liked th idea of the library, to have one (rather nice) interface, but it all seems a bit risky now.16:10
mordredwouterdb: which threadpool is still there in 604926 ?16:14
mordredwouterdb: also - we could add a close method for you pretty easily if that would help16:14
*** dtantsur|brb is now known as dtantsur16:16
*** finucannot is now known as stephenfin16:17
wouterdb@mordred: close method would be great, threadpool is at https://review.openstack.org/#/c/604926/12/openstack/cloud/openstackcloud.py line 784816:19
wouterdbmordred: thanks for your help, I'll consider my options16:19
kmallocmordred: looking closely at the rate limit stuff in ksa today16:20
kmallocmordred: i think the code looks ok, but i want to run through it in depth16:21
kmallocmake sure there are no surprises16:21
kmallocif it's good i think we should land/release this week16:21
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency  https://review.openstack.org/60492616:22
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Add close method to shutdown threadpool  https://review.openstack.org/61397616:22
mordredwouterdb: ^^ that should get you a close() that will also work with the new code16:22
mordredwouterdb: also - that threadpool will only exist if you happen to upload swift LargeObjects16:23
*** wouterdb has quit IRC16:24
mordredaww. we lost wouterdb16:24
mordredkmalloc: sweet - I need to write tests, but I think we should be able to do that within a week16:25
kmallocyeah.16:26
kmalloci expect i'll be able to score +1 (+2 tentatively, pending tests) or -1 with reasons soon16:26
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency  https://review.openstack.org/60492616:32
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Make Connection a context manager  https://review.openstack.org/61397816:32
*** e0ne has quit IRC16:36
*** gkadam has quit IRC16:52
*** d0ugal has joined #openstack-sdks17:04
*** d0ugal has quit IRC17:12
*** markvoelker has joined #openstack-sdks17:13
*** noama has quit IRC17:45
*** jpena is now known as jpena|off18:07
openstackgerritDaniel Speichert proposed openstack/openstacksdk master: Added image properties to Image class  https://review.openstack.org/54454418:38
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Use sdk for list_servers  https://review.openstack.org/53077018:50
*** dtantsur is now known as dtantsur|afk19:11
openstackgerritMerged openstack/openstacksdk master: Call pre/post run task calls from TaskManager.submit_task()  https://review.openstack.org/61350319:47
openstackgerritMerged openstack/openstacksdk master: Add doc depends to tox releasenotes environment  https://review.openstack.org/61350419:49
*** mrhillsman is now known as mrhillsman_lunch19:53
*** lbragstad has quit IRC20:03
*** lbragstad has joined #openstack-sdks20:18
smcginnismordred, dtroyer: Any plans for a python-openstackclient release? I'd like to get https://review.openstack.org/609473 out there.20:42
smcginnisMaybe a last 3.x release before merging those backwards incompatible patches I have out there?20:42
dtroyersmcginnis: we can do a release… as far as switching to 4.x that's not happening quickly unless someone picks up the heavy lifting of all of the ksa & sdk-related auth stuff.  there is an osc4 feature branch…20:44
smcginnisdtroyer: OK, that's fine if those sit out there awhile. Not really time critical on that.20:45
smcginnisdtroyer: Are there any high level docs on what's needed with the auth stuff? Not sure I would have time for something like that, but I might be willing to poke at it a bit if there's not too steep of a curve to get going.20:47
*** mrhillsman_lunch is now known as mrhillsman21:04
*** bobh has quit IRC21:08
*** bobh has joined #openstack-sdks21:10
*** bobh has quit IRC21:15
mordredsmcginnis, dtroyer: I've been planning on jumping in on the ksa/sdk stuff in the feature branch soonish21:21
smcginnismordred: Great. I can't commit to anything, but let me know if there's any way I can help with that.21:21
mordredwill do21:22
*** e0ne has joined #openstack-sdks21:29
*** e0ne has quit IRC21:36
*** mriedem is now known as mriedem_away21:42
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Fix latest flake8 issues  https://review.openstack.org/61403821:44
*** bobh has joined #openstack-sdks21:49
*** bobh has quit IRC21:55
*** bobh has joined #openstack-sdks21:57
*** ml has left #openstack-sdks22:04
*** cdent has quit IRC22:13
*** bobh has quit IRC22:16
*** eandersson has joined #openstack-sdks22:36

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!