| *** markvoelker has quit IRC | 00:35 | |
| *** mtreinish has quit IRC | 00:45 | |
| *** mtreinish has joined #openstack-sdks | 00:46 | |
| *** mriedem has quit IRC | 00:52 | |
| *** mtreinish has quit IRC | 01:06 | |
| *** mtreinish has joined #openstack-sdks | 01:08 | |
| *** slaweq has joined #openstack-sdks | 01:11 | |
| *** slaweq has quit IRC | 01:16 | |
| openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | 01:35 |
|---|---|---|
| *** fanzhang has left #openstack-sdks | 01:44 | |
| *** e0ne has joined #openstack-sdks | 02:16 | |
| *** e0ne has quit IRC | 02:18 | |
| *** chenyb4 has joined #openstack-sdks | 02:41 | |
| *** slaweq has joined #openstack-sdks | 03:11 | |
| *** slaweq has quit IRC | 03:15 | |
| *** slaweq has joined #openstack-sdks | 05:10 | |
| *** gkadam has joined #openstack-sdks | 05:12 | |
| *** slaweq has quit IRC | 05:16 | |
| openstackgerrit | Lajos Katona proposed openstack/python-openstackclient master: Detailed help message for QoS max-burst-kbps value https://review.openstack.org/588168 | 05:38 |
| openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | 05:44 |
| *** markvoelker has joined #openstack-sdks | 05:48 | |
| *** usr2033 has joined #openstack-sdks | 06:13 | |
| usr2033 | hi, i have a simple code like this. https://paste.ofcode.org/t6eXJ2gx9MA9QX7UAGQrTF i have a fundamental problem i guess. Openstack calls takes random time for return and i couldn't handle this. Execution of this code returns four different value for same input. What is the best practice for this problem? | 06:36 |
| openstackgerrit | Chen proposed openstack/python-openstackclient master: Fix inconsistency (nit) https://review.openstack.org/572771 | 06:38 |
| usr2033 | i couldn't different response even one line "os_connection.list_projects()" | 06:44 |
| *** jpich has joined #openstack-sdks | 07:02 | |
| *** slaweq has joined #openstack-sdks | 07:05 | |
| *** slaweq has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-sdks | 07:06 | |
| *** gildub has quit IRC | 07:25 | |
| *** jpena|off is now known as jpena | 07:55 | |
| *** e0ne has joined #openstack-sdks | 07:59 | |
| openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | 07:59 |
| *** gtema has joined #openstack-sdks | 08:25 | |
| *** e0ne has quit IRC | 08:49 | |
| *** ssbarnea has quit IRC | 08:52 | |
| *** e0ne has joined #openstack-sdks | 09:14 | |
| usr2033 | i think i found the problem. list_servers function can handle or work with undefined identity service version but list_projects function call does not. | 09:27 |
| *** e0ne has quit IRC | 09:27 | |
| *** cdent has joined #openstack-sdks | 09:31 | |
| *** ssbarnea has joined #openstack-sdks | 09:32 | |
| *** e0ne has joined #openstack-sdks | 09:37 | |
| *** chenyb4 has quit IRC | 10:06 | |
| *** tosky has joined #openstack-sdks | 10:19 | |
| *** e0ne has quit IRC | 10:21 | |
| *** tosky has quit IRC | 10:35 | |
| *** tosky has joined #openstack-sdks | 10:36 | |
| *** dave-mccowan has joined #openstack-sdks | 10:55 | |
| *** dave-mccowan has quit IRC | 11:00 | |
| *** dtantsur|afk is now known as dtantsur | 11:01 | |
| *** dave-mccowan has joined #openstack-sdks | 11:03 | |
| *** jpena is now known as jpena|lunch | 11:06 | |
| *** gildub has joined #openstack-sdks | 11:10 | |
| *** cdent has quit IRC | 11:58 | |
| *** cdent has joined #openstack-sdks | 12:01 | |
| *** jpena|lunch is now known as jpena | 12:02 | |
| *** mriedem has joined #openstack-sdks | 12:05 | |
| mordred | usr2033: ah- sorry about that - the very next thing on my todo list is to finish plumbing in version discovery so that _everything_ can work without a defined service version | 12:06 |
| *** mriedem has quit IRC | 12:17 | |
| *** olaph has joined #openstack-sdks | 12:36 | |
| dtantsur | wait, does Image API really allow you to set random string attributes on an Image object? O___o | 12:59 |
| mordred | dtantsur: yup | 13:25 |
| mordred | dtantsur: that was one of the changes in image api v2 | 13:25 |
| mordred | dtantsur: it got rid of the "properties" attribute | 13:25 |
| dtantsur | wownotwow | 13:26 |
| mordred | and instead put user-defined key/value metadata into the main image object itself | 13:26 |
| mordred | right? | 13:26 |
| *** dmsimard has quit IRC | 13:26 | |
| mordred | in shade we chose to ignore that design choice and continue to present it as properties even if the service is running v2 | 13:26 |
| mordred | which is what I expect to do to fix the brokenness around image in sdk currently | 13:27 |
| mordred | dtantsur: what's even better is that operators can define top-level keys to be "reserved" in their config | 13:27 |
| dtantsur | O.M.G. | 13:28 |
| mordred | dtantsur: you can't un-know that | 13:28 |
| dtantsur | unfortunately | 13:30 |
| dtantsur | I'm looking into JSON patch support.. and it's a mess | 13:30 |
| dtantsur | I'll throw a half-finished patch soon just to collect opinions | 13:31 |
| *** dmsimard has joined #openstack-sdks | 13:31 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Correct update operations for baremetal https://review.openstack.org/590770 | 13:34 |
| dtantsur | mordred: wdyt about the overall approach ^^^ ? | 13:34 |
| mordred | dtantsur: I suppose we can't just assume jsonpatch should be used if commit_message = 'PATCH' can we? | 13:40 |
| usr2033 | mordred: thanks for response. i had a problem with get_project function. Normally get_project function in cloud/openstackcloud.py accept domain_id but in use like in get_compute_quota i can't pass domain_id to function. I had patched for that file for myself. I opened story in https://storyboard.openstack.org/#!/story/2003285 | 13:42 |
| mordred | dtantsur: overall approach looks good | 13:43 |
| dtantsur | mordred: I assumed HTTP PATCH can also be used with an incomplete resource representation | 13:44 |
| dtantsur | though openstack services seem to use PUT for that | 13:45 |
| mordred | yah - they do seem to - but I think you're right- better safe than sorry | 13:47 |
| mordred | maybe we could default it to None, then have a little method like def _use_json_patch(self): if self.commit_method is None: return self.commit_method == 'PATCH' ; else return self.commit_method | 13:49 |
| mordred | but maybe that'stoo much - dunno, just thinking out loud | 13:49 |
| *** e0ne has joined #openstack-sdks | 14:11 | |
| *** gildub has quit IRC | 14:27 | |
| openstackgerrit | Alan Bishop proposed openstack/python-openstackclient master: Deprecate volume create --project and --user options https://review.openstack.org/575804 | 14:30 |
| *** e0ne has quit IRC | 14:39 | |
| *** bobh has joined #openstack-sdks | 14:43 | |
| *** bobh has quit IRC | 14:49 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix the heat template resource more cleaner https://review.openstack.org/590786 | 14:53 |
| mordred | Shrews: ^^ | 14:53 |
| *** usr2033 has quit IRC | 15:01 | |
| *** tosky has quit IRC | 15:03 | |
| *** e0ne has joined #openstack-sdks | 15:03 | |
| *** e0ne has quit IRC | 15:10 | |
| cdent | mordred: I wish to register my informal +1 on dtantsur as sdk core | 15:21 |
| *** olaph has quit IRC | 15:30 | |
| *** mriedem has joined #openstack-sdks | 15:30 | |
| mordred | cdent: so noted | 15:32 |
| cdent | he's OK | 15:32 |
| cdent | someday might even get a huzzah | 15:32 |
| mordred | cdent: wow. that's pretty strong | 15:39 |
| cdent | ikr | 15:39 |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add simple create/show/delete functional tests for all baremetal resources https://review.openstack.org/590806 | 15:41 |
| openstackgerrit | Tim Rozet proposed openstack/python-openstackclient master: Cinder: Add version checking https://review.openstack.org/590807 | 15:42 |
| dtantsur | wow, I real huzzah! | 15:43 |
| dtantsur | I must be really cool! | 15:43 |
| dtantsur | * a real huzzah | 15:44 |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add simple create/show/delete functional tests for all baremetal resources https://review.openstack.org/590806 | 15:54 |
| *** gkadam has quit IRC | 16:06 | |
| openstackgerrit | Merged openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | 16:10 |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Correct update operations for baremetal https://review.openstack.org/590770 | 16:12 |
| openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Correct update operations for baremetal https://review.openstack.org/590770 | 16:18 |
| dtantsur | mordred: I found an inconsistency while working on ^^^ | 16:19 |
| dtantsur | when for a field the server name does not match our name (e.g. instance_uuid vs instance_id for nodes), we use the former when accessing it but the latter when updating | 16:19 |
| dtantsur | e.g. node.instance_id but self.conn.node_update(node, instance_uuid='...') | 16:19 |
| * dtantsur tries to understand how bad it is | 16:20 | |
| *** jpena is now known as jpena|off | 16:22 | |
| mordred | dtantsur: oh awesome | 16:25 |
| *** mriedem has quit IRC | 16:27 | |
| openstackgerrit | Merged openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | 16:30 |
| mordred | zomg | 16:34 |
| mordred | that happened | 16:34 |
| mordred | MIND BLOWN | 16:34 |
| *** jpich has quit IRC | 16:35 | |
| dtantsur | lol | 16:36 |
| *** purplerbot has quit IRC | 16:38 | |
| *** purplerbot has joined #openstack-sdks | 16:38 | |
| Shrews | mordred: my mind will be blown if nothing breaks because of it :) | 16:39 |
| mordred | Shrews: that'll totally be true for at least some definition of "nothing" | 16:40 |
| mordred | see - now I just have to finish wiring in the discovery code ... | 16:40 |
| dtantsur | "just" | 16:41 |
| mordred | dtantsur: it should be "easy" - I "just" need to make a new descriptor to handle attaching proxy objects to the connection that can handle instantiating and connecting the correct versioned proxy. and then I "just" need to write another one to stick onto the attached proxy that will add a proxy object for each version of the service found in the cloud | 16:46 |
| mordred | piece of cake | 16:46 |
| * mordred cries | 16:46 | |
| mordred | dtantsur: my thinking so far has been make conn.image be the version of the service that's found via discovery (taking config overrides in to account) - but also have conn.image.v1 and conn.image.v2 be explicit instance of openstack.image.v1._proxy.Proxy and openstack.image.v2._proxy.Proxy | 16:47 |
| mordred | does that make sense and/or sound like a somewhat unterrible idea? | 16:48 |
| *** gtema has quit IRC | 16:49 | |
| * dtantsur thinks | 16:51 | |
| dtantsur | mordred: are you going to provide a common subset of v1 and v2 via conn.image? | 16:51 |
| dtantsur | and #2: are we going to do it even for services with only one major version? | 16:51 |
| mordred | dtantsur: for #2 - I think so - although I doubt it'll ever get used | 16:52 |
| dtantsur | yeah, so for e.g. baremetal, conn.baremetal and conn.v1.baremetal is the same. what about image? | 16:53 |
| mordred | dtantsur: for #1 - it's a really great question - I had been thinking of just making what shows up in conn.image be different based on whats found- which is what happens today if you just set the config variable differently | 16:53 |
| dtantsur | conn.image - is it latest or a common subset? | 16:53 |
| dtantsur | this is probably the realistic option, even though it's not great from interoperability PoV | 16:53 |
| mordred | BUT - the shade layer is designed as an abstraction layer - maybe it would be worth making an 'unversioned' proxy that is what gets attached in those cases | 16:53 |
| mordred | and if you wanted a specific version's semantics you can always just do conn.image.v2.create_image | 16:54 |
| dtantsur | okay, so conn.image.create_image can behave differently, but conn.image.v2.create_image is the same? | 16:54 |
| mordred | yah. that would be the easier path | 16:55 |
| dtantsur | the easiest, but also quite confusing for consumers.. | 16:55 |
| mordred | and a user can always do conn.image.get_endpoint_info() to find out what version it is | 16:55 |
| mordred | yah | 16:55 |
| * dtantsur is not sure he wants to go the hard path though | 16:55 | |
| mordred | yah | 16:55 |
| mordred | maybe I'll take a stab at it for image, since we already have all of the logic to handle it in the shade code | 16:56 |
| dtantsur | in rust-openstack I only support one major version per service, it's so much easier :D | 16:56 |
| mordred | basically - move the shademethods into an 'unversioned' proxy that calls the other ones | 16:56 |
| mordred | and see how terrible that is | 16:56 |
| dtantsur | I'd be curious to see that | 16:56 |
| mordred | in fact, maybe I'll just do it with create_image | 16:56 |
| mordred | keep it SUPER small so we can see what it looks like | 16:56 |
| dtantsur | yup | 16:57 |
| dtantsur | how many volume service versions do we have, 3? :) | 16:57 |
| dtantsur | mordred: what's openstacksdk's official commitment wrt supporting deprecated major versions? | 16:58 |
| mordred | support all of them until the end of time | 16:58 |
| dtantsur | that's tough | 16:58 |
| mordred | yah | 16:59 |
| mordred | BUT - it's one of the reasons I'm pleased that we have requests-mock based unittests now | 16:59 |
| dtantsur | I wonder how we're going to maintain them when there are no clouds supporting them | 16:59 |
| dtantsur | unit tests are nice, but they only confirm existing assumptions | 16:59 |
| dtantsur | on this positive note I'll call it a day :) | 17:00 |
| *** dtantsur is now known as dtantsur|afk | 17:01 | |
| samueldmq | mordred: Shrews: does 'tox -e functional --end-user' make sense to you at all? | 17:04 |
| samueldmq | I wanted to run functional against public clouds. operator tests don't make sense in that context | 17:05 |
| mordred | dtantsur|afk: I think the main idea is - keep the unittests for existing assumptions - and if someone reports a bug ask them to provide us with an http trace | 17:06 |
| mordred | :) | 17:06 |
| mordred | samueldmq: yes. although in a perfect world I think having each thing be able to detect whether or not the user is allowed to do a thing would be great ... | 17:06 |
| mordred | buit that's not really feasible - so I thik your idea is more achievable | 17:06 |
| samueldmq | mordred: seems like if we had a manner for the user to define what they expect to be able to do and test those things would be nice | 17:07 |
| samueldmq | I agree that idea is not really feasible, since there needs to be a distinction between 403 because I'm not operator vs 403 ohh I should be allowed to do that | 17:08 |
| mordred | yah | 17:10 |
| mordred | also - if clouds have disabled something by policy because they are evil evil people, that can show up as 404 not found not 403 unauthorized | 17:10 |
| mordred | which is one of the reasons I hate the policy system | 17:10 |
| *** e0ne has joined #openstack-sdks | 17:11 | |
| samueldmq | mordred: yes policy is hard. splitting operator vs non-operator for now would be a good first step | 17:13 |
| mordred | ++ | 17:13 |
| samueldmq | you okay if that reflects on really splitting tests into separate files/directories? or should I add a decorator or somehting on the top of the tests? | 17:14 |
| samueldmq | like @operator to indicate that's an operator test | 17:14 |
| samueldmq | s/test/testcase | 17:14 |
| mordred | samueldmq: either thing works for me - I don't have a strong opinion - so whichever seems to work best as you work on it | 17:17 |
| mordred | directories is probably easier | 17:18 |
| samueldmq | nice, I like that. let's just get the thing done | 17:18 |
| mordred | samueldmq: in fact, we could get a little fancy ... | 17:18 |
| samueldmq | also, I found we allow tests to run against other clouds... but we call it so many different things: OS_CLOUD, OS_TEST_CLOUD, OS_DEMO_CLOUD, OS_OPERATOR_CLOUD. so having that consolidated into a single envvar is a must. | 17:19 |
| mordred | we have self.demo_cloud and self.operator_cloud | 17:19 |
| mordred | samueldmq: ++ | 17:19 |
| mordred | samueldmq: if we make an OperatorFunctionalTest base class that is where self.operator_cloud comes from | 17:19 |
| mordred | it could help us make sure we're testing features even in devstack with the correct user vs. operator context | 17:20 |
| mordred | or something | 17:20 |
| samueldmq | base.py for each one of enduser/ operator/ dirs then? | 17:20 |
| mordred | probably still need self.operator_cloud in setUp/tearDown methods though ... | 17:20 |
| mordred | samueldmq: but yeah - start with the directories - and we can figure out if we can do fancier things later :) | 17:21 |
| samueldmq | mordred: nice. I will follow what we had as operator cloud in shade previously | 17:21 |
| samueldmq | to define what's operator and what's not | 17:22 |
| mordred | sounds great to me | 17:24 |
| Shrews | mordred: my wrist is quite sore today so i'm going to stop keyboarding for a while. i'll check in on things later | 17:25 |
| mordred | Shrews: ++ | 17:30 |
| mordred | Shrews: don't push through - gotta let that wrist heal | 17:30 |
| *** purplerbot has quit IRC | 17:32 | |
| *** abishop has joined #openstack-sdks | 17:33 | |
| openstackgerrit | Merged openstack/openstacksdk master: Fix the heat template resource more cleaner https://review.openstack.org/590786 | 17:35 |
| abishop | dtroyer: I need to ask you re-review https://review.openstack.org/575804 (I had to rebase to resolve merge conflict) | 17:37 |
| *** purplerbot has joined #openstack-sdks | 17:40 | |
| *** purplerbot has quit IRC | 17:43 | |
| *** purplerbot has joined #openstack-sdks | 17:48 | |
| *** purplerbot has quit IRC | 17:54 | |
| *** purplerbot has joined #openstack-sdks | 17:54 | |
| *** purplerbot has quit IRC | 17:55 | |
| *** purplerbot has joined #openstack-sdks | 17:56 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Make require_service use conn.has_service in tests https://review.openstack.org/591029 | 17:59 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Consolidate cloud/base.py into functional/base.py https://review.openstack.org/591031 | 18:09 |
| samueldmq | mordred: what is the difference between tests in functional/ vs functional/cloud ? | 18:20 |
| samueldmq | all those in /cloud came from shade? are there known intersections? | 18:20 |
| *** gkadam has joined #openstack-sdks | 19:47 | |
| mordred | samueldmq: yes - that's the only difference | 19:50 |
| *** e0ne has quit IRC | 19:51 | |
| *** olaph has joined #openstack-sdks | 19:53 | |
| *** cdent has quit IRC | 20:17 | |
| *** abishop has quit IRC | 20:47 | |
| *** thrash is now known as thrash|g0ne | 20:52 | |
| *** dave-mccowan has quit IRC | 21:24 | |
| *** dave-mccowan has joined #openstack-sdks | 21:29 | |
| *** imacdonn has quit IRC | 22:12 | |
| *** imacdonn has joined #openstack-sdks | 22:12 | |
| *** dave-mccowan has quit IRC | 22:19 | |
| *** gkadam has quit IRC | 22:34 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!