| *** harlowja has quit IRC | 00:26 | |
| *** bobh has quit IRC | 00:28 | |
| *** mriedem has quit IRC | 01:15 | |
| *** chenyb4 has joined #openstack-sdks | 01:24 | |
| *** yolanda has quit IRC | 02:03 | |
| *** bobh has joined #openstack-sdks | 02:13 | |
| *** lbragstad has quit IRC | 02:18 | |
| *** bobh has quit IRC | 02:34 | |
| *** dave-mccowan has quit IRC | 03:31 | |
| *** e0ne has joined #openstack-sdks | 05:00 | |
| *** Luzi has joined #openstack-sdks | 05:47 | |
| *** e0ne has quit IRC | 05:58 | |
| openstackgerrit | wangqi proposed openstack/osc-lib master: Remove PyPI downloads https://review.openstack.org/589369 | 06:01 |
|---|---|---|
| *** e0ne has joined #openstack-sdks | 06:02 | |
| *** yolanda has joined #openstack-sdks | 06:41 | |
| *** e0ne has quit IRC | 07:02 | |
| *** gkadam has joined #openstack-sdks | 07:04 | |
| *** gildub has joined #openstack-sdks | 07:33 | |
| *** e0ne has joined #openstack-sdks | 07:35 | |
| *** jpena|off is now known as jpena | 07:35 | |
| *** e0ne has quit IRC | 07:41 | |
| *** jpich has joined #openstack-sdks | 07:45 | |
| *** e0ne has joined #openstack-sdks | 07:52 | |
| *** e0ne has quit IRC | 07:53 | |
| *** dayou has quit IRC | 08:12 | |
| *** cdent has joined #openstack-sdks | 08:14 | |
| *** gtema has joined #openstack-sdks | 08:58 | |
| *** tosky has joined #openstack-sdks | 08:58 | |
| *** finucannot is now known as stephenfin | 09:30 | |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/python-openstackclient master: Fix broken gate jobs https://review.openstack.org/587005 | 09:33 |
| *** chenyb4 has quit IRC | 10:17 | |
| *** olivierbourdon38 has joined #openstack-sdks | 10:26 | |
| *** dayou has joined #openstack-sdks | 10:42 | |
| *** gildub has quit IRC | 10:48 | |
| *** Klumben has quit IRC | 10:54 | |
| frickler | dtroyer: ^^ func tests have passed for this one now, should be ready to unblock the gate once the final slow legacy job finishes | 11:05 |
| openstackgerrit | Chen proposed openstack/python-openstackclient master: Refactor 'server migrate' https://review.openstack.org/589012 | 11:06 |
| *** gildub has joined #openstack-sdks | 11:15 | |
| *** gildub has quit IRC | 11:20 | |
| *** gildub has joined #openstack-sdks | 11:53 | |
| *** gildub has quit IRC | 12:02 | |
| *** edmondsw has joined #openstack-sdks | 12:04 | |
| *** jpena is now known as jpena|lunch | 12:15 | |
| mordred | frickler: it's green! | 12:20 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | 12:29 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | 12:29 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | 12:29 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | 12:29 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | 12:29 |
| *** thrash|g0ne is now known as thrash | 12:33 | |
| frickler | mordred: oh, you are OSC core now, congrats :) may I suggest that you single-approve that patch if noone else comes along today in order to unblock gate? | 12:34 |
| dtroyer | frickler: +++ and thanks for pushing that along | 12:34 |
| frickler | dtroyer: no problem, I was glad to see https://review.openstack.org/558824 approved when I returned from holiday and sad when I noticed that it is still stuck in gate. but I assume it will have to wait until after FF now anyway? | 12:36 |
| dtroyer | frickler: apologies for fouling up the dependency there, it looked like 516701 was still unsettled when I went through the backlog, I see I mis-read it… | 12:40 |
| *** e0ne has joined #openstack-sdks | 12:40 | |
| mordred | frickler, dtroyer yay for that patch! | 12:42 |
| mordred | rods: I believe I finally got https://review.openstack.org/530835 working! | 12:43 |
| mordred | rods: (also, split it apart into multiple patches so it's easier to read) | 12:43 |
| *** gtema has quit IRC | 12:47 | |
| tosky | I noticed that openstackclient-check-plugins is failing on stable/queens and stable/pike; while it is non voting right now, I guess that idea is to stabilize it | 12:52 |
| tosky | you probably know about the issue already, but it seems to be related to python-tripleoclient stable/{queens,pike} which installs tripleo-common from master | 12:53 |
| tosky | and there is a conflicting requirements on the version of python-ironicclient | 12:53 |
| *** bobh has joined #openstack-sdks | 12:54 | |
| openstackgerrit | Monty Taylor proposed openstack/os-service-types master: Add missing release notes https://review.openstack.org/589458 | 12:57 |
| mordred | tosky: that would seem to me to be a bug in python-tripleoclient - does it not follow global-requirements and upper-constraints.txt ? | 13:00 |
| tosky | mordred: it seems it does use them: http://git.openstack.org/cgit/openstack/python-tripleoclient/tree/tox.ini?h=stable/queens | 13:01 |
| tosky | let me share the log from my saharaclient job | 13:02 |
| tosky | http://logs.openstack.org/36/588336/2/check/openstackclient-check-plugins/aed0ebb/ | 13:02 |
| tosky | python-tripleoclient seems to be correctly from stable/queens: http://logs.openstack.org/36/588336/2/check/openstackclient-check-plugins/aed0ebb/job-output.txt.gz#_2018-08-06_19_16_48_339526 | 13:03 |
| tosky | but then tripleo-common is 9.2.0: http://logs.openstack.org/36/588336/2/check/openstackclient-check-plugins/aed0ebb/job-output.txt.gz#_2018-08-06_19_21_53_839209 | 13:03 |
| tosky | while 8.6.x is the last version on stable/queens | 13:03 |
| mordred | wow. that's just fantastic | 13:07 |
| mordred | tosky: tripleo-common===8.6.3 is in the upper-constraints file for stable/queens | 13:08 |
| mordred | tosky: ah- the check plugins job does not respect upper-constraints | 13:11 |
| tosky | ah | 13:13 |
| tosky | something had to be wrong | 13:13 |
| *** mriedem has joined #openstack-sdks | 13:16 | |
| Shrews | mordred: https://review.openstack.org/588656 must have been fun | 13:19 |
| mordred | Shrews: so much fun | 13:19 |
| mordred | Shrews: but if you think that one was fun, you should meet my friend https://review.openstack.org/589250 | 13:19 |
| Shrews | mordred: u have weird friends | 13:20 |
| openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | 13:23 |
| mordred | tosky: ^^ | 13:23 |
| tosky | I miss some of the logic of the joke, but that's fine :D | 13:25 |
| tosky | oh, pbrx is a real thing | 13:26 |
| tosky | what is the difference between pip freeze and pbr freeze? | 13:29 |
| *** jpena|lunch is now known as jpena | 13:30 | |
| openstackgerrit | Merged openstack/os-service-types master: Add missing release notes https://review.openstack.org/589458 | 13:33 |
| tosky | something did not work | 13:38 |
| *** r-mibu has joined #openstack-sdks | 13:42 | |
| openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | 13:53 |
| mordred | tosky: pbr freeze emits some extra info about git shas | 13:56 |
| mordred | tosky: I figured in this case it might be a nice addition so we can check things | 13:57 |
| tosky | ack | 13:58 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | 14:05 |
| mordred | Shrews: I *think* that ^^ is going to pass this time | 14:05 |
| mordred | Shrews: I hope you'll enjoy the change in openstack/tests/functional/image/v2/test_image.py | 14:05 |
| Shrews | mordred: i'm still digesting 589250 now that i have coffee | 14:06 |
| Shrews | mordred: something doesn't seem right | 14:06 |
| Shrews | mordred: you never set the alias_flag attr afaict | 14:07 |
| mordred | yes - that's correct | 14:07 |
| Shrews | mordred: and the set and immediately delete the seen_flag | 14:07 |
| mordred | the alias_flag is the thing we need to check to see if it's already been set | 14:07 |
| mordred | well, the getattr may not seem like a call into a recursion stack ... but it is | 14:07 |
| mordred | so setting the flag before the getattr is a way for the check in the getattr call to know it shouldn't itself make a subsequent getattr call | 14:08 |
| mordred | Shrews: http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/object_store/v1/container.py#n44 and http://git.openstack.org/cgit/openstack/openstacksdk/tree/openstack/object_store/v1/container.py#n51 | 14:09 |
| mordred | Shrews: are the example case that make this whole thing go batty | 14:09 |
| mordred | count is aliased to object_count and object_count is aliased to count - if _neither_ are set, without some sort of something, the infinite recursion happens | 14:10 |
| mordred | Shrews: (also, this took me literally the entire work day yesterday to wrap my head around, so if you're even partially following it on a first coffee, you're doing great) | 14:10 |
| Shrews | mordred: ok, follow the alias thing now. but: setattr(instance, seen_flag, True); value = ; delattr(instance, seen_flag) | 14:12 |
| Shrews | don't get the set-then-delete | 14:12 |
| Shrews | oh! | 14:13 |
| Shrews | ok, coffee just kicked in | 14:13 |
| mordred | \o/ | 14:13 |
| Shrews | mordred: duh | 14:13 |
| mordred | Shrews: should we add a comment there to help future-us understand what the heck is going on? | 14:14 |
| *** thrash is now known as thrash|biab | 14:14 | |
| Shrews | meh, i've been away for a week so i'm just slow. up to you | 14:14 |
| mordred | writing comments is hard | 14:15 |
| Shrews | yah | 14:15 |
| mordred | adriant: if you get a sec when your around, could you check out https://review.openstack.org/#/q/topic:resource-dict - and most importantly make sure it doesn't break you? | 14:16 |
| mordred | it's one of the last 2 breaking API changes on the list before a 1.0 | 14:16 |
| Shrews | mordred: it totally not apparent (until you pasted those container lines) how that test was testing recursion. maybe a comment in that test? | 14:17 |
| mordred | Shrews: ++ | 14:18 |
| mordred | Shrews: ok in that case, I'm adding a comment to the method too | 14:25 |
| Shrews | k. sorry | 14:25 |
| mordred | no - it's a good point - the chances we understand this in a months' time are pretty low | 14:27 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | 14:27 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | 14:27 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | 14:27 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | 14:27 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | 14:27 |
| *** gkadam_ has joined #openstack-sdks | 14:27 | |
| mordred | Shrews: kk. updated | 14:27 |
| *** gkadam has quit IRC | 14:29 | |
| *** yolanda has quit IRC | 14:31 | |
| *** e0ne has quit IRC | 14:39 | |
| *** thrash|biab is now known as thrash | 14:44 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Fix broken gate jobs https://review.openstack.org/587005 | 14:45 |
| *** bobh has quit IRC | 14:56 | |
| *** mriedem is now known as mriedem_afk | 15:06 | |
| *** Luzi has quit IRC | 15:07 | |
| *** bobh has joined #openstack-sdks | 15:17 | |
| mordred | \o | 15:17 |
| mordred | gah | 15:17 |
| mordred | \o/ | 15:17 |
| mordred | is what I meant | 15:17 |
| *** bobh has quit IRC | 15:17 | |
| openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | 15:25 |
| *** bobh has joined #openstack-sdks | 15:45 | |
| *** olivierbourdon38 has quit IRC | 15:46 | |
| *** r-mibu has quit IRC | 16:06 | |
| *** mriedem_afk has quit IRC | 16:11 | |
| *** e0ne has joined #openstack-sdks | 16:18 | |
| *** jpena is now known as jpena|off | 16:21 | |
| *** jpich has quit IRC | 16:27 | |
| *** lbragstad[m] has quit IRC | 16:32 | |
| *** imacdonn has quit IRC | 16:38 | |
| *** imacdonn has joined #openstack-sdks | 16:38 | |
| *** gkadam_ has quit IRC | 16:38 | |
| *** tosky has quit IRC | 16:57 | |
| mordred | Shrews: yay https://review.openstack.org/#/c/589250/ is green! :) | 17:19 |
| Shrews | mordred: +Ad | 17:20 |
| *** e0ne has quit IRC | 17:20 | |
| *** e0ne has joined #openstack-sdks | 17:21 | |
| *** e0ne has quit IRC | 17:22 | |
| *** harlowja has joined #openstack-sdks | 17:31 | |
| *** harlowja has quit IRC | 17:43 | |
| *** markvoelker_ has quit IRC | 17:45 | |
| PagliaccisCloud | anyone got a +2 to spare? https://review.openstack.org/#/c/584484/ | 17:47 |
| *** Leo_m has joined #openstack-sdks | 18:01 | |
| *** e0ne has joined #openstack-sdks | 18:04 | |
| mordred | PagliaccisCloud: I got AJaeger to leave a comment - but it's an update to a translated string which should go through the translations process. the base string seems to have already been fixed in the codebase. however, translation string updates are only proposed when there has been a change in the translations | 18:30 |
| *** madorn has quit IRC | 18:41 | |
| *** madorn has joined #openstack-sdks | 18:43 | |
| frickler | mordred: dtroyer: most of the rechecks I did seem to have passed, the others look like genuine issues to me. would be great if you could put https://review.openstack.org/516701 onto your review list | 18:44 |
| *** openstackgerrit has quit IRC | 18:49 | |
| *** bobh has quit IRC | 19:01 | |
| *** bobh has joined #openstack-sdks | 19:18 | |
| *** bobh has quit IRC | 19:23 | |
| *** mriedem has joined #openstack-sdks | 19:24 | |
| *** e0ne has quit IRC | 19:32 | |
| *** cdent has quit IRC | 19:42 | |
| *** openstackgerrit has joined #openstack-sdks | 19:46 | |
| openstackgerrit | Merged openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | 19:46 |
| openstackgerrit | Merged openstack/python-openstackclient master: Fix missing trailing spaces in network help messages https://review.openstack.org/588616 | 19:46 |
| *** bobh has joined #openstack-sdks | 19:59 | |
| openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | 20:13 |
| mordred | dtroyer, frickler: ^^ that should fix theissues tosky was seeing with openstackclient-check-plugins on stable/queens (and the one in the stack before it, about stestr, is needed in that repo anyway) | 20:15 |
| mordred | dhellmann: ^^ you might find that patch interesting as well - it is a patch thatuses the siblings logic outside of a tox context | 20:16 |
| -openstackstatus- NOTICE: Due to a bug, Zuul has been unable to report on cherry-picked changes over the last 24 hours. This has now been fixed; if you encounter a cherry-picked change missing its results (or was unable to merge), please recheck now. | 20:43 | |
| *** thrash is now known as thrash|g0ne | 20:51 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: DNM Testing pep8 line comments patch https://review.openstack.org/589635 | 20:55 |
| *** slaweq has quit IRC | 20:58 | |
| mordred | Shrews: easy review if you have a sec: https://review.openstack.org/#/c/589212/ | 21:17 |
| *** slaweq has joined #openstack-sdks | 21:23 | |
| *** edmondsw has quit IRC | 21:29 | |
| *** Leo_m has quit IRC | 21:40 | |
| *** Leo_m has joined #openstack-sdks | 21:46 | |
| *** Leo_m has quit IRC | 21:51 | |
| *** Leo_m has joined #openstack-sdks | 21:57 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add dns-domain support to Network object https://review.openstack.org/516701 | 22:10 |
| *** bobh has quit IRC | 22:12 | |
| *** edmondsw has joined #openstack-sdks | 22:54 | |
| *** edmondsw has quit IRC | 22:59 | |
| openstackgerrit | Merged openstack/openstacksdk master: Stop calling get_all_types when service-type is None https://review.openstack.org/589212 | 23:05 |
| *** Leo_m has quit IRC | 23:46 | |
| *** Leo_m_ has joined #openstack-sdks | 23:46 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Stop using the -consumer devstack jobs https://review.openstack.org/589675 | 23:54 |
| mordred | Shrews: ^^ I think openstacksdk is sufficiently integrated with devstack that we shoudl do that | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!