Monday, 2018-07-23

« Sunday, 2018-07-22 Index Tuesday, 2018-07-24 »
*** bobh has joined #openstack-sdks00:53
*** bobh has quit IRC01:02
*** edmondsw has joined #openstack-sdks01:11
*** dasp_ has quit IRC01:15
*** dasp has joined #openstack-sdks01:15
*** edmondsw has quit IRC01:15
*** fabian_ has joined #openstack-sdks01:18
*** fabian_ is now known as chenyb401:28
*** olaph has quit IRC01:32
*** olaph has joined #openstack-sdks01:35
*** mhen has quit IRC01:41
*** mhen has joined #openstack-sdks01:43
*** bobh has joined #openstack-sdks02:50
*** dave-mcc_ has quit IRC02:54
*** bobh has quit IRC02:54
*** edmondsw has joined #openstack-sdks02:59
*** edmondsw has quit IRC03:04
*** slaweq has quit IRC03:52
*** slaweq has joined #openstack-sdks03:59
*** JudeC has joined #openstack-sdks04:24
*** edmondsw has joined #openstack-sdks04:47
*** edmondsw has quit IRC04:52
*** chenyb4 has quit IRC05:29
*** chenyb4 has joined #openstack-sdks05:32
*** chenyb4 has quit IRC06:28
*** chenyb4 has joined #openstack-sdks06:28
*** edmondsw has joined #openstack-sdks06:35
*** edmondsw has quit IRC06:39
*** dtantsur|afk is now known as dtantsur06:45
*** Luzi has joined #openstack-sdks07:05
*** pooja_jadhav has joined #openstack-sdks07:10
*** jpich has joined #openstack-sdks07:13
*** tosky has joined #openstack-sdks07:36
*** dtantsur is now known as dtantsur|brb08:18
*** edmondsw has joined #openstack-sdks08:23
*** edmondsw has quit IRC08:28
*** e0ne has joined #openstack-sdks08:43
*** JudeC has quit IRC08:50
*** r-mibu has joined #openstack-sdks09:02
openstackgerritJosephine Seifert proposed openstack/python-openstackclient master: [WIP] osc-included image signing (using openstacksdk)  https://review.openstack.org/58008609:11
*** dtantsur|brb is now known as dtantsur09:38
*** cdent has joined #openstack-sdks09:39
*** finucannot has quit IRC09:53
*** stephenfin has joined #openstack-sdks09:55
*** chenyb4 has quit IRC10:07
*** edmondsw has joined #openstack-sdks10:11
*** edmondsw has quit IRC10:16
*** dave-mccowan has joined #openstack-sdks11:04
*** tellesnobrega has joined #openstack-sdks12:13
*** edmondsw has joined #openstack-sdks12:13
*** thrash|g0ne is now known as thrash12:20
*** crunchengine has joined #openstack-sdks12:35
*** mriedem has joined #openstack-sdks12:53
*** lbragstad has joined #openstack-sdks13:31
openstackgerritMerged openstack/os-service-types master: Add release note link in README  https://review.openstack.org/57843913:41
*** thrash is now known as thrash|biab13:49
Luzihi osc and sdk: looking through the latest patches I have seen, that since Jul 19 every time zuul checks "osc-functional-devstack" it fails13:50
Luziwith the same failure in every patch13:50
Luziany idea, why this is happening? it is the "test_volume_snapshot" that fails with "Invalid input for field/attribute size. Value: None. None is not of type 'integer', 'string' (HTTP 400)"13:52
*** chenyb4 has joined #openstack-sdks13:53
Luzithis is the earliest patch, that has this error: https://review.openstack.org/#/c/582334/13:59
Luzimordred, dtroyer this might be interesting for you - this might be a bigger bug somewhere14:04
*** pasm has joined #openstack-sdks14:06
pasmhi guys, I found and fixed a bug in osc-lib (https://github.com/psmiraglia/osc-lib)14:08
pasmhow to submit a PR?14:08
dtroyerLuzi: we have had sporadic problems with volume tests over the years, this feels like a real bug somewhere.  It is possible that cinderclient has a change in it that we need to account for, or isn't backward-compatible.  I'll make some time to look at it after lunch…14:09
pasm(hope this is the right place to ask)14:09
Luzidtroyer: thank you :)14:09
dtroyerpasm: it is!14:09
pasm:-)14:09
dtroyerand that looks oddly familiar...14:09
dtroyerpasm: I think it was laready fined here: https://review.openstack.org/#/c/581886/14:10
*** Luzi has quit IRC14:11
pasmdtroyer: it is incopmlete14:11
dtroyerand that was released last week as 1.11.014:11
*** bobh has joined #openstack-sdks14:11
dtroyerah, ok14:11
dtroyergrrr...14:11
pasmdtroyer: there is another occurrence of issubclass()14:12
dtroyerso are you set up to contribute to OpenStack via Gerrit (all the accounts, etc?)14:12
pasmno, totally new14:12
pasmcan you link me a guide about your review workflow?14:13
dtroyerhttps://docs.openstack.org/contributors/common/setup-gerrit.html is the specifics of Gerrit14:14
dtroyermuch of that doc should be useful14:14
*** thrash|biab is now known as thrash14:15
dtroyerpasm: if you''d like to create a bug you can do it in https://storyboard.openstack.org/#!/project/974  (it would be osc-lib's first in storyboard :)14:16
pasmI'll try with Gerrit14:18
*** yolanda__ has joined #openstack-sdks14:19
pasmdtroyer: If I understood well, by setting up git-review I only have to push my change. Is it correct?14:19
dtroyerpasm: the command would be 'git review' rather than push but that's basically what it does, plus some other Gerrit details14:20
dtroyerthe first time you run git review in a repo it sets itself up14:21
pasmdtroyer: ok, I'll try...14:21
*** yolanda_ has quit IRC14:21
*** yolanda__ is now known as yolanda14:26
*** kimamisa has joined #openstack-sdks14:27
openstackgerritRyan Brady proposed openstack-infra/shade master: Add support for static routes  https://review.openstack.org/58066114:32
pasmdtroyer: I should be ready to run "git review", could you confirm me some steps?14:32
dtroyerpasm: ok14:32
pasmdtroyer: 1) clone from https://git.openstack.org/openstack/osc-lib14:32
pasmdtroyer: 2) do changes (withot commit)14:33
*** dave-mccowan has quit IRC14:33
pasmdtroyer: 3) git review -s14:34
pasmdtroyer: 4) git commit14:34
pasmdtroyer: is it correct?14:34
dtroyerI'd swap 2 and 3 to make sure you have everything happy before you have uncommitted changes lying about but it works either way14:34
dtroyerand then git review to submit to gerrit14:36
pasmdtroyer: after "git commit"?14:37
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490514:37
dtroyerpasm: yes14:37
mordreddtroyer: ^^ there's that command I was mentioning on friday14:37
*** chenyb4 has quit IRC14:38
dtroyermordred: nice!14:38
*** purplerbot has quit IRC14:41
*** purplerbot has joined #openstack-sdks14:41
openstackgerritPaolo Smiraglia proposed openstack/osc-lib master: Change issubclass() to isinstance()  https://review.openstack.org/58492014:42
*** dave-mccowan has joined #openstack-sdks14:42
pasmdtroyer: more easy than expected... thanks again!14:45
dtroyerpasm: \o/  thank you!14:45
pasmdtroyer: and now? someone will took in charge my review request?14:46
dtroyerpasm: yes.  we are in a freeze on osc-lib so it may be a bit before it merges, unless we decide that a py37 issue is critical :)14:47
pasmdtroyer: ok, I asked just for personal knowledge14:49
mordredlgtm14:50
pasmdtroyer: back to work now... ciao!14:50
*** bobh has quit IRC15:07
*** bobh has joined #openstack-sdks15:07
mordreddtroyer: I'm looking at the volume snapshot ting ...15:15
mordredugh. it seems like size is a required value now, even though for "create volume from snapshot" the volume size will be the size of the snapshot15:17
*** mrhillsman has quit IRC15:18
*** samueldmq has quit IRC15:19
*** csatari has quit IRC15:19
*** TheJulia has quit IRC15:20
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create  https://review.openstack.org/58493215:20
*** Hazelesque has quit IRC15:21
mordreddtroyer: I *think* that will take care of it15:21
*** mrhillsman has joined #openstack-sdks15:21
*** samueldmq has joined #openstack-sdks15:21
*** Hazelesque has joined #openstack-sdks15:22
*** csatari has joined #openstack-sdks15:23
*** Hazelesque has quit IRC15:24
*** Hazelesque has joined #openstack-sdks15:24
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create  https://review.openstack.org/58493215:33
*** kimamisa has quit IRC15:33
*** TheJulia has joined #openstack-sdks15:35
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create  https://review.openstack.org/58493215:35
mordreddtroyer: also - spoke with smcginnis and jungleboyj in #openstack-cinder - it's a server-side bug they're going to fix15:36
mordreddtroyer: but the osc patch should be harmless, so we might want to land it to unbreak the gate anway15:36
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create  https://review.openstack.org/58493215:40
*** r-mibu has quit IRC15:40
mordredhttps://review.openstack.org/#/c/584944/ <-- cinder fix15:42
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: DNM - Testing cinder fix  https://review.openstack.org/58494815:44
dtroyermordred: ++ on unbreaking.  since it doesn't require another API call, its fine to leave in15:49
mordredcoolio15:55
mordreddtroyer: for that versions command - I also think being able to see it by single service would be a useful filter - but I need to add a new call to keystoneauth for that (I completely didn't think about that case when adding the original call) - so maybe that'll be an improvement for stein15:56
mordred(obviously someone can filter - but the ksa command sure will still run discovery on every endpoint)15:56
dtroyerAdding a client-side filter would be fine until we get the query argument to the call15:57
dtroyeruntil ksa is updated it'll take the same amount of time anyway15:58
mordreddtroyer: nod. good call. so you thnk it should just be a filter to that same command? so "openstack versions list --service-type=compute" ?15:58
dtroyeryeah15:58
mordredwoot. I'll get that updated during this next phone call while I'm ignoring people15:59
* dtroyer is looking, maybe just —service15:59
mordredkk15:59
*** dave-mccowan has quit IRC16:00
dtroyermordred: confirm —service, we use it elsewhere for that, —service-type is used in network for a neutron thing16:01
*** e0ne has quit IRC16:08
*** dave-mccowan has joined #openstack-sdks16:09
*** dave-mccowan has quit IRC16:23
*** dave-mccowan has joined #openstack-sdks16:25
openstackgerritMonty Taylor proposed openstack/service-types-authority master: Add container-infra as an alias for magnum  https://review.openstack.org/58496316:27
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490516:27
mordreddtroyer: okie. there's filter by service - as well as by status. it'll let you specify service by any known alias16:28
*** dave-mccowan has quit IRC16:30
*** jpich has quit IRC16:30
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490516:33
*** dave-mccowan has joined #openstack-sdks16:43
*** JudeC has joined #openstack-sdks16:59
openstackgerritToure Dunnon proposed openstack-infra/shade master: python-shade expose MTU setting.  https://review.openstack.org/57886117:06
*** e0ne has joined #openstack-sdks17:22
*** e0ne has quit IRC17:22
*** dtantsur is now known as dtantsur|afk17:24
lbragstadcurious if i can get some reviews on https://review.openstack.org/#/q/status:open+project:openstack/python-openstackclient+branch:master+topic:bp/unified-limits before client freeze on Thursday?17:27
dtroyerlbragstad: yup, those are on my short list17:33
mordreddtroyer, adriant, rods, slaweq, dtantsur|afk, Qiming: just as a heads-up - Shrews just restarted infra's nodepool ... so as of now nodepool is running on openstacksdk instead of shade in production17:35
dtroyerno pressure there!  :)17:35
mordredit's _mostly_ identical code - so that's mostly a "it looks like we didn't break anything in the merge"17:35
Shrewswell, 1 node of nodepool17:35
mordreddtroyer: :)17:35
mordredShrews: ssh. the other thing sounds more impressive ;)17:35
mordreddtroyer: bwahahaha. my DNM patch to test the cinder fix didn't test anything at all because it didn't touch any code files :)17:37
dtroyerlbragstad: did you see my comments on https://review.openstack.org/#/c/574475/ last week?17:38
*** thrash is now known as thrash|biab17:41
openstackgerritMerged openstack/service-types-authority master: Add container-infra as an alias for magnum  https://review.openstack.org/58496317:55
PagliaccisCloudwould someone mind giving me a hand with this bugfix? zuul keeps failing at creating a volume snap but I didn't changed anything having to do with cinder :/ https://review.openstack.org/#/c/584484/18:08
mordredPagliaccisCloud: there is a recent cinder bug that is causing it. a patch is up to fix it18:14
PagliaccisCloudah ok, thanks mordred. i'll wait it out then.18:15
mordredPagliaccisCloud: https://review.openstack.org/#/c/584944/18:15
mordredis the patch in question18:15
*** tosky has quit IRC18:23
*** e0ne has joined #openstack-sdks18:26
lbragstaddtroyer: oh - i didn't (my dashboard query is sensitive to votes < 0)18:32
lbragstaddtroyer: thanks for the feedback, i'll get those addressed or responded to today18:33
dtroyerlbragstad:, thanks, IIRC the idea applies to both review18:34
slaweqmordred: nice :)18:36
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Pass volume snapshot size to volume create  https://review.openstack.org/58493218:39
dtroyermordred: minor fix ^^^^18:41
mordreddtroyer: ++ thanks!18:43
*** lbragstad_ has joined #openstack-sdks18:47
*** lbragstad has quit IRC18:48
*** lbragstad_ is now known as lbragstad18:51
*** boucherv has joined #openstack-sdks19:01
*** boucherv has left #openstack-sdks19:01
*** cdent has quit IRC19:04
*** thrash|biab is now known as thrash19:09
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Fix error with image show when image name is None  https://review.openstack.org/52946419:16
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Fix error with image show when image name is None  https://review.openstack.org/52946419:17
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490519:29
*** edmondsw has quit IRC20:09
lbragstaddtroyer: i'm getting an odd error addressing one of your comments20:12
lbragstadit's related to making --default-limit a required argument and it seems to stumble with integer types20:12
lbragstadhttp://paste.openstack.org/show/726476/ is the implementation and http://paste.openstack.org/show/726475/ is a trace of the failure20:13
lbragstaddoes the failure jump out to you at all?20:14
lbragstadhttp://paste.openstack.org/show/726477/ is what i have locally for the test20:15
*** pasm has quit IRC20:29
*** kimamisa has joined #openstack-sdks20:30
*** slaweq has quit IRC20:34
*** slaweq has joined #openstack-sdks20:35
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add ability to filter version data by service-type  https://review.openstack.org/58502920:47
*** e0ne has quit IRC20:50
dtroyerlbragstad: in tests when setting arglist we make them all strings and let argparse do the conversion.20:51
lbragstadoh20:52
mordreddtroyer: ^^ that ksa patch above is the one we'll need to make that osc service-type filter be more efficient20:52
dtroyerverifylist has the correct types20:52
dtroyerlbragstad: its odd and I've forgotten exactly why but its that way everywhere I look20:52
lbragstadhuh - interesting... i figured the tests would expect the same type passed in as what's declared in the option definition20:53
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions  https://review.openstack.org/58503020:54
lbragstaddtroyer: that seems to have fixed it, thanks!20:55
dtroyerlbragstad: I think it is because it passes through cliff and argparse and they expect to operate on strings20:55
dtroyeras input20:56
lbragstadthat makes sense20:56
*** edmondsw has joined #openstack-sdks20:56
mordreddtroyer: https://review.openstack.org/#/c/584932/ is green - you wanna click the +A? (I'm not sure my +2 counts since you just uploaded a fix to the original patch)21:05
dtroyermordred: got it.  Thanks for beating me to that :)21:08
mordred\o/21:09
mordreddtroyer: at least it wasn't another race-condition bug21:09
dtroyerno kidding21:14
openstackgerritLance Bragstad proposed openstack/python-openstackclient master: Implement support for registered limits  https://review.openstack.org/57447521:18
*** e0ne has joined #openstack-sdks21:19
lbragstaddtroyer: for https://review.openstack.org/#/c/575211/5/doc/source/cli/command-objects/limit.rst@17 would you like project to be the non-named argument?21:20
dtroyerthe rule is the positional arg should be the name or ID of the resource named in the command… that isn't always possible though21:21
lbragstadso - openstack limit create --service compute --resource-name cores --resource-limit 20 project_foo21:21
*** e0ne has quit IRC21:21
dtroyerI'm thinking it might be resource-name21:22
lbragstadok - so same pattern as registered limits then21:22
dtroyeryes… that's what you use in the other commands to identify the particular limit21:23
dtroyeralso, can the name be used in the other commands or must it be ID only?21:23
lbragstadwell - limits are a little strange in that they have a rather complex uniqueness constraint21:23
lbragstadeach limit must be unique wrt service, default_limit (in the case of registered limits), resource name, and optionally region21:25
dtroyerI wondered… I wouldn't mind doing a bit of work to make UX better, but that can come later, just curious21:25
lbragstadso asking keystone for a list of all limits with resource names of 'cores' is more of a filter21:26
lbragstadyeah - i hear you21:26
lbragstadis that something we should track in a bug/RFE?21:26
lbragstadif it isn't a blocker for these patches?21:26
dtroyerit is certainly not a blocker, unless it was just a find_resource() call away :)  sure, having a tracking story would be helpful21:27
lbragstadcool - i'll get the project limits patch updated and then open a couple RFE for those21:28
dtroyerthanks, I appreciate it21:28
lbragstadabsolutely - thanks for the reviews21:28
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490521:32
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions  https://review.openstack.org/58503021:32
*** kimamisa has quit IRC21:32
lbragstaddtroyer: did osc move to storyboard?21:39
lbragstadhuh - looks like it21:39
dtroyerit did…21:45
openstackgerritLance Bragstad proposed openstack/python-openstackclient master: Implement support for project limits  https://review.openstack.org/57521121:52
lbragstadhttps://storyboard.openstack.org/#!/story/2003074 and https://storyboard.openstack.org/#!/story/200307321:52
lbragstadshould do it dtroyer ^21:52
dtroyerthanks!21:52
lbragstadno problem - i'll keep an eye on the check queue but unit and functional tests pass locally for me21:53
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490521:57
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Add command to show all service versions  https://review.openstack.org/58490521:58
*** bobh has quit IRC22:01
*** edmondsw has quit IRC22:04
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add ability to filter version data by service-type  https://review.openstack.org/58502922:12
*** slaweq has quit IRC22:23
*** mriedem has quit IRC22:39
openstackgerritMerged openstack/python-openstackclient master: Pass volume snapshot size to volume create  https://review.openstack.org/58493222:40
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Fix error with image show when image name is None  https://review.openstack.org/52946422:42
*** slaweq has joined #openstack-sdks23:11
*** slaweq has quit IRC23:16
*** mriedem has joined #openstack-sdks23:21
openstackgerritMonty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions  https://review.openstack.org/58503023:32
*** edmondsw has joined #openstack-sdks23:38
*** edmondsw has quit IRC23:43
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add ability to filter version data by service-type  https://review.openstack.org/58502923:45
*** mriedem has quit IRC23:50
« Sunday, 2018-07-22 Index Tuesday, 2018-07-24 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!