| *** mriedem has quit IRC | 00:07 | |
| *** ttsiouts has quit IRC | 00:15 | |
| *** chenyb4 has joined #openstack-sdks | 01:06 | |
| *** gildub has joined #openstack-sdks | 02:22 | |
| *** ttsiouts has joined #openstack-sdks | 02:37 | |
| *** ttsiouts has quit IRC | 02:39 | |
| *** annp has joined #openstack-sdks | 02:40 | |
| *** bobh has joined #openstack-sdks | 02:43 | |
| *** dtruong has quit IRC | 02:45 | |
| *** dtruong has joined #openstack-sdks | 02:47 | |
| *** bobh has quit IRC | 02:49 | |
| *** ttsiouts has joined #openstack-sdks | 02:50 | |
| *** ttsiouts has quit IRC | 02:55 | |
| *** dave-mccowan has quit IRC | 02:57 | |
| *** sheel has joined #openstack-sdks | 03:03 | |
| *** gildub has quit IRC | 03:09 | |
| *** gildub has joined #openstack-sdks | 03:09 | |
| *** boris_42_ has quit IRC | 03:29 | |
| *** ttsiouts has joined #openstack-sdks | 03:55 | |
| *** ttsiouts has quit IRC | 04:00 | |
| *** dmsimard has quit IRC | 04:13 | |
| *** gildub_ has joined #openstack-sdks | 04:22 | |
| *** gildub has quit IRC | 04:32 | |
| *** gildub_ has quit IRC | 04:32 | |
| *** gildub has joined #openstack-sdks | 04:35 | |
| *** gildub has quit IRC | 06:01 | |
| *** slaweq has joined #openstack-sdks | 06:24 | |
| *** lifeless has quit IRC | 06:26 | |
| *** lifeless has joined #openstack-sdks | 06:26 | |
| *** lifeless_ has joined #openstack-sdks | 06:48 | |
| *** lifeless has quit IRC | 06:48 | |
| *** jpena|off is now known as jpena | 06:51 | |
| *** gtema has joined #openstack-sdks | 07:01 | |
| *** kimamisa has joined #openstack-sdks | 07:06 | |
| *** ttsiouts has joined #openstack-sdks | 07:17 | |
| *** cdent has joined #openstack-sdks | 07:27 | |
| *** slaweq has quit IRC | 07:28 | |
| *** jpich has joined #openstack-sdks | 07:39 | |
| *** lifeless has joined #openstack-sdks | 07:52 | |
| *** lifeless_ has quit IRC | 07:52 | |
| umbSublime | when creating a connection with openstack.connect, how can I specify an alternate path to the default clouds.yaml file ? | 07:55 |
|---|---|---|
| *** e0ne has joined #openstack-sdks | 08:06 | |
| *** cdent has quit IRC | 08:09 | |
| frickler | mnaser: mordred: dtroyer: IIUC it would make sense to release OSC and sdk together, after having this merged https://review.openstack.org/533809 | 08:20 |
| *** gkadam has joined #openstack-sdks | 08:20 | |
| * frickler wouldn't mind if some of the other neutron feature parity things were included, too ;) | 08:21 | |
| *** slaweq has joined #openstack-sdks | 08:23 | |
| openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386 | 08:39 |
| openstackgerrit | tianhui proposed openstack/python-openstackclient master: Compute: Add tags support for server https://review.openstack.org/569386 | 08:41 |
| *** gildub has joined #openstack-sdks | 08:56 | |
| *** dtantsur|afk is now known as dtantsur | 08:58 | |
| *** ttsiouts has quit IRC | 09:16 | |
| *** ttsiouts has joined #openstack-sdks | 09:21 | |
| *** lifeless_ has joined #openstack-sdks | 09:34 | |
| *** lifeless has quit IRC | 09:34 | |
| openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Modify the argument when setting floating ip other properties https://review.openstack.org/575057 | 09:39 |
| *** slaweq has quit IRC | 09:41 | |
| *** lifeless has joined #openstack-sdks | 09:44 | |
| *** lifeless_ has quit IRC | 09:46 | |
| *** slaweq has joined #openstack-sdks | 10:08 | |
| *** slaweq has quit IRC | 10:08 | |
| *** slaweq has joined #openstack-sdks | 10:08 | |
| *** d0ugal has quit IRC | 10:17 | |
| *** lifeless has quit IRC | 10:23 | |
| *** lifeless has joined #openstack-sdks | 10:24 | |
| *** jpena is now known as jpena|off | 10:24 | |
| *** lifeless_ has joined #openstack-sdks | 10:32 | |
| *** jpena|off is now known as jpena | 10:32 | |
| *** lifeless has quit IRC | 10:32 | |
| *** ttsiouts has quit IRC | 10:33 | |
| *** d0ugal has joined #openstack-sdks | 10:37 | |
| *** chenyb4 has quit IRC | 10:37 | |
| *** cdent has joined #openstack-sdks | 10:44 | |
| openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Do not require port argument when updating floating IP https://review.openstack.org/575057 | 10:50 |
| *** ttsiouts has joined #openstack-sdks | 11:17 | |
| *** lifeless_ has quit IRC | 11:42 | |
| *** lifeless has joined #openstack-sdks | 11:42 | |
| *** annp has quit IRC | 11:45 | |
| *** jpena is now known as jpena|lunch | 11:45 | |
| *** vadim has quit IRC | 11:55 | |
| *** edmondsw has joined #openstack-sdks | 12:07 | |
| umbSublime | How can I specify an arbitrary cloud config file when using the openstacksdk ? | 12:17 |
| umbSublime | rather "arbitrary path for the cloud config file" | 12:18 |
| *** chenyb4 has joined #openstack-sdks | 12:19 | |
| *** vadim has joined #openstack-sdks | 12:22 | |
| *** jpich has quit IRC | 12:31 | |
| *** dave-mccowan has joined #openstack-sdks | 12:42 | |
| *** bobh has joined #openstack-sdks | 12:54 | |
| mordred | umbSublime: you can either set the env var OS_CLIENT_CONFIG_FILE or you can pass a list of paths to the config_files parameter of openstack.config.OpenStackConfig- so like: config = openstack.config.OpenStackConfig(config_files=['/path/to/file']) ; cloud_region = config.get_one(cloud='my_cloud') ; conn = openstack.connection.Connection(config=cloud_region) | 12:57 |
| mordred | frickler: I'm getting failing osc-tips jobs on https://review.openstack.org/#/c/557935/ but it doesn't make immediate sense to me why - does it make sense to you? | 12:58 |
| mordred | mnaser: ah - interesting. "Skipping over invalid version data. No stability status in version." | 12:58 |
| mordred | cdent: ^^ does placement's version discovery doc not have a status field? | 12:59 |
| * cdent looks | 12:59 | |
| mordred | cdent: http://paste.openstack.org/show/723359/ is the paste in question | 13:00 |
| cdent | mordred: apparently not. I can fix that | 13:00 |
| cdent | what is it supposed to say. or rather, which of your tomes tells me what to do? | 13:00 |
| cdent | nm, this seems good enough: http://specs.openstack.org/openstack/api-wg/guidelines/microversion_specification.html#version-discovery | 13:01 |
| mordred | cdent: yes - that would be ideal | 13:01 |
| mordred | mnaser: in the mean time, try setting placement_endpoint_override to your placement endpoint | 13:02 |
| cdent | hmmm. we've always had a id, {min,max}_version, but never a status | 13:02 |
| cdent | what's different from what mnaser is doing and what what the scheduler report client (which uses ksa) is doing? | 13:02 |
| mordred | cdent: when keystoneauth does version discovery it filters out statuses that are not CURRENT or SUPPORTED unless you provide a flag | 13:03 |
| mordred | cdent: I'm not 100% sure yet why it's working in nova | 13:03 |
| mordred | cdent: where can I look at the scheduler report client? | 13:04 |
| cdent | nova/scheduler/client/report.py | 13:04 |
| mordred | cdent: weird. I'll have to dig a bit more to figure it out | 13:06 |
| umbSublime | awesome thanks mordred | 13:06 |
| cdent | mordred: it may be in the way nova.utils.get_ksa_adapter is happening | 13:07 |
| cdent | but in any case, I'll add a status | 13:08 |
| mordred | cdent: something something API-SIG recommendations something something | 13:08 |
| mordred | :) | 13:08 |
| cdent | indeed, but also, something something someone ate my clones something something | 13:09 |
| mordred | darned clone eaters | 13:10 |
| mordred | I made you such nice ones just the other day | 13:10 |
| cdent | such brief candles | 13:12 |
| mordred | out. out | 13:14 |
| *** gildub has quit IRC | 13:15 | |
| *** fabian_ has joined #openstack-sdks | 13:15 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Skip calls to glance and nova when got no servers https://review.openstack.org/568344 | 13:21 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add --name-lookup option to server list https://review.openstack.org/568345 | 13:21 |
| *** dave-mccowan has quit IRC | 13:21 | |
| openstackgerrit | Graham Hayes proposed openstack/os-api-ref master: Use 'sphinx.util.logging' https://review.openstack.org/563179 | 13:24 |
| *** mriedem has joined #openstack-sdks | 13:30 | |
| *** fabian_ has quit IRC | 13:36 | |
| cdent | mordred: help me believe that the version discovery doc is not itself microversioned. If it is I'm going to gouge my eyes out | 13:37 |
| cdent | and collapse into a logical black hole | 13:37 |
| *** fabian_ has joined #openstack-sdks | 13:37 | |
| *** chenyb4 has quit IRC | 13:39 | |
| mordred | cdent: it is, in fact, not microversioned | 13:40 |
| cdent | bless you | 13:40 |
| mordred | cdent: and I contend that any changes to it that align it more with the API-SIG guidelines are not breaking API changes | 13:40 |
| cdent | as would I | 13:41 |
| *** slaweq has quit IRC | 13:47 | |
| *** sheel has quit IRC | 13:50 | |
| *** slaweq has joined #openstack-sdks | 13:51 | |
| *** slaweq has quit IRC | 13:51 | |
| *** slaweq has joined #openstack-sdks | 13:52 | |
| * mnaser reads buffer | 13:55 | |
| *** bobh has quit IRC | 13:56 | |
| mnaser | mordred: thanks. `placement = os_client_config.make_rest_client('placement', placement_endpoint_override='https://placement-ca-ymq-1.vexxhost.net')` doesn't seem to do the trick however? | 13:56 |
| mordred | mnaser: well that's annoying | 13:58 |
| mnaser | mordred: my wip is http://paste.openstack.org/show/723387/ | 13:59 |
| mordred | mnaser: I'm unfortunately in a morning of meetings - but I'm very interested in helping to solve this for real -so if I go dark for chunks of time I haven't forgotten about you | 13:59 |
| mnaser | i tried openstacksdk and i was running into the same issues too, alongside is_public not being something changable (that has since been fixed but not released) | 13:59 |
| mnaser | mordred: oh don't worry about it, as async as you want, im not in a total rush about this | 13:59 |
| *** dave-mccowan has joined #openstack-sdks | 14:00 | |
| mordred | mnaser: fwiw, I can reproduce it locally: | 14:02 |
| mordred | >>> import openstack | 14:02 |
| mordred | >>> c=openstack.connect(cloud='vexxhost') | 14:02 |
| mordred | >>> c.placement.get('/allocation_candidates') | 14:02 |
| mordred | (give me same traceback) | 14:02 |
| *** chenyb4 has joined #openstack-sdks | 14:03 | |
| mnaser | mordred: at least it's not me doing something wrong, yay. if there's anything on our side to do, i can look into it but this is a queens deployment | 14:03 |
| mordred | mnaser: how hard would it be for you to cherry-pick https://review.openstack.org/575117 onto your nova? | 14:04 |
| mnaser | mordred: not very, but i'd be much happier doing it if that type of thing gets backported | 14:05 |
| mnaser | like: if you want a cherry pick to see how it looks like with no guarantee that it will stay there (because we will redeploy from upstream stable and the cherry pick will disappear) | 14:05 |
| cdent | mnaser: that _will_ get back ported | 14:06 |
| mordred | cdent: what do you think the chances are we convince anyone to cherry-pick your patch back to stable/queens? | 14:06 |
| *** jpena|lunch is now known as jpena | 14:06 | |
| cdent | jinx | 14:06 |
| mordred | _awesome_ | 14:06 |
| mnaser | cool | 14:06 |
| mnaser | this seems to be relatively low touch | 14:06 |
| mnaser | lets break stuff now | 14:06 |
| * mordred also wants to figure out how nova can use ksa to talk to placement already - but hasn't had time yet | 14:06 | |
| mnaser | i guess there will be a merge conflict because it looks like placement exists in `nova/api/openstack/placement/` in queens but we can take care of that easily in the backport | 14:07 |
| *** chenyb4 has quit IRC | 14:09 | |
| mnaser | mordred, cdent: https://review.openstack.org/#/c/575117/1 cherry-picked and i can see it in effect http://placement-ca-ymq-1.vexxhost.net/ | 14:11 |
| mnaser | i'm still getting a traceback in my code but who knows | 14:11 |
| cdent | same or different? | 14:11 |
| cdent | (traceback and code) | 14:11 |
| mnaser | same code http://paste.openstack.org/show/723387/ giving same traceback | 14:12 |
| cdent | drop the override? | 14:12 |
| mnaser | oh right | 14:12 |
| * mnaser just realized | 14:12 | |
| cdent | I'm concered confused by why the override didn't work, but I'm struggling to speculate because of lack of familiarity with the tools | 14:14 |
| * mnaser sighs | 14:15 | |
| mnaser | i cant even get my `clouds.yaml` running properly | 14:15 |
| mnaser | ok no my clouds.yaml is fine | 14:17 |
| mnaser | http://paste.openstack.org/show/723390/ gives me http://paste.openstack.org/show/723391/ | 14:17 |
| mnaser | (the nova print flavors parts works fine) | 14:17 |
| openstackgerrit | Graham Hayes proposed openstack/os-api-ref master: General overhaul of testing setup https://review.openstack.org/575124 | 14:17 |
| cdent | mnaser: i guess something is having trouble understanding how to define auth handling durig make_rest_client, but again, I've got no insight into that code. | 14:23 |
| mnaser | cdent: yeah i tried digging into it but it is way beyond me :( it's not a fun user experience but then again not many people interact with the placement api directly i assume | 14:24 |
| cdent | as far as I can tell the problems you're experience aren't because of placement itself, it is something about how the libraries are trying to contact it | 14:24 |
| cdent | placement itself is way simple | 14:24 |
| cdent | if curl to placement with a valid keystone token, it will just work | 14:25 |
| * cdent interacts with placement directly all the time | 14:25 | |
| cdent | but i'm not normal | 14:25 |
| mnaser | cdent: oh yeah, i agree, but i'm saying that the tooling to get me something that interacts with it relatively cleanly doesn't exist fully yet | 14:28 |
| mordred | cdent, mnaser: I'm confused both as to why override did not work and also why it's not working now- I still get the same error as before | 14:28 |
| mnaser | don't want to start building out something using requests etc | 14:29 |
| mordred | oh - I think I have an idea | 14:29 |
| * cdent holds breath | 14:29 | |
| mordred | mnaser: can you try adding placement_api_version to your clouds.yaml? (we're still 2 patches away from having discovery work right without having a configured api version) | 14:31 |
| mordred | mnaser: so placement_api_version: 1 | 14:31 |
| mnaser | "IndexError: list index out of range" | 14:31 |
| mordred | sigh | 14:31 |
| * mordred is going to have to _actually_ debug this | 14:31 | |
| mnaser | mordred: http://paste.openstack.org/show/723392/ this is where i am at right now | 14:32 |
| mordred | yah- that looks right | 14:32 |
| mnaser | feel free to throw things my way but i've hit a wall personally, i'd have to figure out the inner working of all of this to work any further | 14:36 |
| mordred | yah - I'll figure it out | 14:37 |
| openstackgerrit | Graham Hayes proposed openstack/os-api-ref master: General overhaul of testing setup https://review.openstack.org/575124 | 14:39 |
| mordred | heh | 14:41 |
| mordred | cdent: $ curl http://placement-ca-ymq-1.vexxhost.net/ | 14:41 |
| mordred | {"versions": [{"status": "CURRENT", "min_version": "1.0", "max_version": "1.17", "id": "v1.0"}]} | 14:41 |
| mordred | there's no links dict | 14:42 |
| cdent | yeah, never has been. is that a problem too? | 14:42 |
| mordred | it's what tells a discovery client where the given endpoint is | 14:42 |
| cdent | you're already there | 14:42 |
| mordred | but a discovery consumer doesn't know that | 14:43 |
| cdent | one sec | 14:43 |
| mordred | for all of the other services, the discovery document is an index to where the actual endpoints are | 14:43 |
| mordred | $ curl http://compute-ca-ymq-1.vexxhost.net/ | 14:43 |
| mordred | {"versions": [{"status": "SUPPORTED", "updated": "2011-01-21T11:33:21Z", "links": [{"href": "http://compute-ca-ymq-1.vexxhost.net/v2/", "rel": "self"}], "min_version": "", "version": "", "id": "v2.0"}, {"status": "CURRENT", "updated": "2013-07-23T11:33:21Z", "links": [{"href": "http://compute-ca-ymq-1.vexxhost.net/v2.1/", "rel": "self"}], "min_version": "2.1", "version": "2.60", "id": "v2.1"}]} | 14:43 |
| cdent | because they are hilariously antiquated things that do weird things like put versions in urls on the same service endpoint for | 14:44 |
| mordred | well - sure | 14:44 |
| cdent | for modern things that don't do such blasphemy, if no link rel self then endpoint is what you already requested | 14:44 |
| cdent | that was supposed to come out as a question, not a dammit! | 14:45 |
| cdent | mordred: i can stick it in too, to that same patch, but it seems...weird | 14:45 |
| mordred | that would be a potential behavior change in keystoneauth ... https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py#L543-L547 | 14:45 |
| *** chenyb4 has joined #openstack-sdks | 14:46 | |
| mordred | kmalloc: ^^ if we stopped skipping entries with no self link and used that to infer that the existing endpoint was the self-link - would you consider that a breaking change to keystoneauth? | 14:46 |
| cdent | i'm happy to fix placement to make life easier | 14:46 |
| cdent | but I think we want to make room for a future where endpoints are endpoints and that's it | 14:47 |
| kmalloc | mordred: hm | 14:47 |
| kmalloc | reading up | 14:47 |
| kmalloc | mordred: it would be a breaking change, behavior changes are breaking =/ | 14:48 |
| mordred | nod. we can queue that up for keystoneauth2 | 14:48 |
| cdent | still confused on how it is currently working for nova? | 14:49 |
| mordred | cdent: that is honestly a fascinating question | 14:49 |
| kmalloc | yeah. i am inclined to say we should ksa2 at this point and drop some behavior | 14:49 |
| cdent | s/still/I am still/ | 14:49 |
| kmalloc | well... if it has links but no self | 14:49 |
| kmalloc | it doesn't skip | 14:49 |
| cdent | no links at all | 14:49 |
| kmalloc | hm. | 14:49 |
| cdent | so maybe the problem is not at the ksa level? | 14:50 |
| kmalloc | maybe. | 14:50 |
| cdent | in which case I'd argue against changing placement /, perhaps? | 14:50 |
| mordred | cdent: yah - it might be that sdk is triggering version discovery where nova + plain ksa is not | 14:50 |
| kmalloc | likely | 14:50 |
| *** ttsiouts has quit IRC | 14:51 | |
| kmalloc | sdk does stuff in some more indirect ways. | 14:51 |
| mordred | cdent: I would prefer to not special-case placement in sdk with a "please don't try version discovery on placement" - also, it'll break discovering available microversions | 14:51 |
| kmalloc | mordred: ftr, i would love to stop skipping no-link items | 14:51 |
| cdent | i'm not suggesting to avoid version discovery | 14:51 |
| kmalloc | i just see some "this might actually break someone" | 14:51 |
| kmalloc | potential | 14:52 |
| cdent | well if you both feel that way I'll add a link | 14:52 |
| mordred | cdent: yah - but nova's use of ksa is really only likely able to work by using ksa in such a way that version discovery is being avoided | 14:52 |
| cdent | I don't feel strongly about it | 14:52 |
| kmalloc | cdent: i don't want you to add a link, i don't think we can change ksa's behavior | 14:52 |
| mordred | yah - I think the link is silly | 14:52 |
| kmalloc | cdent: so, adding a link might be the correct way | 14:52 |
| kmalloc | just not the desirable one | 14:52 |
| cdent | what I do feel strongly about is having version numbers in urls and double endpoints | 14:53 |
| *** ttsiouts has joined #openstack-sdks | 14:53 | |
| kmalloc | mordred: i dislike the volume of inherited ick we carried over from ksc.session | 14:53 |
| mordred | kmalloc: yah | 14:53 |
| cdent | but we are in the reality we are in so... | 14:53 |
| mordred | cdent: totally. | 14:53 |
| kmalloc | cdent: please please please don't do version numbers in urls if you can avoid. | 14:53 |
| kmalloc | cdent: so.. i am with you there | 14:53 |
| kmalloc | mordred: how bad would it be to cut a ksa2 and drop compat behaviors [for sdk] | 14:53 |
| cdent | kmalloc: yeah, don't plan to: placement was designed from the outset to never do that | 14:54 |
| kmalloc | and start iterating on that instead of ksa1 continues? | 14:54 |
| kmalloc | cdent: ++ and i appreciate that so very much! | 14:54 |
| mordred | kmalloc: I don't think it would be _bad_ - but I think it would take us a few months | 14:54 |
| kmalloc | mordred: well we'd need to ksa2 work anyway. i'm inclined to talk to lbragstad about it | 14:54 |
| mordred | kk | 14:54 |
| kmalloc | ksa1 is pretty stable, and we could make ksa2 just without all the icky compat stuff. | 14:55 |
| cdent | can you guys speculate what ksa or the sdk would do if I set the href for the self link to '' | 14:55 |
| mordred | I'll show you the code | 14:55 |
| cdent | I want to do that because no where in placement does placemet know its own scheme, hostname, port, base url. And it is very important that it stay that way | 14:56 |
| cdent | sorry about my n key | 14:56 |
| mordred | cdent: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py#L406-L426 | 14:56 |
| *** ttsiouts has quit IRC | 14:56 | |
| *** ttsiouts has joined #openstack-sdks | 14:57 | |
| mordred | (although there is a bug in that that needs fixing) | 14:57 |
| cdent | I read that as "should be okay": it will result in the discovery url, which is what we want | 14:57 |
| mordred | cdent: yes. I believe that is true - also, we can make mnaser deploy it and we can find out for sure ;) | 14:58 |
| kmalloc | cdent: it should work afaict. | 14:58 |
| kmalloc | but, honestly,sometimes discovery stuff is wonkier than expected -- we have a lot of carry-over magic in lots of places. | 14:59 |
| * kmalloc runs off to meeting. | 14:59 | |
| cdent | yeah, we shall see | 14:59 |
| mordred | cdent, kmalloc: yup. this is the result of having to support the epic amount of incompatible pre-existing mush | 15:00 |
| mnaser | i don't mind making changes if they're not too wild | 15:01 |
| mordred | mnaser: btw - placement_enpdoint_override just worked for me | 15:02 |
| mordred | placement_endpoint_override: http://placement-ca-ymq-1.vexxhost.net/ | 15:02 |
| mnaser | maybe because i'm using os_client_config i guess | 15:03 |
| mnaser | wait wait wait | 15:03 |
| mnaser | mordred: remember the bug i mentioned about endpoint override not working?! | 15:03 |
| mnaser | you fixed it but we might not had a release since | 15:03 |
| mordred | yah | 15:03 |
| mordred | ah | 15:03 |
| mordred | yah - we need a release | 15:03 |
| mnaser | https://review.openstack.org/#/c/565489/ | 15:03 |
| frickler | mordred: nothing obvious on https://review.openstack.org/#/c/557935/ for me, either. though I seem to remember having seen this fail earlier with what I suspected to be race conditions, but on the detach side | 15:08 |
| frickler | mordred: might either be an unstable test and the two in a row just unlucky, or some subtle change in timing somewhere | 15:09 |
| mordred | frickler: nod. I'll recheck again just to be sure | 15:09 |
| frickler | mordred: yeah, if that still has the same failure, I'll start comparing versions with the passing runs earlier | 15:10 |
| cdent | woot on 565489 | 15:14 |
| cdent | mordred, mnaser, kmalloc https://review.openstack.org/575117 updated to add links | 15:19 |
| mnaser | if that seems okay to mordred and other reviews i can push that up to test | 15:22 |
| mordred | mnaser: I think it's worth trying - also, we totally need to make an sdk release | 15:25 |
| mnaser | mordred: ill wait for some nova reviews to roll in before i make that change | 15:27 |
| *** fabian_ has quit IRC | 15:28 | |
| *** lifeless has quit IRC | 15:31 | |
| *** lifeless has joined #openstack-sdks | 15:31 | |
| *** chenyb4 has quit IRC | 15:32 | |
| kmalloc | cdent: ++ | 15:32 |
| *** ttsiouts has quit IRC | 15:43 | |
| *** dtantsur is now known as dtantsur|afk | 15:46 | |
| *** gkadam has quit IRC | 16:08 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add test to verify behavior on '' in self link https://review.openstack.org/575158 | 16:16 |
| mordred | cdent, kmalloc, mnaser: ^^ that satisfies me that the link of '' from placement will do the right thing from sdk | 16:17 |
| kmalloc | mordred: are we cross-gating sdk and ksa? | 16:17 |
| kmalloc | if not, lets get that encoded in a test in KSA too | 16:17 |
| kmalloc | i don't want to accidently break someone down the line. | 16:18 |
| mordred | we are | 16:18 |
| kmalloc | because the behavior changes because of some other "fix" that we miss. | 16:18 |
| kmalloc | ok cool | 16:18 |
| kmalloc | wfm then | 16:18 |
| mordred | and yes - I think a test for that case in ksa is a good idea | 16:18 |
| mordred | but also we cross-gate :) | 16:18 |
| kmalloc | cross-gate makes me happy. i wont ever say no to more quality behavior tests ;) | 16:18 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add tests to verify behavior on '' in self link https://review.openstack.org/575158 | 16:19 |
| mordred | cdent: ^^ added a second test just to verify microversion info is found correctly | 16:19 |
| cdent | mordred: Imma have to take your word for it, that last test its hard to tell what it is actually doing | 16:22 |
| cdent | but overall sanity seems to be in place | 16:22 |
| mordred | cdent: the last test is basically just showing that the metainfo about the service's endpoint (placement.get_endpoint_data()) contains the microversion info that's in the discovery document ... namely that keystoneauth properly discovered the microversion ranges | 16:25 |
| mordred | cdent: but - taking my word for it is also fine :) | 16:25 |
| cdent | yeah, i figured that out once I read the json files, but the assert_calls remains dark | 16:27 |
| mnaser | i like that test, ill keep an eye on it | 16:40 |
| mordred | cdent: yah - for that you have to know a bit more about all of the requests_mock fixtures in that test suite | 16:46 |
| mordred | cdent: the point of "assert_calls()" is to make sure that at the end of the test the http calls you told it to mock were all called and nothing was called that you didn't tell it to mock | 16:47 |
| cdent | ✔ | 16:47 |
| mordred | keeping in mind that the base class already mocks out the "get me a token" interaction from keystone | 16:48 |
| *** e0ne has quit IRC | 17:03 | |
| *** jpena is now known as jpena|off | 17:24 | |
| *** gtema has quit IRC | 17:40 | |
| *** yolanda has quit IRC | 17:50 | |
| *** bobh has joined #openstack-sdks | 17:59 | |
| *** openstackgerrit has quit IRC | 18:04 | |
| *** yolanda has joined #openstack-sdks | 18:05 | |
| *** harlowja has joined #openstack-sdks | 18:10 | |
| *** dave-mccowan has quit IRC | 18:15 | |
| *** e0ne has joined #openstack-sdks | 18:20 | |
| *** boris_42_ has joined #openstack-sdks | 18:45 | |
| *** mriedem has quit IRC | 18:46 | |
| *** mriedem has joined #openstack-sdks | 18:47 | |
| *** cdent has quit IRC | 19:26 | |
| *** gtema has joined #openstack-sdks | 19:27 | |
| *** e0ne has quit IRC | 19:34 | |
| *** openstackgerrit has joined #openstack-sdks | 19:36 | |
| openstackgerrit | Lance Bragstad proposed openstack/python-openstackclient master: Implement support for registered limits https://review.openstack.org/574475 | 19:36 |
| openstackgerrit | Lance Bragstad proposed openstack/python-openstackclient master: Implement support for project limits https://review.openstack.org/575211 | 19:36 |
| *** e0ne has joined #openstack-sdks | 19:40 | |
| *** e0ne has quit IRC | 19:43 | |
| *** bobh has quit IRC | 19:48 | |
| *** bobh has joined #openstack-sdks | 19:48 | |
| *** lifeless_ has joined #openstack-sdks | 19:49 | |
| *** lifeless has quit IRC | 19:49 | |
| *** e0ne has joined #openstack-sdks | 19:56 | |
| *** gtema has quit IRC | 19:57 | |
| *** bobh has quit IRC | 19:57 | |
| *** e0ne has quit IRC | 19:58 | |
| *** dave-mccowan has joined #openstack-sdks | 20:05 | |
| *** bobh has joined #openstack-sdks | 20:24 | |
| *** ttsiouts has joined #openstack-sdks | 20:34 | |
| *** openstackgerrit has quit IRC | 21:04 | |
| *** vadim has quit IRC | 21:11 | |
| *** slaweq has quit IRC | 21:12 | |
| *** slaweq has joined #openstack-sdks | 21:12 | |
| *** lifeless_ has quit IRC | 21:23 | |
| *** lifeless has joined #openstack-sdks | 21:24 | |
| *** bobh has quit IRC | 21:32 | |
| *** edmondsw has quit IRC | 21:33 | |
| *** edmondsw has joined #openstack-sdks | 21:35 | |
| *** lifeless_ has joined #openstack-sdks | 21:36 | |
| *** lifeless has quit IRC | 21:37 | |
| *** edmondsw has quit IRC | 21:40 | |
| *** dave-mccowan has quit IRC | 21:43 | |
| *** kimamisa has quit IRC | 21:58 | |
| *** harlowja has quit IRC | 22:11 | |
| *** harlowja has joined #openstack-sdks | 22:12 | |
| *** ttsiouts has quit IRC | 22:15 | |
| *** harlowja has quit IRC | 22:21 | |
| *** openstackgerrit has joined #openstack-sdks | 22:22 | |
| openstackgerrit | Adam Harwell proposed openstack/python-openstackclient master: Add ability to filter image list by tag https://review.openstack.org/575256 | 22:22 |
| *** slaweq has quit IRC | 22:33 | |
| *** mriedem has quit IRC | 22:40 | |
| *** gkadam has joined #openstack-sdks | 22:46 | |
| openstackgerrit | Adam Harwell proposed openstack/python-openstackclient master: Add ability to filter image list by tag https://review.openstack.org/575256 | 22:48 |
| *** slaweq has joined #openstack-sdks | 22:53 | |
| *** ttsiouts has joined #openstack-sdks | 22:56 | |
| *** ttsiouts has quit IRC | 23:01 | |
| rm_work | running into some issues with openstacksdk between 0.9.19 and 0.10.0 with networking commands, maybe something with version discovery on old clouds? | 23:14 |
| rm_work | I was gonna go through the commits and see if I could figure out what might have caused it, but noticed that between 0.9.19 and 0.10.0 the repo more than doubled in commit count T_T | 23:14 |
| rm_work | anyone have any immediate thoughts about what might be going on? | 23:14 |
| rm_work | http://paste.openstack.org/show/723420/ | 23:18 |
| *** dave-mccowan has joined #openstack-sdks | 23:22 | |
| *** gildub has joined #openstack-sdks | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!