| *** ebbex has quit IRC | 00:18 | |
| *** ebbex has joined #openstack-sdks | 00:20 | |
| *** harlowja has quit IRC | 00:51 | |
| *** chenyb4 has joined #openstack-sdks | 01:03 | |
| *** bobh has quit IRC | 01:22 | |
| *** username_ has joined #openstack-sdks | 01:22 | |
| *** username_ is now known as username__ | 01:23 | |
| chenyb4 | Qiming, Can you help me review this patch ? https://review.openstack.org/#/c/566510/ | 01:27 |
|---|---|---|
| *** bobh has joined #openstack-sdks | 01:56 | |
| *** username__ has quit IRC | 02:35 | |
| *** gildub has joined #openstack-sdks | 02:41 | |
| *** bobh has quit IRC | 02:44 | |
| *** dayou_ has joined #openstack-sdks | 03:01 | |
| *** gildub has quit IRC | 03:04 | |
| *** gildub has joined #openstack-sdks | 03:05 | |
| *** slaweq has joined #openstack-sdks | 03:16 | |
| *** slaweq has quit IRC | 03:20 | |
| *** dave-mccowan has quit IRC | 03:48 | |
| *** amotoki has joined #openstack-sdks | 04:19 | |
| *** slaweq has joined #openstack-sdks | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** gildub has quit IRC | 05:27 | |
| *** gildub_ has joined #openstack-sdks | 05:27 | |
| *** e0ne has joined #openstack-sdks | 05:46 | |
| *** gildub_ has quit IRC | 05:49 | |
| *** gildub_ has joined #openstack-sdks | 05:50 | |
| *** e0ne has quit IRC | 05:50 | |
| *** halbbalda has quit IRC | 05:52 | |
| *** halbbalda has joined #openstack-sdks | 05:53 | |
| *** gildub_ has quit IRC | 06:12 | |
| *** gildub has joined #openstack-sdks | 06:14 | |
| *** thrash|g0ne has quit IRC | 06:14 | |
| *** thrash has joined #openstack-sdks | 06:17 | |
| *** thrash has quit IRC | 06:17 | |
| *** thrash has joined #openstack-sdks | 06:17 | |
| *** gildub has quit IRC | 06:18 | |
| *** annp has joined #openstack-sdks | 06:22 | |
| *** gtema has joined #openstack-sdks | 06:36 | |
| *** slaweq has joined #openstack-sdks | 06:51 | |
| *** gildub has joined #openstack-sdks | 06:57 | |
| *** gildub has quit IRC | 07:24 | |
| *** tosky has joined #openstack-sdks | 07:37 | |
| *** jpich has joined #openstack-sdks | 07:38 | |
| *** jpena|off is now known as jpena | 07:51 | |
| *** dtantsur|afk is now known as dtantsur | 07:53 | |
| *** edmondsw has joined #openstack-sdks | 08:35 | |
| *** edmondsw has quit IRC | 08:40 | |
| *** gkadam__ has joined #openstack-sdks | 09:06 | |
| openstackgerrit | Nobuto Murata proposed openstack/python-openstackclient master: Support --community in openstack image list https://review.openstack.org/565152 | 09:27 |
| *** chenyb4 has quit IRC | 10:24 | |
| *** cdent has joined #openstack-sdks | 10:26 | |
| *** annp has quit IRC | 10:33 | |
| *** slaweq has quit IRC | 10:54 | |
| *** slaweq_ has joined #openstack-sdks | 10:56 | |
| *** gkadam_ has joined #openstack-sdks | 10:59 | |
| *** slaweq has joined #openstack-sdks | 10:59 | |
| *** gkadam__ has quit IRC | 10:59 | |
| *** slaweq_ has quit IRC | 10:59 | |
| *** jpena is now known as jpena|lunch | 11:44 | |
| *** edmondsw has joined #openstack-sdks | 12:10 | |
| *** dave-mccowan has joined #openstack-sdks | 12:43 | |
| *** jpena|lunch is now known as jpena | 12:49 | |
| *** chenyb4 has joined #openstack-sdks | 12:55 | |
| *** cdent has quit IRC | 13:09 | |
| *** yolanda has joined #openstack-sdks | 13:16 | |
| *** yolanda_ has quit IRC | 13:18 | |
| *** cdent has joined #openstack-sdks | 13:39 | |
| mordred | Shrews, slaweq: fell like re-approving https://review.openstack.org/#/c/566320/ ? I bundled in the pep8 fixes too | 13:44 |
| mordred | frickler: ^^ I will do a followup for your comment | 13:44 |
| *** dayou_ has quit IRC | 13:49 | |
| frickler | mordred: o.k., I'll give you a +2, then ;) | 13:53 |
| mordred | frickler: \o/ | 13:55 |
| mnaser | mordred: so i think going by the ML list from gerard about his issues with openstacksdk that they've found a bug | 14:03 |
| frickler | mordred: did you move os-client-config bugs to storyboard now, too? tried to mark https://bugs.launchpad.net/os-client-config/+bug/1768813 as "Fix Released" but that doesn't seem possible anymore | 14:03 |
| openstack | Launchpad bug 1768813 in os-client-config "config.get_cache_expiration_time() function missing in 1.31.0 release" [Critical,Fix committed] - Assigned to Monty Taylor (mordred) | 14:03 |
| mnaser | mordred: comparing a resource to None raises an exception because https://github.com/openstack/openstacksdk/blob/master/openstack/resource.py#L356-L360 | 14:03 |
| mnaser | comparand = None, Exception: <class 'AttributeError'> 'NoneType' object has no attribute '_body' | 14:04 |
| mnaser | (if you have if some_resource != None) | 14:04 |
| slaweq | mordred: +W :) | 14:04 |
| mnaser | would simply returning false if comparand = None be an appropriate fix there? | 14:04 |
| mnaser | (i can push up a patch) | 14:04 |
| mnaser | well, i'll do that and then follow up the discussion in reviews :) | 14:06 |
| *** bobh has joined #openstack-sdks | 14:10 | |
| openstackgerrit | Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230 | 14:11 |
| *** dayou_ has joined #openstack-sdks | 14:13 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234 | 14:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235 | 14:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove D exclusions from flake8 config https://review.openstack.org/567236 | 14:22 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix H103 Apache license header check https://review.openstack.org/567237 | 14:22 |
| mordred | frickler: ^^ see what you made me go and do :) | 14:22 |
| mordred | frickler: yes! it's in storyboard | 14:22 |
| mordred | mnaser: yes - good call | 14:23 |
| mordred | mnaser: patch looks great - but you should always use 'is' when comparing against None | 14:24 |
| mnaser | mordred: that totally ran through my mind but i was like | 14:24 |
| mnaser | "is none.. that's sql" | 14:24 |
| mordred | :) | 14:25 |
| mnaser | mordred: ill update that and also try to add a small test | 14:25 |
| mordred | fwiw, it's because None is a singleton - is checks object identity | 14:26 |
| *** chenyb4 has quit IRC | 14:27 | |
| mnaser | oh i see | 14:28 |
| *** dayou_ has quit IRC | 14:30 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494 | 14:30 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929 | 14:30 |
| mordred | Qiming: re: chenyb4's patch above, the floating ip job and pep8 errors should be handled by https://review.openstack.org/566320 | 14:32 |
| mordred | when it lands we can recheck and all should be good | 14:32 |
| mnaser | mordred: i wonder if this is a bug that happens in python3 only | 14:34 |
| mnaser | i just made a simple test with "foo is None" and commenting out my patch.. it passes, so i'm setting up python3 right now | 14:34 |
| mnaser | not sure if there's something i don't understand or know | 14:34 |
| mordred | oh fun | 14:34 |
| *** _alastor_ has quit IRC | 14:39 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935 | 14:41 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938 | 14:41 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049 | 14:41 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935 | 14:46 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938 | 14:46 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049 | 14:46 |
| mnaser | ok, found it | 14:47 |
| openstackgerrit | Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230 | 14:48 |
| mnaser | mordred: ^ should be okay, commenting out my patch makes tests fail so yay | 14:48 |
| mordred | \o/ | 14:49 |
| mordred | frickler: updated version of that look good to you? | 14:50 |
| mordred | mnaser: frickler had a suggestion on ps1 about doing an isinstance(comparand, Resource) that might still be a good idea | 14:51 |
| mnaser | oh oops | 14:51 |
| mnaser | i didnt see that | 14:51 |
| mnaser | i like that idea | 14:51 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Defer all endpoint discovery to keystoneauth https://review.openstack.org/564494 | 14:52 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Honor service-type aliases in config https://review.openstack.org/566929 | 14:52 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Pass default_microversion to adapter constructor https://review.openstack.org/557935 | 14:52 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Throw an error on missing support for default microversion https://review.openstack.org/557938 | 14:52 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename service_key to service_type https://review.openstack.org/558049 | 14:52 |
| * mordred patchbombs everyone | 14:52 | |
| openstackgerrit | Mohammed Naser proposed openstack/openstacksdk master: Avoid raising exception when comparing resource to None https://review.openstack.org/567230 | 14:55 |
| mnaser | frickler, mordred: update with isinstance usage | 14:55 |
| mordred | mnaser: +2 | 15:00 |
| mnaser | tyvm | 15:03 |
| *** edmondsw has quit IRC | 15:04 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add nodepool-functional-py35-src job https://review.openstack.org/567254 | 15:18 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add python 3.6 jobs https://review.openstack.org/567255 | 15:18 |
| *** thrash is now known as thrash|biab | 15:31 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320 | 15:42 |
| *** tosky has quit IRC | 15:48 | |
| *** tosky has joined #openstack-sdks | 15:48 | |
| *** thrash|biab is now known as thrash | 16:02 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320 | 16:09 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234 | 16:10 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add nodepool-functional-py35-src job https://review.openstack.org/567254 | 16:54 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add python 3.6 jobs https://review.openstack.org/567255 | 16:54 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235 | 16:54 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove D exclusions from flake8 config https://review.openstack.org/567236 | 16:54 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix H103 Apache license header check https://review.openstack.org/567237 | 16:54 |
| *** tosky has quit IRC | 16:57 | |
| *** tosky has joined #openstack-sdks | 16:59 | |
| openstackgerrit | Julie Pichon proposed openstack/python-openstackclient master: Prevent "server migrate --wait" from hanging https://review.openstack.org/567289 | 17:06 |
| *** gtema has quit IRC | 17:11 | |
| *** jpena is now known as jpena|off | 17:17 | |
| *** jpich has quit IRC | 17:17 | |
| Shrews | mordred: comment on https://review.openstack.org/567234 | 17:22 |
| mordred | Shrews: good call ... I'll do a followup cleanup patch there (we can honestly get rid of most of thatfile) | 17:24 |
| *** stevebaker has quit IRC | 17:28 | |
| *** dmellado has quit IRC | 17:29 | |
| *** gkadam_ has quit IRC | 17:43 | |
| *** gtema has joined #openstack-sdks | 18:36 | |
| *** d0ugal_ has joined #openstack-sdks | 18:37 | |
| *** d0ugal has quit IRC | 18:37 | |
| dtantsur | elmiko, cdent, edleafe, FYI tomorrow is a public holiday in Germany, so I'm unlikely to show up at the meeting | 18:37 |
| cdent | ✔ | 18:38 |
| edleafe | dtantsur: ack | 18:40 |
| *** dtantsur is now known as dtantsur|afk | 18:49 | |
| *** dmellado has joined #openstack-sdks | 18:58 | |
| *** stevebaker has joined #openstack-sdks | 19:02 | |
| openstackgerrit | Merged openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320 | 19:36 |
| *** cdent has quit IRC | 19:45 | |
| *** edmondsw has joined #openstack-sdks | 19:54 | |
| openstackgerrit | Merged openstack/openstacksdk master: Fix F405 errors https://review.openstack.org/567234 | 20:49 |
| *** gtema has quit IRC | 20:49 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add comment about W503 being skipped https://review.openstack.org/567235 | 21:05 |
| *** dmellado has quit IRC | 21:15 | |
| *** dave-mccowan has quit IRC | 21:17 | |
| *** stevebaker has quit IRC | 21:20 | |
| *** dave-mccowan has joined #openstack-sdks | 21:22 | |
| *** dmellado has joined #openstack-sdks | 21:23 | |
| *** dmellado has quit IRC | 21:27 | |
| *** stevebaker has joined #openstack-sdks | 21:45 | |
| *** stevebaker has quit IRC | 21:58 | |
| *** bobh has quit IRC | 22:07 | |
| *** slaweq has quit IRC | 22:10 | |
| *** slaweq has joined #openstack-sdks | 22:10 | |
| *** zigo has quit IRC | 22:11 | |
| *** zigo has joined #openstack-sdks | 22:11 | |
| openstackgerrit | Merged openstack/openstacksdk master: Change clustering example test create parameter https://review.openstack.org/566510 | 22:13 |
| openstackgerrit | Merged openstack/openstacksdk master: add missing attribute in LBaaS v2 Pool API https://review.openstack.org/566434 | 22:35 |
| *** edmondsw has quit IRC | 23:10 | |
| *** edmondsw has joined #openstack-sdks | 23:11 | |
| *** edmondsw has quit IRC | 23:15 | |
| *** tosky has quit IRC | 23:38 | |
| mnaser | mordred: if you're around, should i recheck or rebase my change about the none comparision? | 23:50 |
| mnaser | it looks like its failing with some unrelated pep8 stuff, is there a change i should go on top of? | 23:51 |
| *** gildub has joined #openstack-sdks | 23:52 | |
| openstackgerrit | Merged openstack/openstacksdk master: close files after open in unit/base https://review.openstack.org/566321 | 23:54 |
| *** stevebaker has joined #openstack-sdks | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!