Friday, 2018-04-20

*** edmondsw has joined #openstack-sdks00:27
*** edmondsw has quit IRC00:32
*** harlowja has quit IRC00:46
*** slaweq has joined #openstack-sdks00:56
*** slaweq has quit IRC01:01
*** dave-mccowan has quit IRC01:01
*** mhen has quit IRC01:10
*** mhen has joined #openstack-sdks01:15
*** dave-mccowan has joined #openstack-sdks01:26
*** olaph has quit IRC01:39
*** olaph has joined #openstack-sdks01:39
*** dave-mccowan has quit IRC01:47
openstackgerritDongcan Ye proposed openstack/python-openstackclient master: Fix functional job failed  https://review.openstack.org/56234501:49
*** olaph1 has joined #openstack-sdks01:50
*** olaph has quit IRC01:51
*** bobh has joined #openstack-sdks01:56
*** salv-orl_ has joined #openstack-sdks01:58
*** salv-orl_ has quit IRC02:00
*** salv-orlando has quit IRC02:01
*** edmondsw has joined #openstack-sdks02:15
*** edmondsw has quit IRC02:20
*** slaweq has joined #openstack-sdks02:57
*** slaweq has quit IRC03:02
*** bobh has quit IRC03:04
openstackgerritKiseok Kim proposed openstack/openstacksdk master: Fix typo in README.rst  https://review.openstack.org/56291603:06
adriantmordred, dtroyer_zz: Are we moving the openstackclient to only use the SDK? I heard murmurings about that, but was curious how far along it got.03:20
adriantI ask because I know the openstackclient uses some weird Swift layer that is unique to itself and part of me is very very tempted to replace that with the SDK because the openstackclient still lacks features that the swift-cli has.03:21
adriantand I really want to stop telling people they have to use the swift client...03:21
adriantlets be honest, I want to stop using the swift client :P03:21
*** bobh has joined #openstack-sdks03:22
*** bobh has quit IRC03:23
*** bobh has joined #openstack-sdks03:23
*** bobh has quit IRC03:28
*** annp has quit IRC03:54
*** annp has joined #openstack-sdks03:55
*** shu-mutow has joined #openstack-sdks04:14
*** slaweq has joined #openstack-sdks04:58
*** slaweq has quit IRC05:03
*** salv-orlando has joined #openstack-sdks05:11
*** e0ne has joined #openstack-sdks05:23
*** slaweq has joined #openstack-sdks06:00
*** slaweq has quit IRC06:04
*** e0ne has quit IRC06:18
openstackgerritLingxian Kong proposed openstack/openstackclient master: Add python-qinlingclient to zuul job  https://review.openstack.org/56294906:42
*** kimamisa has joined #openstack-sdks07:16
*** ralonsoh has joined #openstack-sdks07:19
*** slaweq has joined #openstack-sdks07:31
*** jpich has joined #openstack-sdks07:50
*** jpena|off is now known as jpena08:00
*** e0ne has joined #openstack-sdks08:19
*** gkadam has joined #openstack-sdks08:30
*** shu-mutow is now known as shu-mutow-AWAY08:46
*** dayou has quit IRC09:09
*** dayou has joined #openstack-sdks09:11
*** sdague has joined #openstack-sdks09:28
*** rcarrillocruz has joined #openstack-sdks09:40
*** salv-orlando has quit IRC09:43
*** salv-orlando has joined #openstack-sdks09:46
*** cdent has joined #openstack-sdks10:00
*** ralonsoh_ has joined #openstack-sdks10:01
openstackgerritTovin Seven proposed openstack/openstackclient master: Trivial: Update pypi url to new url  https://review.openstack.org/56303210:04
*** ralonsoh has quit IRC10:05
openstackgerritTovin Seven proposed openstack/osc-lib master: Trivial: Update pypi url to new url  https://review.openstack.org/56303310:05
openstackgerritSergey Skripnick proposed openstack/openstacksdk master: Heat files parameter  https://review.openstack.org/56303510:08
*** ralonsoh__ has joined #openstack-sdks10:10
*** ralonsoh_ has quit IRC10:14
openstackgerritTovin Seven proposed openstack/python-openstackclient master: Trivial: Update pypi url to new url  https://review.openstack.org/56306210:23
*** heatuser has joined #openstack-sdks10:25
*** markvoelker has quit IRC10:30
*** markvoelker has joined #openstack-sdks10:30
*** markvoelker has quit IRC10:35
*** olaph has joined #openstack-sdks10:52
*** olaph1 has quit IRC10:54
*** olaph1 has joined #openstack-sdks11:05
*** olaph has quit IRC11:07
*** alex_xu has quit IRC11:14
*** alex_xu has joined #openstack-sdks11:19
*** alex_xu has quit IRC11:23
*** alex_xu has joined #openstack-sdks11:29
cdentedleafe, elmiko, dtantsur|pto : I've asked for a single day at the PTG (again). Seemed to work well last time.11:39
*** mhen has left #openstack-sdks12:00
*** annp has quit IRC12:02
*** kimamisa has quit IRC12:02
*** markvoelker has joined #openstack-sdks12:02
*** thrash|g0ne is now known as thrash12:05
*** kimamisa has joined #openstack-sdks12:26
*** stephenfin is now known as finucannot12:28
*** cdent has quit IRC12:32
*** olaph has joined #openstack-sdks12:35
*** olaph1 has quit IRC12:36
*** heatuser has quit IRC12:38
*** olaph1 has joined #openstack-sdks12:49
*** olaph has quit IRC12:50
pooja_jadhavcdent: Hi12:53
*** edleafe is now known as figleaf12:56
*** olaph1 is now known as olaph12:57
*** kimamisa has quit IRC12:57
*** edmondsw has joined #openstack-sdks13:05
*** dave-mccowan has joined #openstack-sdks13:07
*** edmondsw has quit IRC13:10
*** cdent has joined #openstack-sdks13:15
*** kimamisa has joined #openstack-sdks13:28
openstackgerritMerged openstack/osc-lib master: Trivial: Update pypi url to new url  https://review.openstack.org/56303313:39
pooja_jadhavcdent : Hi13:40
cdenthi pooja_jadhav13:40
pooja_jadhavcdent: Want to dicuss about split logger13:41
openstackgerritMerged openstack/openstackclient master: Trivial: Update pypi url to new url  https://review.openstack.org/56303213:41
*** olaph1 has joined #openstack-sdks13:42
*** olaph has quit IRC13:43
pooja_jadhavcdent: Actually, for testing purpose of split logger, I want to test nova cinder interaction. So put _SESSION._split_loggers = True after line https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L8613:43
cdentpooja_jadhav: sorry, I'm not sure I know what you're talking about. I don't have a memory of talking about split logger.13:43
openstackgerritMerged openstack/python-openstackclient master: Trivial: Update pypi url to new url  https://review.openstack.org/56306213:43
pooja_jadhavcdent: https://review.openstack.org/#/c/50576413:45
pooja_jadhavcdent: want to dicuss about this above patch Monty has proposed and merged into master branch13:46
cdentpooja_jadhav: oh that, yeah, I don't really know much about that. mordred might but he's at a conference right now13:46
pooja_jadhavcdent: Ohk... I have ping him several times, but haven't got rly :(13:47
pooja_jadhavcdent: Who else can help me in this13:48
pooja_jadhav??13:48
cdentI can talking with you about it, but it will mostly be you explaining what you're trying to do to me, and maybe as part of that things will be more clear13:49
pooja_jadhavcdent: Actually, I am facing issue while using split logger parameter in nova-cinder interaction.13:49
pooja_jadhavcdent: i will tell you what i am trying to do.13:50
pooja_jadhavcdent: after line https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L86.. i am setting  _SESSION._split_loggers = True just for time being testing.13:50
pooja_jadhavso when request goes from nova to cinder ( i should request into see split logging) as passed split_logger = True13:51
pooja_jadhavcdent: But the code in keystoneauth at line https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L613-L617  is making split_logger = False  if logger is already passed. and because of this request-ids are not getting logged13:53
cdentI think instead of doing _SESSION._split_loggers = True after that call you instead need to pass split_loggers=True in the call to load_session_from_conf_options13:53
cdentdoes that make any difference13:53
pooja_jadhavbut this load_session_from_conf_options method dont have this parameter13:54
pooja_jadhavhow can I pass that split_logger to load_session_from_conf_options13:55
cdentpooja_jadhav: from what I can tell load_session_from_conf_options takes kwargs:13:56
cdenthttps://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/session.py#L24613:57
pooja_jadhavok13:57
*** dims has quit IRC13:58
pooja_jadhavbut the issue is, logger is getting passed from some where14:00
pooja_jadhavand that if condition in keystoneauth at line https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L613-L617 making split_logger to False14:00
*** mnaser has quit IRC14:00
*** mnaser has joined #openstack-sdks14:01
pooja_jadhavso it only logs (request, response and response body) except request-id14:02
*** dims has joined #openstack-sdks14:04
openstackgerritMário Santos proposed openstack-infra/shade master: Adds kwargs support when creating a Neutron subnet  https://review.openstack.org/56313414:05
cdentsorry pooja_jadhav got distracted for a moment, re-reading14:09
pooja_jadhavno issue14:09
cdentBased on what you are saying I think you've found a bug.14:10
cdentif you can't find mordred, you might try speaking with cmurphy or lbragstad ?14:12
cdentIf you're able to come up with a minimal test case that demostrates the problem, that would probably be useful too14:12
cmurphykmalloc might also be able to help with that14:14
cmurphyI can try but would have to refresh my memory a bit14:14
pooja_jadhavok14:16
pooja_jadhavin keystonenauth, in def request()- if logger is passed then split_logger sets to False, and because of this request-ids are not getting logged14:17
pooja_jadhavIn my opion also, it a bug14:17
pooja_jadhavMy aim is to use split_logger functionality wherever keystoneauth session is getting used.14:18
pooja_jadhavI already had discussion with kmalloc14:19
cmurphypooja_jadhav: I think if a logger is passed then that indicates you only want to use one logger, ie the one that you passed, and so splitting loggers wouldn't make sense14:20
pooja_jadhavcmurphy: ohk, But I am able to see (3 parts of request in splits like(keystoneauth.session.request, keystoneauth.session.response, keystoneauth.session.body)14:22
pooja_jadhavcmurphy: Only the part I am not able to see is keystoneauth.session.request-id14:23
cmurphypooja_jadhav: so you think something around here is going wrong? https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L772-L77514:26
pooja_jadhavcmurphy: yes14:26
pooja_jadhavcmurphy: Split_logger is getting as False and because of that request-is is not get logged.14:27
dtroyer_zzadriant: it has been the plan for OSC to use the SDK once it has a 1.0 release since the SDK was started.  We relented on the 1.0 for Network in order to not add the neutronclient dependency and other reasons, and it has been painful as the SDK has made at least two changes we have been required to work around and handle multiple SDK versions for.14:28
cmurphypooja_jadhav: you said you're passing in a logger and that's why it's getting set to false, can you not pass in a logger?14:29
dtroyer_zzThe api.object layer in OSC was largely lifted from swiftclient since swiftclient was still only available in the swift repo at the time.  I put it into the form I was proposing for a low-level SDK that was subsequently not merged.  and it has sat there ever since waiting for the SDK 1.0 as explained above14:30
dtroyer_zzso yes, once we have an SDK 1.0 folks can go nuts converting commands to use it, with adequate compatibility testing in place14:31
pooja_jadhavpooja_jadhav: in cinder client they are getting logger, I have comment out that code, i am able to see request-ids but, it will solve only for cinder client.14:32
pooja_jadhavcmurphy: in cinder client they are getting logger, I have comment out that code, i am able to see request-ids but, it will solve only for cinder client.14:32
pooja_jadhavcmurphy: at line https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L115-L11614:33
pooja_jadhavcmuphy: IMO, we should fix at central place so that, i will solve for all other services issue14:34
pooja_jadhav cmuphy: But still Not clear how to fix at keystoneauth.14:34
cmurphypooja_jadhav: I don't really agree, I think any client that want to opt into using the split loggers should be explicit about it by setting split_loggers to true and stopping passing in its own logger14:35
pooja_jadhavcmurphy: Ohk, I will try to fix that in cinder client then,14:37
cmurphyok :)14:37
pooja_jadhavcmurphy, cdent : Thanks for your inputs :)14:37
*** samueldmq has quit IRC14:40
*** samueldmq has joined #openstack-sdks14:41
*** cdent has quit IRC14:52
*** edmondsw has joined #openstack-sdks14:54
*** edmondsw has quit IRC14:58
*** olaph has joined #openstack-sdks14:59
*** olaph1 has quit IRC15:01
*** dave-mccowan has quit IRC15:24
openstackgerritMário Santos proposed openstack-infra/shade master: Adds kwargs support when creating a Neutron subnet  https://review.openstack.org/56313415:28
*** e0ne has quit IRC15:36
*** cdent has joined #openstack-sdks15:41
*** dims has quit IRC16:06
*** dims has joined #openstack-sdks16:11
openstackgerritStephen Finucane proposed openstack/os-api-ref master: Raise warning if top-level value is not a dict  https://review.openstack.org/56317816:21
openstackgerritStephen Finucane proposed openstack/os-api-ref master: Use 'sphinx.util.logging'  https://review.openstack.org/56317916:21
*** olaph has quit IRC16:28
*** olaph has joined #openstack-sdks16:30
melwittdtroyer_zz: hi, we're trying to resolve a problem where we couldn't update the constraint for python-novaclient to 10.1.0 because of removed functionality that OSC couldn't leverage in queens. because of this, users that install queens are unable to use the volume multi-attach feature with the older novaclient (old review https://review.openstack.org/#/c/538070),16:33
melwittwe've proposed a backport of the adjustments from rocky to queens in an effort to be able to update the queens constraint to 10.1.0 https://review.openstack.org/#/c/56284016:34
melwittyour review would be appreciated16:34
*** jpich has quit IRC16:35
*** gkadam has quit IRC16:42
*** edmondsw has joined #openstack-sdks16:42
*** kimamisa has quit IRC16:44
*** edmondsw has quit IRC16:47
*** ralonsoh__ has quit IRC17:07
*** cdent has quit IRC17:09
*** jpena is now known as jpena|off17:09
*** e0ne has joined #openstack-sdks17:31
*** dave-mccowan has joined #openstack-sdks18:06
*** thrash is now known as thrash|biab18:42
openstackgerritmelissaml proposed openstack/keystoneauth master: Trivial: Update pypi url to new url  https://review.openstack.org/56322718:50
*** harlowja has joined #openstack-sdks19:02
*** olaph1 has joined #openstack-sdks19:07
*** olaph has quit IRC19:08
*** olaph has joined #openstack-sdks19:31
*** olaph1 has quit IRC19:32
*** thrash|biab is now known as thrash19:49
*** edmondsw has joined #openstack-sdks20:19
*** kimamisa has joined #openstack-sdks20:22
*** edmondsw has quit IRC20:23
dtroyer_zzmelwitt: +2  I'd like amotoki to stamp it too since this is adding functionality to a stable release.  We can't properly version this when we release it…20:26
melwittunderstood. thanks dtroyer_zz20:30
openstackgerritmelissaml proposed openstack/openstacksdk master: Trivial: Update pypi url to new url  https://review.openstack.org/56328720:31
*** dave-mccowan has quit IRC20:32
*** slaweq has quit IRC21:00
*** slaweq has joined #openstack-sdks21:01
*** slaweq has quit IRC21:06
*** olaph1 has joined #openstack-sdks21:08
*** olaph has quit IRC21:08
*** thrash is now known as thrash|g0ne21:10
*** lbragstad has quit IRC21:17
*** lbragstad has joined #openstack-sdks21:19
*** e0ne has quit IRC21:25
*** e0ne has joined #openstack-sdks21:35
*** figleaf is now known as edleafe21:44
*** e0ne has quit IRC22:05
*** edmondsw has joined #openstack-sdks22:07
*** sdague has quit IRC22:11
*** edmondsw has quit IRC22:11
kmallocOk22:16
*** salv-orl_ has joined #openstack-sdks23:45
*** salv-orlando has quit IRC23:48
*** edmondsw has joined #openstack-sdks23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!