| EmilienM | hi, any chance to have a review on https://review.openstack.org/#/c/553374/ please | 00:21 |
|---|---|---|
| *** lifeless_ has joined #openstack-sdks | 00:46 | |
| *** lifeless has quit IRC | 00:46 | |
| *** chenyb4 has joined #openstack-sdks | 01:02 | |
| *** Kevin_Zheng has joined #openstack-sdks | 01:14 | |
| *** dayou has quit IRC | 01:56 | |
| *** annp has joined #openstack-sdks | 01:56 | |
| *** gildub has joined #openstack-sdks | 02:17 | |
| *** dave-mccowan has quit IRC | 02:31 | |
| *** gildub has quit IRC | 02:31 | |
| *** gildub has joined #openstack-sdks | 02:32 | |
| *** yolanda has quit IRC | 02:44 | |
| *** yolanda has joined #openstack-sdks | 02:45 | |
| *** ldl has joined #openstack-sdks | 02:46 | |
| *** ldl has quit IRC | 02:46 | |
| *** ldl has joined #openstack-sdks | 02:46 | |
| openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | 02:50 |
| *** salv-orl_ has joined #openstack-sdks | 02:50 | |
| *** salv-orlando has quit IRC | 02:52 | |
| *** yolanda has quit IRC | 02:53 | |
| *** yolanda has joined #openstack-sdks | 02:54 | |
| *** e0ne has joined #openstack-sdks | 06:21 | |
| *** gildub has quit IRC | 06:26 | |
| *** dayou has joined #openstack-sdks | 06:48 | |
| openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | 07:09 |
| *** d0ugal has joined #openstack-sdks | 07:12 | |
| *** d0ugal has quit IRC | 07:12 | |
| *** d0ugal has joined #openstack-sdks | 07:12 | |
| *** gildub has joined #openstack-sdks | 07:17 | |
| *** d0ugal has quit IRC | 07:21 | |
| openstackgerrit | Peter Balogh proposed openstack/python-openstacksdk master: Fix TypeError in case of FloatingIP add and remove https://review.openstack.org/552112 | 07:25 |
| openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | 07:26 |
| *** tovin07 has joined #openstack-sdks | 07:31 | |
| *** salv-orl_ has quit IRC | 07:32 | |
| *** salv-orlando has joined #openstack-sdks | 07:33 | |
| *** salv-orlando has quit IRC | 07:33 | |
| *** salv-orlando has joined #openstack-sdks | 07:33 | |
| *** d0ugal has joined #openstack-sdks | 07:49 | |
| *** kmy has joined #openstack-sdks | 08:04 | |
| *** jpena|off is now known as jpena | 08:11 | |
| *** gildub has quit IRC | 08:21 | |
| *** gildub has joined #openstack-sdks | 08:21 | |
| *** gkadam has joined #openstack-sdks | 08:22 | |
| *** Kevin_Zheng has quit IRC | 08:30 | |
| *** Kevin_Zheng has joined #openstack-sdks | 08:31 | |
| *** e0ne has quit IRC | 08:33 | |
| *** cdent has joined #openstack-sdks | 08:50 | |
| *** d0ugal has quit IRC | 09:02 | |
| *** jpich has joined #openstack-sdks | 09:07 | |
| *** baffle has quit IRC | 09:13 | |
| *** baffle has joined #openstack-sdks | 09:14 | |
| *** ralonsoh has joined #openstack-sdks | 09:35 | |
| *** gildub has quit IRC | 09:38 | |
| *** kmy has quit IRC | 09:45 | |
| *** kmy has joined #openstack-sdks | 09:47 | |
| *** e0ne has joined #openstack-sdks | 09:55 | |
| *** gildub has joined #openstack-sdks | 10:05 | |
| openstackgerrit | chenyb4 proposed openstack/python-openstacksdk master: Use defined version instead of service.version parameter https://review.openstack.org/554223 | 10:28 |
| *** gildub has quit IRC | 10:28 | |
| *** gildub has joined #openstack-sdks | 10:30 | |
| *** ralonsoh_ has joined #openstack-sdks | 10:33 | |
| *** ralonsoh has quit IRC | 10:37 | |
| *** jpena is now known as jpena|brb | 10:38 | |
| *** kmy has quit IRC | 10:50 | |
| *** kmy has joined #openstack-sdks | 10:51 | |
| *** ralonsoh__ has joined #openstack-sdks | 11:03 | |
| *** ralonsoh_ has quit IRC | 11:07 | |
| *** annp has quit IRC | 11:15 | |
| *** dayou has quit IRC | 11:25 | |
| *** jpena|brb is now known as jpena | 11:37 | |
| *** dayou has joined #openstack-sdks | 11:47 | |
| *** chenyb4 has quit IRC | 12:00 | |
| *** edmondsw has joined #openstack-sdks | 12:17 | |
| *** openstackgerrit has quit IRC | 12:33 | |
| mugsie | elmiko: if you have any questions, please give me a ping :) | 12:36 |
| elmiko | mugsie: ack, will do! | 12:38 |
| *** d0ugal has joined #openstack-sdks | 12:41 | |
| *** d0ugal has quit IRC | 12:41 | |
| *** d0ugal has joined #openstack-sdks | 12:41 | |
| *** jpena is now known as jpena|lunch | 12:44 | |
| cdent | elmiko, edleafe, anything blocking merging those microversion-parse changes? You guys +1d, but you should have the power to +2 if you want. I'd like to release a new version, even if its not yet perfect (as long as it doesn't break stuf, that's good enough) | 12:45 |
| elmiko | cdent: nothing blocking from me | 12:49 |
| elmiko | gimme like an hour and i can start adding the +2s | 12:49 |
| elmiko | unless edleafe gets to it first ;) | 12:50 |
| cdent | cool, thanks, no huge rush, just got reminded of it by my to do list | 12:50 |
| *** gildub has quit IRC | 12:54 | |
| elmiko | ack | 12:59 |
| *** ldl has quit IRC | 13:03 | |
| edleafe | cdent: elmiko: I had one little comment, but added a +2. elmiko, if you agree, wanna push it through? | 13:08 |
| elmiko | edleafe: sounds good! | 13:09 |
| *** chenyb4 has joined #openstack-sdks | 13:37 | |
| *** jpena|lunch is now known as jpena | 13:42 | |
| *** SamYaple has quit IRC | 13:52 | |
| elmiko | cdent: i +w to the 2 that had other support | 13:53 |
| elmiko | i'd prefer more than just my lone review on these: | 13:53 |
| elmiko | https://review.openstack.org/#/c/550251/3 | 13:53 |
| elmiko | https://review.openstack.org/#/c/550263/3 | 13:53 |
| elmiko | https://review.openstack.org/#/c/550264/3 | 13:54 |
| *** openstackgerrit has joined #openstack-sdks | 13:54 | |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | 13:54 |
| cdent | elmiko: yeah. edleafe I added another patch to the end fixing the bug. | 13:55 |
| *** dmellado has quit IRC | 13:55 | |
| elmiko | cool | 13:55 |
| elmiko | is that the one you just posted? | 13:55 |
| cdent | yeah | 13:55 |
| elmiko | looked sensible | 13:55 |
| edleafe | cdent: cool. I would have just fixed it in place, but... meh | 13:59 |
| openstackgerrit | Merged openstack/microversion-parse master: Provide a helper method to get headers from environ https://review.openstack.org/495356 | 13:59 |
| cdent | edleafe: for a change that didn't check that method at all? dirty! | 13:59 |
| openstackgerrit | Merged openstack/microversion-parse master: Import functions from placement https://review.openstack.org/496212 | 14:00 |
| edleafe | Guess I'm a dirty guy | 14:01 |
| cdent | Newflash: edleafe states well known fact, wins t-shirt | 14:02 |
| edleafe | \o/ | 14:02 |
| edleafe | My wardrobe needs sprucing up | 14:02 |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/keystoneauth master: Be more verbose when version discovery fails https://review.openstack.org/554044 | 14:04 |
| *** stevebaker has quit IRC | 14:04 | |
| frickler | kmalloc: ^^ just for you ;) | 14:05 |
| *** finucannot is now known as stephenfin | 14:07 | |
| *** bobh has joined #openstack-sdks | 14:07 | |
| elmiko | cdent: LOL | 14:10 |
| *** SamYaple has joined #openstack-sdks | 14:11 | |
| *** chenyb4 has quit IRC | 14:14 | |
| *** chenyb4 has joined #openstack-sdks | 14:17 | |
| cdent | edleafe: use your dirty old guy wisdom to fix that attribute problem on Version, I responded | 14:20 |
| elmiko | that sounds like the best super power ever | 14:28 |
| openstackgerrit | Merged openstack/os-client-config master: Add image_format for VEXXHOST profile https://review.openstack.org/554351 | 14:36 |
| *** d0ugal has quit IRC | 14:38 | |
| *** stevebaker has joined #openstack-sdks | 14:42 | |
| mnaser | mordred: did you ever get around this? https://specs.openstack.org/openstack/openstack-specs/specs/clouds-yaml-support.html | 14:47 |
| mnaser | i have a user who likes using python-openstackclient because clouds.yaml, but image member list is missing from it right now, so they have to use glanceclient | 14:47 |
| *** chenyb4 has quit IRC | 14:48 | |
| mordred | mnaser: we should just fix python-openstackclient - I've given up on that spec in favor of thinking we should delete python-*client | 14:48 |
| mnaser | mordred: ok cool, i'll try to push a patch to add that support i guess | 14:49 |
| mnaser | mordred: accepting and rejecting memberships is there, just listing is missing | 14:49 |
| edleafe | cdent: who said I'm old?? | 14:49 |
| mordred | edleafe: who didn't? | 14:49 |
| *** chenyb4 has joined #openstack-sdks | 14:50 | |
| * edleafe shakes his cane at mordred | 14:50 | |
| edleafe | cdent: answered | 14:50 |
| * mordred falls over in alarm and probably breaks his hip | 14:50 | |
| *** dmellado has joined #openstack-sdks | 14:54 | |
| kmalloc | frickler: fantastic! | 14:56 |
| kmalloc | frickler: thanks for the test! | 14:56 |
| *** dmellado has quit IRC | 14:56 | |
| kmalloc | mordred: can we please delete python-*-client? | 14:57 |
| kmalloc | mordred: please? :) | 14:57 |
| mordred | kmalloc: ++ | 14:57 |
| *** dtantsur|afk is now known as dtantsur | 15:00 | |
| *** dmellado has joined #openstack-sdks | 15:01 | |
| dtantsur | elmiko: office hours is not a bad idea, but I also think that we should encourage people to talk async and on public ML | 15:02 |
| dtantsur | e.g. I won't be able to attend apac-friendly times, I suspect | 15:02 |
| dtantsur | or rather: either me or the US | 15:02 |
| edleafe | dtantsur: early APAC is late for me | 15:03 |
| *** dmellado has quit IRC | 15:04 | |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251 | 15:04 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252 | 15:04 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263 | 15:04 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264 | 15:04 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | 15:04 |
| cdent | there ya go edleafe, I think. and thanks. | 15:04 |
| *** dmellado has joined #openstack-sdks | 15:05 | |
| *** stevebaker has quit IRC | 15:06 | |
| mnaser | i'm working on adding support for glance image list | 15:07 |
| mnaser | i'm getting this when trying to run commands in tox venv (tox -evenv -- openstack image list) | 15:07 |
| mnaser | 'module' object has no attribute 'OpenStackConfigException' | 15:07 |
| mnaser | any ideas? | 15:07 |
| mnaser | http://paste.openstack.org/show/706188/ | 15:08 |
| mnaser | unless im doing something wrong, i dont think anything should be causing an excpetion like that | 15:08 |
| *** stevebaker has joined #openstack-sdks | 15:10 | |
| *** d0ugal has joined #openstack-sdks | 15:10 | |
| mnaser | ok looks like it tries to get occ_exceptions from openstack.config and fallback to os_client_config if it cant find it | 15:10 |
| mnaser | os_client_config has OpenStackConfigException but i have no idea what 'openstack.config' comes from | 15:10 |
| mnaser | dtroyer: | 15:11 |
| mnaser | https://github.com/openstack/osc-lib/commit/86129e6f88289ef14bfaa3f7c9cdfbea8d9fc944 looks like this might be related? | 15:11 |
| mnaser | or actually, mordred: https://github.com/openstack/python-openstacksdk/commit/80716c144203a37edc7ddd324e0bc6be6cfda1e5 the renaming of OpenStackConfigException => ConfigException here broke things | 15:12 |
| dtroyer | mnaser: what SDk version do you have? | 15:12 |
| mnaser | dtroyer: working on master using tox, so i assume whatever the latest thing it'll pull | 15:13 |
| mnaser | dtroyer: requirements.txt looks like it points to openstacksdk>=0.11.2 -- let me see what wasa pulled i | 15:14 |
| dtroyer | I think there is a 0.12.0 now | 15:14 |
| dtroyer | this spanning multiple versions during the changeover is getting long and painful | 15:15 |
| *** dmellado has quit IRC | 15:16 | |
| *** stevebaker has quit IRC | 15:17 | |
| mnaser | dtroyer: sorry, got a call, openstacksdk==0.12.0 indeed | 15:20 |
| mnaser | i think the best 'compatible' way to take care of this would be to subclass ConfigException in openstacksdk as a 'compatibility' shim in the meantime | 15:20 |
| mnaser | i can push up a patch if that's the best way of taking care of it for now | 15:21 |
| cdent | edleafe: since you're my python wisdom source today, how do you feel about iterating over a set and popping members out of it? | 15:23 |
| dtroyer | mnaser: in theory this should have been caught by the -tips jobs, did it get missed because OSc functional tests don't touch that command? | 15:23 |
| elmiko | dtantsur: ack, and yeah, it will be a team effort to provide what the community might want. in general i agree with the notion of promoting async comms | 15:24 |
| mnaser | dtroyer: well, im just writing this command now (list image members) | 15:24 |
| mnaser | but i think this is probably broken with any command over all | 15:24 |
| dtroyer | ok, I'm finally catching up on the exact problem | 15:26 |
| EmilienM | hello, can someone review https://review.openstack.org/#/c/553374/ please? | 15:27 |
| dtroyer | that's a gap in the functional tests, ie no negative tests there | 15:27 |
| EmilienM | I'm ok to send free mapple sirup | 15:28 |
| *** dave-mccowan has joined #openstack-sdks | 15:29 | |
| dtroyer | mnaser: I'd probably lean toward restoring the compatibility in the SDK for that exception, we're going to have to go through a lot of code to change all those over someday anyway but really can't do that yet | 15:29 |
| dtroyer | and yes, that potentially affects any command that needs auth | 15:30 |
| *** chenyb4 has quit IRC | 15:30 | |
| openstackgerrit | Mohammed Naser proposed openstack/python-openstackclient master: Add support to list image members https://review.openstack.org/554590 | 15:32 |
| mnaser | ^ my first osc change so it probably is mising a whole lot of stuff (and couldn't find a sample to iterate on) | 15:32 |
| mnaser | dtroyer: so what would be the best direction (aka, can i help with that?) | 15:33 |
| dtroyer | mnaser: my gut says to put in a compat exception back into the SDK since that is what changed. It appears, though, that osc-lib _may_ be the only casualty, but it'll be messier to fix there until we rip out the os-client-config imports | 15:35 |
| *** thrash is now known as thrash|bbl | 15:35 | |
| dtroyer | which is not going to happen until we get an SDK 1.0 release | 15:35 |
| mnaser | dtroyer: and the concern is how do you make sure that gets removed eventually and doesn't sit ther forever, but i cant imagine that being very harmful | 15:35 |
| *** stevebaker has joined #openstack-sdks | 15:36 | |
| mnaser | unless, well, people start relying on it. | 15:36 |
| mordred | mnaser: sorry - on phone, will help in just a few | 15:36 |
| mnaser | which they probably will if thats what is bubbling up the excpetion in osc_lib | 15:36 |
| mnaser | np :) | 15:36 |
| dtroyer | I would expect it to get caught when cleaning up the o-c-c stuff | 15:36 |
| mordred | in the shade layer we made the old exception classes aliases for the new ones - we should defintely do that here | 15:37 |
| dtroyer | I'm planning to rip out much of that module for OSC 4 anyway so we'll default to doing basically the same thing that all other SDK consumers do WRT auth and special cases | 15:37 |
| mordred | mnaser: if we just put a OpenStackConfigException = ConfigException in openstack/config/exceptions.py it should be happier | 15:38 |
| edleafe | cdent: it *can* be ok to do that; depends on what you're doing with the members of the set | 15:38 |
| edleafe | cdent: generally I use a 'to_remove' var to hold the ones to remove, and then remove 'em after the iteration | 15:39 |
| mnaser | mordred: ok cool, i'd nominate myself to push up a patch for that but i think it would be useful to have the context of that in a note/commit message which i'm probably not the best at writing given i dont know the whole relationship between all these clients :) | 15:39 |
| cdent | edleafe: I'll put it up for people to think about. I'm pretty sure it works for the case I've got, but we'll see | 15:39 |
| cdent | edleafe: it's basically this: http://paste.openstack.org/show/706227/ | 15:40 |
| cdent | (untested) | 15:42 |
| edleafe | cdent: did you run that? | 15:44 |
| cdent | untested | 15:44 |
| cdent | I'm getting ready to test it | 15:44 |
| cdent | but I hadn't gotten that far because I realized it may very well be to dirty, so I thought I'd ask the dirty guy before I kept moving | 15:44 |
| dtroyer | mnaser: regarding the new command, stevemar points out a prior attempt and the objection then that "image member" is not currently a resource in OSC. I don't like that name, the only place OSC uses "member" at all is in the image set command options —accept, —reject and —pending, there phrased as "project membership status". So we treat this as an image property already, not as a top-level resource | 15:45 |
| edleafe | cdent: Generally you can't change the size of a set during an iteration over it | 15:46 |
| dtroyer | Adding a —member (or —membership or —project) option to image show seems more natural, except that the nested structure of a list of data inside a field is always messy | 15:46 |
| *** stevebaker has quit IRC | 15:46 | |
| cdent | edleafe: ooops, I misread the docs for set.pop() for one thing | 15:47 |
| edleafe | cdent: Since they're sets, I'd just grab the set of forbidden, and then do difference_update() to remove the forbidden traits | 15:48 |
| cdent | yeah, I'll do that | 15:48 |
| mnaser | dtroyer: i see.. so what is it that you'd recommend, i think ideally image member should be a resource and things like 'image member add' and 'image member remove' should be how things are | 15:48 |
| mnaser | (or they should have been from the start, at least imho) | 15:48 |
| mnaser | as members are image resources, i guess we can compare them to metadata | 15:49 |
| cdent | edleafe: my confusion originated from conflating behaviors in a while loop with a for loop. but yeah, will do something that's less clever and actually works | 15:49 |
| dtroyer | mnaser: we have image add/remove project already for that | 15:50 |
| dtroyer | again, we didn't use the 'member' word | 15:50 |
| mnaser | yeah but then image list project is weird | 15:50 |
| mnaser | or doesnt even technically work | 15:50 |
| dtroyer | there is a parallel to this with security groups and security group rules | 15:50 |
| mnaser | so what was the solution from that parallel | 15:51 |
| dtroyer | security group rules _are_ a top-level resource and treated as that everywhere. | 15:51 |
| dtroyer | they have their own properties/attributes and require the full set of create/delete/list/show commands | 15:52 |
| dtroyer | the member list isn't the same thing | 15:52 |
| dtroyer | so that's not the best example of a one-to-many relationship after all :( | 15:52 |
| *** stevebaker has joined #openstack-sdks | 15:53 | |
| dtroyer | the project list attached to an image is just another property that can have multiple values | 15:54 |
| mnaser | dtroyer: well, its an http resource so its not like it comes along a 'image show' http request | 15:55 |
| dtroyer | right, but frankly I don't care what the REST API looks like, it is about the model presented to the user. which is one reason not automatically pulling the data is a consideration, via adding an option to image show | 15:56 |
| *** salv-orlando has quit IRC | 15:56 | |
| mnaser | i mean if it was a flat list (ex: projects only), it wouldn't be that bad to add it to the show | 15:57 |
| *** salv-orlando has joined #openstack-sdks | 15:57 | |
| mnaser | the issue is that it presents other things like .. member id and status (ex: accepted, pending, etc) | 15:57 |
| *** salv-orlando has quit IRC | 15:57 | |
| *** salv-orlando has joined #openstack-sdks | 15:57 | |
| mnaser | i dont mind pushing it up to show but the thing that would make me sad is that the user will have a very hard time parsing it using the tools available in osc | 15:57 |
| mnaser | ex cant use --columns and so on | 15:58 |
| dtroyer | right, that's a general problem with a number of our data structures, and is one reason we played with adding a jq interface to make dealing with nested data via JSON easier. turns out to still be rather messy to do in a CLI | 16:00 |
| openstackgerrit | Jens Harbott (frickler) proposed openstack/keystoneauth master: Be more verbose when version discovery fails https://review.openstack.org/554044 | 16:01 |
| *** jamielennox has quit IRC | 16:01 | |
| *** stevebaker has quit IRC | 16:02 | |
| dtroyer | mnaser: so since image memebr has an ID, that improves the case for it being a top-level resource. however, I'm not aware of any place to actually use that ID. It is the status that makes this messy. | 16:02 |
| *** stevebaker has joined #openstack-sdks | 16:05 | |
| dtroyer | I still don't like "image member" but it is better than "image project". unless we come up with something obviously better, lets add "image member" as a top-level resource, which means adding it to the resource list in doc/source/cli/commands.rst. It should be in its own module but I don't plan on adding other commands so leaving it in image.py is probably fine. | 16:06 |
| dtroyer | I don't know what the API looks like offhand, but adding a —project option to image member list might be nice at some point to only list images that a particular project has access to. future. | 16:07 |
| dtroyer | and now lunch. I'll summarize this in the review after lunch. thanks for the command and for letting me think through this out loud to refresh my mind. | 16:08 |
| dtroyer | EmilienM: I'll get to your review after lunch too | 16:09 |
| mordred | dtroyer, mnaser: ok - back ... | 16:10 |
| EmilienM | dtroyer: thanks! | 16:10 |
| *** stevebaker has quit IRC | 16:12 | |
| *** stevebaker has joined #openstack-sdks | 16:14 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Provide OpenStackConfigException backwards compat https://review.openstack.org/554615 | 16:15 |
| mordred | mnaser, dtroyer: ^^ that should unstick mnaser's issue ... although now that we can make osc-lib depend on openstacksdk>=0.12 - we could make a pass through and update it to remove the occ paths... I'll do that as a followup | 16:16 |
| mordred | perhaps land that patch, cut an sdk point release, bump the min in global-requirements, then push up osc-lib patches to remove occ fallback paths? | 16:17 |
| mordred | dtroyer: that sound like an ok plan? | 16:17 |
| *** stevebaker has quit IRC | 16:22 | |
| *** stevebaker has joined #openstack-sdks | 16:24 | |
| *** salv-orlando has quit IRC | 16:28 | |
| *** salv-orlando has joined #openstack-sdks | 16:28 | |
| *** salv-orlando has quit IRC | 16:33 | |
| *** stevebaker has quit IRC | 16:35 | |
| mordred | frickler: left a comment on your ksa patch | 16:37 |
| *** jamielennox has joined #openstack-sdks | 16:38 | |
| *** stevebaker has joined #openstack-sdks | 16:39 | |
| frickler | mordred: I tend to agree with your comment, would you want to reword the original message down on L199 accordingly? would seem sensible to keep those in sync | 16:40 |
| *** gkadam has quit IRC | 16:47 | |
| mordred | frickler: I'd love to - it's my least favorite error message ... however, ... | 16:49 |
| mordred | kmalloc: ^^ do we consider error message text part of keystoneauth's api? | 16:49 |
| kmalloc | hm | 16:49 |
| kmalloc | mordred: i hope we don't. but honestly, haven't thought about that | 16:49 |
| kmalloc | mordred: maybe we should? | 16:49 |
| mordred | kmalloc: me either | 16:49 |
| kmalloc | i'm willing to make a call on that right here conferring with you ... and.... | 16:50 |
| kmalloc | i'm inclined to say no | 16:50 |
| kmalloc | but the exception class would be. | 16:50 |
| mordred | kmalloc: specifically, "Could not determine a suitable URL or the plugin" - which almost never actually means what it says | 16:50 |
| kmalloc | yeah | 16:50 |
| mordred | kmalloc: yah - exception class == part of aPI for sure | 16:50 |
| kmalloc | so, i think the message shouldn't be because it might change to be "better" in the future | 16:51 |
| kmalloc | unless it's structured data. | 16:51 |
| kmalloc | whichcase it would be part of the api | 16:51 |
| kmalloc | if it's just a "message", it's not part of the api (in my mind, but i could be convinced otherwise) | 16:51 |
| mordred | kmalloc: yah - but in that case I'd expect us to put that data on the execeptoin instance | 16:51 |
| kmalloc | right | 16:51 |
| kmalloc | so, you're good with saying it's not part of the API? | 16:52 |
| mordred | kmalloc: so maybe let's say "no" - and if people are finding places in which they need to look at exception text, then we nee more specific exception classes | 16:52 |
| kmalloc | wfm | 16:52 |
| kmalloc | ^5 | 16:52 |
| mordred | frickler: ^^ | 16:52 |
| kmalloc | exception text is useful for humans | 16:52 |
| kmalloc | not for programatic use. | 16:52 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Fix 'block_store' aliases define error https://review.openstack.org/554403 | 16:52 |
| mordred | frickler: also - fwiw, maybe toss in an 'if isinstance(e, exceptions.DiscoveryFailure): raise else: raise exceptions.DiscoveryFailure(...) so that we don't lose the original discovery context just because we made an attempt to guess a versioned endpoint | 16:53 |
| *** stevebaker has quit IRC | 17:00 | |
| *** stevebaker has joined #openstack-sdks | 17:09 | |
| *** bobh has quit IRC | 17:13 | |
| *** stevebaker has quit IRC | 17:19 | |
| *** stevebaker has joined #openstack-sdks | 17:28 | |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Improve Version.matches() method https://review.openstack.org/550251 | 17:28 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Add MicroversionMiddleware https://review.openstack.org/550252 | 17:28 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Allow passing a json_error_formatter to the middleware https://review.openstack.org/550263 | 17:28 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Clean up package version and python version support https://review.openstack.org/550264 | 17:28 |
| openstackgerrit | Chris Dent proposed openstack/microversion-parse master: Do not use redundant attr check for keys in fold_headers https://review.openstack.org/554547 | 17:28 |
| *** salv-orlando has joined #openstack-sdks | 17:29 | |
| *** salv-orlando has quit IRC | 17:34 | |
| *** ralonsoh__ has quit IRC | 17:35 | |
| *** e0ne has quit IRC | 17:35 | |
| *** stevebaker has quit IRC | 17:44 | |
| *** jpich has quit IRC | 17:50 | |
| *** stevebaker has joined #openstack-sdks | 17:54 | |
| *** salv-orlando has joined #openstack-sdks | 18:07 | |
| *** stevebaker has quit IRC | 18:07 | |
| *** thrash|bbl is now known as thrash | 18:12 | |
| *** dtantsur is now known as dtantsur|afk | 18:16 | |
| *** stevebaker has joined #openstack-sdks | 18:16 | |
| *** jpena is now known as jpena|away | 18:18 | |
| *** harlowja has joined #openstack-sdks | 18:23 | |
| *** stevebaker has quit IRC | 18:29 | |
| *** dave-mccowan has quit IRC | 18:32 | |
| *** stevebaker has joined #openstack-sdks | 18:36 | |
| *** dave-mccowan has joined #openstack-sdks | 18:45 | |
| *** stevebaker has quit IRC | 18:46 | |
| *** stevebaker has joined #openstack-sdks | 18:48 | |
| *** stevebaker has quit IRC | 18:57 | |
| *** dave-mccowan has quit IRC | 19:03 | |
| *** stevebaker has joined #openstack-sdks | 19:06 | |
| *** bobh has joined #openstack-sdks | 19:27 | |
| *** stevebaker has quit IRC | 19:30 | |
| *** stevebaker has joined #openstack-sdks | 19:36 | |
| *** dave-mccowan has joined #openstack-sdks | 19:36 | |
| *** stevebaker has quit IRC | 19:45 | |
| *** stevebaker has joined #openstack-sdks | 19:45 | |
| *** salv-orlando has quit IRC | 19:51 | |
| *** salv-orlando has joined #openstack-sdks | 19:52 | |
| *** e0ne has joined #openstack-sdks | 19:53 | |
| *** salv-orlando has quit IRC | 19:56 | |
| *** stevebaker has quit IRC | 19:58 | |
| *** stevebaker has joined #openstack-sdks | 19:59 | |
| *** dave-mccowan has quit IRC | 20:03 | |
| *** dave-mccowan has joined #openstack-sdks | 20:04 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Use defined version instead of service.version parameter https://review.openstack.org/554223 | 20:07 |
| *** stevebaker has quit IRC | 20:08 | |
| *** stevebaker has joined #openstack-sdks | 20:08 | |
| *** stevebaker has quit IRC | 20:13 | |
| *** stevebaker has joined #openstack-sdks | 20:23 | |
| *** stevebaker has quit IRC | 20:30 | |
| *** dave-mccowan has quit IRC | 20:31 | |
| *** openstackgerrit has quit IRC | 20:33 | |
| *** stevebaker has joined #openstack-sdks | 20:36 | |
| *** stevebaker has quit IRC | 20:44 | |
| *** edmondsw has quit IRC | 20:51 | |
| *** stevebaker has joined #openstack-sdks | 20:51 | |
| *** salv-orlando has joined #openstack-sdks | 20:52 | |
| *** dmellado has joined #openstack-sdks | 20:56 | |
| *** salv-orlando has quit IRC | 20:57 | |
| *** dmellado has quit IRC | 20:58 | |
| *** dave-mccowan has joined #openstack-sdks | 21:00 | |
| *** dmellado has joined #openstack-sdks | 21:02 | |
| *** openstackgerrit has joined #openstack-sdks | 21:06 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Fix additional output encoding issues https://review.openstack.org/554698 | 21:06 |
| *** dmellado has quit IRC | 21:08 | |
| *** stevebaker has quit IRC | 21:09 | |
| *** stevebaker has joined #openstack-sdks | 21:10 | |
| *** dmellado has joined #openstack-sdks | 21:12 | |
| *** dmellado has quit IRC | 21:13 | |
| *** bobh has quit IRC | 21:13 | |
| *** dmellado has joined #openstack-sdks | 21:15 | |
| *** stevebaker has quit IRC | 21:20 | |
| *** dmellado has quit IRC | 21:32 | |
| *** e0ne has quit IRC | 21:33 | |
| *** salv-orlando has joined #openstack-sdks | 21:53 | |
| dhellmann | dtroyer : regarding https://review.openstack.org/#/c/554698/1 I wonder if cliff should grow support for progress bars? | 21:55 |
| dhellmann | https://pypi.python.org/pypi/progressbar was pretty easy to use in downpour | 21:56 |
| dhellmann | oh, although I wonder if that's actively supported any more if it's on code.google.com | 21:57 |
| dhellmann | ah, redirects to https://github.com/niltonvolpato/python-progressbar | 21:57 |
| dhellmann | aha, I actually used https://pypi.python.org/pypi/progressbar2 | 21:59 |
| dhellmann | anyway, let me know if you think that would be a useful thing to be able to do via cliff | 21:59 |
| dtroyer | dhellmann: maybe? I really didn't know what to do with that _show_progress() function. Putting it where I did made calling easy to get cliff's stdout but made testing harder than I wanted to finesse to get a ppinter to the nested function. | 22:00 |
| dhellmann | yeah | 22:00 |
| dhellmann | oh, you could have made it a method instead of a closure | 22:01 |
| dhellmann | that would make it easier to mock it out or whatever | 22:01 |
| dtroyer | but then it would require passing self around and changing the signature of the callback | 22:01 |
| dhellmann | self is passed automatically to a bound method | 22:01 |
| dhellmann | if the signature is "def _show_progress(self, progress)" and you pass self._show_progress the callback will expect 1 arg | 22:02 |
| dtroyer | ok, so I didn't even try that because I assumed it needed a second argument. | 22:02 |
| dhellmann | nah, it does the easy thing | 22:02 |
| dtroyer | that is certainly a better solution | 22:02 |
| dhellmann | what sorts of values are passed to that method? | 22:02 |
| dhellmann | are they text like "working" or are they percentages? | 22:02 |
| *** dmellado has joined #openstack-sdks | 22:04 | |
| dtroyer | it is anything… if the resource being waited on has a progrss attribute, that is passed back | 22:05 |
| dtroyer | *progress attribute | 22:05 |
| dhellmann | so a progress bar might not really work | 22:05 |
| dhellmann | oh, there's an "animated marker" | 22:06 |
| dhellmann | eh, it's something to think about | 22:07 |
| dtroyer | it isn't something I really thing we should be doing, as that kind of stuff often just pollutes logs, but some like it as a touchy-feedbacky thing, even if it is usually not very accurate | 22:08 |
| dhellmann | that's true, i guess | 22:09 |
| dtroyer | it could be tied to logging levels to address that, but I've never really cared enough to follow up | 22:09 |
| dhellmann | I guess it's hard to tell if self.stdout is sys.stdout after we wrap it up | 22:10 |
| dhellmann | it could be its own flag --progress or something | 22:10 |
| dhellmann | I don't feel strongly enough about it to push and implement it; it just seemed like a thing to talk about in light of that patch | 22:10 |
| dhellmann | I'll leave a wishlist ticket in lp in case someone else wants to do it | 22:11 |
| dtroyer | sure, and I appreciate the reviews, this (encoding I/O) is an area I don't seem to be able to keep in my head and have to periodically e-learn it | 22:11 |
| dhellmann | it's like a sandwich. the encoding/decoding steps are the bread and the application is the peanut butter | 22:12 |
| dtroyer | :) it much be dinnertime in GA? | 22:13 |
| dhellmann | https://bugs.launchpad.net/python-cliff/+bug/1757278 | 22:13 |
| openstack | Launchpad bug 1757278 in cliff "add support for progress bar/widgets" [Wishlist,New] | 22:13 |
| dhellmann | haha, yeah, I think I'm hungry :-) | 22:14 |
| dhellmann | speaking of eating, it' time to go exercise some | 22:14 |
| *** dave-mccowan has quit IRC | 22:17 | |
| *** gildub has joined #openstack-sdks | 22:25 | |
| *** stevebaker has joined #openstack-sdks | 22:27 | |
| *** dave-mccowan has joined #openstack-sdks | 22:28 | |
| *** harlowja has quit IRC | 22:57 | |
| *** jpena|away is now known as jpena|off | 23:21 | |
| *** Anticime1 is now known as Anticimex | 23:29 | |
| mordred | dtroyer, dhellmann: fwiw, ianw has poked a little bit at the idea of having some of the calls in shade (so now obviously for sdk) to be able to have progress callbacks... | 23:44 |
| mordred | it's a little different than what you're discussing - this is more of a "do something in the requests/adapter layer so that as we upload 12G images we can tell that it's not just stuck" | 23:44 |
| mordred | but - I could see the existence of a progress bar facility and the existence of an image upload/download progress callback being complimentary | 23:45 |
| *** harlowja has joined #openstack-sdks | 23:49 | |
| *** cdent has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!