| *** salv-orlando has quit IRC | 00:06 | |
| *** salv-orlando has joined #openstack-sdks | 00:07 | |
| *** salv-orlando has quit IRC | 00:12 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Work around discovery being a bit messy for cinder https://review.openstack.org/545174 | 00:22 |
|---|---|---|
| openstackgerrit | Daniel Speichert proposed openstack/python-openstacksdk master: Strip API version from subsequent paginated links https://review.openstack.org/543035 | 00:26 |
| openstackgerrit | Daniel Speichert proposed openstack/python-openstacksdk master: It seems to be working as expected for glance pagination. https://review.openstack.org/545175 | 00:39 |
| *** bobh has joined #openstack-sdks | 00:48 | |
| *** bobh has quit IRC | 00:52 | |
| *** salv-orlando has joined #openstack-sdks | 01:08 | |
| *** salv-orlando has quit IRC | 01:12 | |
| *** salv-orlando has joined #openstack-sdks | 02:08 | |
| *** fzdarsky__ has joined #openstack-sdks | 02:11 | |
| *** salv-orlando has quit IRC | 02:13 | |
| *** fzdarsky_ has quit IRC | 02:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/openstackclient master: Updated from global requirements https://review.openstack.org/521902 | 02:36 |
| *** slaweq has joined #openstack-sdks | 02:46 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/544222 | 02:49 |
| *** slaweq has quit IRC | 02:50 | |
| *** dave-mccowan has joined #openstack-sdks | 03:01 | |
| *** salv-orlando has joined #openstack-sdks | 03:09 | |
| *** dave-mcc_ has joined #openstack-sdks | 03:14 | |
| *** salv-orlando has quit IRC | 03:14 | |
| *** dave-mccowan has quit IRC | 03:15 | |
| *** harlowja_ has quit IRC | 03:23 | |
| *** dave-mcc_ has quit IRC | 03:41 | |
| *** gkadam has joined #openstack-sdks | 03:42 | |
| *** bobh has joined #openstack-sdks | 03:52 | |
| *** bobh has quit IRC | 03:57 | |
| *** salv-orlando has joined #openstack-sdks | 04:23 | |
| *** salv-orlando has quit IRC | 04:29 | |
| *** bobh has joined #openstack-sdks | 04:30 | |
| *** gildub has joined #openstack-sdks | 04:31 | |
| *** gildub has quit IRC | 04:39 | |
| *** harlowja has joined #openstack-sdks | 04:46 | |
| *** slaweq has joined #openstack-sdks | 04:46 | |
| *** slaweq has quit IRC | 04:51 | |
| *** harlowja has quit IRC | 04:59 | |
| *** bobh has quit IRC | 05:03 | |
| *** harlowja has joined #openstack-sdks | 05:19 | |
| *** salv-orlando has joined #openstack-sdks | 05:25 | |
| *** harlowja has quit IRC | 05:27 | |
| *** salv-orlando has quit IRC | 05:29 | |
| *** salv-orlando has joined #openstack-sdks | 06:25 | |
| *** openstackstatus has quit IRC | 06:27 | |
| *** openstack has joined #openstack-sdks | 06:31 | |
| *** ChanServ sets mode: +o openstack | 06:31 | |
| *** salv-orlando has joined #openstack-sdks | 06:32 | |
| *** gkadam has quit IRC | 07:04 | |
| *** halbbalda has joined #openstack-sdks | 07:09 | |
| *** gkadam has joined #openstack-sdks | 07:10 | |
| *** reedip has quit IRC | 07:10 | |
| *** halbbalda has quit IRC | 07:16 | |
| *** halbbalda has joined #openstack-sdks | 07:17 | |
| *** gkadam has quit IRC | 07:33 | |
| *** slaweq has joined #openstack-sdks | 07:44 | |
| *** dtantsur|afk is now known as dtantsur | 07:46 | |
| *** salv-orlando has quit IRC | 08:32 | |
| *** salv-orlando has joined #openstack-sdks | 08:32 | |
| *** e0ne has joined #openstack-sdks | 08:35 | |
| *** salv-orlando has quit IRC | 08:37 | |
| *** jpena|off is now known as jpena | 08:41 | |
| *** salv-orlando has joined #openstack-sdks | 08:45 | |
| *** slaweq_ has joined #openstack-sdks | 08:48 | |
| *** ralonsoh has joined #openstack-sdks | 08:51 | |
| *** slaweq_ has quit IRC | 08:53 | |
| *** e0ne has quit IRC | 08:54 | |
| *** jpich has joined #openstack-sdks | 08:54 | |
| *** salv-orlando has quit IRC | 09:04 | |
| *** salv-orlando has joined #openstack-sdks | 09:05 | |
| *** salv-orlando has quit IRC | 09:09 | |
| *** stephenfin is now known as finucannot | 09:35 | |
| *** umbSublime has joined #openstack-sdks | 09:45 | |
| *** openstackgerrit has quit IRC | 10:18 | |
| *** e0ne has joined #openstack-sdks | 10:34 | |
| *** cdent has joined #openstack-sdks | 10:46 | |
| *** kmy has quit IRC | 10:49 | |
| *** kmy has joined #openstack-sdks | 10:49 | |
| *** fzdarsky__ is now known as fzdarsky|afk | 10:50 | |
| *** e0ne has quit IRC | 11:12 | |
| *** e0ne has joined #openstack-sdks | 11:13 | |
| *** sdague has joined #openstack-sdks | 11:39 | |
| *** cdent has quit IRC | 12:08 | |
| *** salv-orlando has joined #openstack-sdks | 12:10 | |
| *** cdent has joined #openstack-sdks | 12:38 | |
| *** jpena is now known as jpena|lunch | 12:48 | |
| *** slaweq_ has joined #openstack-sdks | 12:50 | |
| *** slaweq_ has quit IRC | 12:54 | |
| *** dave-mccowan has joined #openstack-sdks | 13:09 | |
| *** zhongjun has quit IRC | 13:20 | |
| *** fzdarsky|afk is now known as fzdarsky | 13:30 | |
| *** dave-mccowan has quit IRC | 13:31 | |
| *** jpena|lunch is now known as jpena | 13:51 | |
| *** cdent has quit IRC | 14:00 | |
| *** ralonsoh_ has joined #openstack-sdks | 14:00 | |
| *** ralonsoh has quit IRC | 14:03 | |
| *** dave-mccowan has joined #openstack-sdks | 14:05 | |
| *** bobh has joined #openstack-sdks | 14:06 | |
| *** edleafe is now known as figleaf | 14:08 | |
| *** openstackgerrit has joined #openstack-sdks | 14:38 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356 | 14:38 |
| *** salv-orl_ has joined #openstack-sdks | 14:55 | |
| *** salv-orlando has quit IRC | 14:58 | |
| *** pooja_jadhav has quit IRC | 15:00 | |
| *** lbragstad has quit IRC | 15:14 | |
| *** lbragstad has joined #openstack-sdks | 15:15 | |
| *** cdent has joined #openstack-sdks | 15:38 | |
| *** slaweq has quit IRC | 15:42 | |
| *** slaweq has joined #openstack-sdks | 15:42 | |
| *** e0ne_ has joined #openstack-sdks | 15:43 | |
| *** e0ne has quit IRC | 15:43 | |
| *** e0ne has joined #openstack-sdks | 15:45 | |
| *** slaweq has quit IRC | 15:45 | |
| *** slaweq has joined #openstack-sdks | 15:45 | |
| *** e0ne_ has quit IRC | 15:47 | |
| *** slaweq has quit IRC | 15:49 | |
| *** salv-orl_ has quit IRC | 16:00 | |
| *** salv-orlando has joined #openstack-sdks | 16:00 | |
| *** salv-orlando has quit IRC | 16:05 | |
| *** slaweq has joined #openstack-sdks | 16:06 | |
| *** finucannot is now known as stephenfin | 16:10 | |
| *** slaweq has quit IRC | 16:11 | |
| *** markvoelker has quit IRC | 16:23 | |
| *** markvoelker_ has joined #openstack-sdks | 16:27 | |
| *** slaweq has joined #openstack-sdks | 16:34 | |
| *** slaweq has quit IRC | 16:39 | |
| *** slaweq has joined #openstack-sdks | 17:04 | |
| *** e0ne has quit IRC | 17:06 | |
| *** jpich has quit IRC | 17:15 | |
| dasp | mordred: I updated https://review.openstack.org/#/c/543035/ and the fix works for Glance. Should I worry about failing tests? Do you think there's a way I can test pagination here? I'm not entirely sure what integration testing is in place but if there was a test with paginated image listing, we probably could have caught the issue. | 17:16 |
| *** bobh has quit IRC | 17:40 | |
| *** harlowja has joined #openstack-sdks | 17:55 | |
| *** lbragstad has quit IRC | 17:55 | |
| *** lbragstad has joined #openstack-sdks | 17:56 | |
| *** jpena is now known as jpena|off | 18:09 | |
| *** salv-orlando has joined #openstack-sdks | 18:10 | |
| *** bobh has joined #openstack-sdks | 18:10 | |
| *** bobh has quit IRC | 18:15 | |
| *** bobh has joined #openstack-sdks | 18:24 | |
| *** ralonsoh_ has quit IRC | 18:26 | |
| *** dtantsur is now known as dtantsur|afk | 18:29 | |
| *** harlowja has quit IRC | 18:44 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372 | 18:45 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373 | 18:45 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356 | 18:45 |
| mordred | dasp: yeah - we should fix the tests, that's a real error. we've got functional tests in place ... but we'd need to get enough images loaded to cause pagination to be returned which I think would be hard on an 8G devstack | 18:46 |
| mordred | dasp: I think for now we should just add a couple of requests-mock tests that return pagination links in all of the combinations | 18:47 |
| mordred | dasp: I'll see if I can't knock up an example of that ... | 18:47 |
| *** harlowja has joined #openstack-sdks | 18:48 | |
| dasp | mordred: makes sense. We can just create 200 fake image with random dd'ed payload of 1 MB each. | 18:49 |
| dasp | mordred: not sure if you've seen my two other changes proposed but they're about properties. I'm not sure if the current approach of adding every possible property added in source as a "known" property is to be continued. There are countless options and metadata definition is really for that. So in one change I proposed adding a few and in another, I fixed loading properties property with "everything else", since Glance image object is | 18:51 |
| dasp | flattened. Is there any established direction for what's the better approach? | 18:51 |
| openstackgerrit | Vladyslav Drok proposed openstack/osc-lib master: Allow to use the none auth plugin https://review.openstack.org/512699 | 18:57 |
| *** cdent has quit IRC | 18:58 | |
| mordred | dasp: I like the 200 fake images with 1M dd payload idea | 19:03 |
| mordred | dasp: will look at the properties patches next - in the shade layer we put everything we don't know about into a 'properties' dict (the flat image object in glance v2 is ... so much fun) | 19:07 |
| mordred | dasp: incidentally, http://paste.openstack.org/show/674819/ fixes the unit tests - but I think I may have been wrong about urljoin being good enough - and we may have to get more clever - so I think definitely getting some testing in place to make sure the right thing happens is going to be essential for this one | 19:07 |
| *** harlowja has quit IRC | 19:10 | |
| mordred | dasp: like- something more akin to your first version - but that just does: if uri.startswith('/v') and uri[2].isdigit(): uri = uri.split('/', 2)[2] | 19:11 |
| mordred | dasp: yeah, I like the idea in 544544 - haven't dug in to the impl details yet. also like 544049 | 19:15 |
| mordred | dasp: in general I think we shold support reasonable/defined image properties like you did in 544049 - and have everything else go to properties | 19:16 |
| dasp | mordred: awesome. Those were drafts to get the job done, so I expect some improvements may need to be applied but it worked for what I needed while writing a tool that uses it. | 19:17 |
| mordred | dasp: I'm tempted to say we should just adopt the shade approach globally and put unknown fields into a generic properties bucket for everything - bu tI haven't actually thought through the ramifications for that, so I think it's safer to do it on image first | 19:18 |
| dasp | mordred: there's another bug that I haven't brought up yet - openstacksdk is sending properties as JSON booleans whenever they are booleans. Glance API is kindly throwing 400. It wants 'true' to be a string instead (I found that out tracing what openstackclient is doing). So whenever I declared the property to be a bool, it's not working as expected due to Glance. | 19:19 |
| dasp | mordred: Then, however, if I assign a string to a property declared as dict, it is actually sent to API as string, so I started to doubt if that type setting does anything at all. | 19:20 |
| dasp | mordred: What I noticed openstackclient is doing is that it always asks for metadata catalog before updating images, then it probably validates client-side and figured out the type for every property. | 19:21 |
| mordred | dasp: I believe the type setting is only used when we're injesting values from remotely - so yeah, it's not going to coerce it if you just set it | 19:22 |
| mordred | dasp: hrm. we should maybe do the same thing as osc for glance and grab the metadata catalog for valdation/coercion | 19:23 |
| mordred | dasp: although now I'm also wanting to have the properties coerce things when you set them - and figure out a 'good' way to be able to specify split typing - like "treat this as a bool for sdk interactoins, but send it as a string please" | 19:24 |
| dasp | mordred: it sounds like it may be needed, although I wish that Glance API could accept booleans/floats even if the property needs to be stored as string later on internally. | 19:26 |
| *** bobh has quit IRC | 19:38 | |
| mordred | dasp: ++ | 19:41 |
| mordred | dasp: of course, the joy here in sdk land is that even if we got glance fixed, we'd still need to support older unfixed clouds. yay us! | 19:42 |
| *** harlowja has joined #openstack-sdks | 19:50 | |
| *** bobh has joined #openstack-sdks | 20:01 | |
| *** salv-orlando has quit IRC | 20:03 | |
| *** salv-orlando has joined #openstack-sdks | 20:04 | |
| *** salv-orlando has quit IRC | 20:08 | |
| *** salv-orlando has joined #openstack-sdks | 20:34 | |
| *** markvoelker_ has quit IRC | 20:55 | |
| *** markvoelker has joined #openstack-sdks | 20:56 | |
| openstackgerrit | Brianna Poulos proposed openstack/python-openstackclient master: Update help text for encryption provider https://review.openstack.org/545459 | 21:21 |
| *** edmondsw has quit IRC | 22:01 | |
| *** edmondsw has joined #openstack-sdks | 22:01 | |
| *** edmondsw has quit IRC | 22:06 | |
| *** slaweq has quit IRC | 22:15 | |
| *** kuzko has joined #openstack-sdks | 22:40 | |
| *** GreenBlood has joined #openstack-sdks | 22:40 | |
| *** bobh has quit IRC | 23:20 | |
| *** figleaf is now known as edleafe | 23:22 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372 | 23:23 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373 | 23:23 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356 | 23:23 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!