| mordred | dtroyer: ok. I added a ton of debugging - and it stopped failing :( | 00:11 |
|---|---|---|
| mordred | dtroyer: so I've rebased the real patch again and we'll see if it magically passes this time | 00:12 |
| *** salv-orlando has joined #openstack-sdks | 00:22 | |
| *** salv-orlando has quit IRC | 00:27 | |
| *** kmalloc has quit IRC | 00:29 | |
| *** markvoelker has quit IRC | 00:43 | |
| *** markvoelker has joined #openstack-sdks | 00:44 | |
| *** markvoelker has quit IRC | 00:48 | |
| *** chenyb4 has joined #openstack-sdks | 00:55 | |
| *** dave-mccowan has joined #openstack-sdks | 01:13 | |
| *** slaweq has joined #openstack-sdks | 01:13 | |
| *** slaweq has quit IRC | 01:18 | |
| *** pzchen has joined #openstack-sdks | 01:20 | |
| *** markvoelker has joined #openstack-sdks | 01:30 | |
| *** zhongjun has joined #openstack-sdks | 01:34 | |
| adriant | mordred: left you a note and a paste on one of those patches | 01:48 |
| adriant | when I try initialising the connection directly with auth vars rather than a session, it still looks at the envvars | 01:49 |
| adriant | but the sessions logic works! :P | 01:50 |
| mordred | adriant: yay for the sessions! boo for the other thing ... thanks for test driving | 01:51 |
| mordred | adriant: I've got another fun patch almost ready ... | 01:51 |
| adriant | mordred: not a problem, and my current use case is a good one for testing this since it's within the context/scope of a running openstack client command, so there are envvars/clouds.yaml things to explicitly avoid :P | 01:52 |
| adriant | it's rare someone will ever hit this same problem, but... better to ensure they don't because their context may be even worse | 01:52 |
| *** salv-orlando has joined #openstack-sdks | 01:53 | |
| *** salv-orlando has quit IRC | 01:57 | |
| mordred | the complex problems are the best :) | 01:58 |
| mordred | adriant: BWAHAHAHAHA. found it and it's silly | 02:12 |
| mordred | adriant: http://paste.openstack.org/show/658082 | 02:13 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Add a descriptor object for each service proxy https://review.openstack.org/539232 | 02:13 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Ensure Connection can be made from keyword arguments https://review.openstack.org/539233 | 02:14 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Add OpenStackCloud object to Connection https://review.openstack.org/539234 | 02:14 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Cleanup the BaseProxy docs a bit https://review.openstack.org/539270 | 02:14 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Rename BaseProxy to Proxy https://review.openstack.org/539271 | 02:14 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Merge Connection and OpenStackCloud https://review.openstack.org/539394 | 02:14 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove openstack_cloud factory function https://review.openstack.org/539395 | 02:14 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Shift config exceptions to openstack.exceptions https://review.openstack.org/539396 | 02:14 |
| adriant | mordred: hah! | 02:14 |
| mordred | and there's tonight's patch bomb ... I shall now remove myself from the compute and eat some fish | 02:14 |
| adriant | good plan, will play with those some more and see how it looks | 02:14 |
| adriant | mostly looks great | 02:14 |
| *** harlowja has quit IRC | 02:15 | |
| *** fzdarsky_ has joined #openstack-sdks | 02:28 | |
| *** fzdarsky|afk has quit IRC | 02:31 | |
| *** d0ugal has quit IRC | 02:50 | |
| *** mgagne has quit IRC | 03:22 | |
| *** melwitt has quit IRC | 03:23 | |
| *** jamielennox has quit IRC | 03:23 | |
| *** mgagne has joined #openstack-sdks | 03:24 | |
| *** mgagne is now known as Guest87240 | 03:24 | |
| *** melwitt has joined #openstack-sdks | 03:25 | |
| *** jamielennox has joined #openstack-sdks | 03:29 | |
| *** chenyb4 has quit IRC | 03:30 | |
| *** gkadam has quit IRC | 03:33 | |
| *** salv-orlando has joined #openstack-sdks | 03:54 | |
| *** salv-orlando has quit IRC | 04:00 | |
| *** shu-mutou-AWAY has quit IRC | 04:15 | |
| *** dave-mccowan has quit IRC | 04:32 | |
| *** slaweq has joined #openstack-sdks | 04:45 | |
| *** slaweq has quit IRC | 04:50 | |
| *** harlowja has joined #openstack-sdks | 04:51 | |
| *** chenyb4 has joined #openstack-sdks | 04:56 | |
| *** reedip has joined #openstack-sdks | 04:58 | |
| *** markvoelker has quit IRC | 05:06 | |
| *** slaweq has joined #openstack-sdks | 05:19 | |
| *** salv-orlando has joined #openstack-sdks | 05:20 | |
| *** gkadam has joined #openstack-sdks | 05:23 | |
| *** slaweq has quit IRC | 05:24 | |
| *** chenyb4 has quit IRC | 05:55 | |
| *** chenyb4 has joined #openstack-sdks | 05:57 | |
| *** salv-orlando has quit IRC | 05:58 | |
| *** salv-orlando has joined #openstack-sdks | 05:59 | |
| openstackgerrit | Hunt Xu proposed openstack/python-openstacksdk master: resource: don't early terminate list https://review.openstack.org/539424 | 06:38 |
| *** gkadam has quit IRC | 06:38 | |
| *** gkadam has joined #openstack-sdks | 06:42 | |
| *** slaweq has joined #openstack-sdks | 06:52 | |
| *** gkadam has quit IRC | 06:52 | |
| *** gkadam has joined #openstack-sdks | 06:54 | |
| *** slaweq has quit IRC | 06:56 | |
| *** harlowja has quit IRC | 07:01 | |
| *** markvoelker has joined #openstack-sdks | 07:11 | |
| *** salv-orlando has quit IRC | 07:12 | |
| *** e0ne has joined #openstack-sdks | 07:34 | |
| *** tulivu_ has joined #openstack-sdks | 07:36 | |
| *** tulivu_ has quit IRC | 07:38 | |
| *** pooja-jadhav is now known as pooja_jadhav | 07:39 | |
| *** markvoelker has quit IRC | 07:42 | |
| *** slaweq has joined #openstack-sdks | 07:43 | |
| *** salv-orlando has joined #openstack-sdks | 07:44 | |
| *** tulivu has joined #openstack-sdks | 07:44 | |
| *** slaweq has quit IRC | 07:48 | |
| *** salv-orl_ has joined #openstack-sdks | 07:59 | |
| *** salv-orlando has quit IRC | 08:01 | |
| *** slaweq has joined #openstack-sdks | 08:08 | |
| *** slaweq has quit IRC | 08:13 | |
| *** ralonsoh has joined #openstack-sdks | 08:16 | |
| *** slaweq has joined #openstack-sdks | 08:18 | |
| *** slaweq_ has joined #openstack-sdks | 08:19 | |
| *** slaweq has quit IRC | 08:22 | |
| *** ralonsoh has quit IRC | 08:23 | |
| *** salv-orl_ has quit IRC | 08:24 | |
| *** e0ne has quit IRC | 08:25 | |
| *** ralonsoh has joined #openstack-sdks | 08:26 | |
| *** e0ne has joined #openstack-sdks | 08:30 | |
| *** markvoelker has joined #openstack-sdks | 08:39 | |
| *** jpena|off is now known as jpena | 08:43 | |
| *** salv-orlando has joined #openstack-sdks | 08:45 | |
| openstackgerrit | Hunt Xu proposed openstack/python-openstacksdk master: Implement list projects for user https://review.openstack.org/539460 | 08:45 |
| openstackgerrit | Hunt Xu proposed openstack/python-openstacksdk master: resource: don't early terminate list https://review.openstack.org/539424 | 08:46 |
| *** edmondsw has joined #openstack-sdks | 08:50 | |
| *** edmondsw has quit IRC | 08:54 | |
| *** gkadam has quit IRC | 09:03 | |
| *** gkadam has joined #openstack-sdks | 09:04 | |
| *** d0ugal has joined #openstack-sdks | 09:05 | |
| *** kmy has quit IRC | 09:08 | |
| *** kmy has joined #openstack-sdks | 09:09 | |
| *** markvoelker has quit IRC | 09:12 | |
| *** e0ne has quit IRC | 09:12 | |
| *** e0ne has joined #openstack-sdks | 09:21 | |
| *** e0ne has quit IRC | 09:42 | |
| *** e0ne has joined #openstack-sdks | 10:05 | |
| *** markvoelker has joined #openstack-sdks | 10:09 | |
| *** chenyb4 has quit IRC | 10:11 | |
| *** annp has quit IRC | 10:14 | |
| *** gkadam has quit IRC | 10:19 | |
| *** gkadam has joined #openstack-sdks | 10:20 | |
| *** sdague has joined #openstack-sdks | 10:20 | |
| *** dtantsur|afk is now known as dtantsur | 10:36 | |
| *** markvoelker has quit IRC | 10:42 | |
| openstackgerrit | Chen Hanxiao proposed openstack/python-openstackclient master: Add --image-property parameter in 'server create' https://review.openstack.org/535664 | 10:48 |
| *** salv-orlando has quit IRC | 10:52 | |
| *** salv-orlando has joined #openstack-sdks | 10:52 | |
| *** salv-orlando has quit IRC | 10:57 | |
| openstackgerrit | Hunt Xu proposed openstack/python-openstacksdk master: Fix TypeError for overrided get methods https://review.openstack.org/539494 | 11:08 |
| *** markvoelker has joined #openstack-sdks | 11:39 | |
| *** salv-orlando has joined #openstack-sdks | 11:53 | |
| *** salv-orlando has quit IRC | 11:57 | |
| *** dave-mccowan has joined #openstack-sdks | 12:09 | |
| *** markvoelker has quit IRC | 12:12 | |
| *** chenyb4 has joined #openstack-sdks | 12:25 | |
| *** cdent has joined #openstack-sdks | 12:39 | |
| *** jpena is now known as jpena|lunch | 12:49 | |
| *** markvoelker has joined #openstack-sdks | 13:09 | |
| *** edmondsw has joined #openstack-sdks | 13:22 | |
| *** ralonsoh_ has joined #openstack-sdks | 13:31 | |
| *** ralonsoh has quit IRC | 13:35 | |
| *** pepijn has joined #openstack-sdks | 13:36 | |
| *** markvoelker has quit IRC | 13:37 | |
| *** alex_xu has quit IRC | 13:37 | |
| *** markvoelker has joined #openstack-sdks | 13:37 | |
| *** alex_xu has joined #openstack-sdks | 13:39 | |
| *** tobberydberg has quit IRC | 13:41 | |
| *** salv-orlando has joined #openstack-sdks | 13:42 | |
| *** jpena|lunch is now known as jpena | 13:51 | |
| *** ralonsoh__ has joined #openstack-sdks | 13:57 | |
| *** yolanda has quit IRC | 14:01 | |
| *** ralonsoh_ has quit IRC | 14:01 | |
| *** yolanda has joined #openstack-sdks | 14:03 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Merge Connection and OpenStackCloud https://review.openstack.org/539394 | 14:20 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove openstack_cloud factory function https://review.openstack.org/539395 | 14:20 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Shift config exceptions to openstack.exceptions https://review.openstack.org/539396 | 14:20 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Cleanup the BaseProxy docs a bit https://review.openstack.org/539270 | 14:20 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Rename BaseProxy to Proxy https://review.openstack.org/539271 | 14:20 |
| *** tosky has joined #openstack-sdks | 14:54 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Shift voting flag for ansible-devel job https://review.openstack.org/539563 | 14:57 |
| tosky | hi! I noticed a regression when running some tempest tests; while requirements and upper-constraints pins to openstacksdk 0.9.19, tempest install the last version (0.11.0) | 14:57 |
| tosky | and when running a simple `openstack network list --external`, I get | 14:57 |
| tosky | Invalid query params: router:external | 14:57 |
| tosky | I don't seem to see an existing bug, so I'm going to file one, but I'm not sure if openstackclient 3.14.0 is supposed to work with openstacksdk 0.11.0 | 14:59 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Shift voting flag and test_matrix_branch for ansible-devel job https://review.openstack.org/539563 | 15:06 |
| mordred | tosky: yes - we do expect openstackclient 3.14.0 to work with 0.11 - so yes please to the bug | 15:10 |
| *** fzdarsky_ has quit IRC | 15:10 | |
| tosky | mordred: so again openstacksdk only, not against openstackclient? | 15:11 |
| mordred | tosky: yah - I'd consider it a bug in the 0.11 release that we should figure out and get a point-release cut for | 15:11 |
| tosky | mordred: thanks, I was halfway through it, incoming | 15:11 |
| *** alex_xu has quit IRC | 15:11 | |
| tosky | here you are: https://bugs.launchpad.net/python-openstacksdk/+bug/1746535 | 15:12 |
| openstack | Launchpad bug 1746535 in OpenStack SDK "`openstack network list --external` breaks with openstacksdk 0.11.0 + openstackclient 3.14.0" [Undecided,New] | 15:12 |
| *** alex_xu has joined #openstack-sdks | 15:13 | |
| *** chenyb4 has quit IRC | 15:15 | |
| *** slaweq_ has quit IRC | 15:25 | |
| *** Guest87240 is now known as mgagne | 15:27 | |
| *** mgagne has joined #openstack-sdks | 15:27 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Split request logging into four different loggers https://review.openstack.org/505764 | 15:33 |
| *** tobberydberg has joined #openstack-sdks | 15:34 | |
| *** salv-orlando has quit IRC | 15:37 | |
| mnaser | mordred: forgive me if i'm misusing shade, but get_volume() seems to want to list volumes and then find it (assumingly trying to filter by name first) | 15:38 |
| mnaser | so trying to do get_volume() in the admin tenant results in no volume found | 15:38 |
| mnaser | is there some switch i'm not turning on? | 15:38 |
| mordred | mnaser: yes - that is the default behavior. there is a constructor flag "use_direct_get" which will cause it to use get instead of list for gets | 15:38 |
| mnaser | mordred: wonderful, that's exactly what i needed, thank you | 15:39 |
| mnaser | hmm | 15:40 |
| mordred | mnaser: I believe we'll flip the value of that default in the openstacksdk version of shade - we filter list calls to support nodepool, which I promise you do not want doing 1000s of get calls ... but for humans who are not nodepool it can be unexpected behavior :) | 15:40 |
| mnaser | mordred: i think that flag might have been lost somehow | 15:41 |
| openstackgerrit | Merged openstack-infra/shade master: Add devel branches and override-checkout for ansible-devel job https://review.openstack.org/536159 | 15:41 |
| mnaser | it seems like it is not a constructor value but a thing to set as an attribute to cloud | 15:41 |
| mnaser | (aka cloud.use_direct_get = True) | 15:41 |
| *** salv-orlando has joined #openstack-sdks | 15:41 | |
| mordred | mnaser: I see it on the constructor? | 15:41 |
| mnaser | note to self don't trust github search | 15:41 |
| mordred | mnaser: http://git.openstack.org/cgit/openstack-infra/shade/tree/shade/openstackcloud.py#n137 | 15:42 |
| mordred | mnaser: never trust github | 15:42 |
| mnaser | it doesn't seem to be in the release shipped with rdo pike, maybe i'll ask for a bump sometime soon | 15:42 |
| mordred | oh - yah - it's a new flag | 15:42 |
| mordred | got implemented this cycle | 15:43 |
| mnaser | shade==1.22.2 and this merged in 1.24.0 | 15:43 |
| mnaser | ok cool venv it is | 15:43 |
| mordred | \o/ | 15:43 |
| mordred | mnaser: luckily 1.24.0 is post-client-ectomy, so the venv should be quite small | 15:43 |
| mnaser | oh awesome | 15:43 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Shift voting flag and test_matrix_branch for ansible-devel job https://review.openstack.org/539563 | 15:45 |
| tosky | client-ectomy++ | 15:46 |
| mordred | tosky: ++ seriously. so much better | 15:47 |
| tosky | and it helps packagers | 15:48 |
| mnaser | ok slip up | 15:51 |
| mnaser | shade.openstack_cloud != shade.OpenStackCloud | 15:51 |
| mnaser | that got me confused for a while why it was still false | 15:51 |
| *** gkadam has quit IRC | 15:52 | |
| *** slaweq has joined #openstack-sdks | 15:56 | |
| *** pepijn has quit IRC | 16:05 | |
| *** tovin07 has quit IRC | 16:09 | |
| *** tovin07 has joined #openstack-sdks | 16:10 | |
| mordred | mnaser: oh - well piddle. we should add that parameter to the shade.openstack_cloud constructor | 16:13 |
| mnaser | mordred: and looks like get_server doesn't respect use_direct_get because it uses the find function all the time, but get_server_by_id also has 2 extra calls that get fips and ports | 16:14 |
| mnaser | (i dont have time to look into it right now just fyi) | 16:14 |
| *** tulivu has quit IRC | 16:15 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Plumb use-direct-get through factory functions https://review.openstack.org/539586 | 16:16 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Switch to providing created_at field for servers https://review.openstack.org/536003 | 16:17 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Plumb use-direct-get through factory functions https://review.openstack.org/539586 | 16:17 |
| mordred | mnaser: ^^ there you go - I'll look at servers real quick | 16:18 |
| *** ralonsoh has joined #openstack-sdks | 16:38 | |
| *** ralonsoh__ has quit IRC | 16:41 | |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/533991 | 16:44 |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Split docs requirements and update tox.ini https://review.openstack.org/539594 | 16:44 |
| *** tovin07 has quit IRC | 16:52 | |
| *** tovin07 has joined #openstack-sdks | 16:53 | |
| *** slaweq has quit IRC | 16:55 | |
| *** e0ne has quit IRC | 16:58 | |
| *** harlowja has joined #openstack-sdks | 17:02 | |
| *** slaweq has joined #openstack-sdks | 17:03 | |
| *** slaweq has quit IRC | 17:11 | |
| *** ralonsoh_ has joined #openstack-sdks | 17:21 | |
| *** ralonsoh has quit IRC | 17:24 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Merge Connection and OpenStackCloud https://review.openstack.org/539394 | 17:28 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove openstack_cloud factory function https://review.openstack.org/539395 | 17:28 |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Split docs requirements and update tox.ini https://review.openstack.org/539594 | 17:37 |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/533991 | 17:37 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Split request logging into four different loggers https://review.openstack.org/505764 | 17:52 |
| openstackgerrit | Merged openstack-infra/shade master: Shift voting flag and test_matrix_branch for ansible-devel job https://review.openstack.org/539563 | 18:03 |
| *** jpena is now known as jpena|away | 18:13 | |
| *** e0ne has joined #openstack-sdks | 18:17 | |
| *** e0ne has quit IRC | 18:19 | |
| *** tosky has quit IRC | 18:28 | |
| *** dtantsur is now known as dtantsur|afk | 18:37 | |
| *** e0ne has joined #openstack-sdks | 18:40 | |
| *** harlowja has quit IRC | 18:52 | |
| *** edleafe has quit IRC | 19:09 | |
| *** edleafe has joined #openstack-sdks | 19:09 | |
| *** jpena|away is now known as jpena|off | 19:24 | |
| *** ralonsoh_ has quit IRC | 19:30 | |
| *** harlowja has joined #openstack-sdks | 19:37 | |
| *** cdent has quit IRC | 19:53 | |
| *** calebb has quit IRC | 19:57 | |
| *** salv-orlando has quit IRC | 20:00 | |
| *** salv-orlando has joined #openstack-sdks | 20:00 | |
| *** calebb has joined #openstack-sdks | 20:01 | |
| *** calebb is now known as squid | 20:02 | |
| *** squid is now known as calebb | 20:02 | |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Shift config exceptions to openstack.exceptions https://review.openstack.org/539396 | 20:03 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Cleanup the BaseProxy docs a bit https://review.openstack.org/539270 | 20:03 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Rename BaseProxy to Proxy https://review.openstack.org/539271 | 20:03 |
| *** salv-orlando has quit IRC | 20:05 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Plumb use-direct-get through factory functions https://review.openstack.org/539586 | 20:08 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Fix get_server to work with use_direct_get https://review.openstack.org/539663 | 20:08 |
| mordred | mnaser: ^^ ok. those should work for you now | 20:08 |
| openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Add get_client_config method to CloudRegion https://review.openstack.org/539678 | 20:52 |
| openstackgerrit | Merged openstack-infra/shade master: Switch to providing created_at field for servers https://review.openstack.org/536003 | 20:59 |
| mordred | dtroyer: feel like merging https://review.openstack.org/#/c/525283/ ? | 20:59 |
| *** salv-orlando has joined #openstack-sdks | 21:01 | |
| dtroyer | mordred: ugh, I didn't do that yet??? | 21:01 |
| dtroyer | done | 21:02 |
| adriant | mordred: I'm look at https://bugs.launchpad.net/python-openstacksdk/+bug/1746535 | 21:02 |
| openstack | Launchpad bug 1746535 in OpenStack SDK "`openstack network list --external` breaks with openstacksdk 0.11.0 + openstackclient 3.14.0" [Undecided,New] | 21:02 |
| adriant | it was introduced by my patch, but... what worries me is this likely means that that never actually worked. | 21:02 |
| adriant | my patch just exposes the error rather than drops the param on the floor | 21:03 |
| openstackgerrit | Merged openstack/os-client-config master: Add betacloud to the vendors https://review.openstack.org/527248 | 21:03 |
| adriant | although, it is also possible my patch's logic is busted, so that is an option | 21:03 |
| openstackgerrit | Tim Burke proposed openstack/python-openstacksdk master: Let enforcer.py work under both py2 and py3 https://review.openstack.org/539685 | 21:03 |
| mordred | timburke: ^^ thanks. I could have sworn I'd done that already, but clearly I'm smoking something | 21:05 |
| *** salv-orlando has quit IRC | 21:06 | |
| mordred | adriant: oh - piddle - I said this morning I'd look at that and totally forgot | 21:06 |
| timburke | mordred: np. i saw https://review.openstack.org/#/c/525642/ but for some reason it got abandoned | 21:06 |
| * timburke shrugs | 21:06 | |
| mordred | timburke: oh. it was stacked on another thing that got abandoned ... who knows. | 21:07 |
| adriant | mordred: looks my patch is at fault. will play with it and submit a fix. | 21:09 |
| mordred | adriant: cool. there's a followup to that that we do in shade that I've been meaning to port over - I'll do that on top of your patch | 21:10 |
| mordred | adriant: luckily it's easy enough to reproduce ... | 21:10 |
| adriant | oh... | 21:10 |
| adriant | I think I see the issue | 21:10 |
| adriant | it isn't technically my code | 21:10 |
| mordred | can we blame you anyway thought? :) | 21:11 |
| adriant | mordred: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/network.py#L500-L501 | 21:11 |
| adriant | the client supplies both | 21:11 |
| adriant | but only the second does anything | 21:11 |
| mordred | adriant: AH | 21:12 |
| adriant | my code simply ensures that you're supplying it as: "is_router_external" since it is dropped otherwise | 21:12 |
| *** e0ne has quit IRC | 21:12 | |
| adriant | lemme double check | 21:12 |
| mordred | so - yah- introducing the strictness broke a thing that was just passing multiple options and counting on unsupported things falling on the floor | 21:12 |
| adriant | we can potentially introduce a "strict_list_params" boolean if we want, and default it to false, with a deprecation warning? | 21:13 |
| mordred | yah. I'd love it if we could introduce that on the Connection and not on each call ... | 21:14 |
| adriant | oh yeah, no on each call... | 21:14 |
| adriant | not* | 21:15 |
| mordred | also - I may be overthinking this ... but at least in the openstackclient case, the extra argument is the 'real' name for something we have a mapping for | 21:15 |
| adriant | patch for openstackclient? | 21:16 |
| mordred | adriant: we *could* have it do something similar to what your swift patch did a while back (look at the keys and then also the values) | 21:16 |
| adriant | yeah, I can add that in | 21:16 |
| adriant | but I bet you someone somewhere is passing in bogus values... but my worry is they are doing so expecting it to work | 21:16 |
| mordred | thatwould let people use the REST-side parameters or the sdk parameters | 21:16 |
| adriant | oh, so we do the remapping if they supply the values? | 21:17 |
| adriant | yeah, could work | 21:17 |
| mordred | yah. we've already got is_router_external='router:external' in sdk | 21:18 |
| adriant | ok, lemme play with that | 21:18 |
| mordred | so if we're just add a friendly mapping for folks before the set - then router:external would turn in to is_router_external twice- and then set would collapse it and OSC would work again | 21:18 |
| mordred | cool | 21:18 |
| adriant | and anyone beyond that is actually supplying bogus values does get an error, but... that's probably a good thing | 21:19 |
| mordred | agree | 21:19 |
| adriant | mordred: ok, now I'm confused... what branch are we working against? because it looks like you've merged stuff to stable queens but not master | 21:22 |
| mordred | both - go ahead and write it for master and we can then cherry-pick it back to stable queens | 21:22 |
| adriant | but why is stable queens further ahead of master? :P | 21:23 |
| openstackgerrit | Merged openstack/os-client-config master: Split docs requirements and update tox.ini https://review.openstack.org/539594 | 21:24 |
| mordred | adriant: I may have fast-tracked two patches earlier to squeeze them in to the release ;) | 21:24 |
| openstackgerrit | Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/533991 | 21:25 |
| adriant | mordred: I think master is broken. | 21:30 |
| mordred | adriant: awesome | 21:30 |
| adriant | https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy.py#L43 | 21:31 |
| adriant | https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L18 | 21:31 |
| mordred | adriant: hah. yes. that is, indeed, broken | 21:32 |
| mordred | although amusingly the patch to rename BaseProxy to Proxy would fix that | 21:32 |
| adriant | and after fixing that i get: AttributeError: 'module' object has no attribute 'Body' | 21:32 |
| mordred | adriant: what's trying to call in through Proxy2? | 21:33 |
| * adriant *shrugs* | 21:33 | |
| * mordred looks | 21:33 | |
| adriant | lemme see | 21:33 |
| mordred | adriant: on master for me, openstack network list --external gets through to where it's supposed to fail | 21:34 |
| adriant | oh ffs | 21:35 |
| adriant | I think i see my issue | 21:35 |
| adriant | ugh, the random fucking pyc files for 'meter' didn't get cleaned up | 21:35 |
| adriant | i'm very confused by that... | 21:36 |
| adriant | I nuked my venv | 21:36 |
| mordred | I hate leftover .pyc files | 21:36 |
| adriant | *sigh* and other random cruft leftover from using "python setup.py install" ages ago with an old version that included meter code :/ | 21:38 |
| adriant | works now... | 21:39 |
| adriant | mordred: for that query mapping fix | 21:44 |
| adriant | right now, if I just add the values to my checking, and nothing else, the 'values' data takes precedence over the real expected key if both are supplied | 21:45 |
| adriant | are you ok with my making it so that if you supply both, we take the one we prefer them to sue? | 21:45 |
| adriant | use* | 21:45 |
| adriant | e.g.is_router_external > router:external | 21:45 |
| mordred | adriant: yah - I think that seems right - if you supply both, we should have the 'official' thing wins | 21:46 |
| adriant | mordred: currently would do it the other way https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource.py#L234 | 21:47 |
| adriant | so I'll update transpose to check if the key is already present | 21:47 |
| mordred | ++ | 21:47 |
| *** salv-orlando has joined #openstack-sdks | 21:47 | |
| adriant | oh wait no I'm being silly. transpose just drops them. I need to make it actually try and use both. | 21:49 |
| mordred | adriant: I must afk for a couple of hours - will check back in when I'm back - thanks for diving in on this! | 21:50 |
| *** salv-orl_ has joined #openstack-sdks | 22:23 | |
| *** salv-orlando has quit IRC | 22:25 | |
| *** edmondsw has quit IRC | 22:32 | |
| *** edmondsw has joined #openstack-sdks | 22:33 | |
| *** edmondsw has quit IRC | 22:37 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Make functional-tips job voting https://review.openstack.org/525283 | 22:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/539718 | 22:41 |
| *** salv-orl_ has quit IRC | 22:42 | |
| *** salv-orlando has joined #openstack-sdks | 22:43 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Let enforcer.py work under both py2 and py3 https://review.openstack.org/539685 | 22:44 |
| *** salv-orlando has quit IRC | 22:47 | |
| openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Add server-side names to query param checking https://review.openstack.org/539722 | 22:53 |
| adriant | mordred: fixed ^ | 22:56 |
| adriant | and the fix actually adds some nicer logic overall | 22:57 |
| *** slaweq has joined #openstack-sdks | 23:04 | |
| *** slaweq has quit IRC | 23:09 | |
| *** slaweq has joined #openstack-sdks | 23:11 | |
| *** slaweq has quit IRC | 23:15 | |
| *** d0ugal has quit IRC | 23:20 | |
| *** sdague has quit IRC | 23:20 | |
| *** salv-orlando has joined #openstack-sdks | 23:43 | |
| *** salv-orlando has quit IRC | 23:47 | |
| *** sdague has joined #openstack-sdks | 23:53 | |
| *** umbSublime has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!