| *** edmondsw has quit IRC | 00:00 | |
| mordred | ignore that ^^ | 00:12 |
|---|---|---|
| mordred | Qiming: if you have a sec, feel like reviewing https://review.openstack.org/#/c/530769/ ? I think it should be ok from your earlier comments | 00:14 |
| mordred | Qiming: also, I pushed up a patch to heat to shift it from using senlinclient to using SDK https://review.openstack.org/#/c/532680/ and a senlin patch https://review.openstack.org/#/c/532641/ that I'd love your feedback on | 00:16 |
| *** chenyb4 has joined #openstack-sdks | 00:46 | |
| *** dayou has quit IRC | 00:50 | |
| *** dayou has joined #openstack-sdks | 01:03 | |
| *** slaweq has joined #openstack-sdks | 01:19 | |
| *** slaweq_ has joined #openstack-sdks | 01:21 | |
| *** slaweq has quit IRC | 01:24 | |
| *** slaweq_ has quit IRC | 01:25 | |
| *** edmondsw has joined #openstack-sdks | 01:44 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 01:46 | |
| *** edmondsw has quit IRC | 01:48 | |
| *** markvoelker has joined #openstack-sdks | 01:50 | |
| *** bobh has joined #openstack-sdks | 01:53 | |
| *** annp has joined #openstack-sdks | 02:11 | |
| *** chenyb4 has quit IRC | 02:22 | |
| *** Qiming has quit IRC | 02:33 | |
| *** markvoelker has quit IRC | 02:36 | |
| *** chenyb4 has joined #openstack-sdks | 02:39 | |
| *** Qiming has joined #openstack-sdks | 02:39 | |
| *** adriant has joined #openstack-sdks | 02:57 | |
| adriant | is it just me, or query params/filters are busted for the openstackSDK? | 02:58 |
| adriant | I'm trying to list stuff via the SDK and the list commands appear to just take key/values as kwargs, but those aren't actually being used since QueryParameters._transpose() appears to gobble them up... | 02:59 |
| adriant | from what I can tell, this is because 'somewhere' on the resource we need to define what they acceptable query params are... or something? but this isn't actually happening anywhere. | 03:06 |
| adriant | no wait... they are actually being used | 03:07 |
| adriant | just not at all for any of the identity | 03:07 |
| adriant | but then the terrifying thing is that after mangling the query, i get returned EVERYTHING | 03:08 |
| adriant | so if I do: sdk.identity.projects(name="some project") | 03:09 |
| adriant | a list with projects of that name, OR nothing | 03:09 |
| adriant | yet I get everything... | 03:09 |
| adriant | because my query is being mangled and the API then does a call for everything | 03:10 |
| adriant | I think it would be much much safer to no mangle the query, just throw a damn error | 03:10 |
| adriant | not* | 03:10 |
| adriant | if you attempt to query with a key that isn't setup to be queried with, throw an error rather than return to me a list of data that I may act upon thinking it matched my query... | 03:11 |
| adriant | when it didn't. | 03:11 |
| *** slaweq has joined #openstack-sdks | 03:21 | |
| *** slaweq_ has joined #openstack-sdks | 03:21 | |
| *** ldl has joined #openstack-sdks | 03:22 | |
| *** slaweq has quit IRC | 03:25 | |
| *** slaweq_ has quit IRC | 03:26 | |
| *** thrash is now known as thrash|g0ne | 03:32 | |
| *** gkadam has joined #openstack-sdks | 04:03 | |
| openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Raise error when supplying invalid query params https://review.openstack.org/532723 | 04:04 |
| openstackgerrit | Adrian Turjak proposed openstack/python-openstacksdk master: Raise error when supplying invalid query params https://review.openstack.org/532723 | 04:05 |
| adriant | mordred, briancurtin: : ^ this technically break functionality, but because you're now requiring explicit definition of valid queries in the Resource2 class, rather than just passing them through without checking like Resource did, you can confirm people are being sensible. | 04:08 |
| adriant | Identity has been moved to Resource2, but no one setup any valid queries for it... so trying to list projects and filtering by name returns all projects... which is an unsafe query because you're mangling the query I supplied since no one configured it as valid in the code. | 04:10 |
| adriant | But... since we are configuring valid queries in the code (a good thing), we can stop people from making stupid mistakes by throwing this kind of error. | 04:10 |
| adriant | Which means we actually need to define the queries. I'll dig through and see if there is a patch for adding filters to identityv3, if not, I'll submit that. | 04:11 |
| *** bobh has quit IRC | 04:11 | |
| adriant | hah, fuck, nvm, my bad. the version of the sdk I was using to test doesn't have it... master does... ignore me | 04:14 |
| adriant | Still worth throwing errors for invalid queries because it's safer, since we know what a valid query is | 04:18 |
| *** shu-mutou has quit IRC | 04:35 | |
| *** shu-mutou has joined #openstack-sdks | 04:36 | |
| *** gkadam has quit IRC | 05:16 | |
| *** edmondsw has joined #openstack-sdks | 05:20 | |
| *** edmondsw has quit IRC | 05:24 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 05:32 | |
| *** markvoelker has joined #openstack-sdks | 05:47 | |
| *** slaweq has joined #openstack-sdks | 06:09 | |
| *** slaweq has quit IRC | 06:13 | |
| *** annp has quit IRC | 06:38 | |
| *** markvoelker has quit IRC | 06:40 | |
| *** markvoelker has joined #openstack-sdks | 06:42 | |
| *** edmondsw has joined #openstack-sdks | 07:08 | |
| *** edmondsw has quit IRC | 07:13 | |
| *** dims_ has quit IRC | 07:21 | |
| *** dims has joined #openstack-sdks | 07:25 | |
| *** reedip has quit IRC | 07:34 | |
| *** slaweq has joined #openstack-sdks | 07:38 | |
| *** reedip has joined #openstack-sdks | 07:47 | |
| *** annp has joined #openstack-sdks | 08:01 | |
| *** fzdarsky has joined #openstack-sdks | 08:07 | |
| *** slaweq_ has joined #openstack-sdks | 08:10 | |
| *** slaweq_ has quit IRC | 08:14 | |
| *** gkadam has joined #openstack-sdks | 08:18 | |
| *** reedip has quit IRC | 08:34 | |
| openstackgerrit | Zhaokun Fu proposed openstack/python-openstackclient master: add --password option for openstack server create https://review.openstack.org/490718 | 08:34 |
| *** jpena|off is now known as jpena | 08:34 | |
| *** reedip has joined #openstack-sdks | 08:46 | |
| *** b_bezak has joined #openstack-sdks | 08:47 | |
| *** Mr_Broken has joined #openstack-sdks | 08:48 | |
| Mr_Broken | Hey guys, | 08:48 |
| Mr_Broken | Any chance that shade will be supporting SubnetPool functionality ? ( create, delete , manage ? ) | 08:48 |
| *** ralonsoh has joined #openstack-sdks | 08:50 | |
| *** edmondsw has joined #openstack-sdks | 08:56 | |
| *** b_bezak has quit IRC | 08:57 | |
| *** edmondsw has quit IRC | 09:01 | |
| *** jpich has joined #openstack-sdks | 09:02 | |
| *** e0ne has joined #openstack-sdks | 09:21 | |
| *** fzdarsky has quit IRC | 09:26 | |
| *** dtantsur|afk is now known as dtantsur | 09:38 | |
| *** fzdarsky has joined #openstack-sdks | 09:59 | |
| *** slaweq_ has joined #openstack-sdks | 10:11 | |
| *** markvoelker has quit IRC | 10:13 | |
| *** slaweq_ has quit IRC | 10:15 | |
| *** cdent has joined #openstack-sdks | 10:30 | |
| *** e0ne has quit IRC | 10:38 | |
| *** e0ne has joined #openstack-sdks | 10:39 | |
| *** edmondsw has joined #openstack-sdks | 10:44 | |
| *** slaweq_ has joined #openstack-sdks | 10:46 | |
| *** slaweq_ has quit IRC | 10:48 | |
| *** slaweq_ has joined #openstack-sdks | 10:48 | |
| *** slaweq has quit IRC | 10:48 | |
| *** edmondsw has quit IRC | 10:49 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Add query filters for find_network https://review.openstack.org/476410 | 11:02 |
| *** chenyb4 has quit IRC | 11:06 | |
| *** fzdarsky has quit IRC | 11:27 | |
| *** sdague has joined #openstack-sdks | 11:39 | |
| *** e0ne has quit IRC | 11:58 | |
| *** cdent has quit IRC | 12:02 | |
| *** jpena is now known as jpena|lunch | 12:04 | |
| *** jkilpatr has joined #openstack-sdks | 12:05 | |
| *** annp has quit IRC | 12:05 | |
| *** slaweq has joined #openstack-sdks | 12:11 | |
| *** markvoelker has joined #openstack-sdks | 12:14 | |
| *** cdent has joined #openstack-sdks | 12:16 | |
| *** slaweq has quit IRC | 12:16 | |
| *** ldl has quit IRC | 12:28 | |
| *** e0ne has joined #openstack-sdks | 12:30 | |
| *** dayou has quit IRC | 12:32 | |
| *** edmondsw has joined #openstack-sdks | 12:33 | |
| *** e0ne has quit IRC | 12:33 | |
| *** Mr_Broken has quit IRC | 12:34 | |
| *** edmondsw has quit IRC | 12:38 | |
| *** e0ne has joined #openstack-sdks | 12:42 | |
| *** bobh has joined #openstack-sdks | 12:42 | |
| *** markvoelker has quit IRC | 12:48 | |
| *** e0ne has quit IRC | 12:52 | |
| *** dayou has joined #openstack-sdks | 12:53 | |
| *** e0ne has joined #openstack-sdks | 12:53 | |
| *** jpena|lunch is now known as jpena | 13:00 | |
| *** Mr_Broken has joined #openstack-sdks | 13:12 | |
| *** thrash|g0ne is now known as thrash | 13:18 | |
| *** e0ne has quit IRC | 13:20 | |
| *** fzdarsky has joined #openstack-sdks | 13:22 | |
| *** e0ne has joined #openstack-sdks | 13:24 | |
| *** bobh has quit IRC | 13:25 | |
| *** dayou has quit IRC | 13:26 | |
| *** e0ne has quit IRC | 13:30 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/api-wg master: [WIP] Add guideline on exposing microversions in SDKs https://review.openstack.org/532814 | 13:31 |
| *** e0ne has joined #openstack-sdks | 13:33 | |
| *** e0ne has quit IRC | 13:34 | |
| *** dayou has joined #openstack-sdks | 13:39 | |
| *** markvoelker has joined #openstack-sdks | 13:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/cliff master: sphinxext: Warn if namespace or command pattern invalid https://review.openstack.org/510913 | 13:47 |
| *** rabel_b1 has joined #openstack-sdks | 13:52 | |
| *** efried has joined #openstack-sdks | 13:53 | |
| *** e0ne has joined #openstack-sdks | 13:58 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/api-wg master: Add guideline on exposing microversions in SDKs https://review.openstack.org/532814 | 14:02 |
| dtantsur | cdent, mordred, TheJulia, thought dump complete ^^^ :) | 14:03 |
| *** slaweq has joined #openstack-sdks | 14:12 | |
| *** dave-mccowan has joined #openstack-sdks | 14:16 | |
| *** slaweq has quit IRC | 14:17 | |
| *** markvoelker has quit IRC | 14:18 | |
| mordred | dtantsur: ooh, fun reading for this morning | 14:18 |
| dtantsur | haha, I hope you enjoy it :) I did steal a few things from Shade docs ;) | 14:19 |
| mordred | dtantsur: it's good - and it's a hard topic. I think that's an excellent write up | 14:20 |
| dtantsur | cool! | 14:21 |
| *** edmondsw has joined #openstack-sdks | 14:21 | |
| mordred | adriant: in shade we do a hybrid approach, which is that we send query parameters to the service if we know about them, but then also filter results client-side before returning them, in case someone wants to filter by something that's not possible as a server-side filter | 14:22 |
| *** edmondsw_ has joined #openstack-sdks | 14:24 | |
| mordred | adriant: I was actually just thinking the other day about adding that post-filtering to Resource2 ... but I think we'd also want to add a flag to control pushdown behavior | 14:24 |
| mordred | because there are three general things people tend to want "pushdown as many filters to the server as possible and apply any remaining filters client-side" "pushdown everything and error if some filters can't be handled server-side" "pushdown nothing and do all filtering client-side" | 14:25 |
| *** edmondsw has quit IRC | 14:28 | |
| *** jkilpatr has quit IRC | 14:39 | |
| *** jkilpatr has joined #openstack-sdks | 14:45 | |
| *** edmondsw_ is now known as edmondsw | 14:45 | |
| *** markvoelker has joined #openstack-sdks | 15:02 | |
| *** markvoelker has quit IRC | 15:02 | |
| *** rabel__b1 has joined #openstack-sdks | 15:03 | |
| *** rabel_b1 has quit IRC | 15:05 | |
| *** jkilpatr has quit IRC | 15:13 | |
| *** jkilpatr has joined #openstack-sdks | 15:13 | |
| *** jkilpatr has quit IRC | 15:13 | |
| *** jkilpatr has joined #openstack-sdks | 15:13 | |
| *** edmondsw has quit IRC | 15:18 | |
| *** cleong has joined #openstack-sdks | 15:20 | |
| *** markvoelker has joined #openstack-sdks | 15:24 | |
| *** edmondsw has joined #openstack-sdks | 15:24 | |
| *** bobh has joined #openstack-sdks | 15:24 | |
| *** slaweq_ has quit IRC | 15:30 | |
| *** slaweq has joined #openstack-sdks | 15:31 | |
| *** slaweq has quit IRC | 15:35 | |
| *** slaweq has joined #openstack-sdks | 16:09 | |
| *** slaweq has quit IRC | 16:13 | |
| *** slaweq_ has joined #openstack-sdks | 16:13 | |
| *** slaweq_ has quit IRC | 16:17 | |
| *** e0ne has quit IRC | 16:24 | |
| *** thrash is now known as thrash|biab | 16:26 | |
| *** cdent has quit IRC | 16:47 | |
| *** dtantsur is now known as dtantsur|afk | 16:47 | |
| *** cdent has joined #openstack-sdks | 16:52 | |
| *** fzdarsky has quit IRC | 17:00 | |
| *** thrash|biab is now known as thrash | 17:03 | |
| *** jpich has quit IRC | 17:17 | |
| cdent | elmiko, edleafe, dtantsur|afk : https://etherpad.openstack.org/p/api-sig-newsletter please and thank you | 17:22 |
| *** amotoki has quit IRC | 17:24 | |
| edleafe | looking... | 17:24 |
| edleafe | looks like cdent has his thesaurus at the ready :) | 17:25 |
| cdent | I am a thesaurus | 17:26 |
| *** rabel__b1 has quit IRC | 17:27 | |
| edleafe | cdent: one small wording change, but otherwise LGTM | 17:28 |
| cdent | yah, seems a sensible change | 17:28 |
| cdent | thanks | 17:28 |
| cdent | shipped | 17:29 |
| *** slaweq has joined #openstack-sdks | 17:33 | |
| *** gkadam has quit IRC | 17:37 | |
| *** slaweq has quit IRC | 17:37 | |
| -openstackstatus- NOTICE: Due to an unexpected issue with zuulv3.o.o, we were not able to preserve running jobs for a restart. As a result, you'll need to recheck your previous patchsets | 17:48 | |
| *** ralonsoh has quit IRC | 18:04 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Add floating IP qos_policy actions https://review.openstack.org/517845 | 18:10 |
| *** jpena is now known as jpena|off | 18:16 | |
| elmiko | sorry cdent, was otherwise occupied :| | 18:36 |
| cdent | no problem | 18:37 |
| *** cdent has quit IRC | 18:59 | |
| *** jkilpatr_ has joined #openstack-sdks | 19:00 | |
| *** jkilpatr has quit IRC | 19:01 | |
| *** jkilpatr_ has quit IRC | 19:07 | |
| *** gkadam has joined #openstack-sdks | 19:17 | |
| *** slaweq has joined #openstack-sdks | 19:20 | |
| *** jkilpatr_ has joined #openstack-sdks | 19:21 | |
| *** edmondsw_ has joined #openstack-sdks | 19:48 | |
| *** edmonds__ has joined #openstack-sdks | 19:48 | |
| *** edmondsw has quit IRC | 19:52 | |
| *** edmondsw_ has quit IRC | 19:52 | |
| adriant | mordred: as long as we make the defaults sensible, and give the user control over them, I'm game. My problem is that if I give it incorrect params, or even correct params thatthe API accepts but we haven't coded in yet, and the code gobbles them up and doesn't tell me... | 19:53 |
| adriant | I'll be screwed when i realise the query I got back includes a list of everything, and none of the filters were actually passed along. | 19:54 |
| adriant | throwing an error at least tells me to submit a patch to add missing filters to the SDK, or that I made a typo and threw in the wrong filter. | 19:55 |
| adriant | silent failure = pain | 19:55 |
| adriant | like I was using 0.9.19 which switched identity to resource2 but didn't yet have the identity filters merged, so when trying to filter project list by name I got back a full list, which... confused me since resource1 just passed the whole dict through. | 19:57 |
| adriant | mordred: as new services add filters, people will try using them via the SDK sometimes before we add them there, so we either need to make it clear we don't support them yet (error), or a way to explicitly bypass which filters we configure and just pass the filters through raw. The latter of which really could just be a case of: "do a raw API cal | 19:59 |
| adriant | l" if we don't want to add too much complexity. | 19:59 |
| openstackgerrit | Merged openstack/osc-lib master: Fix find() interface when attr is not specified https://review.openstack.org/529934 | 20:07 |
| *** gkadam has quit IRC | 20:12 | |
| *** e0ne has joined #openstack-sdks | 20:55 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add floating IP qos_policy actions https://review.openstack.org/517845 | 21:03 |
| *** edmonds__ is now known as edmondsw | 21:07 | |
| *** e0ne has quit IRC | 21:09 | |
| *** Mr_Broken has quit IRC | 21:10 | |
| openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Re-enable octavia functional tests https://review.openstack.org/531514 | 21:14 |
| *** jkilpatr_ has quit IRC | 21:27 | |
| *** e0ne has joined #openstack-sdks | 21:32 | |
| *** cleong has quit IRC | 21:33 | |
| *** jkilpatr has joined #openstack-sdks | 21:52 | |
| *** slaweq has quit IRC | 21:55 | |
| *** slaweq has joined #openstack-sdks | 21:56 | |
| *** e0ne has quit IRC | 21:57 | |
| *** dave-mccowan has quit IRC | 22:16 | |
| *** dave-mccowan has joined #openstack-sdks | 22:17 | |
| *** dave-mccowan has quit IRC | 22:25 | |
| *** bobh has quit IRC | 22:32 | |
| *** slaweq has quit IRC | 22:46 | |
| *** markvoelker has quit IRC | 22:49 | |
| *** markvoelker has joined #openstack-sdks | 22:49 | |
| *** Jeffrey4l has quit IRC | 22:53 | |
| *** markvoelker has quit IRC | 22:54 | |
| *** edmondsw has quit IRC | 22:54 | |
| *** edmondsw has joined #openstack-sdks | 22:55 | |
| *** Jeffrey4l has joined #openstack-sdks | 22:56 | |
| *** markvoelker has joined #openstack-sdks | 22:56 | |
| *** edmondsw has quit IRC | 22:59 | |
| *** markvoelker has quit IRC | 22:59 | |
| *** markvoelker has joined #openstack-sdks | 23:00 | |
| *** markvoelker has quit IRC | 23:05 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!