| *** yuanying_ has joined #openstack-sdks | 00:05 | |
| *** yuanying has quit IRC | 00:06 | |
| *** yuanying has joined #openstack-sdks | 00:31 | |
| *** yuanying_ has quit IRC | 00:31 | |
| *** yuanying has quit IRC | 00:49 | |
| *** yuanying has joined #openstack-sdks | 01:02 | |
| *** rajathagasthya has joined #openstack-sdks | 01:40 | |
| *** annp has joined #openstack-sdks | 01:44 | |
| *** fzdarsky_ has joined #openstack-sdks | 01:56 | |
| *** yuanying has quit IRC | 01:57 | |
| *** fzdarsky has quit IRC | 01:59 | |
| *** yuanying has joined #openstack-sdks | 02:00 | |
| *** dave-mccowan has quit IRC | 02:53 | |
| *** d0ugal has quit IRC | 03:19 | |
| *** d0ugal_ has joined #openstack-sdks | 03:19 | |
| *** markvoelker has quit IRC | 03:26 | |
| *** markvoelker has joined #openstack-sdks | 03:26 | |
| *** markvoelker has quit IRC | 03:30 | |
| *** rajathagasthya has quit IRC | 04:23 | |
| *** GrineBloude has joined #openstack-sdks | 05:10 | |
| *** dasanind_ has joined #openstack-sdks | 05:15 | |
| *** frickler_ has joined #openstack-sdks | 05:15 | |
| *** ankur-gupta-f4_ has joined #openstack-sdks | 05:17 | |
| *** mvpnitesh has joined #openstack-sdks | 05:18 | |
| *** GreenBlood has quit IRC | 05:22 | |
| *** dasanind has quit IRC | 05:22 | |
| *** ankur-gupta-f4 has quit IRC | 05:22 | |
| *** frickler has quit IRC | 05:22 | |
| *** ankur-gupta-f4_ is now known as ankur-gupta-f4 | 05:22 | |
| *** dasanind_ is now known as dasanind | 05:22 | |
| *** markvoelker has joined #openstack-sdks | 05:27 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 05:35 | |
| *** stephenfin has quit IRC | 05:44 | |
| *** dgonzalez has quit IRC | 05:44 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: Add '--no-live' and '--force' option in 'server migrate' https://review.openstack.org/427565 | 05:45 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: Add '--no-live' and '--force' option in 'server migrate' https://review.openstack.org/427565 | 05:45 |
| *** stephenfin has joined #openstack-sdks | 05:45 | |
| *** dgonzalez has joined #openstack-sdks | 05:46 | |
| openstackgerrit | Merged openstack/keystoneauth master: Optimize the link address https://review.openstack.org/473745 | 05:54 |
| *** markvoelker has quit IRC | 06:00 | |
| *** baffle has quit IRC | 06:03 | |
| *** baffle has joined #openstack-sdks | 06:03 | |
| *** gouthamr has quit IRC | 06:14 | |
| *** tovin07_ has joined #openstack-sdks | 06:17 | |
| openstackgerrit | lan proposed openstack/service-types-authority master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/480846 | 06:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-openstackclient master: List/show all server migration types https://review.openstack.org/450119 | 06:47 |
| *** markvoelker has joined #openstack-sdks | 06:58 | |
| *** bhagyashri_s has quit IRC | 07:00 | |
| *** chenyb4 has quit IRC | 07:10 | |
| *** chenyb4 has joined #openstack-sdks | 07:12 | |
| *** chenying_ has joined #openstack-sdks | 07:12 | |
| *** chenying has quit IRC | 07:16 | |
| *** jpich has joined #openstack-sdks | 07:19 | |
| openstackgerrit | Spencer Yu proposed openstack/python-openstackclient master: Add the other commands for karbor osc plugin https://review.openstack.org/480879 | 07:28 |
| *** markvoelker has quit IRC | 07:30 | |
| *** frickler_ is now known as frickler | 07:44 | |
| *** d0ugal_ has quit IRC | 07:46 | |
| *** d0ugal has joined #openstack-sdks | 07:46 | |
| *** d0ugal has quit IRC | 07:46 | |
| *** d0ugal has joined #openstack-sdks | 07:46 | |
| *** ralonsoh has joined #openstack-sdks | 07:46 | |
| *** e0ne has joined #openstack-sdks | 07:59 | |
| *** mvpnitesh has quit IRC | 08:20 | |
| *** markvoelker has joined #openstack-sdks | 08:27 | |
| *** snecklifter has joined #openstack-sdks | 08:34 | |
| *** snecklifter has quit IRC | 08:41 | |
| *** RuiChen has joined #openstack-sdks | 08:42 | |
| *** markvoelker has quit IRC | 09:02 | |
| *** dfflanders has joined #openstack-sdks | 09:04 | |
| *** mvpnitesh has joined #openstack-sdks | 09:16 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 09:37 | |
| *** snecklifter has joined #openstack-sdks | 09:48 | |
| *** dfflanders has quit IRC | 09:50 | |
| *** markvoelker has joined #openstack-sdks | 09:59 | |
| *** tovin07_ has quit IRC | 10:05 | |
| *** jpich_ has joined #openstack-sdks | 10:05 | |
| *** jpich has quit IRC | 10:08 | |
| *** cdent has joined #openstack-sdks | 10:11 | |
| *** mvpnitesh has quit IRC | 10:14 | |
| *** mvpnitesh has joined #openstack-sdks | 10:19 | |
| *** jpich_ is now known as jpich | 10:25 | |
| *** mvpnitesh has quit IRC | 10:26 | |
| *** mvpnitesh has joined #openstack-sdks | 10:27 | |
| *** markvoelker has quit IRC | 10:32 | |
| *** markvoelker has joined #openstack-sdks | 11:02 | |
| snecklifter | hmmm, docs.o.o is having a bad day it appears | 11:26 |
| *** annp has quit IRC | 12:07 | |
| *** mvpnitesh has quit IRC | 12:24 | |
| *** mvpnitesh has joined #openstack-sdks | 12:33 | |
| *** chlong_ has joined #openstack-sdks | 12:36 | |
| *** mvpnitesh has quit IRC | 12:39 | |
| *** gouthamr has joined #openstack-sdks | 13:18 | |
| *** rate has joined #openstack-sdks | 13:28 | |
| *** rate is now known as chenyb4_ | 13:28 | |
| *** chenyb4__ has joined #openstack-sdks | 13:39 | |
| *** chenyb4_ has quit IRC | 13:42 | |
| *** chenyb4 has quit IRC | 13:51 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Add the other commands for karbor osc plugin https://review.openstack.org/480879 | 13:51 |
| *** chenyb4 has joined #openstack-sdks | 13:52 | |
| *** edleafe- is now known as edleafe | 13:52 | |
| *** chenyb4 has quit IRC | 13:59 | |
| *** bobh has joined #openstack-sdks | 14:12 | |
| *** mvpnitesh has joined #openstack-sdks | 14:16 | |
| snecklifter | stevemar: ping, would you be able to +W that backport pls? https://review.openstack.org/#/c/480595/ | 15:08 |
| stevemar | snecklifter: done | 15:10 |
| snecklifter | stevemar: many thanks | 15:11 |
| snecklifter | seanhandley: see^^? some people _dont_ demand beer for reviews... | 15:11 |
| *** e0ne has quit IRC | 15:13 | |
| seanhandley | they're missing a trick! | 15:17 |
| openstackgerrit | Merged openstack/python-openstackclient master: Allow objects to be streamed to stdout https://review.openstack.org/476199 | 15:24 |
| *** reedip has quit IRC | 15:24 | |
| *** e0ne has joined #openstack-sdks | 15:28 | |
| *** e0ne has quit IRC | 15:28 | |
| *** reedip has joined #openstack-sdks | 15:38 | |
| stevemar | snecklifter: damn, missed out on a beer! | 15:45 |
| snecklifter | stevemar: ok, next time you are in Manchester, England... | 15:45 |
| stevemar | if i only had a boat | 15:46 |
| snecklifter | you need one in Manchester, never stops raining | 15:46 |
| *** jpich has quit IRC | 15:49 | |
| elmiko | edleafe, cdent, are we meeting today? | 16:02 |
| cdent | oh yeah | 16:02 |
| cdent | my calendar didn't warn me | 16:02 |
| elmiko | XD | 16:02 |
| elmiko | i started the meeting already | 16:02 |
| *** rajathagasthya has joined #openstack-sdks | 16:17 | |
| cdent | elmiko, edleafe : https://etherpad.openstack.org/p/api-wg-newsletter | 16:26 |
| * elmiko looks | 16:27 | |
| elmiko | cdent: lgtm | 16:28 |
| elmiko | thanks | 16:28 |
| edleafe | cdent: Not as witty as your usual output, but given your layoff, acceptable | 16:28 |
| cdent | cheers, I'll try to do better next time | 16:29 |
| *** mvpnitesh has quit IRC | 16:30 | |
| efried | mordred Are three-part version numbers (e.g. v1.2.3) okay or not? | 16:33 |
| efried | or four, or five...? | 16:33 |
| *** ralonsoh has quit IRC | 16:34 | |
| *** rajathag_ has joined #openstack-sdks | 16:41 | |
| *** snecklifter has quit IRC | 16:42 | |
| *** rajathagasthya has quit IRC | 16:42 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: Network tag support https://review.openstack.org/461195 | 17:25 |
| *** chenyb4__ has quit IRC | 17:27 | |
| *** chenyb4_ has joined #openstack-sdks | 17:28 | |
| *** chenyb4_ has quit IRC | 17:32 | |
| *** hoangcx has quit IRC | 17:33 | |
| amotoki | is there a plan to release a new version of cliff? | 17:42 |
| amotoki | osc and neutronclient (possibly other osc plugins) can use the sphinxext to generate CLI reference automatically. it reduces developer boring effort a lot. | 17:44 |
| *** rajathag_ has quit IRC | 17:48 | |
| *** hoangcx has joined #openstack-sdks | 17:49 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: Use openstackdocstheme in release note https://review.openstack.org/481173 | 17:53 |
| *** dave-mccowan has joined #openstack-sdks | 18:02 | |
| *** rajathagasthya has joined #openstack-sdks | 18:05 | |
| openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: Use openstackdocstheme in release note https://review.openstack.org/481173 | 18:13 |
| *** hoangcx has quit IRC | 18:53 | |
| dtroyer | amotoki: yes, soon. I've got a question on https://review.openstack.org/479157 yet | 18:57 |
| dtroyer | dhellmann: any opinions on ^^^^ ?? | 18:58 |
| mordred | efried: they are not | 18:58 |
| dhellmann | dtroyer : looking | 18:58 |
| efried | mordred Okay. Also looking at other (lack of) validation in discover.py | 18:59 |
| mordred | efried: ah - so - discover.py should likely be more permissive if it sensibly can | 18:59 |
| mordred | efried: I don't think a service returning a three-part version should break discover.py - but I also think we should be clear in docs that it's not 'supported' | 19:00 |
| efried | mordred I'm working on a change to address some of the (post-merge) comments I put on https://review.openstack.org/#/c/469087/14 | 19:00 |
| mordred | efried: woot! | 19:01 |
| efried | mordred How would you feel about a log warning if len(version_tuple) != 2 ? | 19:01 |
| dtroyer | osc meeting in #openstack-meeting if anyone is around... | 19:02 |
| *** hoangcx has joined #openstack-sdks | 19:06 | |
| *** cdent has quit IRC | 19:11 | |
| mordred | efried: as long as it's squelchable - the big isssue is as a consumer of a cloud, if the cloud decides for whatever reason to return a version triple, I can't actually do anything about it, and now I've got warnings spamming me | 19:11 |
| efried | mordred Mm, fair enough. | 19:11 |
| mordred | efried: as a real-world example of this - there's a warning in python-requests about subjectaltname in ssl certs that gets tripped by the certs deployed on rackspace public cloud | 19:12 |
| mordred | efried: which is why we have the requestsexceptions lib - which has an easy-button for making that go away | 19:12 |
| stevemar | amotoki: +2! just need dtroyer to look at it now :) | 19:15 |
| dtroyer | stevemar: join us in #openstack-meeting if you have a minute | 19:16 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add tests for display command classes and hooks https://review.openstack.org/481192 | 19:17 |
| efried | mordred But version tuples should have at *least* two parts, yes? | 19:22 |
| efried | Today if you normalize_version_number([1]) you get (1,) | 19:22 |
| mordred | efried: you'd think - but no - versions in urls often only have one number (v2) | 19:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-api-ref master: Updated from global requirements https://review.openstack.org/478040 | 19:34 |
| mordred | efried: and the normalize_version code is used as part of matching requested versions with found versions | 19:34 |
| efried | mordred But in discover.py, you're specifically translating "v2" to (2, 0) | 19:34 |
| mordred | yup | 19:34 |
| mordred | we can't change that- it's pre-existing keystoneauth behavior | 19:34 |
| efried | So you want "v2" => (2, 0) and "2" => (2, 0) but [2] => (2,) ? | 19:35 |
| mordred | hrm. no - that seems like a bug | 19:35 |
| efried | okay, cool, swhat I'm fixing. | 19:35 |
| mordred | kk :) | 19:35 |
| efried | mordred Honestly, I'm having trouble keeping straight which pieces of data are coming from where, and where they're going to. | 19:36 |
| mordred | efried: yah- doing a refactor inside of discovery.py is overdue | 19:37 |
| efried | mordred Here's another poser for ya. | 19:38 |
| efried | mordred In Discover.version_data - if max_version is set, but "" (empty string) or 0 or None, do we want to behave same as if it's absent (i.e. default to using the `version` field) or use actual None, which (I think) equates to `latest` ? | 19:41 |
| efried | mordred I would think we would want to do the former (especially if `version` is present). But today I believe we're doing the latter. | 19:43 |
| efried | Because {'key': None}.get('key', 'default') returns None, not 'default'. | 19:43 |
| mordred | efried: if max_version and version are both set, that's an error. if max_version is set but is set to "" or 0 - I think that's super confusing and we should throw an error | 19:45 |
| mordred | efried: and we haven't released with max_version yet - so I think making that change should be fine | 19:46 |
| efried | mordred Okay, none of that is throwing an error today. So can I add those checks (for mutual exclusivity and bogus max_version)? | 19:46 |
| mordred | efried: mutual exclusivity should have a check ... http://git.openstack.org/cgit/openstack/keystoneauth/tree/keystoneauth1/discover.py#n116 | 19:48 |
| mordred | efried: but you can certianly make it better! | 19:48 |
| efried | mordred Okay, cool. I haven't grokked the various code paths here, but it looks like that validation won't get run if Discover.version_data is called directly. | 19:51 |
| openstackgerrit | Dean Troyer proposed openstack/cliff master: add tests for display command classes and hooks https://review.openstack.org/481192 | 19:51 |
| efried | efried In fact, I just wrote a test case to prove it. | 19:52 |
| efried | Well | 19:52 |
| efried | At least it doesn't trigger for 'max_version': '' | 19:52 |
| efried | which makes sense in light of the loose boolean checks in _normalize_version_args | 19:52 |
| mordred | efried: ah - awesome. well that's definitely a bug then | 19:53 |
| efried | mordred Confirmed even with a real value there. | 19:53 |
| efried | I'll work on it. | 19:53 |
| mordred | efried: thank you for being so thorough! | 19:54 |
| efried | mordred Sure thing; hope I'm not just spinning my wheels. If nothing else, it's helping me understand the code. | 19:54 |
| mordred | efried: you're definitely not spinning your wheels - and you understanding the code is a *GREAT* outcome | 19:55 |
| efried | mordred get_version_data, get_versioned_data, version_data, version_data_for -- Can I get an ugh? | 20:22 |
| *** hoangcx has quit IRC | 20:22 | |
| mordred | efried: yah- sorry about that | 20:23 |
| *** fzdarsky_ is now known as fzdarsky|afk | 20:36 | |
| *** hoangcx has joined #openstack-sdks | 20:36 | |
| openstackgerrit | Monty Taylor proposed openstack/service-types-authority master: Improve validation & documentation https://review.openstack.org/478556 | 20:44 |
| openstackgerrit | Merged openstack/service-types-authority master: Improve validation & documentation https://review.openstack.org/478556 | 20:51 |
| openstackgerrit | Eric Fried proposed openstack/service-types-authority master: Remove validate.py main() https://review.openstack.org/478562 | 21:00 |
| *** cdent has joined #openstack-sdks | 21:02 | |
| *** cdent has quit IRC | 21:13 | |
| openstackgerrit | Monty Taylor proposed openstack/service-types-authority master: Add ./ to latest link https://review.openstack.org/481283 | 21:22 |
| openstackgerrit | Gage Hugo proposed openstack/python-openstackclient master: WIP - Add project tags functionality https://review.openstack.org/481284 | 21:22 |
| openstackgerrit | Merged openstack/service-types-authority master: Add ./ to latest link https://review.openstack.org/481283 | 21:31 |
| efried | mordred The return from discover.get_version_data - that's allowed to say max_version='latest', right? | 21:50 |
| efried | kinda looks like not. | 21:52 |
| mordred | efried: the top-level get_version_data? | 21:52 |
| efried | yeah | 21:52 |
| mordred | nope - that'll only have values that show up in version discovery documents | 21:53 |
| *** hoangcx has quit IRC | 21:53 | |
| openstackgerrit | Monty Taylor proposed openstack/service-types-authority master: Stop publishing yaml file https://review.openstack.org/481305 | 21:58 |
| *** dave-mccowan has quit IRC | 22:05 | |
| *** hoangcx has joined #openstack-sdks | 22:08 | |
| *** bobh has quit IRC | 22:11 | |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: normalize_version_number([1]) => (1, 0) and docs https://review.openstack.org/481309 | 22:19 |
| efried | mordred ^ it's a start. | 22:19 |
| efried | mordred Is there some reason you didn't want Discover.versioned_data_for() to return an EndpointData? | 22:24 |
| mordred | efried: great patch! I left a few comments - mostly centered around one thing that will likely make you punch yourself in the face | 22:24 |
| mordred | efried: I'm not coming up with a good reason right off the bat - it's probably a result of how that stack was developed | 22:26 |
| efried | mordred Possibly you were trying to keep it consistent with data_for(), which it seems to supersede. But it seems like since you're superseding anyway, you might as well make it prettier. I haven't dug all the way in yet, though. | 22:27 |
| mordred | efried: originally versioned_data_for was just an update to data_for | 22:27 |
| efried | right | 22:27 |
| mordred | efried: but then we realized that it was changing data_for's behavior | 22:27 |
| mordred | which we can't do | 22:27 |
| efried | So might as well shoot the whole hog. | 22:27 |
| mordred | so the solution was to just split it out - which we could do without reworking the whole stack | 22:28 |
| mordred | HOWEVER - we're not released yet -so reworking it to return an EndpointData potentially makes sense | 22:28 |
| mordred | (like you say - might was well shoot the whole hog) | 22:28 |
| mordred | efried: might be a smidge tricky given how get_versioned_data works ... but if you see a path - go for it | 22:30 |
| efried | k | 22:30 |
| openstackgerrit | Dean Troyer proposed openstack/cliff master: add tests for display command classes and hooks https://review.openstack.org/481192 | 22:32 |
| openstackgerrit | Rajath Agasthya proposed openstack/cliff master: Run hooks for DisplayCommandBase https://review.openstack.org/479157 | 22:40 |
| openstackgerrit | Rajath Agasthya proposed openstack/cliff master: add tests for display command classes and hooks https://review.openstack.org/481192 | 22:40 |
| *** hoangcx has quit IRC | 23:24 | |
| *** hoangcx has joined #openstack-sdks | 23:40 | |
| *** efried has quit IRC | 23:41 | |
| -openstackstatus- NOTICE: nb03.openstack.org has been cleaned up and rebooted, and should return to building rotation | 23:44 | |
| *** efried has joined #openstack-sdks | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!