| *** markvoelker has quit IRC | 00:07 | |
| *** adriant has joined #openstack-sdks | 00:19 | |
| *** hoangcx has joined #openstack-sdks | 00:51 | |
| *** dave-mccowan has joined #openstack-sdks | 00:57 | |
| *** dave-mccowan has quit IRC | 01:02 | |
| *** markvoelker has joined #openstack-sdks | 01:03 | |
| *** fzdarsky_ has joined #openstack-sdks | 01:30 | |
| *** fzdarsky has quit IRC | 01:33 | |
| *** chlong has quit IRC | 01:50 | |
| *** salv-orlando has joined #openstack-sdks | 02:05 | |
| *** salv-orl_ has quit IRC | 02:08 | |
| *** Shrews has quit IRC | 02:20 | |
| *** Shrews has joined #openstack-sdks | 02:23 | |
| *** marst has joined #openstack-sdks | 02:27 | |
| *** annp has joined #openstack-sdks | 02:36 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/python-openstacksdk master: Remove support for py34 https://review.openstack.org/471571 | 03:39 |
|---|---|---|
| reedip | stevemar : o/ | 03:40 |
| *** marst has quit IRC | 03:49 | |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367 | 04:03 |
| *** adriant has quit IRC | 04:35 | |
| *** adriant has joined #openstack-sdks | 04:39 | |
| *** adriant has quit IRC | 04:40 | |
| *** dims has quit IRC | 05:09 | |
| stevemar | hey reedip | 05:11 |
| *** gildub_ has quit IRC | 05:27 | |
| *** dims has joined #openstack-sdks | 05:41 | |
| *** gildub has joined #openstack-sdks | 06:10 | |
| *** salv-orlando has quit IRC | 06:25 | |
| *** gildub has quit IRC | 06:46 | |
| *** salv-orlando has joined #openstack-sdks | 07:09 | |
| *** salv-orl_ has joined #openstack-sdks | 07:32 | |
| *** salv-orlando has quit IRC | 07:37 | |
| *** jpich has joined #openstack-sdks | 07:53 | |
| *** jamielennox is now known as jamielennox|away | 08:50 | |
| *** cdent has joined #openstack-sdks | 09:08 | |
| openstackgerrit | Merged openstack/keystoneauth master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/470663 | 09:08 |
| *** jamielennox|away is now known as jamielennox | 09:10 | |
| *** sdague has joined #openstack-sdks | 09:31 | |
| *** e0ne has joined #openstack-sdks | 09:31 | |
| *** ralonsoh has joined #openstack-sdks | 09:55 | |
| openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341 | 09:56 |
| *** fzdarsky_ is now known as fzdarsky|lunch | 09:58 | |
| *** cdent has quit IRC | 10:01 | |
| *** annp has quit IRC | 10:06 | |
| *** hoangcx has quit IRC | 10:40 | |
| *** hoangcx has joined #openstack-sdks | 10:43 | |
| *** cdent has joined #openstack-sdks | 10:44 | |
| *** hoangcx has quit IRC | 10:44 | |
| *** e0ne has quit IRC | 11:04 | |
| *** rate has joined #openstack-sdks | 11:05 | |
| *** rate is now known as chenyb4_ | 11:08 | |
| *** jkilpatr has joined #openstack-sdks | 11:10 | |
| *** chenyb4_ has quit IRC | 11:21 | |
| *** chenyb4_ has joined #openstack-sdks | 11:23 | |
| openstackgerrit | Akihiro Motoki proposed openstack/cliff master: sphinxext: Add 'application' option to the autoprogram directive https://review.openstack.org/469726 | 11:31 |
| *** fzdarsky|lunch is now known as fzdarsky | 11:38 | |
| *** chenyb4_ has quit IRC | 11:50 | |
| *** chlong has joined #openstack-sdks | 12:02 | |
| openstackgerrit | Dinesh Bhor proposed openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054 | 12:24 |
| openstackgerrit | Merged openstack/python-openstacksdk master: Remove support for py34 https://review.openstack.org/471571 | 12:26 |
| *** 21WAACJDQ has joined #openstack-sdks | 12:30 | |
| Dinesh_Bhor | briancurtin, Qiming: thanks for review. Addressed the review comments: https://review.openstack.org/#/c/319054/5 | 12:35 |
| briancurtin | Dinesh_Bhor: my question was more about why line 162 in _proxy.py is even needed. is it? | 12:36 |
| Dinesh_Bhor | briancurtin: yes, otherwise how can I get the image to update | 12:37 |
| briancurtin | Dinesh_Bhor: in all cases in all other update calls across all other services around the whole SDK, there is an assumption that if you’re calling update on something, you’re calling it with either a resource instance that you obtained in some other way or you have the ID of a resource you obtained in some other way | 12:39 |
| briancurtin | you would have done `x = get_blah(…); update_blah(x, name=“foo”)` | 12:39 |
| briancurtin | so update doing an extra get on that line is what I’m wondering about. i guess it could be necessary if there’s something i don’t understand about it, but that’s what i’d like to know | 12:40 |
| *** 21WAACJDQ has quit IRC | 12:40 | |
| *** chenyb4_ has joined #openstack-sdks | 12:40 | |
| *** chenyb4_ has quit IRC | 12:41 | |
| *** salv-orl_ has quit IRC | 12:49 | |
| *** salv-orlando has joined #openstack-sdks | 12:50 | |
| Dinesh_Bhor | briancurtin: sorry but right now I am not able to visualize what you are trying to say. I will check this part. | 12:52 |
| briancurtin | Dinesh_Bhor: for example, update_server just updates a server. it doesn’t do a get. same with anything in there named update_* — https://github.com/openstack/python-openstacksdk/blob/master/openstack/compute/v2/_proxy.py#L414 | 12:53 |
| briancurtin | Dinesh_Bhor: actually, i think i know what you’re trying to do now. 1 sec | 12:54 |
| *** salv-orlando has quit IRC | 12:54 | |
| briancurtin | Dinesh_Bhor: you should do something like https://github.com/openstack/python-openstacksdk/blob/master/openstack/compute/v2/_proxy.py#L343 — so `img = self._get_resource(_image.Image, image); img.update_image(self._session, img, **attrs) | 12:55 |
| briancurtin | the way you have it would be doing an extra HTTP GET call, when we can just use the internal method self._get_resource to construct a resource instance from a string ID if that’s what we have (or it just returns the resource instance if it was given an instance), which avoids the extra roundtrip | 12:57 |
| Dinesh_Bhor | briancurtin: ohh, now I got your point. | 12:58 |
| briancurtin | Dinesh_Bhor: you might want to change the update_image name in image/v2/image.py to just update(…). that way we don’t have the proxy update_image calling into image.update_image. it gets a bit wordy that way | 13:00 |
| Dinesh_Bhor | briancurtin: yeah, I will change that | 13:01 |
| briancurtin | Dinesh_Bhor: otherwise i think this is good. i’ll take a look again after your next changes | 13:01 |
| Dinesh_Bhor | briancurtin: yes, thanks. I will update the patch soon | 13:02 |
| *** e0ne has joined #openstack-sdks | 13:06 | |
| *** bobh has joined #openstack-sdks | 13:14 | |
| openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Clean up the changes of os.environ in functional tests https://review.openstack.org/471341 | 13:17 |
| *** e0ne has quit IRC | 13:26 | |
| *** e0ne has joined #openstack-sdks | 13:28 | |
| *** dave-mccowan has joined #openstack-sdks | 13:37 | |
| *** dave-mccowan has quit IRC | 13:41 | |
| *** chlong has quit IRC | 13:43 | |
| *** dave-mccowan has joined #openstack-sdks | 13:45 | |
| openstackgerrit | Dinesh Bhor proposed openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054 | 13:46 |
| Dinesh_Bhor | briancurtin: ^^ Please take a look at it when you get time | 14:04 |
| briancurtin | Dinesh_Bhor: that looks good! i assume the tests will pass but will wait for them to show up and then it’s a +2 | 14:11 |
| *** dave-mccowan has quit IRC | 14:12 | |
| *** hongbin has joined #openstack-sdks | 14:50 | |
| *** marst has joined #openstack-sdks | 14:57 | |
| *** ralonsoh_ has joined #openstack-sdks | 15:04 | |
| *** ralonsoh has quit IRC | 15:07 | |
| *** ralonsoh_ is now known as ralonsoh | 15:07 | |
| *** dave-mccowan has joined #openstack-sdks | 15:21 | |
| *** salv-orlando has joined #openstack-sdks | 15:22 | |
| *** chlong has joined #openstack-sdks | 15:27 | |
| *** reedip_ has joined #openstack-sdks | 15:39 | |
| *** fzdarsky is now known as fzdarsky|afk | 16:01 | |
| *** dave-mccowan has quit IRC | 16:05 | |
| openstackgerrit | Akihiro Motoki proposed openstack/cliff master: sphinxext: Add 'application' option to the autoprogram directive https://review.openstack.org/469726 | 16:12 |
| openstackgerrit | Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367 | 16:22 |
| *** reedip_ has quit IRC | 16:30 | |
| *** jpich has quit IRC | 16:36 | |
| *** jkilpatr has quit IRC | 16:36 | |
| *** jkilpatr has joined #openstack-sdks | 16:40 | |
| *** dave-mccowan has joined #openstack-sdks | 16:42 | |
| *** ediardo has quit IRC | 16:45 | |
| *** salv-orlando has quit IRC | 16:51 | |
| *** e0ne has quit IRC | 16:57 | |
| openstackgerrit | Merged openstack/python-openstacksdk master: Fix update_image unsupported media type https://review.openstack.org/319054 | 17:00 |
| *** ralonsoh has quit IRC | 17:06 | |
| *** salv-orlando has joined #openstack-sdks | 17:14 | |
| *** cdent has quit IRC | 17:25 | |
| *** e0ne has joined #openstack-sdks | 17:39 | |
| *** dtantsur is now known as dtantsur|afk | 17:50 | |
| *** e0ne has quit IRC | 18:02 | |
| *** dave-mccowan has quit IRC | 18:12 | |
| *** e0ne has joined #openstack-sdks | 18:19 | |
| *** salv-orlando has quit IRC | 18:21 | |
| *** salv-orlando has joined #openstack-sdks | 18:21 | |
| *** salv-orlando has quit IRC | 18:25 | |
| *** dave-mccowan has joined #openstack-sdks | 19:23 | |
| *** salv-orlando has joined #openstack-sdks | 19:26 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear some excessive connection counts while we debug the intermittent request failures reported over the past few minutes | 20:06 | |
| dhellmann | dtroyer, stevemar : do the cliff tests pass for you on master? I'm seeing a failure with the smart help formatter | 20:15 |
| dtroyer | dhellmann: I'll check | 20:18 |
| dhellmann | dtroyer : oh, it fails for me because I have a wide terminal | 20:18 |
| dhellmann | and it's not forcing the width | 20:19 |
| *** e0ne_ has joined #openstack-sdks | 20:19 | |
| dhellmann | the test, that is | 20:19 |
| *** marst_ has joined #openstack-sdks | 20:20 | |
| *** e0ne has quit IRC | 20:22 | |
| *** marst has quit IRC | 20:23 | |
| *** e0ne has joined #openstack-sdks | 20:40 | |
| *** e0ne has quit IRC | 20:42 | |
| *** e0ne_ has quit IRC | 20:42 | |
| *** salv-orl_ has joined #openstack-sdks | 20:43 | |
| *** e0ne has joined #openstack-sdks | 20:44 | |
| *** salv-orlando has quit IRC | 20:46 | |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: make smart help formatter test deterministic https://review.openstack.org/471916 | 21:06 |
| openstackgerrit | Doug Hellmann proposed openstack/cliff master: add --fit-width option to table formatter https://review.openstack.org/471917 | 21:06 |
| *** sdague has quit IRC | 21:16 | |
| *** e0ne has quit IRC | 21:19 | |
| *** frickler_ has joined #openstack-sdks | 21:26 | |
| *** Hazelesque_ has joined #openstack-sdks | 21:26 | |
| *** RuiChen has quit IRC | 21:29 | |
| *** frickler has quit IRC | 21:29 | |
| *** Hazelesque has quit IRC | 21:29 | |
| *** jgriffith has quit IRC | 21:29 | |
| *** Kevin_Zheng has quit IRC | 21:29 | |
| *** jgriffith_ has joined #openstack-sdks | 21:29 | |
| *** hongbin has quit IRC | 21:47 | |
| *** hongbin has joined #openstack-sdks | 21:51 | |
| *** bobh has quit IRC | 22:02 | |
| *** chlong has quit IRC | 22:32 | |
| *** jkilpatr has quit IRC | 22:34 | |
| *** salv-orl_ has quit IRC | 22:37 | |
| *** salv-orlando has joined #openstack-sdks | 22:37 | |
| *** salv-orlando has quit IRC | 22:41 | |
| *** marst_ has quit IRC | 22:52 | |
| *** bobh has joined #openstack-sdks | 23:10 | |
| *** openstack has joined #openstack-sdks | 23:15 | |
| *** RuiChen has joined #openstack-sdks | 23:21 | |
| *** Kevin_Zheng has joined #openstack-sdks | 23:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!