| *** bobh has quit IRC | 00:38 | |
| jamielennox | efried: assume you've left, why use the oslo conf options instead of the keystoneauth options in https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/adapter.py ? | 00:41 |
|---|---|---|
| *** salv-orlando has joined #openstack-sdks | 00:42 | |
| efried | jamielennox Is that not what I'm doing? | 00:42 |
| jamielennox | efried: so in keystoneauth we define our own option type: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/opts.py | 00:43 |
| jamielennox | the idea being that these things can be available on CLI, oslo.config, and in the weird ways glance does things | 00:43 |
| efried | jamielennox Ohh, I see now. | 00:44 |
| jamielennox | i mean there might be no reason to provide adapter options via CLI | 00:44 |
| efried | jamielennox I'm missing this line: https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/session.py@159 | 00:44 |
| efried | jamielennox Yeah, not providing CLI options right now, but that doesn't mean we never will. And I should do it consistently with how loading.session is. | 00:45 |
| jamielennox | efried: so session is not necessarily the best one to copy | 00:45 |
| jamielennox | or maybe it is :) | 00:45 |
| efried | Waidaminute - I am already doing cfg = _utils.get_oslo_config() | 00:46 |
| efried | jamielennox https://review.openstack.org/#/c/460337/3/keystoneauth1/loading/adapter.py@51 | 00:46 |
| *** salv-orlando has quit IRC | 00:46 | |
| efried | So okay, you're saying I should *not* do that the same way as session does? /me confused. | 00:46 |
| jamielennox | efried: so the idea with all of this loading as mentioned is that there are a number of ways you can do it, one of which is oslo.config | 00:47 |
| jamielennox | if you look at the most simple plugin you see it returns keystoneauth opts from get_options: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/_plugins/admin_token.py#L33 | 00:47 |
| jamielennox | then when dealing with oslo.config specifically it converts the ksa opt to an oslo opt: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/conf.py#L128 | 00:49 |
| jamielennox | this means that os-c-c can use ksa loading without worrying about oslo.config | 00:49 |
| jamielennox | now there are times where you want oslo.config to behave differently to just the standard ksa opts, and you can override it with the oslo_config_opts that you're doing - and that's fine, that's what session does because we matched old variables names to new variable names | 00:50 |
| jamielennox | just in this case it looks like a really simple pass through (you're not manipulating variables), so you could probably just do it as ksa opts | 00:51 |
| jamielennox | so i'm just wondering if that's planned or just the result of looking at session | 00:51 |
| efried | jamielennox Result of looking at session, for sure. | 00:52 |
| *** hongbin has quit IRC | 00:52 | |
| efried | jamielennox Though looking at loading.conf, it appears to be kinda auth-specific. | 00:52 |
| jamielennox | efried: yea, i'm just having another look through that as well | 00:53 |
| jamielennox | it was definitely designed around auth | 00:53 |
| jamielennox | i never considered non-auth loading at the time | 00:54 |
| efried | Okay. | 00:55 |
| efried | jamielennox I do have to bail before my wife gets steamed. If you want to leave comments in the review, or email me, or something, we can hash it out. | 00:55 |
| jamielennox | efried: yea, i'll try and have a closer look, just thought i'd see if you were here | 00:56 |
| jamielennox | thanks | 00:56 |
| * mordred hopes by steamed that efried is implying that if he stays on longer his wife will become upset, and not that if he stays on longer his wife will get cooked via steam, because that level of pressure seems really stressful | 01:01 | |
| *** yanyanhu has joined #openstack-sdks | 01:37 | |
| *** gildub has joined #openstack-sdks | 01:38 | |
| *** chlong has quit IRC | 01:50 | |
| *** jamielennox is now known as jamielennox|away | 01:59 | |
| *** jamielennox|away is now known as jamielennox | 02:13 | |
| *** markvoelker has quit IRC | 02:31 | |
| *** Kevin_Zheng has joined #openstack-sdks | 02:58 | |
| *** gildub has quit IRC | 03:15 | |
| *** dave-mccowan has quit IRC | 03:25 | |
| *** gildub has joined #openstack-sdks | 03:33 | |
| *** Dinesh_Bhor has joined #openstack-sdks | 03:47 | |
| *** hidekazu has joined #openstack-sdks | 03:58 | |
| *** hidekazu has quit IRC | 03:59 | |
| *** markvoelker has joined #openstack-sdks | 03:59 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Funcional tests: quota list https://review.openstack.org/461618 | 04:27 |
| *** salv-orlando has joined #openstack-sdks | 04:30 | |
| openstackgerrit | Robert van Leeuwen proposed openstack/python-openstackclient master: Fixes osc port set allowed-address for ports without previous set allowed address https://review.openstack.org/461364 | 05:08 |
| *** salv-orlando has quit IRC | 06:15 | |
| *** adriant has quit IRC | 06:35 | |
| *** e0ne has joined #openstack-sdks | 06:35 | |
| *** salv-orlando has joined #openstack-sdks | 07:20 | |
| *** Serlex has joined #openstack-sdks | 07:41 | |
| *** jamielennox is now known as jamielennox|away | 08:02 | |
| *** john-davidge has joined #openstack-sdks | 08:20 | |
| *** john-davidge has quit IRC | 08:20 | |
| *** jamielennox|away is now known as jamielennox | 08:22 | |
| *** john-davidge has joined #openstack-sdks | 08:24 | |
| *** e0ne has quit IRC | 08:34 | |
| *** e0ne has joined #openstack-sdks | 08:48 | |
| *** john-davidge has quit IRC | 08:58 | |
| *** cdent has joined #openstack-sdks | 09:00 | |
| *** john-davidge has joined #openstack-sdks | 09:01 | |
| *** john-davidge has quit IRC | 09:02 | |
| *** gildub has quit IRC | 09:15 | |
| *** john-davidge has joined #openstack-sdks | 09:26 | |
| *** fzdarsky has joined #openstack-sdks | 09:28 | |
| *** gildub has joined #openstack-sdks | 09:37 | |
| *** sdague has joined #openstack-sdks | 09:38 | |
| *** amit213 has quit IRC | 09:43 | |
| *** sindhu has quit IRC | 09:43 | |
| *** dasanind has quit IRC | 09:43 | |
| *** nikhil has quit IRC | 09:43 | |
| *** gildub has quit IRC | 09:45 | |
| *** salv-orl_ has joined #openstack-sdks | 09:52 | |
| *** salv-orlando has quit IRC | 09:55 | |
| *** nikhil has joined #openstack-sdks | 09:56 | |
| *** heyongli has quit IRC | 10:05 | |
| *** heyongli has joined #openstack-sdks | 10:13 | |
| *** fzdarsky has quit IRC | 10:13 | |
| *** amit213 has joined #openstack-sdks | 10:16 | |
| *** dasanind has joined #openstack-sdks | 10:17 | |
| *** sindhu has joined #openstack-sdks | 10:17 | |
| *** yanyanhu has quit IRC | 10:27 | |
| *** jkilpatr has quit IRC | 10:32 | |
| *** salv-orl_ has quit IRC | 10:39 | |
| *** e0ne has quit IRC | 10:45 | |
| *** Cagelin has joined #openstack-sdks | 11:03 | |
| *** jkilpatr has joined #openstack-sdks | 11:03 | |
| *** john-davidge has quit IRC | 11:15 | |
| *** john-davidge has joined #openstack-sdks | 11:36 | |
| *** e0ne has joined #openstack-sdks | 11:37 | |
| *** john-davidge has quit IRC | 11:40 | |
| *** e0ne has quit IRC | 11:44 | |
| *** gildub has joined #openstack-sdks | 11:48 | |
| *** dave-mccowan has joined #openstack-sdks | 12:05 | |
| *** Cagelin has quit IRC | 12:12 | |
| *** efried has quit IRC | 12:15 | |
| *** annegentle has quit IRC | 12:25 | |
| *** efried has joined #openstack-sdks | 12:28 | |
| efried | jamielennox You still around? | 12:34 |
| *** cdent has quit IRC | 12:46 | |
| *** gildub has quit IRC | 12:50 | |
| *** cdent has joined #openstack-sdks | 12:51 | |
| *** chlong has joined #openstack-sdks | 13:13 | |
| mordred | efried: he's in australia - so usually will only overlap early in the US morning or at the end of the day | 13:26 |
| efried | mordred Yeah, figured as much, but was worth a shot ;-) | 13:27 |
| efried | mordred If you have the cycles today, wanna take a look at those two changes? | 13:27 |
| efried | ksa [https://review.openstack.org/460337] and nova [https://review.openstack.org/458257] | 13:27 |
| mordred | efried: yes! I have a panel session in 45 minutes, but after that I totally will | 13:29 |
| efried | mordred Thanks! | 13:29 |
| *** openstackgerrit has quit IRC | 13:48 | |
| *** gouthamr has joined #openstack-sdks | 13:59 | |
| *** markvoelker has quit IRC | 14:04 | |
| *** annegentle has joined #openstack-sdks | 14:09 | |
| *** bobh has joined #openstack-sdks | 14:20 | |
| *** hongbin has joined #openstack-sdks | 14:20 | |
| *** markvoelker has joined #openstack-sdks | 14:30 | |
| *** salv-orlando has joined #openstack-sdks | 14:33 | |
| *** ameade has quit IRC | 14:43 | |
| *** NobodyCam has quit IRC | 14:43 | |
| *** etoews has quit IRC | 14:43 | |
| *** stevemar has quit IRC | 14:43 | |
| *** csatari has quit IRC | 14:44 | |
| *** peterstac has quit IRC | 14:44 | |
| *** ankur-gupta-f4 has quit IRC | 14:44 | |
| *** redrobot has quit IRC | 14:44 | |
| *** Shrews has quit IRC | 14:45 | |
| *** keekz has quit IRC | 14:45 | |
| *** Kevin_Zheng has quit IRC | 14:45 | |
| *** briancurtin has quit IRC | 14:45 | |
| *** lifeless has quit IRC | 14:47 | |
| *** sshank has quit IRC | 14:47 | |
| *** greghaynes has quit IRC | 14:47 | |
| *** lifeless has joined #openstack-sdks | 14:48 | |
| *** keekz has joined #openstack-sdks | 14:50 | |
| *** csatari has joined #openstack-sdks | 14:51 | |
| *** sshank has joined #openstack-sdks | 14:52 | |
| *** redrobot has joined #openstack-sdks | 14:52 | |
| *** redrobot is now known as Guest92102 | 14:52 | |
| *** Shrews has joined #openstack-sdks | 14:54 | |
| *** greghaynes has joined #openstack-sdks | 14:57 | |
| *** ameade has joined #openstack-sdks | 15:01 | |
| *** NobodyCam has joined #openstack-sdks | 15:01 | |
| *** etoews has joined #openstack-sdks | 15:07 | |
| *** openstackgerrit has joined #openstack-sdks | 15:10 | |
| openstackgerrit | Merged openstack/keystoneauth master: Introduce keystoneauth1.loading.adapter https://review.openstack.org/460337 | 15:10 |
| *** chlong has quit IRC | 15:13 | |
| *** annegentle has quit IRC | 15:22 | |
| *** chlong has joined #openstack-sdks | 15:29 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Functional tests: Identity v2 and DevStack https://review.openstack.org/461826 | 15:32 |
| *** amotoki has joined #openstack-sdks | 15:40 | |
| *** markvoelker has quit IRC | 15:47 | |
| *** peterstac has joined #openstack-sdks | 15:49 | |
| *** stevemar has joined #openstack-sdks | 15:50 | |
| *** salv-orl_ has joined #openstack-sdks | 15:52 | |
| *** markvoelker has joined #openstack-sdks | 15:53 | |
| *** Serlex has quit IRC | 15:54 | |
| *** salv-orlando has quit IRC | 15:54 | |
| *** annegentle has joined #openstack-sdks | 15:58 | |
| *** chlong has quit IRC | 16:04 | |
| *** amotoki has quit IRC | 16:21 | |
| *** Kevin_Zheng has joined #openstack-sdks | 16:44 | |
| *** salv-orl_ has quit IRC | 16:45 | |
| *** ankur-gupta-f4 has joined #openstack-sdks | 16:45 | |
| *** briancurtin has joined #openstack-sdks | 16:46 | |
| openstackgerrit | Ed Leafe proposed openstack/api-wg master: Microversions: add next_min_version field in version body https://review.openstack.org/446138 | 16:57 |
| openstackgerrit | Ed Leafe proposed openstack/api-wg master: Microversions: add signal when raising minimum version https://review.openstack.org/446138 | 17:02 |
| *** e0ne has joined #openstack-sdks | 17:09 | |
| *** erlon has joined #openstack-sdks | 17:11 | |
| *** e0ne has quit IRC | 17:15 | |
| *** salv-orlando has joined #openstack-sdks | 17:51 | |
| *** chlong has joined #openstack-sdks | 18:03 | |
| *** jamielennox is now known as jamielennox|away | 18:22 | |
| *** e0ne has joined #openstack-sdks | 19:05 | |
| *** salv-orlando has quit IRC | 19:05 | |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Funcional tests: quota list https://review.openstack.org/461618 | 19:09 |
| openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Nova-net functional tests: aggregates https://review.openstack.org/461491 | 19:09 |
| *** annegentle has quit IRC | 19:20 | |
| *** purplerbot has quit IRC | 19:43 | |
| *** markvoelker has quit IRC | 19:50 | |
| *** salv-orlando has joined #openstack-sdks | 19:57 | |
| *** Serlex has joined #openstack-sdks | 20:04 | |
| *** gouthamr has quit IRC | 20:13 | |
| openstackgerrit | Merged openstack/python-openstackclient master: Functional tests: Identity v2 and DevStack https://review.openstack.org/461826 | 20:17 |
| *** annegentle has joined #openstack-sdks | 20:19 | |
| *** jkilpatr has quit IRC | 20:22 | |
| *** markvoelker has joined #openstack-sdks | 20:32 | |
| *** markvoelker has quit IRC | 20:33 | |
| *** markvoelker has joined #openstack-sdks | 20:34 | |
| *** e0ne has quit IRC | 20:46 | |
| *** annegentle has quit IRC | 20:47 | |
| *** jamielennox|away is now known as jamielennox | 21:01 | |
| *** chlong has quit IRC | 21:01 | |
| *** annegentle has joined #openstack-sdks | 21:03 | |
| *** jkilpatr has joined #openstack-sdks | 21:11 | |
| *** chlong has joined #openstack-sdks | 21:16 | |
| *** adriant has joined #openstack-sdks | 21:30 | |
| *** Serlex has quit IRC | 21:34 | |
| *** annegentle has quit IRC | 21:44 | |
| *** annegentle has joined #openstack-sdks | 21:44 | |
| *** salv-orl_ has joined #openstack-sdks | 21:52 | |
| *** salv-orlando has quit IRC | 21:54 | |
| openstackgerrit | Ed Leafe proposed openstack/api-wg master: Microversions: add next_min_version field in version body https://review.openstack.org/446138 | 22:08 |
| *** gouthamr has joined #openstack-sdks | 22:12 | |
| *** bobh has quit IRC | 22:13 | |
| *** erlon has quit IRC | 22:21 | |
| *** chlong has quit IRC | 22:22 | |
| *** annegentle has quit IRC | 22:25 | |
| *** dave-mccowan has quit IRC | 22:31 | |
| *** salv-orl_ has quit IRC | 22:43 | |
| *** dave-mccowan has joined #openstack-sdks | 22:49 | |
| *** annegentle has joined #openstack-sdks | 22:53 | |
| *** annegentle has quit IRC | 22:59 | |
| *** hongbin has quit IRC | 22:59 | |
| *** annegentle has joined #openstack-sdks | 23:04 | |
| *** annegentle has quit IRC | 23:10 | |
| *** sdague has quit IRC | 23:17 | |
| *** cdent has quit IRC | 23:32 | |
| *** bobh has joined #openstack-sdks | 23:33 | |
| *** gildub has joined #openstack-sdks | 23:36 | |
| *** hongbin has joined #openstack-sdks | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!